On Tue, May 05, 2015 at 02:56:41PM -0500, Scott Wood wrote:
Don't insist that you must be special and different from everyone else.
There are some users of U16_MAX, U32_MAX, and U64_MAX. Why use a limit
for a different type than is being used? Why have s16/s32 at all if
you're going to
Stuart-B08248; Wood Scott-B07421; Erez Nir-RM30794; katz Itai-
RM05202; Hamciuc Bogdan-BHAMCIU1; Marginean Alexandru-R89243; Schmitt
Richard-B43082
Subject: Re: [PATCH 1/7] staging: fsl-mc: MC bus IRQ support
On Mon, May 04, 2015 at 10:09:08PM +, Jose Rivera wrote
On Tue, May 05, 2015 at 04:08:49PM +, Jose Rivera wrote:
Subject: Re: [PATCH 1/7] staging: fsl-mc: MC bus IRQ support
On Mon, May 04, 2015 at 10:09:08PM +, Jose Rivera wrote:
+ WARN_ON((int16_t)irq_count 0);
This code is doing WARN_ON(test_bit(15, (unsigned
On Mon, May 04, 2015 at 10:09:08PM +, Jose Rivera wrote:
+ WARN_ON((int16_t)irq_count 0);
This code is doing WARN_ON(test_bit(15, (unsigned long *)irq_count));.
That seems like nonsense. Anyway, just delete the WARN_ON().
I disagree. This WARN_ON is checking that
On Tue, 2015-05-05 at 19:40 +0300, Dan Carpenter wrote:
On Tue, May 05, 2015 at 04:08:49PM +, Jose Rivera wrote:
Subject: Re: [PATCH 1/7] staging: fsl-mc: MC bus IRQ support
On Mon, May 04, 2015 at 10:09:08PM +, Jose Rivera wrote:
+ WARN_ON((int16_t)irq_count 0
; Erez Nir-RM30794; katz Itai-
RM05202; Hamciuc Bogdan-BHAMCIU1; Marginean Alexandru-R89243; Schmitt
Richard-B43082
Subject: Re: [PATCH 1/7] staging: fsl-mc: MC bus IRQ support
On Tue, 2015-05-05 at 11:08 -0500, Rivera Jose-B46482 wrote:
to read what goto error; does. The error handling
On Tue, 2015-05-05 at 11:08 -0500, Rivera Jose-B46482 wrote:
to read what goto error; does. The error handling here calls
devm_kfree() which is not needed... devm_ functions automatically
clean up after themselves. This seems a pattern throughout. Do a
search for
; Sharma Bhupesh-B45370;
gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; ag...@suse.de;
Erez Nir-RM30794; katz Itai-RM05202; Marginean Alexandru-R89243; Schmitt
Richard-B43082
Subject: Re: [PATCH 1/7] staging: fsl-mc: MC bus IRQ support
On Tue, 2015-05-05 at 19:40 +0300, Dan
...@vger.kernel.org; ag...@suse.de;
Erez Nir-RM30794; katz Itai-RM05202; Marginean Alexandru-R89243; Schmitt
Richard-B43082
Subject: Re: [PATCH 1/7] staging: fsl-mc: MC bus IRQ support
On Tue, 2015-05-05 at 19:40 +0300, Dan Carpenter wrote:
On Tue, May 05, 2015 at 04:08:49PM +, Jose Rivera wrote
-ker...@vger.kernel.org; Yoder Stuart-
B08248; Sharma Bhupesh-B45370; ag...@suse.de; Hamciuc Bogdan-BHAMCIU1;
Erez Nir-RM30794; katz Itai-RM05202; Wood Scott-B07421; Marginean
Alexandru-R89243; Schmitt Richard-B43082
Subject: Re: [PATCH 1/7] staging: fsl-mc: MC bus IRQ support
On Tue, Apr 28
On Tue, Apr 28, 2015 at 12:39:04PM -0500, J. German Rivera wrote:
Change-Id: I2a986c465989c3811de19cfe9ed0b77168250cb1
Reviewed-on: http://git.am.freescale.net:8181/33626
Tested-by: Review Code-CDREVIEW cdrev...@freescale.com
These things are totally useless to the rest of us. Don't add them.
11 matches
Mail list logo
