Re: [PATCH net-next v2 0/2] dpaa2-eth: Move DPAA2 Ethernet driver

2018-09-01 Thread David Miller
From: Ioana Radulescu Date: Wed, 29 Aug 2018 04:42:38 -0500 > The Freescale/NXP DPAA2 Ethernet driver was first included in > drivers/staging, due to its dependencies on two components located > there at the time of its initial submission: > * the fsl-mc bus driver, which was moved to

RE: [PATCH net-next v2 0/2] dpaa2-eth: Move DPAA2 Ethernet driver

2018-08-29 Thread Ioana Ciocoi Radulescu
e...@linuxfoundation.org; linux- > ker...@vger.kernel.org; Ioana Ciornei ; Laurentiu > Tudor > Subject: Re: [PATCH net-next v2 0/2] dpaa2-eth: Move DPAA2 Ethernet > driver > > There are a few static checker warnings for the driver but only the > first one looks like a possibly re

Re: [PATCH net-next v2 0/2] dpaa2-eth: Move DPAA2 Ethernet driver

2018-08-29 Thread Dan Carpenter
On Wed, Aug 29, 2018 at 12:06:44PM +, Ioana Ciocoi Radulescu wrote: > > > > There are a few static checker warnings for the driver but only the > > first one looks like a possibly real bug. > > Thanks for the report, what tool did you use to get these warnings? > These are Smatch warnings,

Re: [PATCH net-next v2 0/2] dpaa2-eth: Move DPAA2 Ethernet driver

2018-08-29 Thread Dan Carpenter
There are a few static checker warnings for the driver but only the first one looks like a possibly real bug. drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c:1116 dpaa2_eth_stop() error: uninitialized symbol 'dpni_enabled'. drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c:1671 set_fq_affinity()