Re: [PATCH v2 2/3] staging: unisys: convert pack pragma to __packed

2015-06-19 Thread Dan Carpenter
On Fri, Jun 12, 2015 at 04:46:07PM -0400, David Kershner wrote: It was noticed that iochannel.h was still using pragmas to pack the datastructures, should be using __packed instead. Signed-off-by: David Kershner david.kersh...@unisys.com Could you take some time and figure out which structs

RE: [PATCH v2 2/3] staging: unisys: convert pack pragma to __packed

2015-06-19 Thread Kershner, David A
: [PATCH v2 2/3] staging: unisys: convert pack pragma to __packed On Fri, Jun 12, 2015 at 04:46:07PM -0400, David Kershner wrote: It was noticed that iochannel.h was still using pragmas to pack the datastructures, should be using __packed instead. Signed-off-by: David Kershner david.kersh

Re: [PATCH v2 2/3] staging: unisys: convert pack pragma to __packed

2015-06-19 Thread Jes Sorensen
@linuxdriverproject.org; Romer, Benjamin M Subject: Re: [PATCH v2 2/3] staging: unisys: convert pack pragma to __packed On Fri, Jun 12, 2015 at 04:46:07PM -0400, David Kershner wrote: It was noticed that iochannel.h was still using pragmas to pack the datastructures, should be using __packed instead

Re: [PATCH v2 2/3] staging: unisys: convert pack pragma to __packed

2015-06-19 Thread Dan Carpenter
On Fri, Jun 19, 2015 at 03:02:32PM +, Kershner, David A wrote: Thanks for the find. Unfortunately, all the structs defined in iochannel.h need to be packed since they are shared across different OS and code instances. I'll look into changing the s-Par firmware and will update the

Re: [PATCH v2 2/3] staging: unisys: convert pack pragma to __packed

2015-06-12 Thread Greg KH
On Fri, Jun 12, 2015 at 04:46:07PM -0400, David Kershner wrote: It was noticed that iochannel.h was still using pragmas to pack the datastructures, should be using __packed instead. Signed-off-by: David Kershner david.kersh...@unisys.com --- drivers/staging/unisys/include/iochannel.h | 45