On Thu, 2013-09-12 at 08:40 +0900, Tetsuo Handa wrote:
Joe Perches wrote:
- seq_printf(m, %s%d%n, con-name, con-index, len);
+ len = seq_printf(m, %s%d, con-name, con-index);
Isn't len always 0 or -1 ?
Right. Well you're no fun...
These uses would seem broken anyway because the
On Wed, Sep 11, 2013 at 05:04:17PM -0700, Joe Perches wrote:
On Thu, 2013-09-12 at 08:40 +0900, Tetsuo Handa wrote:
Joe Perches wrote:
- seq_printf(m, %s%d%n, con-name, con-index, len);
+ len = seq_printf(m, %s%d, con-name, con-index);
Isn't len always 0 or -1 ?
On Thu, 2013-09-12 at 09:06 +0100, David Laight wrote:
On Wed, Sep 11, 2013 at 05:04:17PM -0700, Joe Perches wrote:
On Thu, 2013-09-12 at 08:40 +0900, Tetsuo Handa wrote:
Joe Perches wrote:
- seq_printf(m, %s%d%n, con-name, con-index, len);
+ len = seq_printf(m, %s%d,
On Wed, Sep 11, 2013 at 4:22 PM, Joe Perches j...@perches.com wrote:
Using vsnprintf or its derivatives with %n can have security
vulnerability implications.
Prior to commit fef20d9c1380
(vsprintf: unify the format decoding layer for its 3 users),
any use of %n was ignored.
Reintroduce
On Wed, Sep 11, 2013 at 05:04:17PM -0700, Joe Perches wrote:
On Thu, 2013-09-12 at 08:40 +0900, Tetsuo Handa wrote:
Joe Perches wrote:
- seq_printf(m, %s%d%n, con-name, con-index, len);
+ len = seq_printf(m, %s%d, con-name, con-index);
Isn't len always 0 or -1 ?
Right. Well
On Thu, 2013-09-12 at 01:19 +0100, Al Viro wrote:
On Wed, Sep 11, 2013 at 05:04:17PM -0700, Joe Perches wrote:
On Thu, 2013-09-12 at 08:40 +0900, Tetsuo Handa wrote:
Joe Perches wrote:
- seq_printf(m, %s%d%n, con-name, con-index, len);
+ len = seq_printf(m, %s%d,
