RE: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups for nidstring.c

2015-11-03 Thread Simmons, James A.
>Yeah. That is often the fastest way to fix all the checkpatch warnings. > >Checkpatch warnings are pretty mechanical. Just send like 100 patches >at a time until everything is fixed. Don't overthink. Say your patch >breaks the alignment then you have to fix that, but otherwise only fix >one

Re: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups for nidstring.c

2015-11-02 Thread Dan Carpenter
Yeah. That is often the fastest way to fix all the checkpatch warnings. Checkpatch warnings are pretty mechanical. Just send like 100 patches at a time until everything is fixed. Don't overthink. Say your patch breaks the alignment then you have to fix that, but otherwise only fix one thing

RE: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups for nidstring.c

2015-11-01 Thread Simmons, James A.
>On Thu, Oct 29, 2015 at 07:28:21PM -0400, James Simmons wrote: >> With nidstring now having the latest fixes we can >> now clean up all the remaining checkpatch errors >> for nidstring.c. > >Please be specific as to exactly what you changed, and break it up into >one-patch-per-thing. And no,

Re: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups for nidstring.c

2015-11-01 Thread Michael Shuey
I suspect you're over-thinking it. The maintainers appear to be reacting to the different types of style changes - "checkpatch cleanups" is an awfully broad commit message. I'd suggest breaking this patch (and any others like it) into two pieces; one with whitespace cleanups, and one with the