Re: [PATCH] staging: vt6656: fixed a CamelCase coding style issue.

2021-02-19 Thread Selvakumar E
Hi Dan Carpenter Thanks for the feedback, I'll work on the suggestion and come back with a fix. Regards Selvakumar Elangovan On Fri, Feb 19, 2021 at 5:42 PM Dan Carpenter wrote: > > You're not asking the right questions. > > On Fri, Feb 19, 2021 at 03:28:35PM +0530, Selvakumar Elangovan wrote:

Re: [PATCH] staging: vt6656: fixed a CamelCase coding style issue.

2021-02-19 Thread Dan Carpenter
You're not asking the right questions. On Fri, Feb 19, 2021 at 03:28:35PM +0530, Selvakumar Elangovan wrote: > This patch renames CamelCase macros uVar and uModulo into u_var and > u_module in device.h > Is "u_var" a good name? What does the "u_" even mean? > This issue was reported by checkpa

Re: [PATCH] staging: vt6656: fixed a CamelCase coding style issue.

2021-02-19 Thread Greg KH
On Fri, Feb 19, 2021 at 03:28:35PM +0530, Selvakumar Elangovan wrote: > This patch renames CamelCase macros uVar and uModulo into u_var and > u_module in device.h > > This issue was reported by checkpatch.pl > > Signed-off-by: Selvakumar Elangovan > --- > drivers/staging/vt6656/device.h | 8 +++