Re: [PATCH] xillybus: place 'else' on same line as '}'

2014-07-17 Thread Greg Kroah-Hartman
On Sun, Jul 13, 2014 at 08:07:00PM -0700, Jeremiah Mahler wrote: > Place 'else' on same line as closing brace '}' as per > Documentation/CodingStyle. Fixes 1 error found by checkpatch.pl. > > Signed-off-by: Jeremiah Mahler > --- > drivers/staging/xillybus/xillybus_core.c | 3 +-- > 1 file chang

Re: [PATCH] xillybus: place 'else' on same line as '}'

2014-07-14 Thread Dan Carpenter
On Mon, Jul 14, 2014 at 09:40:39AM +0300, Eli Billauer wrote: > Hi, > > Thanks for this. > > And since I looked at the part in Codingstyle that deals with > if-else, I found another few mistakes regarding braces around a > single statement. The rules say, it turns out, that if one of the > clause

Re: [PATCH] xillybus: place 'else' on same line as '}'

2014-07-13 Thread Eli Billauer
Hi, Thanks for this. And since I looked at the part in Codingstyle that deals with if-else, I found another few mistakes regarding braces around a single statement. The rules say, it turns out, that if one of the clauses in an if-else is longer than one statement, both clauses should be wrapp