Re: [PATCH 07/22] staging: erofs: remove redundant #include "internal.h"

2019-07-31 Thread Chao Yu
On 2019/7/29 14:51, Gao Xiang wrote: > Because #include "internal.h" is included in xattr.h I think it would be better to remove "internal.h" in xattr.h, and include them both in .c file in where we need xattr definition. Thanks, ___ devel mailing list

Re: [PATCH 07/22] staging: erofs: remove redundant #include "internal.h"

2019-07-31 Thread Gao Xiang
Hi Chao, On 2019/7/31 15:03, Chao Yu wrote: > On 2019/7/29 14:51, Gao Xiang wrote: >> Because #include "internal.h" is included in xattr.h > > I think it would be better to remove "internal.h" in xattr.h, and include them > both in .c file in where we need xattr definition. It seems that all xat

Re: [PATCH 07/22] staging: erofs: remove redundant #include "internal.h"

2019-07-31 Thread Chao Yu
Hi Xiang, On 2019/7/31 15:08, Gao Xiang wrote: > Hi Chao, > > On 2019/7/31 15:03, Chao Yu wrote: >> On 2019/7/29 14:51, Gao Xiang wrote: >>> Because #include "internal.h" is included in xattr.h >> >> I think it would be better to remove "internal.h" in xattr.h, and include >> them >> both in .c

Re: [PATCH 07/22] staging: erofs: remove redundant #include "internal.h"

2019-07-31 Thread Gao Xiang
On 2019/7/31 20:07, Chao Yu wrote: > Hi Xiang, > > On 2019/7/31 15:08, Gao Xiang wrote: >> Hi Chao, >> >> On 2019/7/31 15:03, Chao Yu wrote: >>> On 2019/7/29 14:51, Gao Xiang wrote: Because #include "internal.h" is included in xattr.h >>> >>> I think it would be better to remove "internal.

Re: [PATCH 07/22] staging: erofs: remove redundant #include "internal.h"

2019-07-31 Thread Chao Yu
On 2019/7/31 20:54, Gao Xiang wrote: > > > On 2019/7/31 20:07, Chao Yu wrote: >> Hi Xiang, >> >> On 2019/7/31 15:08, Gao Xiang wrote: >>> Hi Chao, >>> >>> On 2019/7/31 15:03, Chao Yu wrote: On 2019/7/29 14:51, Gao Xiang wrote: > Because #include "internal.h" is included in xattr.h >