Re: [PATCH 2/4] staging: ozwpan: Increment port number for new device.

2013-08-12 Thread Greg KH
On Mon, Aug 05, 2013 at 06:40:13PM +0100, Rupesh Gujare wrote: > This patch fixes crash issue when there is quick cycle of > de-enumeration & enumeration due to loss of wireless link. > > It is found that sometimes new device (or coming back device) > returns very fast, even before USB core read o

Re: [PATCH 2/4] staging: ozwpan: Increment port number for new device.

2013-08-06 Thread Dan Carpenter
On Tue, Aug 06, 2013 at 11:26:14AM +0100, Rupesh Gujare wrote: > I will work on it, once this patch series is applied to staging tree. > > I am assuming that you have no objection for it, & I will follow up > with above style nits in follow on patches. Yes. That's fine. regards, dan carpenter

Re: [PATCH 2/4] staging: ozwpan: Increment port number for new device.

2013-08-06 Thread Rupesh Gujare
On 05/08/13 21:23, Dan Carpenter wrote: On Mon, Aug 05, 2013 at 07:43:16PM +0100, Rupesh Gujare wrote: On 05/08/13 18:53, Dan Carpenter wrote: On Mon, Aug 05, 2013 at 06:40:13PM +0100, Rupesh Gujare wrote: This patch fixes crash issue when there is quick cycle of de-enumeration & enumeration d

Re: [PATCH 2/4] staging: ozwpan: Increment port number for new device.

2013-08-05 Thread Dan Carpenter
Here is what oz_hcd_pd_arrived() looks like after my changes: These lines: - if (ozhcd == NULL) + if (!ozhcd) were personal preference and not official kernel style guidelines. Either way is fine for pointers. oz_ep_alloc() can return NULL. There was no check for failure in the origi

Re: [PATCH 2/4] staging: ozwpan: Increment port number for new device.

2013-08-05 Thread Dan Carpenter
On Mon, Aug 05, 2013 at 07:43:16PM +0100, Rupesh Gujare wrote: > On 05/08/13 18:53, Dan Carpenter wrote: > >On Mon, Aug 05, 2013 at 06:40:13PM +0100, Rupesh Gujare wrote: > >>This patch fixes crash issue when there is quick cycle of > >>de-enumeration & enumeration due to loss of wireless link. > >

Re: [PATCH 2/4] staging: ozwpan: Increment port number for new device.

2013-08-05 Thread Rupesh Gujare
On 05/08/13 18:53, Dan Carpenter wrote: On Mon, Aug 05, 2013 at 06:40:13PM +0100, Rupesh Gujare wrote: This patch fixes crash issue when there is quick cycle of de-enumeration & enumeration due to loss of wireless link. It is found that sometimes new device (or coming back device) returns very

Re: [PATCH 2/4] staging: ozwpan: Increment port number for new device.

2013-08-05 Thread Dan Carpenter
On Mon, Aug 05, 2013 at 06:40:13PM +0100, Rupesh Gujare wrote: > This patch fixes crash issue when there is quick cycle of > de-enumeration & enumeration due to loss of wireless link. > > It is found that sometimes new device (or coming back device) > returns very fast, even before USB core read o