On Tue, Dec 15, 2015 at 05:10:39PM +, Simmons, James A. wrote:
>I have been pondering if pushing bug fixes before style cleanups
> is the right thing to do.
Generally push the least controversial patches first so that if you
have to redo one patch, then the rest are already applied and don't n
>Actually we're going to have to redo so much code that it's not worth it
>for me to review the rest of these patches.
Sorry I didn't get back to you sooner but I was on vacation. Thanks for
reviewing this work. Especially since this is the first major bug fixing merge
for the lustre client wh
Actually we're going to have to redo so much code that it's not worth it
for me to review the rest of these patches. Please just look over
everything again:
BAD: return -1;
GOOD: return -EINVAL;
BAD: failed0:
GOOD: free_something:
BAD: if (rc != 0)
GOOD: if (rc)
Do one thing per p
