Re: [PATCH 6/7] iio: light: tsl2583: add locking to sysfs *_store() functions

2016-10-24 Thread Dan Carpenter
On Sat, Oct 22, 2016 at 06:29:55PM +0100, Jonathan Cameron wrote: > On 19/10/16 12:37, Dan Carpenter wrote: > > I appologize for laughing, but I am still secretly amused in my heart. > > > > regards, > > dan carpenter > > > Fewer beers or less caffeine for Dan! ;) > > Key take away here is kee

Re: [PATCH 6/7] iio: light: tsl2583: add locking to sysfs *_store() functions

2016-10-22 Thread Jonathan Cameron
On 19/10/16 12:37, Dan Carpenter wrote: > I appologize for laughing, but I am still secretly amused in my heart. > > regards, > dan carpenter > Fewer beers or less caffeine for Dan! Key take away here is keep things simple. The gotos in my mind would actually have made sense, but I wouldn't do

Re: [PATCH 6/7] iio: light: tsl2583: add locking to sysfs *_store() functions

2016-10-19 Thread Dan Carpenter
I appologize for laughing, but I am still secretly amused in my heart. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 6/7] iio: light: tsl2583: add locking to sysfs *_store() functions

2016-10-19 Thread Dan Carpenter
On Wed, Oct 19, 2016 at 06:32:09AM -0400, Brian Masney wrote: > @@ -778,6 +796,8 @@ static ssize_t illuminance0_lux_table_store(struct device > *dev, > goto luxable_store_done; > } > > + mutex_lock(&chip->als_mutex); > + > if (chip->taos_chip_status == TSL258X_CHIP_