RE: [PATCH 7/8] drivers: scsi: storvsc: Set srb_flags in all cases

2014-07-11 Thread KY Srinivasan
t; a...@canonical.com; linux-s...@vger.kernel.org; sta...@vger.kernel.org > Subject: Re: [PATCH 7/8] drivers: scsi: storvsc: Set srb_flags in all cases > > > default: > > vm_srb->data_in = UNKNOWN_TYPE; > > - vm_srb->w

RE: [PATCH 7/8] drivers: scsi: storvsc: Set srb_flags in all cases

2014-07-10 Thread KY Srinivasan
; jasow...@redhat.com; a...@canonical.com; > linux-s...@vger.kernel.org; sta...@vger.kernel.org > Subject: Re: [PATCH 7/8] drivers: scsi: storvsc: Set srb_flags in all cases > > On Wed, Jul 09, 2014 at 06:40:09PM +, KY Srinivasan wrote: > > > On Tue, Jul 08, 2014 a

Re: [PATCH 7/8] drivers: scsi: storvsc: Set srb_flags in all cases

2014-07-10 Thread Christoph Hellwig
> default: > vm_srb->data_in = UNKNOWN_TYPE; > - vm_srb->win8_extension.srb_flags = 0; > + vm_srb->win8_extension.srb_flags |= (SRB_FLAGS_DATA_IN | > + SRB_FLAGS_DATA_OUT); This would usually be a command

Re: [PATCH 7/8] drivers: scsi: storvsc: Set srb_flags in all cases

2014-07-10 Thread Christoph Hellwig
On Wed, Jul 09, 2014 at 06:40:09PM +, KY Srinivasan wrote: > > On Tue, Jul 08, 2014 at 05:46:51PM -0700, K. Y. Srinivasan wrote: > > > Correctly set SRB flags for all valid I/O directions. Some IHV drivers > > > on the Windows host require this. > > > > What are IHV drivers? > > If the target

RE: [PATCH 7/8] drivers: scsi: storvsc: Set srb_flags in all cases

2014-07-09 Thread KY Srinivasan
t; a...@canonical.com; linux-s...@vger.kernel.org; sta...@vger.kernel.org > Subject: Re: [PATCH 7/8] drivers: scsi: storvsc: Set srb_flags in all cases > > On Tue, Jul 08, 2014 at 05:46:51PM -0700, K. Y. Srinivasan wrote: > > Correctly set SRB flags for all valid I/O directions. Some

Re: [PATCH 7/8] drivers: scsi: storvsc: Set srb_flags in all cases

2014-07-09 Thread Christoph Hellwig
On Tue, Jul 08, 2014 at 05:46:51PM -0700, K. Y. Srinivasan wrote: > Correctly set SRB flags for all valid I/O directions. Some IHV drivers on the > Windows host require this. What are IHV drivers? Otherwise looks fine, Reviewed-by: Christoph Hellwig