Re: [PATCH v2 1/2] staging: gdm7240: adding LTE USB driver

2013-07-25 Thread Greg KH
On Thu, Jul 25, 2013 at 02:56:51PM +0900, Won Kang wrote: > Anyway, you are right that endianess matters only when using this SDK. > If you suggest to remove the ioctl because SDK is optional, I will > agree. Thanks, I've now removed it from the driver. greg k-h __

Re: [PATCH v2 1/2] staging: gdm7240: adding LTE USB driver

2013-07-25 Thread Won Kang
>> GDM7240 is in LE where as GDM7243 (currently under development) is in BE. > > But why does this information need to be sent to userspace? > GDM724x chips have different endianess because of their internal architecture.The device sends out and accepts LTE protocol information in its own endianes

Re: [PATCH v2 1/2] staging: gdm7240: adding LTE USB driver

2013-07-25 Thread Greg KH
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Thu, Jul 25, 2013 at 01:15:07PM +0900, Won Kang wrote: > GDM7240 is in LE where as GDM7243 (currently under development) is in BE. But why does this information need to be sent to userspace? > Use

Re: [PATCH v2 1/2] staging: gdm7240: adding LTE USB driver

2013-07-25 Thread Won Kang
GDM7240 is in LE where as GDM7243 (currently under development) is in BE. User space applications needs to discover the endianess to properly encode/decode LTE control protocols. We have existing customers already deploying units in large volume, and want to avoid forcing them to change SDK APIs a

Re: [PATCH v2 1/2] staging: gdm7240: adding LTE USB driver

2013-07-24 Thread Greg KH
On Thu, Jul 25, 2013 at 12:53:40AM +0300, Dan Carpenter wrote: > > +static int gdm_lte_ioctl_get_data(struct wm_req_t *req, struct net_device > > *dev) > > +{ > > + u16 id = req->data_id; > > + > > + switch (id) { > > + case GET_ENDIAN_INFO: > > + /* required for the user space app

Re: [PATCH v2 1/2] staging: gdm7240: adding LTE USB driver

2013-07-24 Thread Dan Carpenter
> +static int gdm_lte_ioctl_get_data(struct wm_req_t *req, struct net_device > *dev) > +{ > + u16 id = req->data_id; > + > + switch (id) { > + case GET_ENDIAN_INFO: > + /* required for the user space application to find out device > endian */ > + get_dev_endian

Re: [PATCH v2 1/2] staging: gdm7240: adding LTE USB driver

2013-07-24 Thread Dan Carpenter
On Thu, Jul 25, 2013 at 03:36:17AM +0900, Won Kang wrote: > +- Explain reason for multiples of 512 bytes in alloc_tx_struct() Actually I remembered that I had seen this before in gdm_usb_send() from drivers/staging/gdm72xx/gdm_usb.c. Apparently there is a firmware bug. /* * In s

Re: [PATCH v2 1/2] staging: gdm7240: adding LTE USB driver

2013-07-24 Thread Greg KH
On Thu, Jul 25, 2013 at 03:36:17AM +0900, Won Kang wrote: > GCT Semiconductor GDM7240 is 4G LTE chip. > This driver supports GCT reference platform as a USB device. I've applied this now, and fixed up the tty build warnings (which you should have also seen.) I'm not sure I got the tty fixes corre

회신: Re: [PATCH v2 1/2] staging: gdm7240: adding LTE USB driver

2013-07-24 Thread Won Kang
Hi Joe, Got it. Thanks Regards, Won 원본 메시지 발신: Joe Perches 날짜: 2013/07/25 오전 3:42 (GMT+09:00) 수신: Won Kang 참조: linux-ker...@vger.kernel.org,de...@driverdev.osuosl.org,gre...@linuxfoundation.org,Won Kang 제목: Re: [PATCH v2 1/2] staging: gdm7240: adding LTE USB driver On

Re: [PATCH v2 1/2] staging: gdm7240: adding LTE USB driver

2013-07-24 Thread Joe Perches
On Thu, 2013-07-25 at 03:36 +0900, Won Kang wrote: > GCT Semiconductor GDM7240 is 4G LTE chip. > This driver supports GCT reference platform as a USB device. > > Signed-off-by: Won Kang > > staging: gdm7240: added contacts for code maintanance > > Signed-off-by: Won Kang > > staging: gdm7240: