Re: [PATCH v2 2/7] staging: qlge: Initialize devlink health dump framework

2020-10-20 Thread Shung-Hsi Yu
On Tue, Oct 20, 2020 at 04:36:09PM +0800, Shung-Hsi Yu wrote: > This patch trigger the following KASAN error inside qlge_init_device(). Sorry, I meant to reply to the v3 series, please ignore this email. ___ devel mailing list de...@linuxdriverproject.o

Re: [PATCH v2 2/7] staging: qlge: Initialize devlink health dump framework

2020-10-20 Thread Shung-Hsi Yu
Hi, This patch trigger the following KASAN error inside qlge_init_device(). [...] general protection fault, probably for non-canonical address 0xdc4b: [#1] SMP DEBUG_PAGEALLOC KASAN PTI [...] KASAN: null-ptr-deref in range [0x0258-0x025f] [...] CPU: 0 PID

Re: [PATCH v2 2/7] staging: qlge: Initialize devlink health dump framework

2020-10-14 Thread Coiby Xu
On Wed, Oct 14, 2020 at 04:08:46PM +0300, Dan Carpenter wrote: On Wed, Oct 14, 2020 at 06:43:01PM +0800, Coiby Xu wrote: static int qlge_probe(struct pci_dev *pdev, const struct pci_device_id *pci_entry) { struct net_device *ndev = NULL; struct qlge_adapte

Re: [PATCH v2 2/7] staging: qlge: Initialize devlink health dump framework

2020-10-14 Thread Dan Carpenter
On Wed, Oct 14, 2020 at 06:43:01PM +0800, Coiby Xu wrote: > static int qlge_probe(struct pci_dev *pdev, > const struct pci_device_id *pci_entry) > { > struct net_device *ndev = NULL; > struct qlge_adapter *qdev = NULL; > + struct devlink *devlink; > stati