Re: [PATCH v2 4/5] staging: rtl8712: fix multiline derefernce warning

2020-04-02 Thread Dan Carpenter
Hi Aiman, On Sat, Mar 28, 2020 at 12:17:19PM -0700, Joe Perches wrote: > On Fri, 2020-03-27 at 20:08 -0400, aimannajjar wrote: > > so these would be > > ether_addr_copy(pwlanhdr->addr2, pattr->src); > > and pwlanhdr isn't a particularly valuable name > for an automatic eit

Re: [PATCH v2 4/5] staging: rtl8712: fix multiline derefernce warning

2020-03-28 Thread Aiman Najjar
On Sat, Mar 28, 2020 at 12:17:19PM -0700, Joe Perches wrote: > On Fri, 2020-03-27 at 20:08 -0400, aimannajjar wrote: > > This patch fixes the following checkpatch warning in > > rtl8712x_xmit.c: > > > > WARNING: Avoid multiple line dereference - prefer > > 'psta->sta_xmitpriv.txseq_tid[pattrib->p

Re: [PATCH v2 4/5] staging: rtl8712: fix multiline derefernce warning

2020-03-28 Thread Joe Perches
On Fri, 2020-03-27 at 20:08 -0400, aimannajjar wrote: > This patch fixes the following checkpatch warning in > rtl8712x_xmit.c: > > WARNING: Avoid multiple line dereference - prefer > 'psta->sta_xmitpriv.txseq_tid[pattrib->priority]' > 544: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:544: > +