Re: [PATCH v3] imx-drm: Add mx6 hdmi transmitter support

2013-10-30 Thread Russell King - ARM Linux
On Mon, Oct 28, 2013 at 06:26:49PM -0200, Fabio Estevam wrote: > + /*Wait for PHY PLL lock */ > + msec = 4; > + val = hdmi_readb(hdmi, HDMI_PHY_STAT0) & HDMI_PHY_TX_PHY_LOCK; > + while (!val) { > + udelay(1000); > + if (msec-- == 0) { > +

Re: [PATCH v3] imx-drm: Add mx6 hdmi transmitter support

2013-10-29 Thread Fabio Estevam
On Tue, Oct 29, 2013 at 9:47 PM, Russell King - ARM Linux wrote: > The issues surrounding DT and DRM were given an airing last week at > kernel summit in a session chaired by David Airlie. > > The Kernel Summit session was to discuss issues surrounding DT and DRM, > or more specifically DT and co

Re: [PATCH v3] imx-drm: Add mx6 hdmi transmitter support

2013-10-29 Thread Russell King - ARM Linux
On Tue, Oct 29, 2013 at 08:01:46PM -0200, Fabio Estevam wrote: > Hi Greg, > > On Mon, Oct 28, 2013 at 7:03 PM, Greg KH wrote: > > And why is new support being added to this driver instead of working to > > get it out of staging? > > Philipp Zabel mentioned that he will submit the imx-drm driver

Re: [PATCH v3] imx-drm: Add mx6 hdmi transmitter support

2013-10-29 Thread Fabio Estevam
Hi Greg, On Mon, Oct 28, 2013 at 7:03 PM, Greg KH wrote: > On Mon, Oct 28, 2013 at 06:26:49PM -0200, Fabio Estevam wrote: >> From: Fabio Estevam >> >> This is based on the initial work done by Sascha Hauer and Tony Prisk. > > What is "this"? Ok, I will improve the commit log. > And why is new

Re: [PATCH v3] imx-drm: Add mx6 hdmi transmitter support

2013-10-29 Thread Russell King - ARM Linux
On Tue, Oct 29, 2013 at 01:45:50PM -0200, Fabio Estevam wrote: > On Tue, Oct 29, 2013 at 1:00 PM, Fabio Estevam wrote: > > > Today I was able to get access to a wandboard solo and the HDMI image > > does look different compared to a wandboard quad board: > > > > - The Linux logo penguins are stea

Re: [PATCH v3] imx-drm: Add mx6 hdmi transmitter support

2013-10-29 Thread Fabio Estevam
On Tue, Oct 29, 2013 at 1:00 PM, Fabio Estevam wrote: > Today I was able to get access to a wandboard solo and the HDMI image > does look different compared to a wandboard quad board: > > - The Linux logo penguins are steady on mx6q, but on mx6solo the > contour lines look like they flicker. > -

Re: [PATCH v3] imx-drm: Add mx6 hdmi transmitter support

2013-10-29 Thread Fabio Estevam
On Mon, Oct 28, 2013 at 7:19 PM, Russell King - ARM Linux wrote: > On Mon, Oct 28, 2013 at 06:26:49PM -0200, Fabio Estevam wrote: >> From: Fabio Estevam >> >> This is based on the initial work done by Sascha Hauer and Tony Prisk. > > It looks like you've also taken some of the suggestions I've ma

Re: [PATCH v3] imx-drm: Add mx6 hdmi transmitter support

2013-10-28 Thread Russell King - ARM Linux
On Mon, Oct 28, 2013 at 06:26:49PM -0200, Fabio Estevam wrote: > From: Fabio Estevam > > This is based on the initial work done by Sascha Hauer and Tony Prisk. It looks like you've also taken some of the suggestions I've made too - like the voltage drive and symbol transmit control settings. It

Re: [PATCH v3] imx-drm: Add mx6 hdmi transmitter support

2013-10-28 Thread Greg KH
On Mon, Oct 28, 2013 at 06:26:49PM -0200, Fabio Estevam wrote: > From: Fabio Estevam > > This is based on the initial work done by Sascha Hauer and Tony Prisk. What is "this"? And why is new support being added to this driver instead of working to get it out of staging? I thought we went throu