Re: [PATCH v7 10/24] wfx: add fwio.c/fwio.h

2021-10-07 Thread Pali Rohár
Hello Rob! Could you look at issue below to represent antenna (pds) firmware file requirement for this driver in DTS file? On Thursday 07 October 2021 11:16:29 Kalle Valo wrote: > Pali Rohár writes: > > > On Friday 01 October 2021 17:09:41 Jérôme Pouiller wrote: > >> On Friday 1 October 2021 13:

Re: [PATCH v7 10/24] wfx: add fwio.c/fwio.h

2021-10-07 Thread Pali Rohár
On Thursday 07 October 2021 11:19:10 Kalle Valo wrote: > Jérôme Pouiller writes: > > > On Friday 1 October 2021 18:08:32 CEST Pali Rohár wrote: > >> On Friday 01 October 2021 17:09:41 Jérôme Pouiller wrote: > >> > On Friday 1 October 2021 13:58:38 CEST Kalle Valo wrote: > >> > > Jerome Pouiller

Re: [PATCH v7 10/24] wfx: add fwio.c/fwio.h

2021-10-07 Thread Jérôme Pouiller
On Thursday 7 October 2021 10:08:53 CEST Kalle Valo wrote: > Jérôme Pouiller writes: > > On Friday 1 October 2021 13:58:38 CEST Kalle Valo wrote: > >> Jerome Pouiller writes: > >> > >> > From: Jérôme Pouiller > >> > > >> > Signed-off-by: Jérôme Pouiller > >> > >> [...] > >> > >> > +static int g

Re: [PATCH v7 10/24] wfx: add fwio.c/fwio.h

2021-10-07 Thread Kalle Valo
Jérôme Pouiller writes: > On Friday 1 October 2021 18:08:32 CEST Pali Rohár wrote: >> On Friday 01 October 2021 17:09:41 Jérôme Pouiller wrote: >> > On Friday 1 October 2021 13:58:38 CEST Kalle Valo wrote: >> > > Jerome Pouiller writes: >> > > >> > > > From: Jérôme Pouiller >> > > > >> > > > Si

Re: [PATCH v7 10/24] wfx: add fwio.c/fwio.h

2021-10-07 Thread Kalle Valo
Pali Rohár writes: > On Friday 01 October 2021 17:09:41 Jérôme Pouiller wrote: >> On Friday 1 October 2021 13:58:38 CEST Kalle Valo wrote: >> > Jerome Pouiller writes: >> > >> > > From: Jérôme Pouiller >> > > >> > > Signed-off-by: Jérôme Pouiller >> > >> > [...] >> > >> > > +static int get_

Re: [PATCH v7 10/24] wfx: add fwio.c/fwio.h

2021-10-07 Thread Kalle Valo
Jérôme Pouiller writes: > On Friday 1 October 2021 13:58:38 CEST Kalle Valo wrote: >> Jerome Pouiller writes: >> >> > From: Jérôme Pouiller >> > >> > Signed-off-by: Jérôme Pouiller >> >> [...] >> >> > +static int get_firmware(struct wfx_dev *wdev, u32 keyset_chip, >> > +

Re: [PATCH v7 10/24] wfx: add fwio.c/fwio.h

2021-10-01 Thread Jérôme Pouiller
On Friday 1 October 2021 18:08:32 CEST Pali Rohár wrote: > On Friday 01 October 2021 17:09:41 Jérôme Pouiller wrote: > > On Friday 1 October 2021 13:58:38 CEST Kalle Valo wrote: > > > Jerome Pouiller writes: > > > > > > > From: Jérôme Pouiller > > > > > > > > Signed-off-by: Jérôme Pouiller > > >

Re: [PATCH v7 10/24] wfx: add fwio.c/fwio.h

2021-10-01 Thread Pali Rohár
On Friday 01 October 2021 17:09:41 Jérôme Pouiller wrote: > On Friday 1 October 2021 13:58:38 CEST Kalle Valo wrote: > > Jerome Pouiller writes: > > > > > From: Jérôme Pouiller > > > > > > Signed-off-by: Jérôme Pouiller > > > > [...] > > > > > +static int get_firmware(struct wfx_dev *wdev, u3

Re: [PATCH v7 10/24] wfx: add fwio.c/fwio.h

2021-10-01 Thread Jérôme Pouiller
On Friday 1 October 2021 13:58:38 CEST Kalle Valo wrote: > Jerome Pouiller writes: > > > From: Jérôme Pouiller > > > > Signed-off-by: Jérôme Pouiller > > [...] > > > +static int get_firmware(struct wfx_dev *wdev, u32 keyset_chip, > > + const struct firmware **fw, int *file

Re: [PATCH v7 10/24] wfx: add fwio.c/fwio.h

2021-10-01 Thread Kalle Valo
Jerome Pouiller writes: > From: Jérôme Pouiller > > Signed-off-by: Jérôme Pouiller [...] > +static int get_firmware(struct wfx_dev *wdev, u32 keyset_chip, > + const struct firmware **fw, int *file_offset) > +{ > + int keyset_file; > + char filename[256]; > + co