Re: Two rtlwifi drivers?

Pkshih writes: >> My recommendation is to avoid accumulating patches at all cost and start >> submitting them as soon as you can. This way you get patches committed >> much more smoother. So do not wait until _all_ patches are ready, >> instead start submitting patches as

RE: Two rtlwifi drivers?

el...@vger.kernel.org; > kernel-janit...@vger.kernel.org > Subject: Re: Two rtlwifi drivers? > > Hi PK, > > you got good answers already so only short reply from me: > > Pkshih <pks...@realtek.com> writes: > > > 3) Coming drivers -- rtl8723de and rtl8

RE: Two rtlwifi drivers?

el...@vger.kernel.org; > kernel-janit...@vger.kernel.org > Subject: Re: Two rtlwifi drivers? > > > > 4) As Kalle mentioned, rtlwifi contains many magic numbers, and I > >plan to fix them after rtl8723de and rtl8821ce. Because the drivers > >are developing,

Re: Two rtlwifi drivers?

Hi PK, you got good answers already so only short reply from me: Pkshih writes: > 3) Coming drivers -- rtl8723de and rtl8821ce >We're developing the two drivers, and rtl8723de and rtl8821ce will >be ready on 2017Q4 and 2018Q1 respectively. The drivers are based on >

Re: Two rtlwifi drivers?

Am 16.10.2017 um 15:07 schrieb Kalle Valo: > Oleksij Rempel writes: > >>> 4) As Kalle mentioned, rtlwifi contains many magic numbers, and I >>>plan to fix them after rtl8723de and rtl8821ce. Because the drivers >>>are developing, the changes will make us hard to

Re: Two rtlwifi drivers?

Oleksij Rempel writes: >> 4) As Kalle mentioned, rtlwifi contains many magic numbers, and I >>plan to fix them after rtl8723de and rtl8821ce. Because the drivers >>are developing, the changes will make us hard to integrate. However, >>I don't have plan to

Re: Two rtlwifi drivers?

Dan Carpenter writes: > On Mon, Oct 16, 2017 at 02:41:38AM +, Pkshih wrote: >> 2) The rtlwifi in staging >>In staging, the module phydm v13 contains bugs, so I want to upgrade >>to v21 (Realtek internal version number). This upgrade contains a >>big

Re: Two rtlwifi drivers?

Pkshih; 莊彥宣; Johannes Berg; Souptick > > Joarder; > > de...@driverdev.osuosl.org; linux-wirel...@vger.kernel.org; > > kernel-janit...@vger.kernel.org > > Subject: Re: Two rtlwifi drivers? > > > > On Thu, Oct 12, 2017 at 11:38:06AM +0300, Kalle Valo wrote: > &

Re: Two rtlwifi drivers?

On Mon, Oct 16, 2017 at 02:41:38AM +, Pkshih wrote: > 2) The rtlwifi in staging >In staging, the module phydm v13 contains bugs, so I want to upgrade >to v21 (Realtek internal version number). This upgrade contains a >big patch that the difference between v13 and v21, and there are

Re: Two rtlwifi drivers?

arpenter; Pkshih; 莊彥宣; Johannes Berg; Souptick >> Joarder; >> de...@driverdev.osuosl.org; linux-wirel...@vger.kernel.org; >> kernel-janit...@vger.kernel.org >> Subject: Re: Two rtlwifi drivers? >> >> On Thu, Oct 12, 2017 at 11:38:06AM +0300, Kalle Valo wrote: >

RE: Two rtlwifi drivers?

..@vger.kernel.org; > kernel-janit...@vger.kernel.org > Subject: Re: Two rtlwifi drivers? > > On Thu, Oct 12, 2017 at 11:38:06AM +0300, Kalle Valo wrote: > > > So what to do? Any ideas? What makes your life easier? You can just > > > ignore the staging tree, as it sh

Re: Two rtlwifi drivers?

On Thu, Oct 12, 2017 at 11:38:06AM +0300, Kalle Valo wrote: > > So what to do? Any ideas? What makes your life easier? You can just > > ignore the staging tree, as it should not affect your portion of the > > kernel at all, right? > > Yes, I automatically ignore anything staging related. But

Re: Two rtlwifi drivers?

Larry Finger writes: > On 10/11/2017 08:13 AM, Greg Kroah-Hartman wrote: > >> On Wed, Oct 11, 2017 at 12:06:00PM +0300, Kalle Valo wrote: >> I think it's horrid too. But, if no one is able to do the real work >> here, we hurt users who just need to use their hardware

Re: Two rtlwifi drivers?

Greg Kroah-Hartman writes: >> >> I'm getting slightly annoyed that we now apparently have two duplicate >> >> rtlwifi drivers (with the same name!) and I'm being spammed by staging >> >> patches. Was this really a smart thing to do? And what will be the >> >> future

Re: Two rtlwifi drivers?

On 10/11/2017 08:13 AM, Greg Kroah-Hartman wrote: On Wed, Oct 11, 2017 at 12:06:00PM +0300, Kalle Valo wrote: (Sorry for taking so long with the reply, I wanted first to check what the rtlwifi in staging contains.) Larry Finger writes: On 08/24/2017 07:14 AM,

Re: Two rtlwifi drivers?

On Wed, Oct 11, 2017 at 03:13:10PM +0200, Greg Kroah-Hartman wrote: > And it seems like the company isn't willing to do the real work, so > dumping this in staging is the best we can do at the moment. I'm more optimistic. There are a lot of @realtek.com addresses in the CC list and that's a new

Re: Two rtlwifi drivers?

On Wed, Oct 11, 2017 at 12:06:00PM +0300, Kalle Valo wrote: > (Sorry for taking so long with the reply, I wanted first to check what > the rtlwifi in staging contains.) > > Larry Finger writes: > > > On 08/24/2017 07:14 AM, Kalle Valo wrote: > >> Dan Carpenter

Re: Two rtlwifi drivers?

(Sorry for taking so long with the reply, I wanted first to check what the rtlwifi in staging contains.) Larry Finger writes: > On 08/24/2017 07:14 AM, Kalle Valo wrote: >> Dan Carpenter writes: >> >>> Smatch is distrustful of the "capab"

Re: Two rtlwifi drivers?

On 08/24/2017 07:14 AM, Kalle Valo wrote: Dan Carpenter writes: Smatch is distrustful of the "capab" value and marks it as user controlled. I think it actually comes from the firmware? Anyway, I looked at other drivers and they added a bounds check and it seems

Two rtlwifi drivers?

Dan Carpenter writes: > Smatch is distrustful of the "capab" value and marks it as user > controlled. I think it actually comes from the firmware? Anyway, I > looked at other drivers and they added a bounds check and it seems like > a harmless thing to have so I have