Re: kernel BUG at drivers/android/binder_alloc.c:LINE! (4)

2019-06-18 Thread Dan Carpenter
It's weird that that binder_alloc_copy_from_buffer() is a void function. It would be easier to do the error handling at that point, instead of in the callers. It feels like we keep hitting similar bugs to this. regards, dan carpenter ___ devel mailing

kernel BUG at drivers/android/binder_alloc.c:LINE! (4)

2019-06-18 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:9e0babf2 Linux 5.2-rc5 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=159e6121a0 kernel config: https://syzkaller.appspot.com/x/.config?x=d16883d6c7f0d717 dashboard link: https://syzkaller.appspo

Re: kernel BUG at drivers/android/binder_alloc.c:LINE! (3)

2019-05-17 Thread Todd Kjos
On Fri, May 17, 2019 at 8:33 AM Dmitry Vyukov wrote: > > On Fri, May 17, 2019 at 5:26 PM Todd Kjos wrote: > > > > Yes (and syzbot seemed to confirm the fix). I didn't realize I needed > > to manually close the issue. I guess you closed it yesterday. > > This is required to auto-close the bug when

Re: kernel BUG at drivers/android/binder_alloc.c:LINE! (3)

2019-05-17 Thread Dmitry Vyukov
On Fri, May 17, 2019 at 5:26 PM Todd Kjos wrote: > > Yes (and syzbot seemed to confirm the fix). I didn't realize I needed > to manually close the issue. I guess you closed it yesterday. This is required to auto-close the bug when the commit is merged: > IMPORTANT: if you fix the bug, please add

Re: kernel BUG at drivers/android/binder_alloc.c:LINE! (3)

2019-05-17 Thread Todd Kjos
Yes (and syzbot seemed to confirm the fix). I didn't realize I needed to manually close the issue. I guess you closed it yesterday. From: Dmitry Vyukov Date: Fri, May 17, 2019 at 3:08 AM To: syzbot Cc: Arve Hjønnevåg, Christian Brauner, open list:ANDROID DRIVERS, Greg Kroah-Hartman, Joel Fernande

Re: kernel BUG at drivers/android/binder_alloc.c:LINE! (3)

2019-03-29 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger crash: Reported-and-tested-by: syzbot+f9f3f388440283da2...@syzkaller.appspotmail.com Tested on: commit: 8c2ffd91 Linux 5.1-rc2 git tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/lin

Re: kernel BUG at drivers/android/binder_alloc.c:LINE! (3)

2019-03-28 Thread Todd Kjos
Sigh. One more try... master with the same patch as an attachment. (the patch is already queued up in gregkh's 'char-misc-linus' branch). #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git master On Thu, Mar 28, 2019 at 5:20 PM syzbot wrote: > > Hello, > > syzbot tr

Re: kernel BUG at drivers/android/binder_alloc.c:LINE! (3)

2019-03-28 Thread syzbot
Hello, syzbot tried to test the proposed patch but build/boot failed: timed out Tested on: commit: 0532a1b0 virt: vbox: Implement passing requestor info to t.. git tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-linus kernel config: h

Re: kernel BUG at drivers/android/binder_alloc.c:LINE! (3)

2019-03-28 Thread syzbot
syzbot has bisected this bug to: commit 1a7c3d9bb7a926e88d5f57643e75ad1abfc55013 Author: Todd Kjos Date: Fri Feb 8 18:35:14 2019 + binder: create userspace-to-binder-buffer copy function bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=15b9383f20 start commit: 1a9df

Re: kernel BUG at drivers/android/binder_alloc.c:LINE! (3)

2019-03-28 Thread syzbot
Hello, syzbot tried to test the proposed patch but build/boot failed: patch is already applied Tested on: commit: 0532a1b0 virt: vbox: Implement passing requestor info to t.. git tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-linus compil

Re: kernel BUG at drivers/android/binder_alloc.c:LINE! (3)

2019-03-28 Thread Todd Kjos
The fix for this is in Greg KH's char-misc-linus branch. Pointing syzbot at it to verify: #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-linus On Thu, Mar 28, 2019 at 9:14 AM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD comm

kernel BUG at drivers/android/binder_alloc.c:LINE! (3)

2019-03-28 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:1a9df9e2 Merge git://git.kernel.org/pub/scm/linux/kernel/g.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11fed11f20 kernel config: https://syzkaller.appspot.com/x/.config?x=8dcdce25ea72bedf da

Re: kernel BUG at drivers/android/binder_alloc.c:LINE! (2)

2019-02-14 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:b3418f8bddf4 Add linux-next specific files for 20190214 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=12ccad60c0 kernel config: https://syzkaller.appspot.com/x/.config?x=8a3a37525

Re: kernel BUG at drivers/android/binder_alloc.c:LINE! (2)

2019-02-14 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger crash: Reported-and-tested-by: syzbot+55de1eb4975dec156...@syzkaller.appspotmail.com Tested on: commit: b3418f8bddf4 Add linux-next specific files for 20190214 git tree: https://git.kernel.org/

Re: kernel BUG at drivers/android/binder_alloc.c:LINE! (2)

2019-02-14 Thread Todd Kjos
On Thu, Feb 14, 2019 at 3:35 AM syzbot wrote: > > syzbot has found a reproducer for the following crash on: > > HEAD commit:b3418f8bddf4 Add linux-next specific files for 20190214 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=161d2048c0 > kernel c

Re: kernel BUG at drivers/android/binder_alloc.c:LINE! (2)

2019-02-14 Thread syzbot
Hello, syzbot tried to test the proposed patch but build/boot failed: failed to checkout kernel repo https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/linux-next: failed to run ["git" "fetch" "https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git"; "linux-ne

Re: kernel BUG at drivers/android/binder_alloc.c:LINE! (2)

2019-02-14 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:b3418f8bddf4 Add linux-next specific files for 20190214 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=161d2048c0 kernel config: https://syzkaller.appspot.com/x/.config?x=8a3a37525

kernel BUG at drivers/android/binder_alloc.c:LINE! (2)

2019-02-14 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:b3418f8bddf4 Add linux-next specific files for 20190214 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=15d98978c0 kernel config: https://syzkaller.appspot.com/x/.config?x=8a3a37525a677c71 dashb

Re: kernel BUG at drivers/android/binder_alloc.c:LINE!

2018-01-31 Thread Dan Carpenter
On Wed, Jan 31, 2018 at 01:00:35PM +0100, Dmitry Vyukov wrote: > On Wed, Jan 31, 2018 at 9:08 AM, Dan Carpenter > wrote: > > On Tue, Jan 30, 2018 at 11:59:47PM -0800, Eric Biggers wrote: > >> On Fri, Dec 01, 2017 at 04:22:00PM -0800, syzbot wrote: > >> > syzkaller has found reproducer for the fol

Re: kernel BUG at drivers/android/binder_alloc.c:LINE!

2018-01-31 Thread Dan Carpenter
On Tue, Jan 30, 2018 at 11:59:47PM -0800, Eric Biggers wrote: > On Fri, Dec 01, 2017 at 04:22:00PM -0800, syzbot wrote: > > syzkaller has found reproducer for the following crash on > > 3c1c4ddffb58b9e10b3365764fe59546130b3f32 > > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/mas

Re: kernel BUG at drivers/android/binder_alloc.c:LINE!

2018-01-31 Thread Eric Biggers
On Fri, Dec 01, 2017 at 04:22:00PM -0800, syzbot wrote: > syzkaller has found reproducer for the following crash on > 3c1c4ddffb58b9e10b3365764fe59546130b3f32 > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw c