Re: [External] Re: staging: Add MA USB Host driver

2020-01-22 Thread Vladimir Stankovic
On 22.1.20. 09:49, gre...@linuxfoundation.org wrote: > A: http://en.wikipedia.org/wiki/Top_post > > Q: Were do I find info about this thing called top-posting? > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting su

Re: [External] Re: staging: Add MA USB Host driver

2020-01-22 Thread gre...@linuxfoundation.org
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I includ

Re: [External] Re: staging: Add MA USB Host driver

2020-01-22 Thread Vladimir Stankovic
Hi Greg, It was section 2.5 of the kernel development process, "staging trees". In particular, statement "where many sub-directories for drivers or filesystems that are on their way to being added to the kernel tree live" caught our attention. Now, by reading it once again, I see that the rest

Re: [External] Re: staging: Add MA USB Host driver

2020-01-21 Thread gre...@linuxfoundation.org
On Wed, Jan 22, 2020 at 07:40:59AM +, Vladimir Stankovic wrote: > Hi Greg, > > Our intention was to follow Linux kernel development process and add our > driver to staging first. That's not the "normal" development process at all, where did you read that? staging is only for code that needs

Re: [External] Re: staging: Add MA USB Host driver

2020-01-21 Thread Vladimir Stankovic
Hi Greg, Our intention was to follow Linux kernel development process and add our driver to staging first. Will resubmit patch with TODO added. Regards, Vladimir On 22.1.20. 08:03, gre...@linuxfoundation.org wrote: > On Mon, Jan 20, 2020 at 09:30:43AM +, Vladimir Stankovic wrote: >> MA-USB H

Re: staging: Add MA USB Host driver

2020-01-21 Thread gre...@linuxfoundation.org
On Mon, Jan 20, 2020 at 09:30:43AM +, Vladimir Stankovic wrote: > MA-USB Host driver provides USB connectivity over an available > network, allowing host device to access remote USB devices attached > to one or more MA USB devices (accessible via network). > > This driver has been developed to

Re: staging: Add MA USB Host driver

2020-01-21 Thread Dan Carpenter
On Mon, Jan 20, 2020 at 09:30:43AM +, Vladimir Stankovic wrote: > +int mausb_enqueue_event_from_user(uint8_t madev_addr, uint32_t all_events) > +{ > + unsigned long flags; > + uint16_t num_of_completed, > + num_of_events; > + struct mausb_device *dev; > + > + spin_l

Re: staging: Add MA USB Host driver

2020-01-20 Thread Dan Carpenter
This code is not terrible. It would have helped a lot if you had run it through checkpatch --strict. This driver initializes most local variables to zero which disables GCC's uninitialized error variable checking and generally makes the code harder to understand. Try to remove this as much as yo