Re: [PATCH] staging: fix macros with multiple statements in rtl8723bs/core/rtw_security.c

2017-05-25 Thread Jamie Huang
On Thu, 25 May 2017 09:15:33 +1000 "Tobin C. Harding" wrote: > On Wed, May 24, 2017 at 10:38:57PM +0800, Jamie Huang wrote: > > Comment on your patch subject line. Patches to staging typically > include the driver in the subject. You can view previous commits to > get an idea

Re: [PATCH] staging: fix macros with multiple statements in rtl8723bs/core/rtw_security.c

2017-05-24 Thread Tobin C. Harding
On Wed, May 24, 2017 at 10:38:57PM +0800, Jamie Huang wrote: Comment on your patch subject line. Patches to staging typically include the driver in the subject. You can view previous commits to get an idea using $ git log --pretty=oneline drivers/staging/rtl8723bs/core/rtw_security.c And from

[PATCH] staging: fix macros with multiple statements in rtl8723bs/core/rtw_security.c

2017-05-24 Thread Jamie Huang
ERROR: Macros with multiple statements should be enclosed in a do - while loop Detected by scripts/checkpatch.pl -f Signed-off-by: Jamie Huang --- drivers/staging/rtl8723bs/core/rtw_security.c | 120 -- 1 file changed, 73 insertions(+), 47

Re: [PATCH] staging: fix macros with multiple statements in rtl8723bs/core/rtw_security.c

2017-05-12 Thread Greg KH
On Sun, May 07, 2017 at 06:23:14PM +0800, Jamie Huang wrote: > On Sat, 6 May 2017 20:20:57 -0700 > Greg KH wrote: > > > On Fri, May 05, 2017 at 02:00:43AM +0800, Jamie Huang wrote: > > > ERROR: Macros with multiple statements should be enclosed in a do - > > > while

Re: [PATCH] staging: fix macros with multiple statements in rtl8723bs/core/rtw_security.c

2017-05-07 Thread Jamie Huang
On Sat, 6 May 2017 20:20:57 -0700 Greg KH wrote: > On Fri, May 05, 2017 at 02:00:43AM +0800, Jamie Huang wrote: > > ERROR: Macros with multiple statements should be enclosed in a do - > > while loop Detected by scripts/checkpatch.pl -f > > > > Signed-off-by: Jamie

Re: [PATCH] staging: fix macros with multiple statements in rtl8723bs/core/rtw_security.c

2017-05-06 Thread Greg KH
On Fri, May 05, 2017 at 02:00:43AM +0800, Jamie Huang wrote: > ERROR: Macros with multiple statements should be enclosed in a do - while loop > Detected by scripts/checkpatch.pl -f > > Signed-off-by: Jamie Huang > --- > drivers/staging/rtl8723bs/core/rtw_security.c | 34 >

Re: staging: fix macros with multiple statements in rtl8723bs/core/rtw_security.c

2017-05-04 Thread kbuild test robot
Hi Jamie, [auto build test ERROR on staging/staging-testing] [also build test ERROR on next-20170504] [cannot apply to v4.11] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH] staging: fix macros with multiple statements in rtl8723bs/core/rtw_security.c

2017-05-04 Thread Jamie Huang
ERROR: Macros with multiple statements should be enclosed in a do - while loop Detected by scripts/checkpatch.pl -f Signed-off-by: Jamie Huang --- drivers/staging/rtl8723bs/core/rtw_security.c | 34 +++ 1 file changed, 24 insertions(+), 10

Re: staging: fix macros with multiple statements in rtl8723bs/core/rtw_security.c

2017-05-04 Thread Jamie Huang
On Thu, 4 May 2017 11:57:48 +0300 Dan Carpenter wrote: > Read the first couple paragraphs of > Documentation/process/email-clients.rst for how to send patches. > > > @@ -2236,10 +2248,12 @@ static void rijndaelEncrypt(u32 rk[/*44*/], > > u8 pt[16], u8 ct[16]) s3 =

Re: staging: fix macros with multiple statements in rtl8723bs/core/rtw_security.c

2017-05-04 Thread Dan Carpenter
Read the first couple paragraphs of Documentation/process/email-clients.rst for how to send patches. > @@ -2236,10 +2248,12 @@ static void rijndaelEncrypt(u32 rk[/*44*/], u8 > pt[16], u8 ct[16]) > s3 = GETU32(pt + 12) ^ rk[3]; > > #define ROUND(i, d, s) \ > -d##0 = TE0(s##0) ^ TE1(s##1)

staging: fix macros with multiple statements in rtl8723bs/core/rtw_security.c

2017-05-04 Thread Jamie Huang
ging: fix macros with multiple statements in rtl8723bs/core/rtw_security.c ERROR: Macros with multiple statements should be enclosed in a do - while loop Detected by scripts/checkpatch.pl -f Signed-off-by: Jamie Huang <jamiens...@163.com> --- drivers/staging/rtl8723bs/core/rtw_