Re: [PATCH 0/6] Re-instate octeon staging drivers

2020-03-04 Thread Chris Packham
On Wed, 2020-03-04 at 12:50 +0100, Greg KH wrote: > On Wed, Mar 04, 2020 at 06:25:34PM +0800, YunQiang Su wrote: > > Greg KH 于2020年3月4日周三 下午2:39写道: > > > > > > On Wed, Mar 04, 2020 at 09:48:46AM +0800, YunQiang Su wrote: > > > > Greg KH 于2020年2月13日周四 上午5:52写道: > > > > > > > > > > On Wed, Feb 05

Re: [PATCH 0/6] Re-instate octeon staging drivers

2020-03-04 Thread Greg KH
On Wed, Mar 04, 2020 at 06:25:34PM +0800, YunQiang Su wrote: > Greg KH 于2020年3月4日周三 下午2:39写道: > > > > On Wed, Mar 04, 2020 at 09:48:46AM +0800, YunQiang Su wrote: > > > Greg KH 于2020年2月13日周四 上午5:52写道: > > > > > > > > On Wed, Feb 05, 2020 at 01:11:10PM +1300, Chris Packham wrote: > > > > > This se

Re: [PATCH 0/6] Re-instate octeon staging drivers

2020-03-04 Thread YunQiang Su
Greg KH 于2020年3月4日周三 下午2:39写道: > > On Wed, Mar 04, 2020 at 09:48:46AM +0800, YunQiang Su wrote: > > Greg KH 于2020年2月13日周四 上午5:52写道: > > > > > > On Wed, Feb 05, 2020 at 01:11:10PM +1300, Chris Packham wrote: > > > > This series re-instates the octeon drivers that were recently removed > > > > and

Re: [PATCH 0/6] Re-instate octeon staging drivers

2020-03-03 Thread Greg KH
On Wed, Mar 04, 2020 at 09:48:46AM +0800, YunQiang Su wrote: > Greg KH 于2020年2月13日周四 上午5:52写道: > > > > On Wed, Feb 05, 2020 at 01:11:10PM +1300, Chris Packham wrote: > > > This series re-instates the octeon drivers that were recently removed and > > > addresses the build issues that lead to that d

Re: [PATCH 0/6] Re-instate octeon staging drivers

2020-03-03 Thread YunQiang Su
Greg KH 于2020年2月13日周四 上午5:52写道: > > On Wed, Feb 05, 2020 at 01:11:10PM +1300, Chris Packham wrote: > > This series re-instates the octeon drivers that were recently removed and > > addresses the build issues that lead to that decision. > > > > I've approached Cavium/Marvell about taking a more act

Re: [PATCH 0/6] Re-instate octeon staging drivers

2020-02-12 Thread Greg KH
On Wed, Feb 05, 2020 at 01:11:10PM +1300, Chris Packham wrote: > This series re-instates the octeon drivers that were recently removed and > addresses the build issues that lead to that decision. > > I've approached Cavium/Marvell about taking a more active interest in getting > the code out of st

[PATCH 0/6] Re-instate octeon staging drivers

2020-02-04 Thread Chris Packham
This series re-instates the octeon drivers that were recently removed and addresses the build issues that lead to that decision. I've approached Cavium/Marvell about taking a more active interest in getting the code out of staging and into their proper location. No reply on that (yet). Chris Pack

Re: [PATCH 0/2] Use ccm(aes) aead transform in staging drivers

2019-08-16 Thread Ard Biesheuvel
On Fri, 16 Aug 2019 at 10:00, Christina Quast wrote: > > Use ccm(aes) aead transform instead of invoking the AES block cipher > block by block. > Thanks! This eliminates another two users of the bare cipher API, which is not the right abstraction for drivers to use. Reviewed-by: Ard Biesheuvel

[PATCH 0/2] Use ccm(aes) aead transform in staging drivers

2019-08-16 Thread Christina Quast
Use ccm(aes) aead transform instead of invoking the AES block cipher block by block. Christina Quast (2): staging: rtl8192u: ieee80211: ieee80211_crypt_ccmp.c: Use crypto API ccm(aes) staging: rtl8192e: rtllib_crypt_ccmp.c: Use crypto API ccm(aes) drivers/staging/rtl8192e/Kconfig

Re: [PATCH v2] staging: drivers: rtl8712: removing unnecessary parenthesis

2019-08-15 Thread Greg KH
On Thu, Aug 15, 2019 at 11:26:40AM -0400, hugoziviani wrote: > Fix checkpatch error "CHECK: Remove unecessary parenthesis in > drivers/staging/rtl8712/rtl871x_mlme.c" > > Signed-off-by: hugoziviani > --- > drivers/staging/rtl8712/rtl871x_mlme.c | 84 +- > 1 file changed,

[PATCH v2] staging: drivers: rtl8712: removing unnecessary parenthesis

2019-08-15 Thread hugoziviani
Fix checkpatch error "CHECK: Remove unecessary parenthesis in drivers/staging/rtl8712/rtl871x_mlme.c" Signed-off-by: hugoziviani --- drivers/staging/rtl8712/rtl871x_mlme.c | 84 +- 1 file changed, 42 insertions(+), 42 deletions(-) diff --git a/drivers/staging/rtl8712/rt

Re: [PATCH] staging: drivers: rtl8712: removing unnecessary parenthesis

2019-08-12 Thread Greg KH
On Fri, Aug 09, 2019 at 11:18:23PM -0400, Hugo Eduardo Ziviani wrote: > Fix checkpatch error "CHECK: Remove unecessary parenthesis in > drivers/staging/rtl8712/rtl871x_mlme.c" > > Signed-off-by: Hugo Eduardo Ziviani > --- > drivers/staging/rtl8712/rtl871x_mlme.c | 89 +-

[PATCH] staging: drivers: rtl8712: removing unnecessary parenthesis

2019-08-09 Thread Hugo Eduardo Ziviani
Fix checkpatch error "CHECK: Remove unecessary parenthesis in drivers/staging/rtl8712/rtl871x_mlme.c" Signed-off-by: Hugo Eduardo Ziviani --- drivers/staging/rtl8712/rtl871x_mlme.c | 89 +- 1 file changed, 44 insertions(+), 45 deletions(-) diff --git a/drivers/staging/r

Re: [PATCH] media: schedule removal for legacy staging drivers

2019-06-25 Thread Sakari Ailus
On Tue, Jun 25, 2019 at 08:48:26AM -0300, Mauro Carvalho Chehab wrote: > Keeping legacy problematic code forever is not a good idea. > > So, let's schedule a date for those legacy stuff to rest in piece. > > If someone wants to steps up and take them from the staging ostracism > and do give them

[PATCH] media: schedule removal for legacy staging drivers

2019-06-25 Thread Mauro Carvalho Chehab
Keeping legacy problematic code forever is not a good idea. So, let's schedule a date for those legacy stuff to rest in piece. If someone wants to steps up and take them from the staging ostracism and do give them a rejuvenation shower in order to address the isues pointed on their TODO lists, be

[PATCH 0/3] Fixing style errors in staging/drivers/rtl8192u

2019-06-03 Thread Christian Müller
This series of patches fixes various style errors in the rtl8192u staging driver. These fixes contain reformatting of code comments, changing of indentations, cleaning up commented out code within the source-code and fixes for individual errors indicated by the checkpatch tool. Christian Müller (1

Re: [PATCH] staging drivers fixed coding style error

2017-07-13 Thread Greg KH
On Thu, Jul 13, 2017 at 07:17:56AM -0700, smklearn wrote: > Fixed coding style error flagged checkpatch.pl: > - ERROR: space prohibited after that open parenthesis '(' > - WARNING: Block comments use * on subsequent lines > > Signed-off-by: Shy More > > Output after fixing coding sty

[PATCH] staging drivers fixed coding style error

2017-07-13 Thread smklearn
Fixed coding style error flagged checkpatch.pl: - ERROR: space prohibited after that open parenthesis '(' - WARNING: Block comments use * on subsequent lines Signed-off-by: Shy More Output after fixing coding style issues: $KERN/scripts/checkpatch.pl -f ./media/atomisp/p

Re: [PATCHv2] Checkpatch fixes for staging/drivers/ks7010.

2017-02-24 Thread Greg KH
On Wed, Feb 22, 2017 at 01:52:58PM -0800, Matthew Giassa wrote: > Wrapping complex macros with parentheses. > Adding extra spaces between macros and integer literals. > Indentation changes to remove checkpatch warnings. > Swapping out C++-style comments with C-style comments. > > Signed-off-by: Ma

[PATCHv2] Checkpatch fixes for staging/drivers/ks7010.

2017-02-22 Thread Matthew Giassa
Wrapping complex macros with parentheses. Adding extra spaces between macros and integer literals. Indentation changes to remove checkpatch warnings. Swapping out C++-style comments with C-style comments. Signed-off-by: Matthew Giassa --- drivers/staging/ks7010/ks_wlan_ioctl.h | 74 +

[PATCH 1/2] Revert "Staging: drivers: rtl8188eu: use sizeof(*ptr) instead of sizeof(struct)"

2016-06-05 Thread Hans de Goede
This reverts commit 99aded71b52c ("Staging: drivers: rtl8188eu: use sizeof(*ptr) instead of sizeof(struct)"). This commit is wrong, as adapt->HalData has a type of "void *", so now we are allocating a much to small struct, which causes the driver to overwrite random memo

[PATCH 10/11] Staging: drivers: rtl8188eu: fixed if-NULL comparisons style

2016-05-01 Thread Jacky Boen
Fixed coding style issue Signed-off-by: Jacky Boen --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 82269eb..ef04638 100644 ---

[PATCH 03/11] Staging: drivers: rtl8188eu: fixed block comments style

2016-05-01 Thread Jacky Boen
Fixed coding style issue Signed-off-by: Jacky Boen --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 7831f19..507e448 100644

[PATCH 08/11] Staging: drivers: rtl8188eu: fixed extraneous parentheses

2016-05-01 Thread Jacky Boen
Fix coding style issue Signed-off-by: Jacky Boen --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 30 ++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index f5

[PATCH 11/11] Staging: drivers: rtl8188eu: use sizeof(*ptr) instead of sizeof(struct)

2016-05-01 Thread Jacky Boen
Fix coding style issue Signed-off-by: Jacky Boen --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index ef04638..13c1277 100644 --- a/dr

[PATCH 06/11] Staging: drivers: rtl8188eu: fixed unnecessary else branch

2016-05-01 Thread Jacky Boen
Fixed coding style issue Signed-off-by: Jacky Boen --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 814ecec..c37ba49 100644 ---

[PATCH 09/11] Staging: drivers: rtl8188eu: fixed extraneous spaces

2016-05-01 Thread Jacky Boen
Fix coding style issue Signed-off-by: Jacky Boen --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index a3fffd7..82269eb 100644 --- a/

[PATCH 02/11] Staging: drivers: rtl8188eu: fixed typo

2016-05-01 Thread Jacky Boen
Fixed typo Signed-off-by: Jacky Boen --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index c5e5d52..7831f19 100644 --- a/drivers/staging/

[PATCH 05/11] Staging: drivers: rtl8188eu: fixed brace style

2016-05-01 Thread Jacky Boen
Fixed coding style issue Signed-off-by: Jacky Boen --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 58d38d6..814ecec 100644 --- a/

[PATCH 04/11] Staging: drivers: rtl8188eu: fixed newlines style

2016-05-01 Thread Jacky Boen
Fixed coding style issue Signed-off-by: Jacky Boen --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 507e448..58d38d6 100644 --

[PATCH 07/11] Staging: drivers: rtl8188eu: fixed extraneous indentation

2016-05-01 Thread Jacky Boen
Fixed coding style issue Signed-off-by: Jacky Boen --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index c37ba49..f5e8ac0 100644 --- a/dr

[PATCH 01/11] Staging: drivers: rtl8188eu: move constants to the right in comparisons

2016-05-01 Thread Jacky Boen
Fixed coding style issue Signed-off-by: Jacky Boen --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 07a61b8..c5e5d52 100644 ---

RE: staging drivers

2015-07-20 Thread Weiny, Ira
> On 07/17/2015 02:14 AM, Greg Kroah-Hartman (gre...@linuxfoundation.org) > wrote: > > > > It's up to the IB maintainer if they are willing to let it be in > > stable as-is. > > I wouldn't call it stable as-is. However, that doesn't mean I think it > *must* go to staging. It's a first cut at a t

Re: staging drivers

2015-07-16 Thread Doug Ledford
On 07/17/2015 02:14 AM, Greg Kroah-Hartman (gre...@linuxfoundation.org) wrote: > On Thu, Jul 16, 2015 at 07:18:46PM +, Marciniszyn, Mike wrote: >> Greg, >> >> We are in the process of submitting an RDMA driver for the Intel OPA >> architecture. > > I have no idea what "OPA" is, sorry. Omni-P

Re: staging drivers

2015-07-16 Thread Greg Kroah-Hartman (gre...@linuxfoundation.org)
On Thu, Jul 16, 2015 at 07:18:46PM +, Marciniszyn, Mike wrote: > Greg, > > We are in the process of submitting an RDMA driver for the Intel OPA > architecture. I have no idea what "OPA" is, sorry. > The current massive patch set is submitted to add the driver to the > infiniband tree. >

Re: [PATCH] Staging: drivers: dgnc

2015-07-16 Thread Joe Perches
On Fri, 2015-07-17 at 00:20 +, Craig Inches wrote: > Hi Joe, Rehi Craig. > On Thu, Jul 16, 2015 at 08:30:53AM -0700, Joe Perches wrote: > > On Thu, 2015-07-16 at 23:11 +, Craig Inches wrote: > > > Fixed up some checkpatch.pl style issues. > > > Line greater than 80 Chars in multiple locat

Re: [PATCH] Staging: drivers: dgnc

2015-07-16 Thread Craig Inches
Hi Joe, On Thu, Jul 16, 2015 at 08:30:53AM -0700, Joe Perches wrote: > On Thu, 2015-07-16 at 23:11 +, Craig Inches wrote: > > Fixed up some checkpatch.pl style issues. > > Line greater than 80 Chars in multiple locations. > > I think most all of these are not improvements. Ok, can you

Re: [PATCH] Staging: drivers: dgnc

2015-07-16 Thread Greg KH
On Thu, Jul 16, 2015 at 11:11:33PM +, Craig Inches wrote: > Fixed up some checkpatch.pl style issues. > Line greater than 80 Chars in multiple locations. > > Signed-off-by: Craig Inches > --- > drivers/staging/dgnc/dgnc_tty.c | 168 > ++-- > 1 file change

[PATCH] Staging: drivers: dgnc

2015-07-16 Thread Craig Inches
Fixed up some checkpatch.pl style issues. Line greater than 80 Chars in multiple locations. Signed-off-by: Craig Inches --- drivers/staging/dgnc/dgnc_tty.c | 168 ++-- 1 file changed, 110 insertions(+), 58 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_t

Re: [PATCH] Staging: drivers: dgnc

2015-07-16 Thread Joe Perches
On Thu, 2015-07-16 at 23:11 +, Craig Inches wrote: > Fixed up some checkpatch.pl style issues. > Line greater than 80 Chars in multiple locations. I think most all of these are not improvements. Please use --strict when verifying your patches. Please fix the time on your system.

staging drivers

2015-07-16 Thread Marciniszyn, Mike
Greg, We are in the process of submitting an RDMA driver for the Intel OPA architecture. The current massive patch set is submitted to add the driver to the infiniband tree. I'm wondering if the staging area is a better spot to land the driver at first? That way everyone can see it being rew

Re: [PATCH] Staging: drivers: dgnc

2015-07-16 Thread Craig Inches
On Fri, Jul 17, 2015 at 12:20:42AM +, Craig Inches wrote: > Hi Joe, > > On Thu, Jul 16, 2015 at 08:30:53AM -0700, Joe Perches wrote: > > On Thu, 2015-07-16 at 23:11 +, Craig Inches wrote: > > > Fixed up some checkpatch.pl style issues. > > > Line greater than 80 Chars in multiple locations

[PATCH v2 1/2] staging: drivers: rtl8192u: r819xU_firmware.h: removed commented macro

2015-06-01 Thread Buţiu Alexandru Octavian
Removed commented macro that was no longer needed Signed-off-by: Buţiu Alexandru Octavian --- drivers/staging/rtl8192u/r819xU_firmware.h | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8192u/r819xU_firmware.h b/drivers/staging/rtl8192u/r819xU_firmware.h index cfa22

Re: UAPI headers in staging drivers?

2014-06-02 Thread Greg KH
On Mon, Jun 02, 2014 at 04:00:28PM -0700, Mitchel Humpherys wrote: > What's the protocol for UAPI headers in staging drivers? Specifically, > I'm wondering how people usually install those headers. For example, > there are a bunch of Android UAPI headers under > drivers/stag

UAPI headers in staging drivers?

2014-06-02 Thread Mitchel Humpherys
What's the protocol for UAPI headers in staging drivers? Specifically, I'm wondering how people usually install those headers. For example, there are a bunch of Android UAPI headers under drivers/staging/android/uapi which currently end up at /drivers with a call to `make headers_ins

[PATCH V3] drivers/staging: drivers/staging: Remove useless return variables

2014-05-26 Thread Peter Senna Tschudin
This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that find and fixes this issue is: // @@ type T; constant C; identif

[PATCH 0/3] Fix some bugs in staging drivers

2014-04-09 Thread Larry Finger
While analyzing parts of the recently merged r8723au driver, Jes Sorensen found two bugs that are found in other Reaktek drivers in staging. This set of patches fixes them. Signed-off-by: Larry Finger Larry Finger (3): staging: r8188eu: Calling rtw_get_stainfo() with a NULL sta_addr will

[patch V2 0/8] staging: Drivers to support Unisys Secure Partitioning

2014-03-04 Thread Ken Cox
This series includes a base set of drivers for the Unisys s-Par system. This set of drivers is enough to get a virtual guest up and running on s-Par hardware. The remaining drivers needed to have a fully functional system will be submitted after review of this initial set. s-Par is firmware that

Re: [patch 0/8] staging: Drivers to support Unisys Secure Partitioning

2014-03-03 Thread Dan Carpenter
On Mon, Mar 03, 2014 at 01:24:05PM -0600, Ken Cox wrote: > > On 03/03/2014 01:12 PM, Greg KH wrote: > >Why do you want these in the drivers/staging/ part of the kernel? I > >have my guesses, but you need to tell me why :) > Frankly, I wasn't sure of the most appropriate place since this is a > co

Re: [patch 0/8] staging: Drivers to support Unisys Secure Partitioning

2014-03-03 Thread Ken Cox
On 03/03/2014 01:22 PM, Dan Carpenter wrote: What software do we need to test this? Is there a quick start guide? Unisys hardware/firmware is required. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailma

Re: [patch 0/8] staging: Drivers to support Unisys Secure Partitioning

2014-03-03 Thread Ken Cox
;ll be happy to move them over. Also, I need a TODO file, like the rest of the staging drivers have, listing what needs to be done to get the code out of staging, and who is responsible for the code. Ideally, a MAINTAINERS entry as well, so that the same people get copied when people use scripts/ge

Re: [patch 0/8] staging: Drivers to support Unisys Secure Partitioning

2014-03-03 Thread Dan Carpenter
What software do we need to test this? Is there a quick start guide? regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [patch 0/8] staging: Drivers to support Unisys Secure Partitioning

2014-03-03 Thread Greg KH
he adapter service partition. Why do you want these in the drivers/staging/ part of the kernel? I have my guesses, but you need to tell me why :) Also, I need a TODO file, like the rest of the staging drivers have, listing what needs to be done to get the code out of staging, and who is responsi

[patch 0/8] staging: Drivers to support Unisys Secure Partitioning

2014-03-03 Thread Ken Cox
This series includes a base set of drivers for the Unisys s-Par system. This set of drivers is enough to get a virtual guest up and running on s-Par hardware. The remaining drivers needed to have a fully functional system will be submitted after review of this initial set. s-Par is firmware that

Re: Question about staging drivers

2014-02-21 Thread Dan Carpenter
On Fri, Feb 21, 2014 at 10:37:26AM -0500, Mark Hounschell wrote: > When a kernel subsystem undergoes a global change such as the serial > subsystem has been since 3.5 or so, if a driver is in staging, does it > automatically get those changes if they are applicable to it? Yes. If you change an AP

Re: Question about staging drivers

2014-02-21 Thread Greg KH
On Fri, Feb 21, 2014 at 10:37:26AM -0500, Mark Hounschell wrote: > When a kernel subsystem undergoes a global change such as the serial > subsystem has been since 3.5 or so, if a driver is in staging, does it > automatically get those changes if they are applicable to it? Yes it does.

Question about staging drivers

2014-02-21 Thread Mark Hounschell
When a kernel subsystem undergoes a global change such as the serial subsystem has been since 3.5 or so, if a driver is in staging, does it automatically get those changes if they are applicable to it? Thanks Mark ___ devel mailing list de...@linuxdriver