On 27.11.2013, at 07:47, Gordon Hollingworth wrote:
> In general it should be possible to schedule multiple split
> transactions to a TT but they _must_ be completed on time or the hub
> will drop the transactions on the floor... Unfortunately because of
> the interrupt latency issues it cannot be
On Wed, Nov 27, 2013 at 03:45:12PM +0800, ZHAO Gang wrote:
> @@ -2208,8 +2204,11 @@ static int et131x_rx_dma_memory_alloc(struct
> et131x_adapter *adapter)
> rx_ring = &adapter->rx_ring;
>
> /* Alloc memory for the lookup table */
> - rx_ring->fbr[0] = kmalloc(sizeof(struct fbr_l
On Wed, Nov 27, 2013 at 11:01:18AM +0800, Chen Gang wrote:
> If "!bool_case", it returns unexpected value instead of STATUS_SUCCESS,
> so need fix it, the related warning (with allmodconfig under hexagon):
>
> CC [M] drivers/staging/ft1000/ft1000-usb/ft1000_download.o
> drivers/staging/ft10
On 11/27/2013 05:18 PM, Josh Triplett wrote:
> On Wed, Nov 27, 2013 at 11:01:18AM +0800, Chen Gang wrote:
>> If "!bool_case", it returns unexpected value instead of STATUS_SUCCESS,
>> so need fix it, the related warning (with allmodconfig under hexagon):
>>
>> CC [M] drivers/staging/ft1000/ft1
Ok, yeah. This patch is the right thing. I had a couple minor style
complaints.
On Wed, Nov 27, 2013 at 03:45:12PM +0800, ZHAO Gang wrote:
> The original code allocate rx dma memory in several dma_alloc_coherent calls,
> which causes some problems:
> 1. since dma_alloc_coherent allocate at least
On Wed, Nov 27, 2013 at 03:45:14PM +0800, ZHAO Gang wrote:
> fix make -W1 warning:
> drivers/staging/et131x//et131x.c: In function
> ‘et1310_setup_device_for_multicast’:
> drivers/staging/et131x//et131x.c:1055:6: warning: variable ‘pm_csr’ set but
> not used [-Wunused-but-set-variable]
> u32 pm
Line 633: Removed whitespace.
Signed-off-by: Aldo Iljazi
---
drivers/staging/ced1401/ced_ioc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ced1401/ced_ioc.c
b/drivers/staging/ced1401/ced_ioc.c
index 62efd74..043a932 100644
--- a/drivers/staging/ced1401/ce
On Wed, Nov 27, 2013 at 12:24:22PM +0800, Chen Gang wrote:
> On 11/27/2013 12:03 PM, Greg KH wrote:
> > On Wed, Nov 27, 2013 at 11:48:08AM +0800, Chen Gang wrote:
> >> dev_*() assumes 'go' is already initialized, so need use pr_*() instead
> >> of before 'go' initialized. Related warning (with allm
On 2013-11-26 23:41, H Hartley Sweeten wrote:
There are a lot of debugging messages in the comedi drivers that are
just added noise. Some of them messages are worth keeping but they
should be converted to the appropriate dev_{level} format.
This series is a first pass at cleaning this up.
H Har
On Wed, Nov 27, 2013 at 5:02 PM, Dan Carpenter wrote:
> On Wed, Nov 27, 2013 at 03:45:12PM +0800, ZHAO Gang wrote:
>> @@ -2208,8 +2204,11 @@ static int et131x_rx_dma_memory_alloc(struct
>> et131x_adapter *adapter)
>> rx_ring = &adapter->rx_ring;
>>
>> /* Alloc memory for the lookup ta
On Wed, Nov 27, 2013 at 07:37:30PM +0800, ZHAO Gang wrote:
> On Wed, Nov 27, 2013 at 5:02 PM, Dan Carpenter
> wrote:
> > On Wed, Nov 27, 2013 at 03:45:12PM +0800, ZHAO Gang wrote:
> >> @@ -2208,8 +2204,11 @@ static int et131x_rx_dma_memory_alloc(struct
> >> et131x_adapter *adapter)
> >> rx
On Wed, Nov 27, 2013 at 6:06 PM, Dan Carpenter wrote:
> Ok, yeah. This patch is the right thing. I had a couple minor style
> complaints.
I am happy to hear this.
>
> On Wed, Nov 27, 2013 at 03:45:12PM +0800, ZHAO Gang wrote:
>> The original code allocate rx dma memory in several dma_alloc_coh
On Wed, Nov 27, 2013 at 08:43:57PM +0800, ZHAO Gang wrote:
> >> + /* Update the pointer */
> >> + dma_addr += fbr->buffsize;
> >
> > Do the virt_addr update here as well.
> > virt_addr += fbr->buffsize;
> >
>
>
On Wed, Nov 27, 2013 at 8:04 PM, Dan Carpenter wrote:
> On Wed, Nov 27, 2013 at 07:37:30PM +0800, ZHAO Gang wrote:
>> On Wed, Nov 27, 2013 at 5:02 PM, Dan Carpenter
>> wrote:
>> > On Wed, Nov 27, 2013 at 03:45:12PM +0800, ZHAO Gang wrote:
>> >> @@ -2208,8 +2204,11 @@ static int et131x_rx_dma_mem
On Wed, Nov 27, 2013 at 6:13 PM, Dan Carpenter wrote:
> On Wed, Nov 27, 2013 at 03:45:14PM +0800, ZHAO Gang wrote:
>> fix make -W1 warning:
>> drivers/staging/et131x//et131x.c: In function
>> ‘et1310_setup_device_for_multicast’:
>> drivers/staging/et131x//et131x.c:1055:6: warning: variable ‘pm_cs
On Wed, Nov 27, 2013 at 9:26 PM, Dan Carpenter wrote:
> On Wed, Nov 27, 2013 at 08:43:57PM +0800, ZHAO Gang wrote:
>> >> + /* Update the pointer */
>> >> + dma_addr += fbr->buffsize;
>> >
>> > Do the virt_addr update here as well.
>> >
On Wed, Nov 27, 2013 at 09:38:02PM +0800, ZHAO Gang wrote:
> On Wed, Nov 27, 2013 at 6:13 PM, Dan Carpenter
> wrote:
> > On Wed, Nov 27, 2013 at 03:45:14PM +0800, ZHAO Gang wrote:
> >> fix make -W1 warning:
> >> drivers/staging/et131x//et131x.c: In function
> >> ‘et1310_setup_device_for_multicas
alarm-dev.c:
Lines 71,72: Removed parantheses since return is not a function.
Signed-off-by: Aldo Iljazi
---
drivers/staging/android/alarm-dev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/alarm-dev.c
b/drivers/staging/android/alarm-dev.c
ind
On Tuesday, November 26, 2013 7:57 PM, Dave Jones wrote:
> Introduced in commit b3ff824a81e8.
>
> Signed-off-by: Dave Jones
>
> diff --git a/drivers/staging/comedi/drivers/pcl730.c
> b/drivers/staging/comedi/drivers/pcl730.c
> index d041b714db29..2baaf1db6fbf 100644
> --- a/drivers/staging/comedi
combine two dma_alloc_coherent to one
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 70 +++--
1 file changed, 19 insertions(+), 51 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 7c6031e..bafb
This patch set is based on previously sent v5 of seven patches for et131x.
The v2 version does all changes Dan suggested, except that I think
combine two kmalloc to one is a good(at least not so bad) idea, it
simplify error path in et131x_rx_dma_memory_alloc, and simplify
et131x_rx_dma_memory_free
The original code allocate rx dma memory in several dma_alloc_coherent calls,
which causes some problems:
1. since dma_alloc_coherent allocate at least one page memory, it wastes some
memory when allocation size is smaller than one page.
2. it causes et131x_rx_dma_memory_free as complex as et131
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 7305fb5..764f7d0 100644
--- a/drivers/staging/et131x/et131x.c
+++ b/drivers/staging/
fix make -W1 warning:
drivers/staging/et131x//et131x.c: In function
‘et1310_setup_device_for_multicast’:
drivers/staging/et131x//et131x.c:1055:6: warning: variable ‘pm_csr’ set but not
used [-Wunused-but-set-variable]
u32 pm_csr;
^
drivers/staging/et131x//et131x.c: In function ‘et1310_set
On Wednesday, November 27, 2013 9:39 AM, Hartley Sweeten wrote:
> On Tuesday, November 26, 2013 7:57 PM, Dave Jones wrote:
>> Introduced in commit b3ff824a81e8.
>>
>> Signed-off-by: Dave Jones
>>
>> diff --git a/drivers/staging/comedi/drivers/pcl730.c
>> b/drivers/staging/comedi/drivers/pcl730.c
On Wed, Nov 27, 2013 at 04:59:17PM +, Hartley Sweeten wrote:
> > Added Greg KH and the staging devel list to the CCs.
>
> I just noticed that Dan Carpenter already submitted a patch that fixed this.
> It was merged as commit 9382c06e2d192adec090fb09ff0b699e951f88e1.
Ah, I didn't look at
On Tuesday, November 26, 2013 4:42 PM, H Hartley Sweeten wrote:
> Tidy up the code that does the request_irq().
>
> Signed-off-by: H Hartley Sweeten
> Cc: Ian Abbott
> Cc: Greg Kroah-Hartman
> ---
> drivers/staging/comedi/drivers/pcl816.c | 33
> ++---
> 1 file chan
Tidy up the code that does the request_irq().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
v2: fix a bug in the original patch
drivers/staging/comedi/drivers/pcl816.c | 35 +++--
1 file changed, 7 insertions(+), 28 deletions(-)
diff -
Adding Jonathan.
> From: Paul Zimmerman
> Sent: Wednesday, November 27, 2013 11:34 AM
>
> > From: gordon.hollingwo...@gmail.com [mailto:gordon.hollingwo...@gmail.com]
> > On Behalf Of Gordon
> Hollingworth
> > Sent: Tuesday, November 26, 2013 10:48 PM
> > To: Stephen Warren
> > Cc: Paul Zimmerma
> From: gordon.hollingwo...@gmail.com [mailto:gordon.hollingwo...@gmail.com] On
> Behalf Of Gordon Hollingworth
> Sent: Tuesday, November 26, 2013 10:48 PM
> To: Stephen Warren
> Cc: Paul Zimmerman; Greg Kroah-Hartman; de...@driverdev.osuosl.org; linux-rpi-
> ker...@lists.infradead.org
> Subject:
On Thu, Nov 28, 2013 at 12:53:42AM +0800, ZHAO Gang wrote:
> Signed-off-by: ZHAO Gang
> ---
> drivers/staging/et131x/et131x.c | 11 ++-
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
> index 7305fb5..76
The following changes since commit 6ce4eac1f600b34f2f7f58f9cd8f0503d79e42ae:
Linux 3.13-rc1 (2013-11-22 11:30:55 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-3.13-rc2
for you to fetch changes up to 930ba4a374b
Signed-off-by: ZHAO Gang
---
I now see the good point of separating code style changes from others.
If your code is right, just edit code style change patch until reviewers
are satisfied :-)
drivers/staging/et131x/et131x.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
dif
On 11/27/2013 06:43 PM, Dan Carpenter wrote:
> On Wed, Nov 27, 2013 at 12:24:22PM +0800, Chen Gang wrote:
>> On 11/27/2013 12:03 PM, Greg KH wrote:
>>> On Wed, Nov 27, 2013 at 11:48:08AM +0800, Chen Gang wrote:
dev_*() assumes 'go' is already initialized, so need use pr_*() instead
of bef
From: Wei Yongjun
Fixes the following sparse warning:
drivers/staging/dwc2/core.c:2672:6: warning:
symbol 'dwc2_set_param_uframe_sched' was not declared. Should it be static?
Signed-off-by: Wei Yongjun
---
drivers/staging/dwc2/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
dif
On Thu, Nov 28, 2013 at 12:53:39AM +0800, ZHAO Gang wrote:
> @@ -2208,8 +2203,11 @@ static int et131x_rx_dma_memory_alloc(struct
> et131x_adapter *adapter)
> rx_ring = &adapter->rx_ring;
>
> /* Alloc memory for the lookup table */
> - rx_ring->fbr[0] = kmalloc(sizeof(struct fbr_l
36 matches
Mail list logo
