Re: [patch] Staging: vt6655-6: potential NULL dereference in hostap_disable_hostapd()

2014-01-15 Thread walter harms
Am 07.11.2013 08:55, schrieb Dan Carpenter: > We fixed this to use free_netdev() instead of kfree() but unfortunately > free_netdev() doesn't accept NULL pointers. Smatch complains about > this, it's not something I discovered through testing. > > Fixes: 3030d40b5036 ('staging: vt6655: use free

Re: [patch] Staging: vt6655-6: potential NULL dereference in hostap_disable_hostapd()

2014-01-15 Thread Dan Carpenter
This patch was merged a long time ago, but we still could change free_netdev() as well. I say go for it! regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v4] Staging: comedi: convert while loop to timeout in ni_mio_common.c

2014-01-15 Thread Ian Abbott
On 2014-01-15 03:58, Greg KH wrote: On Tue, Jan 14, 2014 at 06:23:05PM -0600, Chase Southwood wrote: This patch for ni_mio_common.c changes out a while loop for a timeout, which is preferred. Signed-off-by: Chase Southwood --- OK, here's another go at it. Hopefully everything looks more corr

Re: [PATCH v5] Staging: comedi: convert while loop to timeout in ni_mio_common.c

2014-01-15 Thread Ian Abbott
On 2014-01-15 05:15, Chase Southwood wrote: This patch for ni_mio_common.c changes out a while loop for a timeout, which is preferred. Signed-off-by: Chase Southwood --- All right, I think this guy's ready to go now! Thanks for all the help! Chase 2: Changed from simple clean-up to swapping

Re: [PATCH V2 1/1] Drivers: hv: Implement the file copy service

2014-01-15 Thread Olaf Hering
On Tue, Jan 14, K. Y. Srinivasan wrote: > +static int hv_start_fcopy(struct hv_start_fcopy *smsg) > + if (access((char *)smsg->path_name, F_OK)) { > + if (smsg->copy_flags & CREATE_PATH) { > + if (mkdir((char *)smsg->path_name, 0755)) { KY, I guess this needs

[PATCH v6] Staging: comedi: convert while loop to timeout in ni_mio_common.c

2014-01-15 Thread Chase Southwood
This patch for ni_mio_common.c changes out a while loop for a timeout, which is preferred. Signed-off-by: Chase Southwood --- 2: Changed from simple clean-up to swapping a timeout in for a while loop. 3: Removed extra counter variable, and added error checking. 4: No longer using counter varia

RE: [PATCH v4] Staging: comedi: convert while loop to timeout in ni_mio_common.c

2014-01-15 Thread Hartley Sweeten
On Tuesday, January 14, 2014 8:59 PM, Greg KH wrote: > Sleep for at least 10, as I think that's the smallest time delay you can > sleep for anyway (meaning it will be that long no matter what number you > put there less than 10, depending on the hardware used of course.) A bit off topic here but I

RE: [PATCH v6] Staging: comedi: convert while loop to timeout in ni_mio_common.c

2014-01-15 Thread Hartley Sweeten
On Wednesday, January 15, 2014 10:52 AM, Chase Southwood wrote: > This patch for ni_mio_common.c changes out a while loop for a timeout, > which is preferred. > > Signed-off-by: Chase Southwood > --- > > 2: Changed from simple clean-up to swapping a timeout in for a while loop. > > 3: Removed extr

RE: [PATCH V2 1/1] Drivers: hv: Implement the file copy service

2014-01-15 Thread KY Srinivasan
> -Original Message- > From: Olaf Hering [mailto:o...@aepfle.de] > Sent: Wednesday, January 15, 2014 8:33 AM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; a...@canonical.com; jasow...@redhat.com > Subject: Re: [PATCH V2

[PATCH v7] Staging: comedi: convert while loop to timeout in ni_mio_common.c

2014-01-15 Thread Chase Southwood
This patch for ni_mio_common.c changes out a while loop for a timeout, which is preferred. Signed-off-by: Chase Southwood --- Hartley, I sincerely apologize for the obvious mistake, I thought I had built it but clearly I made a mistake somewhere, as your observation is exactly correct. It is no

[PATCH] staging: ced1401: fix coding style in ced_ioc.c (resend)

2014-01-15 Thread Pol Eyschen
Fixed checkpatch.pl issues and removed redundant comment in ced_ioc.cs Signed-off-by: Pol Eyschen --- drivers/staging/ced1401/ced_ioc.c | 483 + 1 file changed, 271 insertions(+), 212 deletions(-) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/sta

[PATCH] Staging: android: fix parentheses coding style issue in alarm-dev.c

2014-01-15 Thread Michał Kwiatkowski
This is a patch to the alarm-dev.c file that removes parentheses which should not appear in return statement. This error was found by the checkpatch.pl tool. Signed-off-by: Michał Kwiatkowski --- drivers/staging/android/alarm-dev.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

Re: [PATCH 1/7] ptp_pch: Add dependency on HAS_IOMEM

2014-01-15 Thread David Miller
All 7 patches applied, thank you. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/1] Drivers: hv: vmbus: Specify the target CPU that should receive notification

2014-01-15 Thread K. Y. Srinivasan
During the initial VMBUS connect phase, starting with WS2012 R2, we should specify the VPCU in the guest that should receive the notification. Fix this issue. This fix is required to properly connect to the host in the kexeced kernel. Signed-off-by: K. Y. Srinivasan Cc: [3.9+] --- driver

Re: [PATCH v4] Staging: comedi: convert while loop to timeout in ni_mio_common.c

2014-01-15 Thread Greg KH
On Wed, Jan 15, 2014 at 06:29:21PM +, Hartley Sweeten wrote: > On Tuesday, January 14, 2014 8:59 PM, Greg KH wrote: > > Sleep for at least 10, as I think that's the smallest time delay you can > > sleep for anyway (meaning it will be that long no matter what number you > > put there less than 1