[PATCH] staging: android: fix coding style

2014-03-13 Thread mourn
From: mourn Signed-off-by: mourn --- drivers/staging/android/uapi/ion.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h index f09e7c1..6aa4956 100644 --- a/drivers/staging/android/uapi/io

Re: [PATCH 0/2] staging: comedi: drivers: replace poc driver with new dac02 driver

2014-03-13 Thread Ian Abbott
On 2014-03-11 19:04, H Hartley Sweeten wrote: The poc driver was a catch-all for some very simple boards. Most of the boards that used to be supported by this driver have been migrated to other common drivers. The only board remaining in it was the DAC02, a two channel analog output board. Int

Re: [PATCH] staging: android: fix coding style

2014-03-13 Thread Mark Einon
On Thu, Mar 13, 2014 at 10:44:55AM +0100, mo...@2600fr.org wrote: > From: mourn > > Signed-off-by: mourn > --- > drivers/staging/android/uapi/ion.h | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) The changes look good, however you should be a bit more specific about whic

Re: [PATCH] staging: android: fix coding style

2014-03-13 Thread Mark Einon
I'll try that again... On Thu, Mar 13, 2014 at 01:50:47PM +, Mark Einon wrote: > On Thu, Mar 13, 2014 at 10:44:55AM +0100, mo...@2600fr.org wrote: > > From: mourn > > > > Signed-off-by: mourn > > --- > > drivers/staging/android/uapi/ion.h | 12 ++-- > > 1 file changed, 6 insertio

Re: [PATCH] staging: android: fix coding style

2014-03-13 Thread mourn
> The changes look good, however you should be a bit more specific about > what the > fixes are, and that you used checkpatch.pl to find them (I assume). > Yes, you are right. I can edit the commit log. > Also, Signed-off-by: should state your full name, which I'm also assuming > isn't > 'mourn'

[PATCH] staging: comedi: 8255_pci: initialize MITE data window

2014-03-13 Thread Ian Abbott
According to National Instruments' PCI-DIO-96/PXI-6508/PCI-6503 User Manual, the physical address in PCI BAR1 needs to be OR'ed with 0x80 and written to register offset 0xC0 in the "MITE" registers (BAR0). Do so during initialization of the National Instruments boards handled by the "8255_pci" dri

Re: [PATCH 3/3] staging/ozwpan: coding style ether_addr_copy

2014-03-13 Thread Jérôme Pinot
On 03/13/14 02:28, Greg Kroah-Hartman wrote: > On Thu, Mar 13, 2014 at 10:21:44AM +0900, Jérôme Pinot wrote: [...] > > diff --git a/drivers/staging/ozwpan/ozcdev.c > > b/drivers/staging/ozwpan/ozcdev.c > > index 5de5981..10c0a96 100644 > > --- a/drivers/staging/ozwpan/ozcdev.c > > +++ b/drivers/st

[PATCH] staging/ozwpan: coding style ether_addr_copy

2014-03-13 Thread Jérôme Pinot
This fixes the following issues detected by checkpatch.pl: WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) #220: FILE: drivers/staging/ozwpan/ozcdev.c:220: + memcpy(g_cdev.active_addr, addr, ETH_ALEN); WARNING: Prefer ether_addr_copy()

[PATCH 0/8] staging: comedi: fl512: clean up driver

2014-03-13 Thread H Hartley Sweeten
I have been unable to locate any data on this board so I am unable to add any of the missing features. This clean up just gets the driver inline with the other cleaned up comedi drivers. H Hartley Sweeten (8): staging: comedi: fl512: tidy up subdevice init staging: comedi: fl512: rename the su

[PATCH 8/8] staging: comedi: fl512: tidy up the multi-line comments

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten Tidy up the multi-line comments to follow the CodingStyle. Add the GPL boilerplate comment found in other comedi drivers. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/fl512.c | 41 ++

[PATCH 3/8] staging: comedi: fl512: remove Fl512_SIZE define

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten This define is only used in the comedi_request_region() call to specify the size of the I/O region to request. Remove the define and just open code the value. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/fl5

[PATCH 5/8] staging: comedi: fl512: define the register map

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten Define the register map and remove the magic values and some unnecessary comments. For aesthetics, remove the 'iobase' local variable and use dev->iobase directly. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drive

[PATCH 7/8] staging: comedi: fl512: tidy up fl512_ao_insn_read()

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten Tidy up this function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/fl512.c | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/drivers/staging/comedi/drivers

[PATCH 2/8] staging: comedi: fl512: rename the subdevice (*insn_{read, write}) functions

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten For aesthetics, rename these functions and remove the unnecessary comments. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/fl512.c | 37 ++ 1 file changed, 15 insertions(+), 22

[PATCH 4/8] staging: comedi: fl512: tidy up fl512_ao_insn_read()

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten For aesthetics, tidy up this function to match the style used in most of the comedi drivers for analog output (*insn_read) functions. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/fl512.c | 10 +- 1 f

[PATCH 6/8] staging: comedi: fl512: tidy up fl512_ao_insn_write()

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten Tidy up this function. Only save the last value written for readback. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/fl512.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) d

[PATCH 1/8] staging: comedi: fl512: tidy up subdevice init

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten Remove the obvious comments and add some whitespace to the subdevice init. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/fl512.c | 48 -- 1 file changed, 16 insertions(+), 32 d

[PATCH v11][ 01/12] [media] v4l2: add new V4L2_PIX_FMT_RGB666 pixel format.

2014-03-13 Thread Denis Carikli
That new macro is needed by the imx_drm staging driver for supporting the QVGA display of the eukrea-cpuimx51 board. Signed-off-by: Denis Carikli Acked-by: Mauro Carvalho Chehab Acked-by: Laurent Pinchart Acked-by: Philipp Zabel --- ChangeLog v9->v10: - Rebased on top of: "211e7f2 [media]

[PATCH v11][ 04/12] imx-drm: Match ipu_di_signal_cfg's clk_pol with its description.

2014-03-13 Thread Denis Carikli
According to the datasheet, setting the di0_polarity_disp_clk field in the GENERAL di register sets the output clock polarity to active high. Signed-off-by: Denis Carikli --- ChangeLog v9->v10: - New patch that is now needed by the "staging: imx-drm: Use de-active and pixelclk-active" patch. --

[PATCH 07/12] drm: drm_display_mode: add signal polarity flags

2014-03-13 Thread Denis Carikli
We need a way to pass signal polarity informations between DRM panels, and the display drivers. To do that, a pol_flags field was added to drm_display_mode. Signed-off-by: Denis Carikli --- ChangeLog v10->v11: - Since the imx-drm won't be able to retrive its regulators from the device tree w

[PATCH v11][ 03/12] imx-drm: Correct BGR666 and the board's dts that use them.

2014-03-13 Thread Denis Carikli
The current BGR666 is not consistent with the other color mapings like BGR24. BGR666 should be in the same byte order than BGR24. Signed-off-by: Denis Carikli Acked-by: Philipp Zabel --- ChangeLog v9->v10: - Rebased. - Added Philipp Zabel's Ack. - Included Lothar Waßmann's suggestion about imx-l

[PATCH v11][ 02/12] imx-drm: Add RGB666 support for parallel display.

2014-03-13 Thread Denis Carikli
Signed-off-by: Denis Carikli Acked-by: Philipp Zabel --- ChangeLog v8->v9: - Rebased. - Added Philipp Zabel's ack. - Shortened the patch title. ChangeLog v8->v9: - Removed the Cc. They are now set in git-send-email directly. - Rebased. ChangeLog v7->v8: - Shrinked even more the Cc list. Change

[PATCH v11][ 05/12] imx-drm: use defines for clock polarity settings

2014-03-13 Thread Denis Carikli
Signed-off-by: Denis Carikli --- ChangeLog v9->v10: - New patch which was splitted out from: "staging: imx-drm: Use de-active and pixelclk-active display-timings.". - Fixes many issues in "staging: imx-drm: Use de-active and pixelclk-active display-timings.": - More clear meaning of the pola

[PATCH 08/12] imx-drm: Use drm_display_mode timings flags.

2014-03-13 Thread Denis Carikli
The previous hardware behaviour was kept if the flags are not set. Signed-off-by: Denis Carikli --- ChangeLog v10->v11: - This patch was splitted-out and adapted from: "Prepare imx-drm for extra display-timings retrival." - The display-timings dt specific part was removed. - The flags names wer

[PATCH v11][ 06/12] ARM: dts: imx5*, imx6*: correct display-timings nodes.

2014-03-13 Thread Denis Carikli
The imx-drm driver can't use the de-active and pixelclk-active display-timings properties yet. Instead the data-enable and the pixel data clock polarity are hardcoded in the imx-drm driver. So theses properties are now set to keep the same behaviour when imx-drm will start using them. Signed-off

[PATCH 09/12] drm/panel: Add Eukrea mbimxsd51 displays.

2014-03-13 Thread Denis Carikli
Signed-off-by: Denis Carikli --- ChangeLog v10->v11: - New patch. --- .../bindings/panel/eukrea,mbimxsd51-cmo-qvga.txt |7 ++ .../bindings/panel/eukrea,mbimxsd51-dvi-svga.txt |7 ++ .../bindings/panel/eukrea,mbimxsd51-dvi-vga.txt|7 ++ drivers/gpu/drm/panel/panel-simple.c

[PATCH 11/12] ARM: dts: mbimx51sd: Add CMO-QVGA backlight support.

2014-03-13 Thread Denis Carikli
Signed-off-by: Denis Carikli --- ChangeLog v9->v11: - Now uses the drm-panel instead of the display-timings. ChangeLog v8->v9: - Removed the Cc. They are now set in git-send-email directly. - The backlight is now on at boot. ChangeLog v6->v7: - Shrinked even more the Cc list. ChangeLog v5->v6:

[PATCH 10/12] ARM: dts: mbimx51sd: Add display support.

2014-03-13 Thread Denis Carikli
The CMO-QVGA, DVI-SVGA and DVI-VGA are added. Signed-off-by: Denis Carikli --- ChangeLog v10->v11: - Now uses the drm-panel instead of the display-timings. This is to get regulator support, which is lacking in the imx-drm driver when using the display-timings. ChangeLog v9->v10: - Rebased -

[PATCH 12/12] ARM: imx_v6_v7_defconfig: Add more drm drivers.

2014-03-13 Thread Denis Carikli
The DRM_PANEL_SIMPLE is needed by the eukrea mbimxsd51's displays. Signed-off-by: Denis Carikli --- - New patch, splitting it would be overkill. --- arch/arm/configs/imx_v6_v7_defconfig |2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/conf

work on Alcor Micro AU6601

2014-03-13 Thread Oleksij Rempel
Hello all, i have a ultrabook with Alcor Micro AU6601 pcie card reader. Suddenly there is no driver for it, so i would like to make one. If i see it correctly, Alcor Micro don't wont to be contacted by any one except OEMs. I started collecting all possible information https://wikidevi.com/wiki/A

[PATCH] Staging: lustre: fld: removed parentheses from return statement.

2014-03-13 Thread Gary Rookard
I removed the useless parentheses from a return statement for a warning fix. Return not a function. Signed-off-by: Gary Alan Rookard --- On branch staging-next drivers/staging/lustre/lustre/fld/fld_request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lu

[PATCH] Staging: lustre: fld: removed parentheses from return statement.

2014-03-13 Thread Gary Rookard
I removed the useless parentheses from a return statement for a warning fix. Return not a function. Signed-off-by: Gary Alan Rookard --- On branch staging-next drivers/staging/lustre/lustre/fld/fld_request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lu

Re: [PATCH 0/8] staging: comedi: fl512: clean up driver

2014-03-13 Thread Ian Abbott
On 2014-03-13 17:09, H Hartley Sweeten wrote: I have been unable to locate any data on this board so I am unable to add any of the missing features. This clean up just gets the driver inline with the other cleaned up comedi drivers. H Hartley Sweeten (8): staging: comedi: fl512: tidy up subde

[PATCH 3/6] Staging: unisys: uislib: Cleanup sparse warnings in uislib

2014-03-13 Thread Ken Cox
Clean up code to get rid of sparse warnings, mostly related to accessing I/O space. Remove uislibcmpxchg64() and use cmpxchg() instead. Signed-off-by: Ken Cox --- drivers/staging/unisys/include/uisqueue.h | 56 +++ drivers/staging/unisys/include/uisutils.h | 8 ++---

[patch 0/6] Staging: unisys: Clean sparse warnings in unisys driver code

2014-03-13 Thread Ken Cox
This series cleans up many sparse warnings in the unisys driver code. There are still some sparse warnings that will be cleaned up in a future patch, but the majority of the warnings are addressed by these patches. ___ devel mailing list de...@linuxdriv

[PATCH 4/6] Staging: unisys: visorchannel: Clean up sparse warnings in visorchannel code

2014-03-13 Thread Ken Cox
Clean up code to get rid of sparse warnings, mostly due to accessing I/O space. Remove visorchannel_get_safe_queue(), visorchannel_safesignalremove(), and visorchannel_safesignalinsert() since they were not called from anywhere. Signed-off-by: Ken Cox --- drivers/staging/unisys/visorchannel/vis

[PATCH 1/6] Staging: unisys: channels: Cleanup sparse warnings

2014-03-13 Thread Ken Cox
Clean up multiple sparse warnings mostly due to different address spaces when accessing I/O memory. Also, remove SignalRemoveAll(), SignalQueueHasOneElement(), SignalQueueIsFull(), because they were never called. Signed-off-by: Ken Cox --- drivers/staging/unisys/channels/channel.c| 166

[PATCH 2/6] Staging: unisys: Clean multiple sparse warnings

2014-03-13 Thread Ken Cox
Cleaned up multiple sparse warnings, mostly due to improper access of I/O space. Also declared functions and variables that were only used locally as static. Removed ULTRA_disp_channel_header(), ULTRA_disp_channel(), ULTRA_disp_vnic_channel() because they were never called. Signed-off-by: Ken Co

[PATCH 5/6] Staging: unisys: visorchipset: Clean up sparse warnings in visorchipset code.

2014-03-13 Thread Ken Cox
Clean up code to get rid of sparse warnings due to accessing I/O space. Also declared functions and variables as static if they are only used locally. Signed-off-by: Ken Cox --- drivers/staging/unisys/visorchipset/controlvm_direct.c | 1 + drivers/staging/unisys/visorchipset/file.c

[PATCH 6/6] Staging: unisys: visorutil: Clean up sparse warnings in visorutil code

2014-03-13 Thread Ken Cox
Clean up code to get rid of sparse warnings. Also fixed variable length arrays declared on the stack. Signed-off-by: Ken Cox --- drivers/staging/unisys/visorutil/procobjecttree.c | 2 +- drivers/staging/unisys/visorutil/visorkmodutils.c | 6 ++ 2 files changed, 3 insertions(+), 5 deletions(

[PATCH 07/26] staging: comedi: gsc_hpdi: tidy up hpdi_cmd_test()

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten For aesthetics, rename this function so it has namespace associated with the driver and move it so that it is not in the middle of the interrupt support code. Absorb the di_cmd_test() helper and tidy up the function a bit. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott

[PATCH 05/26] staging: comedi: gsc_hpdi: tidy up setup_dma_descriptors()

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten For aesthetics, rename this function so it has namespace associated with the driver and move it so that it is not in the middle of the async command support code. Tidy up the function a bit. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- d

[PATCH 18/26] staging: comedi: gsc_hpdi: remove 'volatile' from the private data members

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten As reported by checkpatch.pl, the private data members do not need the volatile tag. Remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/gsc_hpdi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deleti

[PATCH 16/26] staging: comedi: gsc_hpdi: remove disable_plx_interrupts()

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten This helper function is just a simple writel(). Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/gsc_hpdi.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/stag

[PATCH 08/26] staging: comedi: gsc_hpdi: rename hpdi_cancel()

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten For aesthetics, rename this function so it has namespace associated with the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/gsc_hpdi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff -

[PATCH 04/26] staging: comedi: gsc_hpdi: tidy up dio_config_insn()

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten For aesthetics, rename this function so it has namespace associated with the driver and move it so that it is not in the middle of the async command support code. Absorb the dio_config_block_size() helper function and remove the forward declaration. Signed-off-by: H Hart

[PATCH 01/26] staging: comedi: gsc_hpdi: move the (*auto_attach) and (*detach) functions

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten Move these functions closer to the comedi_driver declaration. This removes the need for one of the forward declarations. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/gsc_hpdi.c | 221 +++-

[PATCH 21/26] staging: comedi: gsc_hpdi: rename 'hpdi_iobase' in private data

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten This member in the private data holds the ioremaped PCI BAR2 address which is the primary base address for the boards registers. For aesthetics, rename this member simply 'mmio'. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/stagi

[PATCH 10/26] staging: comedi: gsc_hpdi: rename handle_interrupt()

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten For aesthetics, rename this function so it has namespace associated with the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/gsc_hpdi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

[PATCH 12/26] staging: comedi: gsc_hpdi: rename the (*auto_attach) and (*detach) functions

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten For aesthetics, rename these functions so they have namespace associated with the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/gsc_hpdi.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions

[PATCH 02/26] staging: comedi: gsc_hpdi: absorb setup_subdevices()

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten This function is only called by the (*auto_attach). Absorb it into that function to clarify the attach and remove the need for some of the forward declarations. For aesthetics, add some whitespace to the subdevice init. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott C

[PATCH 19/26] staging: comedi: gsc_hpdi: tidy up gsc_hpdi_drain_dma()

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten Refactor this function to clarify the loop that reads all the full buffers. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/gsc_hpdi.c | 60 +++ 1 file changed, 28 insertions(+), 32

[PATCH 03/26] staging: comedi: gsc_hpdi: move the (*auto_attach) helper functions

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten For aesthetics, move a couple helper functions that are only called by the (*auto_attach) closer to that function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/gsc_hpdi.c | 163 +++---

[PATCH 11/26] staging: comedi: gsc_hpdi: rename drain_dma_buffers()

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten For aesthetics, rename this function so it has namespace associated with the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/gsc_hpdi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

[PATCH 22/26] staging: comedi: gsc_hpdi: tidy up the register map

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten For aesthetics, convert the various enums into simple defines to describe the register map for the board. Group the bit defines with the associated register define. Convert the helper functions for the register bit/shift/mask stuff into simple defines. Signed-off-by: H Ha

[PATCH 25/26] staging: comedi: gsc_hpdi: remove pr_fmt() define

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten This driver no longer has any pr_{level} messages. Remove the pr_fmt(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/gsc_hpdi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/comedi/dri

[PATCH 20/26] staging: comedi: gsc_hpdi: rename 'plx9080_iobase' in private data

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten Rename this member to fix two checkpatch.pl warnings about lines > 80 characters. Also remove the unnecessary comment. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/gsc_hpdi.c | 51 +++---

[PATCH 26/26] staging: comedi: gsc_hpdi: tidy up multi-line comment

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten Tidy up the comment to follow the CodingStyle. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/gsc_hpdi.c | 40 +++ 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/dr

[PATCH 13/26] staging: comedi: gsc_hpdi: rename hpdi_find_board()

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten For aesthetics, rename this function so it has namespace associated with the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/gsc_hpdi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

[PATCH 06/26] staging: comedi: gsc_hpdi: tidy up hpdi_cmd()

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten For aesthetics, rename this function so it has namespace associated with the driver and move it so that it is not in the middle of the interrupt support code. Absorb the di_cmd() helper and tidy up the function a bit. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc:

[PATCH 09/26] staging: comedi: gsc_hpdi: rename abort_dma()

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten For aesthetics, rename this function so it has namespace associated with the driver. Also, remove the unnecessary forward declaration. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/gsc_hpdi.c | 12 +-

[PATCH 00/26] staging: comedi: gsc_hpdi: clean up driver

2014-03-13 Thread H Hartley Sweeten
This is the big clean up series for the coemdi gsc_hpdi driver. H Hartley Sweeten (26): staging: comedi: gsc_hpdi: move the (*auto_attach) and (*detach) functions staging: comedi: gsc_hpdi: absorb setup_subdevices() staging: comedi: gsc_hpdi: move the (*auto_attach) helper functions stagin

[PATCH 17/26] staging: comedi: gsc_hpdi: remove hpdi_writel()

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten This helper function is used to OR bits with a software copy of a register value then writel() the new value to the register. The software copies are never updated in the driver so they are always 0 due to the kzalloc. Remove the unnecessary 'bits' from the private data a

[PATCH 23/26] staging: comedi: gsc_hpdi: tidy up the boardinfo

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten Remove the unnecessary comments in the boardinfo definition and tidy up the declaration. FWIW, I'm not sure this boardinfo is really needed... Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/gsc_hpdi.c | 18 ++

[PATCH 24/26] staging: comedi: gsc_hpdi: convert comedi_error() messages to dev_err()

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten For aesthetics, convert the comedi_error() messages to dev_err(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/gsc_hpdi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/stagi

[PATCH 14/26] staging: comedi: gsc_hpdi: rename init_plx9080()

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten For aesthetics, rename this function so it has namespace associated with the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/gsc_hpdi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

[PATCH 15/26] staging: comedi: gsc_hpdi: rename init_hpdi()

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten For aesthetics, rename this function so it has namespace associated with the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/gsc_hpdi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

[PATCH 4/7] staging: comedi: rti802: tidy up the subdevice init

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten For aesthetics, add some whitespace to the subdevice init. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rti802.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drive

[PATCH 1/7] staging: comedi: rti802: remove RTI802_SIZE define

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten This define is only used in the attach to specify the I/O region size passed to comedi_request_region(). Remove the define and just open code the value. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rti802.c

[PATCH 0/7] staging: comedi: rti802: clean up driver

2014-03-13 Thread H Hartley Sweeten
Clean up this comedi driver. H Hartley Sweeten (7): staging: comedi: rti802: remove RTI802_SIZE define staging: comedi: rti802: tidy up rti802_ao_insn_read() staging: comedi: rti802: tidy up rti802_ao_insn_write() staging: comedi: rti802: tidy up the subdevice init staging: comedi: rti80

[PATCH 5/7] staging: comedi: rti802: tidy up the register map defines

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten For aesthetics, add some whitespace to the register map defines and convert the offsets to hex. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rti802.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletio

[PATCH 6/7] staging: comedi: rti802: tidy up the multi-line comments

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten Tidy up the milti-line comments so they follow the CodingStyle. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rti802.c | 58 - 1 file changed, 28 insertions(+), 30 deletions(-)

[PATCH 3/7] staging: comedi: rti802: tidy up rti802_ao_insn_write()

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten Use comedi_offset_munge() to handle munging the offset binary to two's complement. Tidy up the function a bit. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rti802.c | 27 ++- 1 file

[PATCH 7/7] staging: comedi: rti802: update the MODULE_DESCRIPTION

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten Change the generic MODULE_DESCRIPTION text to something more specific for this driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rti802.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 2/7] staging: comedi: rti802: tidy up rti802_ao_insn_read()

2014-03-13 Thread H Hartley Sweeten
From: H Hartley Sweeten To clarify the function a bit, add a local variable for the 'chan' that is being read and change the final return to 'insn->n'. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rti802.c | 8 +--- 1 file chan

[PATCH 3/3] Staging: lustre: fld: moved EXPORT_SYMBOL() for a fix.

2014-03-13 Thread Gary Rookard
I moved EXPORT_SYMBOL(fld_client_proc_fini); for a EXPORT_SYMBOL should be immediately below its function warning fix. Signed-off-by: Gary Alan Rookard --- Correct patch, first two breaks build. On branch staging-next drivers/staging/lustre/lustre/fld/fld_request.c | 3 +-- 1 file changed, 1 in