It doesn't need to trace status of buffer when buffers are
allocated/deallocated. So stuff of tracing memory status
are removed. And also UISMALLOC/UISFREE macro are removed
completetly. just use kzalloc/kfree.
Signed-off-by: Daeseok Youn
---
drivers/staging/unisys/include/uisutils.h |6 --
Remove unused code under C99 comment style
Signed-off-by: Mathieu Maret
---
drivers/staging/wlags49_h2/wl_netdev.c | 38 --
1 file changed, 38 deletions(-)
diff --git a/drivers/staging/wlags49_h2/wl_netdev.c
b/drivers/staging/wlags49_h2/wl_netdev.c
index ae42c8e
Code is using C99 code style, so change them to kernel style
Signed-off-by: Mathieu Maret
---
drivers/staging/wlags49_h2/wl_netdev.c | 158 +++--
1 file changed, 89 insertions(+), 69 deletions(-)
diff --git a/drivers/staging/wlags49_h2/wl_netdev.c
b/drivers/staging/
Multi statement macro should use do{}while(0)
Signed-off-by: Mathieu Maret
---
drivers/staging/wlags49_h2/wl_netdev.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wlags49_h2/wl_netdev.c
b/drivers/staging/wlags49_h2/wl_netdev.c
index 255d291..645595
Remove space between parenthesis.
Test with simple statement does not need brackets.
Simplify test condition
Signed-off-by: Mathieu Maret
---
drivers/staging/wlags49_h2/wl_netdev.c | 29 +++--
1 file changed, 11 insertions(+), 18 deletions(-)
diff --git a/drivers/staging
Parabéns!
Você ganhou £ 750.000,00 GBP em Coca-Cola Reino Unido on-line
promo caridade. Para registrar em para suas reivindicações, o arquivo na
seguinte;
Nomes: Sexo: País: Tel:
Saudações,
Sra. Margaret Delaney
___
devel mailing list
de...@linux
This patch re-factors some code to fix some 80+ lines as reported by checkpatch.
This patch was suggested and authored by Dan Carpenter. A test case for this
patch has been written and used to show the patch to be correct.
Suggested-by: Dan Carpenter
Signed-off-by: Mark Hounschell
Tested-by: Mar
patch 1 re-factors some code to fix warnings by
checkpatch about 80+ char lines. This patch was
suggested by Dan Carpenter. A test case for this
patch has been written and used and used to show
the patch to be correct.
patch 2 gets rid of the DGAP_LOCK and DGAP_UNLOCK macros
patch 3 re-factors
This patch replaces the DGAP_LOCK and DGAP_UNLOCK macros with
spin_lock_irqsave spin_unlock_irqrestore.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 442 ++--
drivers/staging/dgap/dgap.h | 7 -
2 files changed,
This patch fixes more 80+ char lines as reported by checkpatch
Signed-off-by: Mark Hounschell
Tested-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 40 +---
1 file changed, 25 insertions(+), 15 deletions(-)
diff --git a/drivers
On Wed, Mar 19, 2014 at 04:58:52PM +0900, Daeseok Youn wrote:
>
> It doesn't need to trace status of buffer when buffers are
> allocated/deallocated. So stuff of tracing memory status
> are removed. And also UISMALLOC/UISFREE macro are removed
> completetly. just use kzalloc/kfree.
>
> Signed-off
On Wed, Mar 19, 2014 at 09:20:34AM +0100, Mathieu Maret wrote:
> Multi statement macro should use do{}while(0)
>
> Signed-off-by: Mathieu Maret
> ---
> drivers/staging/wlags49_h2/wl_netdev.c | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/wlags49
Your subject [02/xx] seems a bit odd :)
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi Russell,
(CC'ing Philipp Zabel who might be able to provide feedback as a user of the
component framework)
Could you please have a look at the questions below and provide an answer when
you'll have time ? I'd like to bridge the gap between the component and the
V4L2 asynchronous registratio
On Wed, Mar 19, 2014 at 06:22:14PM +0100, Laurent Pinchart wrote:
> Hi Russell,
>
> (CC'ing Philipp Zabel who might be able to provide feedback as a user of the
> component framework)
>
> Could you please have a look at the questions below and provide an answer
> when
> you'll have time ? I'd
On Wed, Mar 19, 2014 at 05:42:43PM +0100, Mathieu Maret wrote:
>
> Le 19 mars 2014 16:34, "Greg KH" a écrit :
> >
> > On Wed, Mar 19, 2014 at 09:20:34AM +0100, Mathieu Maret wrote:
> > > Multi statement macro should use do{}while(0)
> > >
> > > Signed-off-by: Mathieu Maret
> > > ---
> > > drive
On 03/19/2014 11:49 AM, Greg Kroah-Hartman wrote:
Your subject [02/xx] seems a bit odd :)
Oops. The xx was there in my patches until I knew how many there would
be in the series. Forgot to change it. Sorry. Want me to redo? Easy enough.
___
devel
This series gets rid of a number of macros that ultimately include a goto
statement. The first patches clean up unused macros and macros that reference
other macros which eventually contain a goto statement.
The latter patches actually remove the goto statements.
__
The RETBOOL macro contained a goto statement which is not allowed in
the kernel.
Signed-off-by: Ken Cox
---
drivers/staging/unisys/include/timskmod.h | 4 ---
drivers/staging/unisys/uislib/uisqueue.c | 1 -
.../unisys/visorchannel/visorchannel_funcs.c | 37 +++-
The following macros were never referenced and have been removed:
DEVFROMID
DEVFROMFILE
DEVFROMINODE
DEVFROMIDX
TRY_WPOSTCODE_3
Signed-off-by: Ken Cox
---
drivers/staging/unisys/include/timskmod.h | 118 --
1 file changed, 118 d
The RETVOID macro contained a goto statement which is not allowed in
the kernel.
Signed-off-by: Ken Cox
---
drivers/staging/unisys/include/timskmod.h | 2 --
drivers/staging/unisys/uislib/uisqueue.c| 1 -
drivers/staging/unisys/visorchipset/parser.c|
The RETINT macro included a goto statement which is not allowed in the
kernel.
Signed-off-by: Ken Cox
---
drivers/staging/unisys/include/timskmod.h | 4 --
drivers/staging/unisys/uislib/uisqueue.c | 9 ++--
.../unisys/visorchannel/visorchannel_funcs.c | 10 ++--
driver
Remove the following macros:
TRY
CHKFD
CHKDD
CHKFDX
CHKDDX
ADDPROCLINE
TRY_WPOSTCODE_1
TRY_WPOSTCODE_2
FAIL_WPOSTCODE_2
FAIL_WPOSTCODE_3
Part of a series to get rid of goto statements embedded in macros. I'm
breaking
The RETPTR macro contained a goto statement which is not allowed in
the kernel.
Signed-off-by: Ken Cox
---
drivers/staging/unisys/include/timskmod.h | 4 ---
drivers/staging/unisys/uislib/uislib.c | 11 ---
drivers/staging/unisys/uislib/uisqueue.c | 1 -
.../
The FAIL macro ultimately includes a goto statement which is not allowed
in the kernel.
Signed-off-by: Ken Cox
---
drivers/staging/unisys/include/timskmod.h | 12 ---
.../unisys/visorchannel/visorchannel_funcs.c | 97 ++
drivers/staging/unisys/visorchipset/file
Part of a series to get rid of goto statements embedded in macros. I'm
breaking this up into a series of smaller patches for easier review. The
later patches in the series will actually remove the goto statements.
Signed-off-by: Ken Cox
---
drivers/staging/unisys/include/timskmod.h |
This patch fixes all the simple_strtol and simple_strtoul warnings
as reported by checkpatch. After this patch, checkpatch will report
zero errors or warnings on dgap.c.
Signed-off-by: Mark Hounschell
Tested-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 69 ++
From: Haiyang Zhang
Date: Tue, 18 Mar 2014 15:15:22 -0700
> +struct ndis_obj_header {
> + u8 type;
> + u8 rev;
> + u16 size;
> +} __packed;
> +
> +
> +/* ndis_recv_scale_cap/cap_flag */
One empty line is sufficient, we don't need two of them here.
> +extern u8 netvsc_hash_key[];
We
On Thu, 20 Mar 2014 00:56:05 +0300 Sergei Shtylyov
wrote:
>
> On 03/19/2014 11:40 PM, David Miller wrote:
>
> >> +extern u8 netvsc_hash_key[];
>
> > We no longer use extern in header file function declarations.
>
> Wait, this is a variable declaration. :-)
And the need for the extern on v
Hello.
On 03/19/2014 11:40 PM, David Miller wrote:
+extern u8 netvsc_hash_key[];
We no longer use extern in header file function declarations.
Wait, this is a variable declaration. :-)
WBR, Sergei
___
devel mailing list
de...@linuxdriverproj
> -Original Message-
> > +
> > +
> > +/* ndis_recv_scale_cap/cap_flag */
>
> One empty line is sufficient, we don't need two of them here.
I will fix this and other formats you pointed out below, also check the whole
patch
for similar issues.
> > - net = alloc_etherdev(sizeof(struc
I moved the #defines from implementation file DDRInit.c to
the proper specification file DDRInit.h.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/DDRInit.c | 15 ---
drivers/staging/bcm/DDRInit.h | 15 +++
2 files changed, 15 insertions(
Signed-off-by: Cédric Cabessa
---
drivers/staging/usbip/vhci_hcd.c | 33 ++---
1 file changed, 22 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c
index f690668..1e84577 100644
--- a/drivers/staging/usbip/
Signed-off-by: Cédric Cabessa
---
drivers/staging/usbip/stub_tx.c | 16
drivers/staging/usbip/usbip_common.c | 10 --
drivers/staging/usbip/vhci_sysfs.c | 4 ++--
3 files changed, 14 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/usbip/stub_tx.c b/dr
Various coding style fixes for drivers/staging/usbip
Cédric Cabessa (2):
coding style: fix quoted string split across lines
coding style: fix line over 80 characters
drivers/staging/usbip/stub_tx.c | 16
drivers/staging/usbip/usbip_common.c | 10 --
drivers/stag
octeon-hcd will crash the kernel when SLOB is used. This usually happens
after the 18-byte control transfer when a device descriptor is read.
The DMA engine is always transfering full 32-bit words and if the
transfer is shorter, some random garbage appears after the buffer.
The problem is not visib
Multi statement macro should use do{}while(0)
patch v2 does not break compilation
---
drivers/staging/wlags49_h2/wl_netdev.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wlags49_h2/wl_netdev.c
b/drivers/staging/wlags49_h2/wl_netdev.c
index 255d291..
OK. I will remove __GFP_NORETRY for kmalloc/kzalloc and sent this again.
Thanks.
Daeseok Youn
2014-03-20 0:28 GMT+09:00 Greg KH :
> On Wed, Mar 19, 2014 at 04:58:52PM +0900, Daeseok Youn wrote:
>>
>> It doesn't need to trace status of buffer when buffers are
>> allocated/deallocated. So stuff of
It doesn't need to trace status of buffer when buffers are
allocated/deallocated. So stuff of tracing memory status
are removed. And also UISMALLOC/UISFREE macro are removed
completetly. just use kzalloc/kfree.
Signed-off-by: Daeseok Youn
---
v2: removed __GFP_NORETRY flag for kzalloc()
driver
The DAC02 board, which is the only board supported by this driver, now
has its own comedi driver (dac02).
Remove this obsolete driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/Kconfig | 9 --
drivers/staging/comedi/drivers/Ma
On Monday, March 17, 2014 2:14 PM, Greg KH wrote:
> On Tue, Mar 11, 2014 at 12:04:18PM -0700, H Hartley Sweeten wrote:
>> From: H Hartley Sweeten
>>
>> The DAC02 board, which is the only board supported by this driver, now
>> has its own comedi driver (dac02).
>>
>> Remove this obsolete driver.
On Wed, Mar 19, 2014 at 11:26:04PM +, Hartley Sweeten wrote:
> On Monday, March 17, 2014 2:14 PM, Greg KH wrote:
> > On Tue, Mar 11, 2014 at 12:04:18PM -0700, H Hartley Sweeten wrote:
> >> From: H Hartley Sweeten
> >>
> >> The DAC02 board, which is the only board supported by this driver, now
On Wed, Mar 19, 2014 at 11:04:56PM +0100, Cédric Cabessa wrote:
> Signed-off-by: Cédric Cabessa
In the future, please pick a subject line that says what part of the
kernel you are changing. For example, this patch would be:
staging: usbip: fix quoted string split across lines
I'll fix t
On Wed, Mar 19, 2014 at 05:30:53PM -0400, Gary Rookard wrote:
> I moved the #defines from implementation file DDRInit.c to
> the proper specification file DDRInit.h.
>
> Signed-off-by: Gary Alan Rookard
>
> ---
> On branch staging-next
> drivers/staging/bcm/DDRInit.c | 15 ---
> dri
On Wed, Mar 19, 2014 at 11:56:14PM +0100, Mathieu Maret wrote:
> Multi statement macro should use do{}while(0)
>
> patch v2 does not break compilation
> ---
> drivers/staging/wlags49_h2/wl_netdev.c | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/w
On Thu, 20 Mar 2014, Greg KH wrote:
On Wed, Mar 19, 2014 at 05:30:53PM -0400, Gary Rookard wrote:
I moved the #defines from implementation file DDRInit.c to
the proper specification file DDRInit.h.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/DDRInit.c |
On Wed, Mar 19, 2014 at 10:29:42PM -0400, Gary Rookard wrote:
>
>
> On Thu, 20 Mar 2014, Greg KH wrote:
>
> > On Wed, Mar 19, 2014 at 05:30:53PM -0400, Gary Rookard wrote:
> >> I moved the #defines from implementation file DDRInit.c to
> >> the proper specification file DDRInit.h.
> >>
> >> Sign
On Thu, 20 Mar 2014, Greg KH wrote:
On Wed, Mar 19, 2014 at 10:29:42PM -0400, Gary Rookard wrote:
On Thu, 20 Mar 2014, Greg KH wrote:
On Wed, Mar 19, 2014 at 05:30:53PM -0400, Gary Rookard wrote:
I moved the #defines from implementation file DDRInit.c to
the proper specification file DDR
From: Sergei Shtylyov
Date: Thu, 20 Mar 2014 00:56:05 +0300
> Hello.
>
> On 03/19/2014 11:40 PM, David Miller wrote:
>
>>> +extern u8 netvsc_hash_key[];
>
>> We no longer use extern in header file function declarations.
>
>Wait, this is a variable declaration. :-)
My bad :)
_
It uses the unnecessary S_IFREG bit which will break when my
stricter-checking-for-mode patch goes in.
Since we're fixing it anyway, the extra level of indirection is
confusing for readers (ROOT_W == rw-r--r-- for example).
Also, many of these are other-writable. Is that really intended?
Signed
On Thu, Mar 20, 2014 at 01:42:57PM +1030, Rusty Russell wrote:
> It uses the unnecessary S_IFREG bit which will break when my
> stricter-checking-for-mode patch goes in.
>
> Since we're fixing it anyway, the extra level of indirection is
> confusing for readers (ROOT_W == rw-r--r-- for example).
>
51 matches
Mail list logo
