Use the common kernel coding style.
Signed-off-by: Martin Kepplinger
---
noise from the eudyptula challenge. applies to next-20140408 as well as
linus' current tree.
drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/d
hi,
Support for RTL8187SE devices(0x8199) was added to
rtl8180 recently. See 1eba648f998ef9c31b8cf062754a4a7b4ab9001f
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Apr 8, 2014 at 11:11 PM, Greg KH wrote:
>
> Why the before the '{' character?
It must have slipped in accidentally. Feel free to remove.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinf
On 9 April 2014 08:16, wrote:
> From: Roger Tseng
>
> Realtek USB SD/MMC host driver provides mmc host support based on the Realtek
> USB card reader MFD driver.
>
> Signed-off-by: Roger Tseng
> ---
> drivers/mmc/host/Kconfig |7 +
> drivers/mmc/host/Makefile |1 +
> d
On Tue, 2014-04-08 at 20:21 +0200, Jes Sorensen wrote:
> > 0) I stumbled on two minor Kconfig related issues in the r8723au driver
> > in staging-next.
These have hit mainline now.
> I have fixed these two and pushed the changes into my git tree on
> kernel.org. The tree tracks Greg's staging-nex
On Wed, Apr 09, 2014 at 10:28:01AM +0200, Luis Ortega wrote:
> On Tue, Apr 8, 2014 at 11:11 PM, Greg KH wrote:
> >
> > Why the before the '{' character?
>
> It must have slipped in accidentally. Feel free to remove.
Send a v2 patch...
https://www.google.com/search?q=how+to+send+a+v2+patch
reg
On Wed, Apr 09, 2014 at 09:25:55AM +0200, Martin Kepplinger wrote:
> Use the common kernel coding style.
>
> Signed-off-by: Martin Kepplinger
Reviewed-by: Josh Triplett
>
> drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c |6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>
Fixed badly placed and unnecessary braces.
PS: Performed as task 10 of the Eudyptula Challenge.
Signed-off-by: Luis Ortega
---
Changes for v2:
- Removed accidental
---
drivers/staging/bcm/Qos.c | 174 +-
1 file changed, 48 insertions(+), 126 deletion
A string of goto_buf has a number followed by x or y.
e.g. "3x" means move 3 lines down.
The kstrtol() returns an error(-EINVAL) with this string so
go_pos has unsigned a value of that error.
And also "*cp" has not expected value.
And fix sparse warnings:
drivers/staging/speakup/main.c:1901 hand
On Wed, Apr 09, 2014 at 07:45:46PM +0900, Daeseok Youn wrote:
>
> A string of goto_buf has a number followed by x or y.
> e.g. "3x" means move 3 lines down.
> The kstrtol() returns an error(-EINVAL) with this string so
> go_pos has unsigned a value of that error.
> And also "*cp" has not expected
Removed not needed spaces and fixed too long lines
PS: this is an exercise to get into the "patch submitting workflow"
Signed-off-by: Richard Leitner
---
drivers/staging/comedi/drivers/adl_pci9118.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/
On Wed, Apr 09, 2014 at 01:35:37PM +0200, Richard Leitner wrote:
> Removed not needed spaces and fixed too long lines
>
> PS: this is an exercise to get into the "patch submitting workflow"
Put the "PS" after the --- cut off. Otherwise it's not a PS but a part
of the permanent changelog.
>
> S
On Mon, Apr 07, 2014 at 02:44:48PM +0200, Denis Carikli wrote:
[...]
> +static const struct panel_desc eukrea_mbimxsd51_dvisvga = {
> + .modes = &eukrea_mbimxsd51_dvisvga_mode,
> + .num_modes = 1,
> + .size = {
> + .width = 0,
> + .height = 0,
> + },
> +};
[.
Hi,
The following patches are those which I currently have queued up for
Greg for merging into his stable tree when he's next accepting patches.
If you have any concerns about these patches, please let me know in
a timely fashion.
I've re-ordered and cherry-picked some of Denis' patches, as I can
From: Philipp Zabel
To: linux-arm-ker...@lists.infradead.org
The IPU display controller supports a non-standard green-red-blue ordered
format that is used on the connection between IPU display interface 1 and
the TV encoder on i.MX53.
In preparation for the move of IPU core code out of staging, p
From: Philipp Zabel
To: linux-arm-ker...@lists.infradead.org
Since msleep(2) can sleep up to 20ms anyway, make this explicit by using
usleep_range(2000, 2).
Signed-off-by: Philipp Zabel
Signed-off-by: Russell King
---
drivers/staging/imx-drm/ipu-v3/ipu-dc.c | 2 +-
1 file changed, 1 inser
From: Fabio Estevam
To: linux-arm-ker...@lists.infradead.org
Fix the following static checker warning:
drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn:
variable dereferenced before check 'dmfc' (see line 157)
As 'dmfc' could never be null, there is no need to do suc
From: Fabio Estevam
To: linux-arm-ker...@lists.infradead.org
Use snprintf() in order to fix the following static checker warning:
drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string
overflow. buf_size: 16 length: 18
probably 18 is theory and not real life, but 16 is bas
From: Denis Carikli
To: linux-arm-ker...@lists.infradead.org
Signed-off-by: Denis Carikli
Acked-by: Philipp Zabel
Signed-off-by: Russell King
---
.../devicetree/bindings/staging/imx-drm/fsl-imx-drm.txt | 3 ++-
drivers/staging/imx-drm/ipu-v3/ipu-dc.c | 9
From: Denis Carikli
To: linux-arm-ker...@lists.infradead.org
According to the datasheet, setting the di0_polarity_disp_clk
field in the GENERAL di register sets the output clock polarity
to active high.
Signed-off-by: Denis Carikli
Signed-off-by: Russell King
---
drivers/staging/imx-drm/ipu-v
From: Philipp Zabel
To: linux-arm-ker...@lists.infradead.org
This patch allows to optionally attach the lvds-channel to a panel
supported by a drm_panel driver instead of supplying the modes via
device tree.
Before:
ldb {
...
lvds-channel@0 {
2014-04-09 20:39 GMT+09:00, Dan Carpenter :
> On Wed, Apr 09, 2014 at 07:45:46PM +0900, Daeseok Youn wrote:
>>
>> A string of goto_buf has a number followed by x or y.
>> e.g. "3x" means move 3 lines down.
>> The kstrtol() returns an error(-EINVAL) with this string so
>> go_pos has unsigned a value
tcm825x.c:
ERROR: Macros with complex values should be enclosed in parenthesis
WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then
dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
tcm825x.h:
ERROR: Macros with complex values should be enclosed in parenthesis
Signed-
The kbuild test robot reports the following:
tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 75ff24fa52f0cc512ceee4c377632b91a3a80811
commit: 9176303c404741b2f96796466437f2badf6e289b staging: r8723au: Turn on
build of new driver
date: 4 days ago
config: m
Hi Larry and Jes,
The patch 5e93f3520957: "staging: r8723au: Add source files for new
driver - part 1" from Mar 28, 2014, leads to the following static
checker warning:
drivers/staging/rtl8723au/core/rtw_ieee80211.c:1515 rtw_get_wfd_ie()
error: memcpy() 'wfd_ie' too small (128 vs
Dan Carpenter writes:
> Hi Larry and Jes,
>
> The patch 5e93f3520957: "staging: r8723au: Add source files for new
> driver - part 1" from Mar 28, 2014, leads to the following static
> checker warning:
>
> drivers/staging/rtl8723au/core/rtw_ieee80211.c:1515 rtw_get_wfd_ie()
> error: mem
On Wed, Apr 09, 2014 at 05:33:12PM +0200, Jes Sorensen wrote:
> Dan Carpenter writes:
> > Hi Larry and Jes,
> >
> > The patch 5e93f3520957: "staging: r8723au: Add source files for new
> > driver - part 1" from Mar 28, 2014, leads to the following static
> > checker warning:
> >
> > drivers/sta
This makes the follow-on check for psta != NULL pointless and makes
the whole exercise rather pointless. This is another case of why
blindly zero-initializing variables when they are declared is bad.
Reported-by: Jes Sorensen
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/staging/rtl8188eu
Zero-initializing ether_type masked that the ether type would never be
obtained for 8021x packets and the comparition against eapol_type
would always fail.
Reported-by: Jes Sorensen
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/staging/rtl8712/rtl871x_recv.c | 15 +++
1 file c
While analyzing parts of the recently merged r8723au driver, Jes Sorensen
found two bugs that are found in other Reaktek drivers in staging. This
set of patches fixes them.
Signed-off-by: Larry Finger
Larry Finger (3):
staging: r8188eu: Calling rtw_get_stainfo() with a NULL sta_addr will
Zero-initializing ether_type masked that the ether type would never be
obtained for 8021x packets and the comparition against eapol_type
would always fail.
Reported-by: Jes Sorensen
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 20
On 04/09/2014 08:12 PM, Larry Finger wrote:
Zero-initializing ether_type masked that the ether type would never be
obtained for 8021x packets and the comparition against eapol_type
would always fail.
Reported-by: Jes Sorensen
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/staging/rtl
On 04/09/2014 08:13 PM, Larry Finger wrote:
Zero-initializing ether_type masked that the ether type would never be
obtained for 8021x packets and the comparition against eapol_type
would always fail.
Reported-by: Jes Sorensen
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/staging/rtl
Removed not needed spaces and fixed too long lines
Signed-off-by: Richard Leitner
---
drivers/staging/comedi/drivers/adl_pci9118.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c
b/drivers/staging/comedi/drivers/adl_pci9118.
ERROR: that open brace { should be on the previous line
ERROR: else should follow close brace '}
ERROR: space required before the open parenthesis '(
ERROR: trailing whitespace
ERROR: open brace '{' following function declarations go on the next line
ERROR: space required after that ',' (ctx:VxV)
E
On Wed, Apr 09, 2014 at 10:05:20AM -0500, Larry Finger wrote:
> The kbuild test robot reports the following:
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> master
> head: 75ff24fa52f0cc512ceee4c377632b91a3a80811
> commit: 9176303c404741b2f96796466437f2badf6e289b
From: "K. Y. Srinivasan"
Date: Tue, 8 Apr 2014 12:46:11 -0700
> } else if (net_trans_info & INFO_UDP) {
> - csum_info->transmit.udp_checksum = 1;
> + /* UDP checksum offload is not supported on ws2008r2.
> + * Furthermore, on ws2012 and ws2012r2, there
On Wed, Apr 09, 2014 at 10:10:49AM +0200, Xose Vazquez Perez wrote:
> hi,
>
> Support for RTL8187SE devices(0x8199) was added to
> rtl8180 recently. See 1eba648f998ef9c31b8cf062754a4a7b4ab9001f
Very nice, so, any objection to me deleting the staging driver now?
thanks,
greg k-h
On Wed, 2014-04-09 at 10:05 -0500, Larry Finger wrote:
> The kbuild test robot reports the following:
[]
> diff --git a/drivers/staging/rtl8723au/include/rtw_mlme.h
> b/drivers/staging/rtl8723au/include/rtw_mlme.h
[]
> -void rtw_set_roaming(struct rtw_adapter *adapter, u8 to_roaming);
> -u8 rtw_to
On 04/09/2014 11:24 AM, Sergei Shtylyov wrote:
On 04/09/2014 08:12 PM, Larry Finger wrote:
Zero-initializing ether_type masked that the ether type would never be
obtained for 8021x packets and the comparition against eapol_type
would always fail.
Reported-by: Jes Sorensen
Signed-off-by: Lar
I honestly can't estimate how many rtl8187se users will be gained by
this driver once it will appears in mainline (considering that most
users will probably run kernels from distributions, that updates
fairly slower than vanilla) and how much new use-cases this driver
will suddenly encounter... Ass
The kbuild test robot reports the following:
tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 75ff24fa52f0cc512ceee4c377632b91a3a80811
commit: 9176303c404741b2f96796466437f2badf6e289b staging: r8723au: Turn on
build of new driver
date: 4 days ago
config: m
On 04/09/2014 11:25 AM, Sergei Shtylyov wrote:
On 04/09/2014 08:13 PM, Larry Finger wrote:
Zero-initializing ether_type masked that the ether type would never be
obtained for 8021x packets and the comparition against eapol_type
would always fail.
Reported-by: Jes Sorensen
Signed-off-by: Lar
Larry Finger writes:
> The kbuild test robot reports the following:
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> master
> head: 75ff24fa52f0cc512ceee4c377632b91a3a80811
> commit: 9176303c404741b2f96796466437f2badf6e289b staging: r8723au:
> Turn on build of new
> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Wednesday, April 9, 2014 10:01 AM
> To: KY Srinivasan
> Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> jasow...@redhat.com
> Subj
From: KY Srinivasan
Date: Wed, 9 Apr 2014 18:08:47 +
> Thanks Dave. I will COW the SKB before changing the checksum
> value. I do have a question though. I looked at a bunch of hardware
> drivers and they modify the header information, specially checksum
> field and I could not see where the
> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Wednesday, April 9, 2014 11:37 AM
> To: KY Srinivasan
> Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> jasow...@redhat.com
> Subj
On Wed, Apr 09, 2014 at 12:55:59PM -0500, Larry Finger wrote:
> The kbuild test robot reports the following:
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> master
> head: 75ff24fa52f0cc512ceee4c377632b91a3a80811
> commit: 9176303c404741b2f96796466437f2badf6e289b
From: KY Srinivasan
Date: Wed, 9 Apr 2014 18:39:57 +
>
>
>> -Original Message-
>> From: David Miller [mailto:da...@davemloft.net]
>> Sent: Wednesday, April 9, 2014 11:37 AM
>> To: KY Srinivasan
>> Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org;
>> de...@linuxdriverproject.
On Wed, Apr 09, 2014 at 11:12:59AM -0500, Larry Finger wrote:
> diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c
> b/drivers/staging/rtl8188eu/core/rtw_recv.c
> index 01fcabc..61084d6 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_recv.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
>
On Wed, Apr 09, 2014 at 09:51:53PM +0300, Dan Carpenter wrote:
> > - if (auth_alg == 2) {
> > + if (auth_alg == dot11AuthAlgrthm_8021X) {
> > + /* get ether_type */
> > + ptr = ptr + pfhdr->attrib.hdrlen + LLC_HEADER_SIZE;
> > + memcpy(ðer_type, ptr, 2);
> > +
On Wed, Apr 09, 2014 at 08:24:08PM +0400, Sergei Shtylyov wrote:
> >diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c
> >b/drivers/staging/rtl8188eu/core/rtw_recv.c
> >index 01fcabc..61084d6 100644
> >--- a/drivers/staging/rtl8188eu/core/rtw_recv.c
> >+++ b/drivers/staging/rtl8188eu/core/rtw_
This patch adds a function, is_spar_system(), to check that s-Par
firmware is present, and then uses this function at the beginning of
each module to verify that the modules are being run on an s-Par system
before beginning initialization. If the firmware is not detected, the
module will return a f
On 04/09/2014 11:02 PM, Dan Carpenter wrote:
diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c
b/drivers/staging/rtl8188eu/core/rtw_recv.c
index 01fcabc..61084d6 100644
--- a/drivers/staging/rtl8188eu/core/rtw_recv.c
+++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
@@ -551,7 +551,7 @@ stati
On Wed, Apr 09, 2014 at 02:04:50PM -0500, Romer, Benjamin M wrote:
> This patch adds a function, is_spar_system(), to check that s-Par
> firmware is present, and then uses this function at the beginning of
> each module to verify that the modules are being run on an s-Par system
> before beginning
On Wed, Apr 09, 2014 at 02:04:50PM -0500, Romer, Benjamin M wrote:
> @@ -71,5 +71,6 @@
> u64 somethings, char *buf, size_t bufsize);
> struct seq_file *visor_seq_file_new_buffer(void *buf, size_t buf_size);
> void visor_seq_file_done_buffer(struct seq_file *m);
> +
As suggested by checkpatch.pl, use dev_info() instead of
printk(KERN_INFO ...) to print message.
Signed-off-by: Joel Porquet
---
Only tested by compilation.
drivers/staging/iio/trigger/iio-trig-periodic-rtc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/i
This patch has a million checkpatch.pl warnings... We were so nice to
you on merging this driver directly into staging without commenting on
the style but YOU"RE IN THE ARMY NOW!!! Please, fix all the checkpatch
warnings and resend. :P
> diff --git a/drivers/staging/unisys/include/timskmodutils
On Wed, Apr 09, 2014 at 11:11:52PM +0400, Sergei Shtylyov wrote:
> On 04/09/2014 11:02 PM, Dan Carpenter wrote:
>
> >>>diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c
> >>>b/drivers/staging/rtl8188eu/core/rtw_recv.c
> >>>index 01fcabc..61084d6 100644
> >>>--- a/drivers/staging/rtl8188eu/co
ERROR: spaces required around that '=' (ctx:OxW)
Signed-off-by: Paul McQuade
---
drivers/staging/rtl8192e/rtl819x_BAProc.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c
b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index a
WS2008 R2 does not support udp checksum offload. Furthermore, ws2012 and
ws2012 r2 have issues offloading udp checksum from Linux guests.
This patch-set addresses these issues as well as other bug fixes.
Please apply.
In this version, I have addressed the comment from David Miller with reagards
to
ws2008r2 does not support UDP checksum offload. Thus, we cannnot turn on
UDP offload in the host. Also, on ws2012 and ws2012 r2, there appear to be
an issue with UDP checksum offload.
Fix this issue by computing the UDP checksum in the Hyper-V driver.
Based on Dave Miller's comments, in this versi
An outgoing packet can potentially need per-packet information for
all the offloads and VLAN tagging. Fix this issue.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/netvsc_drv.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/driver
Ws2008R2 supports ndis_version 6.1 and 6.1 is the minimal version required
for various offloads. Negotiate ndis_version 6.1 when on ws2008r2.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/netvsc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
d
Return the appropriate error code and handle the case when the target
file exists correctly. This fixes a bug.
Signed-off-by: K. Y. Srinivasan
Cc: [3.14]
---
include/uapi/linux/hyperv.h |1 +
tools/hv/hv_fcopy_daemon.c |4 +++-
2 files changed, 4 insertions(+), 1 deletions(-)
diff --g
rtl2832_sdr.c: fixup checkpatch issues about long lines
Signed-off-by: Anthony DeStefano
---
drivers/staging/media/rtl2832u_sdr/rtl2832_sdr.c | 23 ---
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/media/rtl2832u_sdr/rtl2832_sdr.c
b/drivers/s
On Wed, Apr 09, 2014 at 08:07:28PM -0400, Anthony DeStefano wrote:
> rtl2832_sdr.c: fixup checkpatch issues about long lines
>
> Signed-off-by: Anthony DeStefano
> ---
> drivers/staging/media/rtl2832u_sdr/rtl2832_sdr.c | 23 ---
> 1 file changed, 16 insertions(+), 7 deletions
rtl2832_sdr.c: fixup checkpatch issues about long lines
Aligned stuff under the ( for this version.
Signed-off-by: Anthony DeStefano
---
drivers/staging/media/rtl2832u_sdr/rtl2832_sdr.c | 26 +---
1 file changed, 19 insertions(+), 7 deletions(-)
diff --git a/drivers/staging
I am Leopold Victoria, i need your aid on something vital and important.
Best Regards
Leopold Victoria (Queen).
Queen Elizabeth House
3 Mansfield Road
Oxford OX1 3TB
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject
69 matches
Mail list logo
