On 06/25/2014 12:04 AM, Thierry Reding wrote:
because on this very simple display board, we only have DVI LVDS signals
without the I2C to detect the display.
That's unfortunate. In that case perhaps a better approach would be to
add a video timings node to the device that provides the DVI outpu
On Wed, Jun 25, 2014 at 06:48:45AM +0200, Sascha Hauer wrote:
> On Mon, Jun 16, 2014 at 12:11:18PM +0200, Denis Carikli wrote:
> > +
> > /*
> > * Bitfield of Display Interface signal polarities.
> > */
> > @@ -37,7 +43,7 @@ struct ipu_di_signal_cfg {
> > unsigned clksel_en:1;
> > unsig
On Mon, Jun 16, 2014 at 12:11:21PM +0200, Denis Carikli wrote:
> The previous hardware behaviour was kept if the
> flags are not set.
I'd like to throw in a patch that I've been carrying for a bit now.
It conflicts with your patches, but I'm happy to fix that conflict
locally (and have been doing
On 06/24/2014 05:06 PM, Russell King - ARM Linux wrote:
> It would be better if you separate the
binding documentation updates from the other functional changes too.
Fixed.
Denis.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.li
On 06/25/2014 06:48 AM, Sascha Hauer wrote:
+#define ENABLE_POL_LOW 0
+#define ENABLE_POL_HIGH1
Adding defines without a proper namespace (IPU_) outside a driver
private header file is not nice. Anyway, instead of adding the
defines ...
Fixed in "imx-drm: use defines for
On Wed, Jun 25, 2014 at 09:43:27AM +0100, Russell King - ARM Linux wrote:
> On Wed, Jun 25, 2014 at 06:48:45AM +0200, Sascha Hauer wrote:
> > On Mon, Jun 16, 2014 at 12:11:18PM +0200, Denis Carikli wrote:
> > > +
> > > /*
> > > * Bitfield of Display Interface signal polarities.
> > > */
> > >
On 06/24/2014 08:12 AM, Ben Chan wrote:
> Thanks Kristina. checkpatch reports 1 errors and 17 warnings on the
> current driver.
>
> I guess I need to first submit patches to staging-next to address
> these issues, and then submit another patch to move it out of staging,
> right?
>
Hi everyone,
A struct member variable is set to the same value more than once
This was found using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/staging/rtl8192u/r8192U_core.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r819
Remove checking if a unsigned int is less than zero
This was found using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/staging/bcm/nvm.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/bcm/nvm.c b/driver
On 23-06-2014 13:44:22, j...@joshtriplett.org wrote:
> On Mon, Jun 23, 2014 at 11:42:33AM +0200, Matthias Beyer wrote:
> > Signed-off-by: Matthias Beyer
>
> As with the previous line-wrapping patch, this doesn't seem like a net
> improvement; the lines seem far more readable un-wrapped.
I don't
This patch fixes the following checkpatch.pl issues in hfa384x_usb.c:
WARNING: void function return statements are not generally useful
Signed-off-by: Quentin Lee
---
drivers/staging/wlan-ng/hfa384x_usb.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.
This patch fixes the following checkpatch.pl issues in hfa384x_usb.c:
WARNING: Missing a blank line after declarations
Signed-off-by: Quentin Lee
---
drivers/staging/wlan-ng/hfa384x_usb.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_us
This patch fixes the following checkpatch.pl issues in hfa384x_usb.c:
WARNING: void function return statements are not generally useful
Signed-off-by: Quentin Lee
---
drivers/staging/wlan-ng/hfa384x_usb.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.
This patch fixes the following checkpatch.pl issues in hfa384x_usb.c:
WARNING: Missing a blank line after declarations
Signed-off-by: Quentin Lee
---
drivers/staging/wlan-ng/hfa384x_usb.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_us
Dear all,
Thanks Joe's reminder. I've resent patch.
Sincerely,
Quentin
2014-06-25 23:28 GMT+08:00, Joe Perches :
> On Wed, 2014-06-25 at 23:24 +0800, Cheng-Wei Lee wrote:
>> This patch fixes the following checkpatch.pl issues in hfa384x_usb.c:
>> WARNING: void function return statements are not
On Wed, Jun 25, 2014 at 04:50:31PM +0200, Matthias Beyer wrote:
> On 23-06-2014 13:44:22, j...@joshtriplett.org wrote:
> > On Mon, Jun 23, 2014 at 11:42:33AM +0200, Matthias Beyer wrote:
> > > Signed-off-by: Matthias Beyer
> >
> > As with the previous line-wrapping patch, this doesn't seem like a
This series removes all references to __DATE__ and __TIME__ from the
unisys drivers and also removes BROKEN from the Kconfig so the drivers
can be built.
PATCH 1: Gets rid of references to __DATE__ and __TIME__
PATCH 2: Removes buildDate and buildTime arguments from BusDeviceInfo_Init()
PATCH 3: R
The unisys drivers no longer need to record the build date and time since the
same info is already in the kernel elsewhere.
Signed-off-by: Ken Cox
---
drivers/staging/unisys/include/vbushelper.h | 8 +++-
drivers/staging/unisys/uislib/uisutils.c| 7 +++
driver
The use of __DATE__ and __TIME__ is no longer allowed in the kernel so this
commit removes those. They were once useful when the drivers were being
built externally, but now that the drivers are in the kernel the use of the
macros is redundant since the kernel already has the same information
else
The drivers do not need to keep track of these fields since the same
information is present elsewhere in the kernel.
Signed-off-by: Ken Cox
---
drivers/staging/unisys/virthba/virthba.c | 2 --
drivers/staging/unisys/virtpci/virtpci.h | 2 --
2 files changed, 4 deletions(-)
diff --git a/drivers/
The unisys drivers now properly check to make sure they are running
on the s-Par platform before they will initialize. This was fixed in
commit fcd0157ece so it is safe to allow the unisys drivers to be built.
This has been tested in the same qemu environment that originally
produced the panic an
On Wed, 2014-06-25 at 23:24 +0800, Cheng-Wei Lee wrote:
> This patch fixes the following checkpatch.pl issues in hfa384x_usb.c:
> WARNING: void function return statements are not generally useful
subject/code mismatch.
> Signed-off-by: Quentin Lee
> ---
> drivers/staging/wlan-ng/hfa384x_usb.c |
On 06/17/2014 06:01 PM, Greg KH wrote:
On Thu, Jun 05, 2014 at 01:56:16PM -0500, Ken Cox wrote:
Added I/O version for the function ultra_vbus_init_channel() to get rid
of noderef sparse warnings when accessing I/O space.
Signed-off-by: Ken Cox
---
.../common-spar/include/channels/vbuschanne
On Mon, Jun 23, 2014 at 06:41:28AM -0700, Joe Perches wrote:
> Adding the helper reduces object code size as well as overall
> source size line count.
>
> It's also consistent with all the various zalloc mechanisms
> in the kernel.
>
> Done with a simple cocci script and some typing.
>
> Joe Per
On Wed, 2014-06-25 at 23:35 +0800, Cheng-Wei Lee wrote:
> This patch fixes the following checkpatch.pl issues in hfa384x_usb.c:
> WARNING: Missing a blank line after declarations
Still has a mismatch between subject and code
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
[]
> @@ -3533,7 +35
Currently the VSC has no chance to notify the VSP of the dirty rectangle on VM
panic because the notification work is done in a workqueue, and in panic() the
kernel typically ends up in an infinite loop, and a typical kernel config has
CONFIG_PREEMPT_VOLUNTARY=y and CONFIG_PREEMPT is not set, so a
Hi Joe,
Thanks for your kindly reply.
I'll submit patch again.
Many thanks,
Quentin
2014-06-26 8:09 GMT+08:00, Joe Perches :
> On Wed, 2014-06-25 at 23:35 +0800, Cheng-Wei Lee wrote:
>> This patch fixes the following checkpatch.pl issues in hfa384x_usb.c:
>> WARNING: Missing a blank line after d
This patch fixes the following checkpatch.pl issues in hfa384x_usb.c:
WARNING: Missing a blank line after declarations
Signed-off-by: Quentin Lee
---
drivers/staging/wlan-ng/hfa384x_usb.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
b/drivers/stagi
On Thu, 2014-06-26 at 09:55 +0800, Cheng-Wei Lee wrote:
> This patch fixes the following checkpatch.pl issues in hfa384x_usb.c:
> WARNING: Missing a blank line after declarations
This time you've got the right subject, and right type of content,
but unfortunately, the content is wrapped and can't
On Tue, Jun 24, 2014 at 09:44:14PM +, Dexuan Cui wrote:
> >On Tue, Jun 24, 2014 at 08:29:17AM +0800, Dexuan Cui wrote:
> >> Currently the VSC has no chance to notify the VSP of the dirty rectangle
> >> on VM
> >> panic because the notification work is done in a workqueue, and in panic()
> >>
On Wed, Jun 25, 2014 at 02:01:03PM -0500, Ken Cox wrote:
>
> On 06/17/2014 06:01 PM, Greg KH wrote:
> >On Thu, Jun 05, 2014 at 01:56:16PM -0500, Ken Cox wrote:
> >>Added I/O version for the function ultra_vbus_init_channel() to get rid
> >>of noderef sparse warnings when accessing I/O space.
> >>
On Wed, Jun 25, 2014 at 11:48:23AM -0500, Ken Cox wrote:
> The use of __DATE__ and __TIME__ is no longer allowed in the kernel so this
> commit removes those. They were once useful when the drivers were being
> built externally, but now that the drivers are in the kernel the use of the
> macros is
On Wed, Jun 25, 2014 at 11:48:25AM -0500, Ken Cox wrote:
> The drivers do not need to keep track of these fields since the same
> information is present elsewhere in the kernel.
>
> Signed-off-by: Ken Cox
Again, just do this, not the first one at all.
greg k-h
__
On Wed, Jun 25, 2014 at 11:48:24AM -0500, Ken Cox wrote:
> The unisys drivers no longer need to record the build date and time since the
> same info is already in the kernel elsewhere.
This should be done instead of the first patch.
greg k-h
___
devel m
Guten Tag ,
Bitte nehmen Sie meine aufrichtigen Entschuldigungen an, wenn meine E-mail
Ihre
pers?nliche Ethik nicht trifft.
F?r ich wei?, dass dies wie ein vollst?ndiges Eindringen zu Ihrer Ruhe
scheinen
kann, aber zurzeit ,dies ist meine Option f?r Kommunikation zu Ihnen.
Dies k?nnte
35 matches
Mail list logo