Re: Anybody working on tidspbridge?

2014-07-09 Thread Tony Lindgren
* Suman Anna [140708 11:40]: > Hi Peter, > > On 07/08/2014 09:36 AM, Greg KH wrote: > > On Tue, Jul 08, 2014 at 03:03:58PM +0200, Peter Meerwald wrote: > >> Hello, > >> > Given the total lack of response here, I suggest just deleting the > driver. No one has ever done the "real work" t

[PATCH 1/2] staging: dgap: use kzalloc instead of kmalloc/memset

2014-07-09 Thread Daeseok Youn
Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index da11dfb..8e3fd87 100644 --- a/drivers/staging/dgap/dgap.c +++ b/drivers/staging/dgap/dgap.c @@

[PATCH 2/2] staging: dgap: remove redundant NULL check in dgap_tty_init()

2014-07-09 Thread Daeseok Youn
The brd is already checked by earlier function in dgap_init_one(). Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 8e3fd87..b60995e 100644 --- a/

Re: [PATCH 054/115] staging: ced1401: remove typedef for TRANSAREA

2014-07-09 Thread Luca Ellero
On 09/07/2014 01:01, Greg KH wrote: On Mon, Jun 30, 2014 at 12:00:46PM +0200, Luca Ellero wrote: Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 21 - drivers/staging/ced1401/usb1401.c |9 ++--- drivers/staging/ced1401/usb1401.h |6 +++---

Re: [PATCH v2 00/10] staging: rtl8723au: Fix USB macro functions

2014-07-09 Thread Jes Sorensen
Greg KH writes: > On Tue, Jul 01, 2014 at 12:06:59PM +0200, jes.soren...@redhat.com wrote: >> From: Jes Sorensen >> >> Greg, >> >> Here is v2 of patch 08/10 "Sanitize USB read/write functions" it >> should fix the 'do not do DMA on the stack' issue with the original >> version. With this patch

[PATCH v2] hyperv: Add netpoll support

2014-07-09 Thread Richard Weinberger
In order to have at least a netconsole to debug kernel issues on Windows Azure this patch implements netpoll support. Sending packets is easy, netvsc_start_xmit() does already everything needed. Signed-off-by: Richard Weinberger --- drivers/net/hyperv/netvsc_drv.c | 11 +++ 1 file change

Re: [PATCH] hyperv: Add netpoll support

2014-07-09 Thread Richard Weinberger
Am 09.07.2014 01:43, schrieb Francois Romieu: > Richard Weinberger : >> Am 09.07.2014 00:47, schrieb Francois Romieu: > [...] >>> What are you taking about ? netconsole does not need to receive. >> >> Isn't netconsole is only one user of netpoll ? > > Out of tree users are irrelevant. See netpoll

Re: [PATCH v2 1/4] staging: rtl8192u: Remove useless return statement in r819xU_phy.c

2014-07-09 Thread Dan Carpenter
These patches look ok now. The only thing is that the changelogs are a little off. On Wed, Jul 09, 2014 at 11:34:17AM +0530, sanjeev sharma wrote: > From: sanjeev sharma Don't use the From header unless you are sending patches on behalf of someone else. It's better if you can configure your em

Re: [PATCH 1/8] Drivers: scsi: storvsc: Change the limits to reflect the values on the host

2014-07-09 Thread Christoph Hellwig
On Tue, Jul 08, 2014 at 05:46:45PM -0700, K. Y. Srinivasan wrote: > + * In Hyper-V, each port/path/target maps to 1 scsi host adapter. Does it still? The STORVSC_FC_MAX_TARGETS define suggests otherwise. > - .cmd_per_lun = 1, > + .cmd_per_lun = 255, This looks like an

Re: [PATCH 2/8] Drivers: scsi: storvsc: Filter commands based on the storage protocol version

2014-07-09 Thread Christoph Hellwig
On Tue, Jul 08, 2014 at 05:46:46PM -0700, K. Y. Srinivasan wrote: > Going forward it is possible that some of the commands that are not currently > implemented will be implemented on future Windows hosts. Make command > filtering > depend on the host version. > + if (vmstor_current_major <= V

Re: [PATCH 3/8] Drivers: scsi: storvsc: Fix a bug in handling VMBUS protocol version

2014-07-09 Thread Christoph Hellwig
> + if ((vmbus_proto_version == VERSION_WS2008) || > + (vmbus_proto_version == VERSION_WIN7)) { This has superflous braces and doesn't use proper Linux indentation. But I think simply using a switch here might be cleaner anyway. ___ devel

Re: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

2014-07-09 Thread Christoph Hellwig
On Tue, Jul 08, 2014 at 05:46:48PM -0700, K. Y. Srinivasan wrote: > Host does not handle WRITE_SAME_16; filter this command out. This patch > is required to handle large devices (greater than 2 TB disks). Storvsc already sets the no_write_same flag, where is the command coming from? _

Re: [PATCH 5/8] Drivers: scsi: storvsc: Fix a bug in the handling of SRB status flags

2014-07-09 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-09 Thread Christoph Hellwig
On Tue, Jul 08, 2014 at 05:46:50PM -0700, K. Y. Srinivasan wrote: > Implement a simple abort handler. The host does not support "Abort"; just > ensure that all inflight I/Os have been accounted for. The abort handler should abort a single command, not wait for all of them. What issue do you see t

Re: [PATCH 7/8] drivers: scsi: storvsc: Set srb_flags in all cases

2014-07-09 Thread Christoph Hellwig
On Tue, Jul 08, 2014 at 05:46:51PM -0700, K. Y. Srinivasan wrote: > Correctly set SRB flags for all valid I/O directions. Some IHV drivers on the > Windows host require this. What are IHV drivers? Otherwise looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH 8/8] drivers: scsi: storvsc: Correctly handle TEST_UNIT_READY failure

2014-07-09 Thread Christoph Hellwig
On Tue, Jul 08, 2014 at 05:46:52PM -0700, K. Y. Srinivasan wrote: > --- a/drivers/scsi/storvsc_drv.c > +++ b/drivers/scsi/storvsc_drv.c > @@ -1023,6 +1023,13 @@ static void storvsc_handle_error(struct vmscsi_request > *vm_srb, > case ATA_12: > set_host_byte(scmn

Re: [PATCH 1/2] staging: silicom: checkpatch fixes

2014-07-09 Thread Dan Carpenter
The patch does too many things, break it up into one type of fix per patch. On Tue, Jul 01, 2014 at 02:24:36PM +0200, Davide Gianforte wrote: > Chechpatch.pl cleanup > > There are still some warnings, most of them are lines over 80 chars > (mainly a semicolon or closing parenthesis). > > Where n

Re: [PATCH V2] staging: gdm72xx: move T_CAPABILITY definitions to hci.h

2014-07-09 Thread Dan Carpenter
On Wed, Jul 02, 2014 at 11:18:07AM +0100, Michalis Pappas wrote: > Signed-off-by: Michalis Pappas > --- > drivers/staging/gdm72xx/gdm_wimax.c | 11 --- > drivers/staging/gdm72xx/hci.h | 6 ++ > 2 files changed, 10 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/

RE: [PATCH v2 1/4] staging: rtl8192u: Remove useless return statement in r819xU_phy.c

2014-07-09 Thread Sharma, Sanjeev
Thanks Dan, -Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Wednesday, July 09, 2014 1:40 PM To: sanjeev sharma Cc: gre...@linuxfoundation.org; de...@driverdev.osuosl.org; peter.se...@gmail.com; linux-ker...@vger.kernel.org; rmf...@gmail.com; teobal...@gm

Re: [PATCH 1/2] staging: media: bcm2048: radio-bcm2048.c - removed IRQF_DISABLED macro

2014-07-09 Thread Pavel Machek
On Wed 2014-07-09 11:36:37, Anil Belur wrote: > From: Anil Belur > > - this patch removes IRQF_DISABLED macro, as this is > deprecated/noop. > > Signed-off-by: Anil Belur Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff

Re: [PATCH 2/2] staging: nokia_h4p: nokia_core.c - removed IRQF_DISABLED macro

2014-07-09 Thread Pavel Machek
On Wed 2014-07-09 11:36:38, Anil Belur wrote: > From: Anil Belur > > - this patch removes the IRQF_DISABLED macro, as this is > deprecated/noop. > > Signed-off-by: Anil Belur Acked-by: Pavel Machek I wonder if it would maek sense to do ./include/linux/interrupt.h:#define IRQF_DISABLED

[PATCH v3 0/4] line wrapping of changelog

2014-07-09 Thread sanjeev sharma
line wrap the changelog as per Dan sanjeev sharma (4): staging: rtl8192u: Remove useless return statements. staging: rtl8192u: Removed unnecessary whitespace & tab warning. staging: rtl8192u: Fixed switch and case indentation error. staging: rtl8192u: Fixed too long lines drivers/staging

[PATCH v3 1/4] staging: rtl8192u: Remove useless return statements.

2014-07-09 Thread sanjeev sharma
From: sanjeev sharma This patch will remove unneeded return statements in code. Signed-off-by: Sanjeev Sharma --- drivers/staging/rtl8192u/r819xU_phy.c | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/staging/rtl8192u/r819xU_phy.c b/drivers/staging/rtl8192u/r819xU_phy

[PATCH v3 4/4] staging: rtl8192u: Fixed too long lines

2014-07-09 Thread sanjeev sharma
From: sanjeev sharma This patch will fix too long lines warning reported by checkpatch.pl. Signed-off-by: Sanjeev Sharma --- drivers/staging/rtl8192u/r819xU_phy.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192u/r819xU_phy.c b/drivers/sta

[PATCH v3 3/4] staging: rtl8192u: Fixed switch and case indentation error.

2014-07-09 Thread sanjeev sharma
From: sanjeev sharma This patch will fix switch and case indentation Error reported by checkpatch script. Signed-off-by: Sanjeev Sharma --- drivers/staging/rtl8192u/r819xU_phy.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192u/r819xU_phy

[PATCH v3 2/4] staging: rtl8192u: Removed unnecessary whitespace & tab warning.

2014-07-09 Thread sanjeev sharma
From: sanjeev sharma This patch will remove whitespace and tabs reported by checkpatch.pl script. Signed-off-by: Sanjeev Sharma --- drivers/staging/rtl8192u/r819xU_phy.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8192u/r819x

Re: [PATCH v3 0/4] line wrapping of changelog

2014-07-09 Thread Dan Carpenter
Great. Thanks! regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/2] staging: nokia_h4p: nokia_core.c - removed IRQF_DISABLED macro

2014-07-09 Thread Anil Shashikumar Belur
On Wednesday 09 July 2014 05:16 PM, Pavel Machek wrote: > I wonder if it would maek sense to do > ./include/linux/interrupt.h:#define IRQF_DISABLED 0 to make it extra > clear that it is nop now? Pavel yes - it makes sense. there are still a few references to the macro in the code. Cheers, Anil _

Re: [PATCH v3 4/4] staging: rtl8192u: Fixed too long lines

2014-07-09 Thread Joe Perches
On Wed, 2014-07-09 at 17:49 +0530, sanjeev sharma wrote: > This patch will fix too long lines warning > reported by checkpatch.pl. Hi Sanjeev. > diff --git a/drivers/staging/rtl8192u/r819xU_phy.c > b/drivers/staging/rtl8192u/r819xU_phy.c [] > @@ -1786,7 +1788,9 @@ void InitialGainOperateWorkItem

Re: [PATCH v2] hyperv: Add netpoll support

2014-07-09 Thread Richard Weinberger
Am 09.07.2014 16:13, schrieb Sergei Shtylyov: > Hello. > > On 07/09/2014 11:58 AM, Richard Weinberger wrote: > >> In order to have at least a netconsole to debug kernel issues on >> Windows Azure this patch implements netpoll support. >> Sending packets is easy, netvsc_start_xmit() does already e

[PATCH v3] hyperv: Add netpoll support

2014-07-09 Thread Richard Weinberger
In order to have at least a netconsole to debug kernel issues on Windows Azure this patch implements netpoll support. Sending packets is easy, netvsc_start_xmit() does already everything needed. Signed-off-by: Richard Weinberger --- drivers/net/hyperv/netvsc_drv.c | 11 +++ 1 file change

Re: [PATCH v2] hyperv: Add netpoll support

2014-07-09 Thread Sergei Shtylyov
Hello. On 07/09/2014 11:58 AM, Richard Weinberger wrote: In order to have at least a netconsole to debug kernel issues on Windows Azure this patch implements netpoll support. Sending packets is easy, netvsc_start_xmit() does already everything needed. Signed-off-by: Richard Weinberger ---

[PATCH] staging: bcm: add missing blank lines after declarations

2014-07-09 Thread Pawel Lebioda
Fix "Missing blank line after declaration" warnings reported by checkpatch.pl. Signed-off-by: Pawel Lebioda --- drivers/staging/bcm/CmHost.c| 1 + drivers/staging/bcm/IPv6Protocol.c | 6 ++ drivers/staging/bcm/InterfaceDld.c | 1 + drivers/staging/bcm/InterfaceInit.c | 1 + drivers

Re: [PATCH] staging: bcm: add missing blank lines after declarations

2014-07-09 Thread Joe Perches
On Wed, 2014-07-09 at 17:59 +0200, Pawel Lebioda wrote: > Fix "Missing blank line after declaration" warnings reported by > checkpatch.pl. trivial unrelated notes: > diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c > index 3dbdf0e..adca0ce 100644 > --- a/drivers/staging/bc

Re: [PATCH 8/8] staging: rtl8712: remove inapplicable comment

2014-07-09 Thread James A. Shackleford
On Tue, Jul 08, 2014 at 01:16:53PM +0300, Dan Carpenter wrote: > On Tue, Jun 24, 2014 at 10:52:41PM -0400, James A Shackleford wrote: > > Signed-off-by: James A Shackleford > > --- > > drivers/staging/rtl8712/osdep_service.h |5 - > > 1 file changed, 5 deletions(-) > > > > diff --git a/d

Re: [PATCH] drivers: staging: android: ion: Kconfig: Let it also depend on HAS_DMA

2014-07-09 Thread Colin Cross
On Mon, Jul 7, 2014 at 1:49 AM, Chen Gang wrote: > ION need HAS_DMA (e.g. need DMA_SHARED_BUFFER), so it has to depend on > HAS_DMA, or can not pass compiling with allmodconfig under score which > NO_DMA. And the related error: > > CC drivers/staging/android/ion/ion_cma_heap.o > driver

Re: [PATCH V2] staging: gdm72xx: move T_CAPABILITY definitions to hci.h

2014-07-09 Thread Michalis Pappas
On 07/09/2014 11:26 AM, Dan Carpenter wrote: >> /* GetInformation mac address */ >> len = 0; >> @@ -621,12 +618,12 @@ static void gdm_wimax_prepare_device(struct net_device >> *dev) >> hci->length = H2B(len); >> gdm_wimax_send(nic, hci, HCI_HEADER_SIZE+len); >> >> -val =

[PATCH v3] staging: gdm72xx: move T_CAPABILITY definitions to hci.h

2014-07-09 Thread Michalis Pappas
Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_wimax.c | 11 +++ drivers/staging/gdm72xx/hci.h | 6 ++ 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/staging/gdm72xx/gdm_wimax.c index 4148013..5748d3

RE: [PATCH 8/8] drivers: scsi: storvsc: Correctly handle TEST_UNIT_READY failure

2014-07-09 Thread KY Srinivasan
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Wednesday, July 9, 2014 1:47 AM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > oher...@suse.com; jbottom...@parallels.com; jasow...@redhat.com; > a...@canonical.com;

RE: [PATCH 7/8] drivers: scsi: storvsc: Set srb_flags in all cases

2014-07-09 Thread KY Srinivasan
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Wednesday, July 9, 2014 1:45 AM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > oher...@suse.com; jbottom...@parallels.com; jasow...@redhat.com; > a...@canonical.com;

Re: [PATCH] staging: gdm72xx: conditionally compile debug code

2014-07-09 Thread Greg KH
On Tue, Jul 01, 2014 at 02:00:15PM +0100, Michalis Pappas wrote: > Signed-off-by: Michalis Pappas > --- > drivers/staging/gdm72xx/gdm_qos.c | 2 ++ > drivers/staging/gdm72xx/gdm_sdio.c | 7 +++ > drivers/staging/gdm72xx/gdm_usb.c | 7 +++ > drivers/staging/gdm72xx/gdm_wimax.c | 6 +++

RE: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-09 Thread KY Srinivasan
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Wednesday, July 9, 2014 1:44 AM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > oher...@suse.com; jbottom...@parallels.com; jasow...@redhat.com; > a...@canonical.com;

Re: [PATCH] staging: gdm72xx: reorder functions and remove function declarations

2014-07-09 Thread Greg KH
On Thu, Jul 03, 2014 at 06:45:03PM +0100, Michalis Pappas wrote: > Signed-off-by: Michalis Pappas > --- > drivers/staging/gdm72xx/gdm_sdio.c | 77 > drivers/staging/gdm72xx/gdm_usb.c | 87 +- > drivers/staging/gdm72xx/gdm_wimax.c | 179 > +---

Re: [PATCH v3] staging: gdm72xx: move T_CAPABILITY definitions to hci.h

2014-07-09 Thread Greg KH
On Wed, Jul 09, 2014 at 07:31:22PM +0100, Michalis Pappas wrote: > Signed-off-by: Michalis Pappas > --- > drivers/staging/gdm72xx/gdm_wimax.c | 11 +++ > drivers/staging/gdm72xx/hci.h | 6 ++ > 2 files changed, 9 insertions(+), 8 deletions(-) This no longer applies cleanly eit

Re: [PATCH 2/2] staging: silicom: function return fixes

2014-07-09 Thread Greg Kroah-Hartman
On Tue, Jul 01, 2014 at 02:33:43PM +0200, Davide Gianforte wrote: > Function return fixes > > Some functions don't need a temporary variable to store return value. > > Where functions always return 0, changed into void functions. > > Signed-off-by: Davide Gianforte > -- > > drivers/staging/si

Re: [PATCH] staging: dgap: removes redundant null check and change paramter for dgap_maxcps_room()

2014-07-09 Thread Greg KH
On Mon, Jul 07, 2014 at 10:27:54AM +0900, Daeseok Youn wrote: > Null checks for tty, un and ch are already done by caller, > so replace parameter "tty" with "ch" and "un". > > And also use a pointer for returning new bytes_available instead of > return variable. Why make that change? It's nicer

Re: [PATCH 1/5] staging: rtl8188eu: Remove WEXT_PRIV private ioctl handlers

2014-07-09 Thread Greg KH
On Tue, Jul 01, 2014 at 10:35:09PM +0530, navin patidar wrote: > Remove WEXT_PRIV (non-standard) ioctl handlers. > > Signed-off-by: navin patidar > --- > drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 6335 > +++- > 1 file changed, 744 insertions(+), 5591 deletions(-) Thi

Re: [PATCH 01/48] staging: rtl8188eu: Remove struct evt_priv and its uses

2014-07-09 Thread Greg KH
On Wed, Jul 02, 2014 at 10:16:57PM +0530, navin patidar wrote: > c2h_wk (work_struct) is naver scheduled to handle events, > so no use of keeping event data. > And also function rtw_hal_c2h_handler() responsible for handling c2h events, > is a dummy function. > > Signed-off-by: navin patidar > --

[PATCH 1/3] staging: rtl8712: remove wrapper function _init_workitem()

2014-07-09 Thread James A Shackleford
The inline function _init_workitem() is just a wrapper around INIT_WORK(). Oddly, this wrapper accepts 3 parameters while INIT_WORK() only accepts 2. The third parameter is unused. Signed-off-by: James A Shackleford --- drivers/staging/rtl8712/osdep_service.h | 5 - drivers/staging/rtl8712

[PATCH 2/3] staging: rtl8712: remove wrapper function _set_workitem()

2014-07-09 Thread James A Shackleford
The inline function _set_workitem() simply wraps schedule_work(). Removed. Signed-off-by: James A Shackleford --- drivers/staging/rtl8712/osdep_service.h | 5 - drivers/staging/rtl8712/rtl8712_led.c | 2 +- drivers/staging/rtl8712/rtl871x_pwrctrl.c | 4 ++-- 3 files changed, 3 inserti

Re: [PATCH] staging: nvec: add missing blank line after declarations

2014-07-09 Thread Greg Kroah-Hartman
On Mon, Jul 07, 2014 at 06:05:41PM +0200, Pawel Lebioda wrote: > Fix 'missing blank line after declaration' warnings reported by checkpatch.pl. > Signed-off-by: Pawel Lebioda > --- > drivers/staging/nvec/nvec_paz00.c | 1 + > drivers/staging/nvec/nvec_power.c | 1 + > drivers/staging/nvec/nvec_ps

[PATCH 3/3] staging: rtl8712: remove #define _workitem struct work_struct

2014-07-09 Thread James A Shackleford
_workitem is just a #define for work_struct. Remove the #define and use struct work_struct directly instead. Signed-off-by: James A Shackleford --- drivers/staging/rtl8712/drv_types.h | 2 +- drivers/staging/rtl8712/osdep_service.h | 1 - drivers/staging/rtl8712/rtl871x_led.h | 2 +-

Re: [PATCH next-20140704]: staging/rtl8821ae/base.c: sparse warning corrections

2014-07-09 Thread Greg KH
On Sun, Jul 06, 2014 at 12:01:11PM +0300, Sami Laine wrote: > From: Sami Laine > > Sparse warning corrections for: > > drivers/staging/rtl8821ae/base.c:1370:16: warning: symbol > 'rtl_make_smps_action' was not declared. Should it be static? > drivers/staging/rtl8821ae/base.c:1543:6: warning: sy

Re: [PATCH next-20140704]: staging/rtl8821ae/debug.c: sparse warning correction

2014-07-09 Thread Greg KH
On Sun, Jul 06, 2014 at 12:05:53PM +0300, Sami Laine wrote: > From: Sami Laine > > Sparse warning correction: > > vers/staging/rtl8821ae/debug.c:80:23: warning: symbol 'proc_topdir' was > not declared. Should it be static? > > Signed-off-by: Sami Laine > --- > diff --git a/drivers/staging/rtl8

Re: [PATCH v3 1/4] staging: rtl8192u: Remove useless return statements.

2014-07-09 Thread Greg KH
On Wed, Jul 09, 2014 at 05:49:39PM +0530, sanjeev sharma wrote: > From: sanjeev sharma No "S" characters? And your 0/4 Subject: was really odd, please fix up and resend all of these. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://

[PATCH v4] staging: gdm72xx: move T_CAPABILITY definitions to hci.h

2014-07-09 Thread Michalis Pappas
Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_wimax.c | 11 +++ drivers/staging/gdm72xx/hci.h | 6 ++ 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/staging/gdm72xx/gdm_wimax.c index 0f71d41..1693cc

[PATCH] staging: rtl8712: remove wrapper function thread_enter()

2014-07-09 Thread James A Shackleford
The inline function thread_enter() accepts a single ignored parameter and is just a wrapper for allow_signal(SIGTERM). Removed. Signed-off-by: James A Shackleford --- drivers/staging/rtl8712/osdep_service.h | 5 - drivers/staging/rtl8712/rtl8712_cmd.c | 2 +- 2 files changed, 1 insertion(

Re: [PATCH next-20140704]: staging/rtl8821ae/base.c: sparse warning corrections

2014-07-09 Thread Andev
On Sun, Jul 6, 2014 at 5:01 AM, Sami Laine wrote: > From: Sami Laine > > Sparse warning corrections for: > > drivers/staging/rtl8821ae/base.c:1370:16: warning: symbol > 'rtl_make_smps_action' was not declared. Should it be static? > drivers/staging/rtl8821ae/base.c:1543:6: warning: symbol 'rtl_f

[PATCH v2] staging: gdm72xx: reorder functions and remove forward declarations

2014-07-09 Thread Michalis Pappas
Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_sdio.c | 77 drivers/staging/gdm72xx/gdm_usb.c | 87 +- drivers/staging/gdm72xx/gdm_wimax.c | 179 +--- 3 files changed, 164 insertions(+), 179 deletions(-) diff -

RE: [PATCH v3] hyperv: Add netpoll support

2014-07-09 Thread Haiyang Zhang
> -Original Message- > From: Richard Weinberger [mailto:rich...@nod.at] > Sent: Wednesday, July 9, 2014 10:24 AM > To: KY Srinivasan; Haiyang Zhang > Cc: sergei.shtyl...@cogentembedded.com; rom...@fr.zoreil.com; > de...@linuxdriverproject.org; net...@vger.kernel.org; linux- > ker...@vger.

Re: [PATCH] staging: gdm72xx: conditionally compile debug code

2014-07-09 Thread Michalis Pappas
On 07/09/2014 07:51 PM, Greg KH wrote: > On Tue, Jul 01, 2014 at 02:00:15PM +0100, Michalis Pappas wrote: >> Signed-off-by: Michalis Pappas >> --- >> drivers/staging/gdm72xx/gdm_qos.c | 2 ++ >> drivers/staging/gdm72xx/gdm_sdio.c | 7 +++ >> drivers/staging/gdm72xx/gdm_usb.c | 7 +++

RE: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

2014-07-09 Thread KY Srinivasan
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Wednesday, July 9, 2014 1:43 AM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > oher...@suse.com; jbottom...@parallels.com; jasow...@redhat.com; > a...@canonical.com;

Re: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

2014-07-09 Thread James Bottomley
On Wed, 2014-07-09 at 19:52 +, KY Srinivasan wrote: > > > -Original Message- > > From: Christoph Hellwig [mailto:h...@infradead.org] > > Sent: Wednesday, July 9, 2014 1:43 AM > > To: KY Srinivasan > > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > > oher...@suse.com;

RE: [PATCH 3/8] Drivers: scsi: storvsc: Fix a bug in handling VMBUS protocol version

2014-07-09 Thread KY Srinivasan
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Wednesday, July 9, 2014 1:42 AM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > oher...@suse.com; jbottom...@parallels.com; jasow...@redhat.com; > a...@canonical.com;

RE: [PATCH 2/8] Drivers: scsi: storvsc: Filter commands based on the storage protocol version

2014-07-09 Thread KY Srinivasan
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Wednesday, July 9, 2014 1:41 AM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > oher...@suse.com; jbottom...@parallels.com; jasow...@redhat.com; > a...@canonical.com;

RE: [PATCH 1/8] Drivers: scsi: storvsc: Change the limits to reflect the values on the host

2014-07-09 Thread KY Srinivasan
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Wednesday, July 9, 2014 1:40 AM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > oher...@suse.com; jbottom...@parallels.com; jasow...@redhat.com; > a...@canonical.com;

Re: [PATCH] staging: gdm72xx: conditionally compile debug code

2014-07-09 Thread Greg KH
On Wed, Jul 09, 2014 at 08:52:07PM +0100, Michalis Pappas wrote: > On 07/09/2014 07:51 PM, Greg KH wrote: > > On Tue, Jul 01, 2014 at 02:00:15PM +0100, Michalis Pappas wrote: > >> Signed-off-by: Michalis Pappas > >> --- > >> drivers/staging/gdm72xx/gdm_qos.c | 2 ++ > >> drivers/staging/gdm72xx

[PATCH 2/2] staging: unisys: added virtpci info entry

2014-07-09 Thread Erik Arfvidson
This patch adds the virtpci debugfs directory and the info entry inside of it. Signed-off-by: Erik Arfvidson --- drivers/staging/unisys/virtpci/virtpci.c | 123 ++- 1 file changed, 119 insertions(+), 4 deletions(-) diff --git a/drivers/staging/unisys/virtpci/virtpci.

Re: [PATCH 2/2] staging: unisys: added virtpci info entry

2014-07-09 Thread Greg KH
On Wed, Jul 09, 2014 at 04:22:43PM -0400, Erik Arfvidson wrote: > This patch adds the virtpci debugfs directory and the info entry > inside of it. > > Signed-off-by: Erik Arfvidson > --- > drivers/staging/unisys/virtpci/virtpci.c | 123 > ++- > 1 file changed, 119 in

Re: [PATCH 2/2] staging: unisys: added virtpci info entry

2014-07-09 Thread Greg KH
On Wed, Jul 09, 2014 at 04:22:43PM -0400, Erik Arfvidson wrote: > @@ -1426,7 +1537,10 @@ static int __init virtpci_mod_init(void) > > LOGINF("successfully registered virtpci_ctrlchan_func (0x%p) as > callback.\n", >(void *) &virtpci_ctrlchan_func); > - > + /*create debugfs

RE: Status of RMI4 drivers?

2014-07-09 Thread Christopher Heiny
Hi Kristina, Once again, my apologies for top-posting. The synaptics-rmi4 driver is intended to work with any RMI4 compliant sensors (subject to platform specific tweaks), and this should handle any of the sensors currently handled by the staging drivers or other drivers based off of the stagi

RE: Status of RMI4 drivers?

2014-07-09 Thread Christopher Heiny
Sorry for top-posting on this - I'm travelling and don't have access to a proper mail client. My work on synaptics-rmi4 has been on hold pending the uprev and some outstanding patches being either rejected or accepted. Dmitry - if there's something that can be done on our end to move things fo

RE: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

2014-07-09 Thread KY Srinivasan
> -Original Message- > From: James Bottomley [mailto:jbottom...@parallels.com] > Sent: Wednesday, July 9, 2014 12:57 PM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; h...@infradead.org; > de...@linuxdriverproject.org; a...@canonical.com; sta...@vger.kernel.org; > linux-s...@vger

Re: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

2014-07-09 Thread James Bottomley
On Wed, 2014-07-09 at 21:14 +, KY Srinivasan wrote: > > > -Original Message- > > From: James Bottomley [mailto:jbottom...@parallels.com] > > Sent: Wednesday, July 9, 2014 12:57 PM > > To: KY Srinivasan > > Cc: linux-ker...@vger.kernel.org; h...@infradead.org; > > de...@linuxdriverproje

RE: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

2014-07-09 Thread KY Srinivasan
> -Original Message- > From: James Bottomley [mailto:jbottom...@parallels.com] > Sent: Wednesday, July 9, 2014 3:27 PM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; m...@mkp.net; h...@infradead.org; > de...@linuxdriverproject.org; a...@canonical.com; sta...@vger.kernel.org; > li

Re: [PATCH] staging: dgap: removes redundant null check and change paramter for dgap_maxcps_room()

2014-07-09 Thread DaeSeok Youn
Hi, 2014-07-10 4:02 GMT+09:00 Greg KH : > On Mon, Jul 07, 2014 at 10:27:54AM +0900, Daeseok Youn wrote: >> Null checks for tty, un and ch are already done by caller, >> so replace parameter "tty" with "ch" and "un". >> >> And also use a pointer for returning new bytes_available instead of >> retur

RE: [PATCH 1/8] Drivers: scsi: storvsc: Change the limits to reflect the values on the host

2014-07-09 Thread KY Srinivasan
> -Original Message- > From: driverdev-devel-boun...@linuxdriverproject.org [mailto:driverdev- > devel-boun...@linuxdriverproject.org] On Behalf Of KY Srinivasan > Sent: Wednesday, July 9, 2014 1:07 PM > To: Christoph Hellwig > Cc: linux-s...@vger.kernel.org; jasow...@redhat.com; linux- >

Re: [PATCH v3] hyperv: Add netpoll support

2014-07-09 Thread David Miller
From: Richard Weinberger Date: Wed, 9 Jul 2014 16:23:59 +0200 > In order to have at least a netconsole to debug kernel issues on > Windows Azure this patch implements netpoll support. > Sending packets is easy, netvsc_start_xmit() does already everything > needed. > > Signed-off-by: Richard Wei

Re: [PATCH 1/5] staging: rtl8188eu: Remove WEXT_PRIV private ioctl handlers

2014-07-09 Thread navin patidar
On Thu, Jul 10, 2014 at 12:34 AM, Greg KH wrote: > On Tue, Jul 01, 2014 at 10:35:09PM +0530, navin patidar wrote: >> Remove WEXT_PRIV (non-standard) ioctl handlers. >> >> Signed-off-by: navin patidar >> --- >> drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 6335 >> +++- >>

Re: [PATCH 1/5] staging: rtl8188eu: Remove WEXT_PRIV private ioctl handlers

2014-07-09 Thread Greg KH
On Thu, Jul 10, 2014 at 06:24:21AM +0530, navin patidar wrote: > On Thu, Jul 10, 2014 at 12:34 AM, Greg KH wrote: > > On Tue, Jul 01, 2014 at 10:35:09PM +0530, navin patidar wrote: > >> Remove WEXT_PRIV (non-standard) ioctl handlers. > >> > >> Signed-off-by: navin patidar > >> --- > >> drivers/s

Re: [PATCH 1/5] staging: rtl8188eu: Remove WEXT_PRIV private ioctl handlers

2014-07-09 Thread navin patidar
On Thu, Jul 10, 2014 at 6:29 AM, Greg KH wrote: > On Thu, Jul 10, 2014 at 06:24:21AM +0530, navin patidar wrote: >> On Thu, Jul 10, 2014 at 12:34 AM, Greg KH wrote: >> > On Tue, Jul 01, 2014 at 10:35:09PM +0530, navin patidar wrote: >> >> Remove WEXT_PRIV (non-standard) ioctl handlers. >> >> >> >

Re: [PATCH 1/5] staging: rtl8188eu: Remove WEXT_PRIV private ioctl handlers

2014-07-09 Thread Greg KH
On Thu, Jul 10, 2014 at 06:56:39AM +0530, navin patidar wrote: > On Thu, Jul 10, 2014 at 6:29 AM, Greg KH wrote: > > On Thu, Jul 10, 2014 at 06:24:21AM +0530, navin patidar wrote: > >> On Thu, Jul 10, 2014 at 12:34 AM, Greg KH > >> wrote: > >> > On Tue, Jul 01, 2014 at 10:35:09PM +0530, navin pa

[PATCH V2] staging: dgap: removes redundant null check and change paramter for dgap_maxcps_room()

2014-07-09 Thread Daeseok Youn
Null checks for tty, un and ch are already done by caller, so replace parameter "tty" with "ch" and "un". Signed-off-by: Daeseok Youn --- V2: revert return type from int to void. leave it originally. drivers/staging/dgap/dgap.c | 21 - 1 files changed, 4 insertions(+), 17

[PATCH 01/69] staging: rtl8188eu: re-use mac_pton() helper

2014-07-09 Thread navin patidar
From: Andy Shevchenko The helper mac_pton() validates and converts MAC address from string format to a number. Originally code uses simple code to do that. With mac_pton() the driver now validates input as well. Signed-off-by: Andy Shevchenko Signed-off-by: navin patidar --- drivers/staging/r

[PATCH 03/69] staging: rtl8188eu: re-use hex_to_bin() instead of custom code

2014-07-09 Thread navin patidar
From: Andy Shevchenko hex_to_bin could be used to convert hexdecimal digit to its binary representation. Signed-off-by: Andy Shevchenko Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 17 - drivers/staging/rtl8188eu/include/wlan_bssdef.h |

[PATCH 02/69] staging: rtl8188eu: substitute custom hex2bin()

2014-07-09 Thread navin patidar
From: Andy Shevchenko Instead of using custom code to convert hexdecinal strings to their binary represantation let's use kernel's library function. Signed-off-by: Andy Shevchenko Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_ieee80211.c |5 --- drivers/staging/rtl8

[PATCH 13/69] staging: rtl8188eu: Remove dummy function rtw_hal_c2h_handler()

2014-07-09 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/hal_intf.c |9 - drivers/staging/rtl8188eu/include/hal_intf.h |4 2 files changed, 13 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c b/drivers/staging/rtl8188eu/hal/hal_intf.c index f002c

[PATCH 06/69] staging: rtl8188eu: Remove usb_osintf.h header file.

2014-07-09 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_ieee80211.c |2 +- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c |2 -- drivers/staging/rtl8188eu/core/rtw_mlme.c |1 - drivers/staging/rtl8188eu/core/rtw_pwrctrl.c |1 - drivers/staging/rtl8188eu/core/rtw

[PATCH 09/69] staging: rtl8188eu: Remove struct evt_priv and its uses

2014-07-09 Thread navin patidar
c2h_wk (work_struct) is naver scheduled to handle events, so no use of keeping event data. And also function rtw_hal_c2h_handler() responsible for handling c2h events, is a dummy function. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 86 -

[PATCH 10/69] staging: rtl8188eu: Remove function c2h_evt_hdl()

2014-07-09 Thread navin patidar
c2h_evt_hdl() calls a dummy function rtw_hal_c2h_handler() to handle events, so no use of keeping it. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 28 1 file changed, 28 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_cm

[PATCH 11/69] staging: rtl8188eu: Remove unused function c2h_evt_read()

2014-07-09 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/hal_com.c | 49 --- drivers/staging/rtl8188eu/include/hal_com.h |2 -- 2 files changed, 51 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/hal_com.c b/drivers/staging/rtl8188eu/hal/hal_com.c

[PATCH 12/69] staging: rtl8188eu: Remove unused function c2h_evt_clear()

2014-07-09 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/hal_com.c | 11 --- drivers/staging/rtl8188eu/include/hal_com.h |2 -- 2 files changed, 13 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/hal_com.c b/drivers/staging/rtl8188eu/hal/hal_com.c index c91a58c..

[PATCH 15/69] staging: rtl8188eu: rtw_cmd.h: Remove unused macro and structure

2014-07-09 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/rtw_cmd.h |9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_cmd.h b/drivers/staging/rtl8188eu/include/rtw_cmd.h index 7a70f02..049e112 100644 --- a/drivers/staging/rtl8188eu/incl

[PATCH 14/69] staging: rtl8188eu: Remove unused function rtw_hal_c2h_id_filter_ccx()

2014-07-09 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/hal_intf.c |5 - drivers/staging/rtl8188eu/include/hal_intf.h |4 2 files changed, 9 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c b/drivers/staging/rtl8188eu/hal/hal_intf.c index 279dd0b..2

[PATCH 18/69] staging: rtl8188eu: Remove unused function rtw_setbasicrate_cmd()

2014-07-09 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_cmd.c| 33 --- drivers/staging/rtl8188eu/include/rtw_cmd.h |1 - 2 files changed, 34 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd.

[PATCH 16/69] staging: rtl8188eu: Remove unused function rtw_getrttbl_cmd()

2014-07-09 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_cmd.c| 34 --- drivers/staging/rtl8188eu/include/rtw_cmd.h |8 --- 2 files changed, 42 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rt

[PATCH 17/69] staging: rtl8188eu: Remove unused function rtw_c2h_wk_cmd()

2014-07-09 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_cmd.c| 33 --- drivers/staging/rtl8188eu/include/rtw_cmd.h |2 -- 2 files changed, 35 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd

[PATCH 20/69] staging: rtl8188eu: Remove unused function rtw_setbbreg_cmd()

2014-07-09 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_cmd.c| 30 --- drivers/staging/rtl8188eu/include/rtw_cmd.h |1 - 2 files changed, 31 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd.

[PATCH 21/69] staging: rtl8188eu: Remove unused function rtw_getbbreg_cmd()

2014-07-09 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_cmd.c| 33 --- drivers/staging/rtl8188eu/include/rtw_cmd.h |1 - 2 files changed, 34 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd.

[PATCH 19/69] staging: rtl8188eu: Remove unused function rtw_setphy_cmd()

2014-07-09 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_cmd.c| 40 --- drivers/staging/rtl8188eu/include/rtw_cmd.h |1 - 2 files changed, 41 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd.

  1   2   >