RE: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-07-21 Thread Yue Zhang (OSTC DEV)
> From: Richard Weinberger [mailto:rich...@nod.at] > Sent: Monday, July 21, 2014 2:55 PM > > Yue, > > Am 21.07.2014 04:44, schrieb Yue Zhang (OSTC DEV): > >> From: Richard Weinberger [mailto:richard.weinber...@gmail.com] > >> Why 10? Is this a random number which works by accident for ifplugd? >

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-07-21 Thread Richard Weinberger
Yue, Am 21.07.2014 10:05, schrieb Yue Zhang (OSTC DEV): > The problem of systemd implementation is that in different distros, the ways > to > restart service are different. Propagating the event to userspace also > doesn't help > for this issue. This way each distro can provide their own rest

RE: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-07-21 Thread Yue Zhang (OSTC DEV)
> From: Richard Weinberger [mailto:rich...@nod.at] > Sent: Monday, July 21, 2014 4:18 PM > > Yue, > > Am 21.07.2014 10:05, schrieb Yue Zhang (OSTC DEV): > > The problem of systemd implementation is that in different distros, the > > ways > > to restart service are different. Propagating the eve

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-07-21 Thread Richard Weinberger
Yue, Am 21.07.2014 10:44, schrieb Yue Zhang (OSTC DEV): > Hi, Richard > > IMHO, all networking implementations should handle the cable offline event. > Consider > this situation. I unplugged the network cable and connect it to a new network > switch > after 10 seconds. If the DHCP renew is not

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-07-21 Thread Olaf Hering
On Mon, Jul 21, Richard Weinberger wrote: > My concern is that 10 seconds is maybe not a the right choice. > (As we cannot know all implementations) Until someone reports an issue with it, 10 is fine. Just like 20 or 666. Olaf ___ devel mailing list de

[PATCH 07/29] staging: rtl8723au: Remove no-op function dm_CheckStatistics()

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_dm.c b/drivers/staging/rtl8723au/hal/rtl8723a_dm.c index 4a3d2e1..3fb54fc 100644 --- a/drivers/staging

[PATCH 20/29] staging: rtl8723au: Eliminate ODM_CMNINFO_POWER_SAVING usage

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 8 ++-- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 4 drivers/staging/rtl8723au/include/odm.h | 3 --- 3 files changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/staging

[PATCH 19/29] staging: rtl8723au: Eliminate ODM_CMNINFO_SCAN related code

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 18 -- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 4 +--- drivers/staging/rtl8723au/include/odm.h | 4 +--- 3 files changed, 10 insertions(+), 16 deletions(-) diff --git a/

[PATCH 10/29] staging: rtl8723au: Remove ODM_CMNINFO_[RT]X_UNI and related code

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 8 drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 4 drivers/staging/rtl8723au/include/odm.h | 6 -- 3 files changed, 18 deletions(-) diff --git a/drivers/staging/rtl8723au/hal

[PATCH 16/29] staging: rtl8723au: Eliminate ugly ODM_CMNINFO_SEC_CHNL_OFFSET usage

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 17 +++-- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 2 -- drivers/staging/rtl8723au/include/odm.h | 3 --- 3 files changed, 7 insertions(+), 15 deletions(-) diff --git a/drive

[PATCH 13/29] staging: rtl8723au: Remove another pile of awful unused ODM variables

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 18 -- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 2 -- drivers/staging/rtl8723au/include/odm.h | 16 3 files changed, 36 deletions(-) diff --git a/drivers/

[PATCH 01/29] staging: rtl8723au: Fold odm_EdcaTurboCheck23aCE23a() into odm_EdcaTurboCheck23a()

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 37 + 1 file changed, 13 insertions(+), 24 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index ce192de..3292b5f 10

[PATCH 15/29] staging: rtl8723au: ODM_DMWatchdog23a(): Take a struct hal_data_8723a *

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen This will allow us to access variables in the hal_data struct directly, and get rid of the horrendous ODM_CMNINFO spaghetti API. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 4 +++- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 2 +- drivers/

[PATCH 08/29] staging: rtl8723au: Remove write-only struct dm_priv->DM_Type variable

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 1 - drivers/staging/rtl8723au/include/rtl8723a_dm.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_dm.c b/drivers/staging/rtl8723au/hal/rtl8723a_dm

[PATCH 25/29] staging: rtl8723au: Remove a pile of fluff for calling into a bunch of no-op functions

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen The whole antenna diversity selection was completely pointless as all the end functions called were no-ops. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 77 drivers/staging/rtl8723au/hal/odm_HWConfig.c | 2 - dr

[PATCH 28/29] staging: rtl8723au: Fold rtw_resume_process23a() into rtw_resume()

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/include/hal_intf.h | 1 - drivers/staging/rtl8723au/os_dep/usb_intf.c | 9 - 2 files changed, 10 deletions(-) diff --git a/drivers/staging/rtl8723au/include/hal_intf.h b/drivers/staging/rtl8723au/include/hal

[PATCH 17/29] staging: rtl8723au: Eliminate ODM_CMNINFO_BW usage

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 19 --- drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 3 ++- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 2 -- drivers/staging/rtl8723au/hal/usb_halinit.c | 4 ++-- drivers/

[PATCH 09/29] staging: rtl8723au: Remove write-only variables struct dm_priv->{Init, }DMFlag

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/hal_com.c | 6 ++ drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 7 --- drivers/staging/rtl8723au/include/rtl8723a_dm.h | 2 -- 3 files changed, 2 insertions(+), 13 deletions(-) diff --git a/dri

[PATCH 00/29] staging: rtl8723au: Remove bad layer API

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Greg, Another set of rtl8723au changes - this was meant to be a 'I'll just fix this little issue' but snowballed into a fair bit more, as I realized just how bad the original code was (patch 10 onwards). The bulk of this set removes a bad layered API. The original driver is t

[PATCH 12/29] staging: rtl8723au: Remove another pile of useless ODM variables

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 16 drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 5 + drivers/staging/rtl8723au/include/odm.h | 16 +--- 3 files changed, 2 insertions(+), 35 deletions(-) dif

[PATCH 04/29] staging: rtl8723au: Remove unused DefaultInitialGain array

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/include/rtl8723a_hal.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723au/include/rtl8723a_hal.h b/drivers/staging/rtl8723au/include/rtl8723a_hal.h index 1f63eb1..3b0b06d 100644 --- a/drivers

[PATCH 05/29] staging: rtl8723au: Remove some redundant check for hw_init_completed

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_dm.c b/drivers/staging/rtl8723au/hal/rtl8723a_dm.c index ac47a97..bf1db90

[PATCH 03/29] staging: rtl8723au: bDMInitialGainEnable is always true

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 10 -- drivers/staging/rtl8723au/include/odm.h | 1 - 2 files changed, 11 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index dd02585..ed

[PATCH 23/29] staging: rtl8723au: Merge Init_ODM_ComInfo_8723a() into rtl8723a_init_dm_priv()

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_dm.c b/drivers/staging/rtl8723au/hal/rtl8723a_dm.c index fa3e5aa..fa82

[PATCH 26/29] staging: rtl8723au: Fold rtl8723a_set_nav_upper() into rtl8723au_hal_init()

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/hal_com.c | 18 -- drivers/staging/rtl8723au/hal/usb_halinit.c | 4 +++- drivers/staging/rtl8723au/include/hal_com.h | 1 - 3 files changed, 3 insertions(+), 20 deletions(-) diff --git a/driv

[PATCH 06/29] staging: rtl8723au: Remove no-op rtl8723a_deinit_dm_priv()

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 4 drivers/staging/rtl8723au/include/rtl8723a_dm.h | 1 - drivers/staging/rtl8723au/os_dep/os_intfs.c | 2 -- 3 files changed, 7 deletions(-) diff --git a/drivers/staging/rtl8723au/hal

[PATCH 29/29] staging: rtl8723au: rtw_resume(): release semaphore before exit on error

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/os_dep/usb_intf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/os_dep/usb_intf.c b/drivers/staging/rtl8723au/os_dep/usb_intf.c index c75427f..06c885f 100644 --- a/dr

[PATCH 27/29] staging: rtl8723au: Reduce wrapper layers around hal_{de, }init() calls

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 52 +++- drivers/staging/rtl8723au/include/hal_intf.h | 4 +-- drivers/staging/rtl8723au/os_dep/os_intfs.c | 6 ++-- drivers/staging/rtl8723au/os_dep/usb_intf.c | 2 +-

[PATCH 24/29] staging: rtl8723au: odm_CommonInfoSelfInit23a(): Use proper register defines

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index 1b39cbe..4e7a198 100644 --- a/drivers/staging/rtl8723

[PATCH 02/29] staging: rtl8723au: Declare odm_EdcaTurbo*() functions static

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index 3292b5f..dd02585 100644 --- a/drivers/staging/rtl87

[PATCH 18/29] staging: rtl8723au: Eliminate ODM_CMNINFO_CHNL usage

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 10 +++--- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 2 -- drivers/staging/rtl8723au/include/odm.h | 4 3 files changed, 3 insertions(+), 13 deletions(-) diff --git a/drivers/sta

[PATCH 21/29] staging: rtl8723au: Eliminate obsolete odm_CmnInfoHook_Debug23a()

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index 754b816..d420f33 100644 --- a/drivers/staging/rtl8723au/hal/odm.c ++

[PATCH 14/29] staging: rtl8723au: We don't need two APIs to set pHalData->odmpriv.SupportAbility

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 6 -- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 3 +-- drivers/staging/rtl8723au/include/odm.h | 1 - 3 files changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/staging/rtl872

[PATCH 22/29] staging: rtl8723au: Remove obsolete ODM23a_CmnInfoHook()

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 15 --- drivers/staging/rtl8723au/include/odm.h | 2 -- 2 files changed, 17 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index d420f

[PATCH 11/29] staging: rtl8723au: Remove useless ODM_CMNINFO_{WM_MODE, BAND} related code

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 8 drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 2 -- drivers/staging/rtl8723au/include/odm.h | 6 -- 3 files changed, 16 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/o

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-07-21 Thread Tom Gundersen
On Fri, Jul 18, 2014 at 12:55 PM, Yue Zhang wrote: > From: Yue Zhang > > This patch addresses the comment from Olaf Hering and Greg KH > for a previous commit 3a494e710367 ("hyperv: Add handler for > RNDIS_STATUS_NETWORK_CHANGE event") > > In previous solution, the driver calls "network restart"

[PATCH v3 1/3] staging: lustre: lov: Cleanup lov_check_set() in lov_request.c

2014-07-21 Thread Riccardo Lucchese
Make the code clearer by introducing a local variable and removing the unnecessary 'if' statement. Signed-off-by: Riccardo Lucchese Acked-by: Julia Lawall --- Changes in v3: - Renamed the local variable 'desc' to 'tgt' to be consistent with other definitions in the driver. Changes in v2: -

staging: lustre: lov: Cleanup style issues in lov_request.c

2014-07-21 Thread Riccardo Lucchese
Hello, This patch series contains one cleanup and two coding style fixes for lov_request.c. This iteration addresses the review comments received by v2. Changes in v3: - Renamed the local variable introduced in v2-1/3 to be consistent with other definitions in the driver. Changes in v2: -

[PATCH v3 2/3] staging: lustre: lov: Add a blank line after declarations in lov_request.c

2014-07-21 Thread Riccardo Lucchese
Fix the following checkpatch.pl issue in lov_request.c: WARNING: Missing a blank line after declarations Signed-off-by: Riccardo Lucchese Acked-by: Julia Lawall --- No changes in v3. Changes in v2: - Changed the subject line to follow the same convention used by previous commits to the same

[PATCH v3 3/3] staging: lustre: lov: Add a space before open braces '{' in lov_request.c

2014-07-21 Thread Riccardo Lucchese
Fix the following checkpatch.pl issue in lov_request.c: ERROR: space required before the open brace '{' Signed-off-by: Riccardo Lucchese Acked-by: Julia Lawall --- No changes in v3. Changes in v2: - Changed the subject line to follow the same convention used by previous commits to the same

RE: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-07-21 Thread Yue Zhang (OSTC DEV)
> From: Tom Gundersen [mailto:t...@jklm.no] > Sent: Monday, July 21, 2014 5:42 PM > > On Fri, Jul 18, 2014 at 12:55 PM, Yue Zhang wrote: > > From: Yue Zhang > > > > This patch addresses the comment from Olaf Hering and Greg KH > > for a previous commit 3a494e710367 ("hyperv: Add handler for > >

Re: [PATCH 0/7] staging: comedi: core: checkpatch.pl --strict cleanup

2014-07-21 Thread Ian Abbott
On 2014-07-18 22:28, H Hartley Sweeten wrote: comedi_fops.c also still has a couple: CHECK: if this code is redundant consider removing it Two of them deal with #if 0'ed code in do_lock_ioctl() and do_unlock_ioctl(). The disabled code would call the subdevice (*lock_f) and (*unlock) callbacks.

Re: [PATCH] staging: comedi: drivers: remove unnecessary *_{IO, MEM}SIZE defines

2014-07-21 Thread Ian Abbott
On 2014-07-19 01:23, H Hartley Sweeten wrote: Some of the legacy comedi drivers have a *_{IO,MEM}SIZE define that is only passed to comedi_request_region() to specify the size of the region. For aesthetics, remove these defines. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-H

Re: [PATCH 7/9] staging: comedi: drivers: remove unnecessary *_SIZE defines

2014-07-21 Thread Ian Abbott
On 2014-07-19 01:01, H Hartley Sweeten wrote: Some of the legacy comedi drivers have a *_SIZE define that is only passed to comedi_request_region() to specify the size of the region. Some of the pnp drivers (pci, etc.) also have a *_SIZE define which is unused. For aesthetics, remove these defi

Re: [PATCH 1/1] Drivers: scsi: storvsc: Add blist flags

2014-07-21 Thread Christoph Hellwig
On Sun, Jul 20, 2014 at 08:33:42PM -0700, K. Y. Srinivasan wrote: > Add blist flags to permit the reading of the VPD pages even when > the target may claim SPC-2 compliance. MSFT targets currently > claim SPC-2 compliance while they implement post SPC-2 features. > With this patch we can correctly

Re: [PATCH 0/9] staging: comedi: misc. cleanup

2014-07-21 Thread Ian Abbott
On 2014-07-19 01:01, H Hartley Sweeten wrote: Some misc. cleanup for comedi that I have had sitting around... H Hartley Sweeten (9): staging: comedi: drivers: cleanup cmd->flags use staging: comedi: ni_at_a2150: remove forward declarations staging: comedi: ni_pcidio: remove forward decl

[PATCH] staging/nvec: Pass proper resource to mfd_add_devices()

2014-07-21 Thread Thierry Reding
From: Thierry Reding The mfd_add_devices() parameter takes a struct resource * as fifth argument, but the nvec driver passes in a void __iomem *. The driver gets away with it because none of the subdevices ever directly access the registers. While at it, use platform_get_irq() instead of platfor

[PATCH] staging/nvec: Remove double const qualifier

2014-07-21 Thread Thierry Reding
From: Thierry Reding The SIMPLE_DEV_PM_OPS macro already uses the const qualifier, so there's no need to repeat it. Signed-off-by: Thierry Reding --- drivers/staging/nvec/nvec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nv

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-07-21 Thread Lennart Poettering
On Mon, 21.07.14 10:21, Yue Zhang (OSTC DEV) (yue...@microsoft.com) wrote: > Some network monitoring daemon, like ifplugd has a deferring mechanism. > When it detects carriers is offline, it doesn't trigger DHCP renew > immediately. > Instead it will wait for another 5 seconds to check whether c

RE: [PATCH 1/1] Drivers: scsi: storvsc: Add blist flags

2014-07-21 Thread KY Srinivasan
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Monday, July 21, 2014 4:27 AM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; a...@canonical.com; > jasow...@redhat.com;

Re: [PATCH 1/8] staging: unisys: add toolaction to sysfs

2014-07-21 Thread Romer, Benjamin M
On Sat, 2014-07-19 at 09:36 -0700, Greg KH wrote: > > /* /sys/devices/platform/visorchipset */ > > static struct platform_device Visorchipset_platform_device = { > > .name = "visorchipset", > > .id = -1, > > + .dev.groups = visorchipset_dev_groups, > > Only create this device when Con

[PATCH] staging: comedi: ni_65xx: don't invert outputs by default

2014-07-21 Thread Ian Abbott
This driver currently inverts the outputs for the DO (digital output) subdevice for some of the boards it supports, indicated by the `invert_outputs` member in the board-specific data being initialized to 1. It seems this driver shouldn't really be inverting outputs for these boards at all, but ha

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-07-21 Thread Tom Gundersen
On Mon, Jul 21, 2014 at 12:21 PM, Yue Zhang (OSTC DEV) wrote: >> From: Tom Gundersen [mailto:t...@jklm.no] >> Sent: Monday, July 21, 2014 5:42 PM >> >> On Fri, Jul 18, 2014 at 12:55 PM, Yue Zhang wrote: >> > From: Yue Zhang >> > >> > This patch addresses the comment from Olaf Hering and Greg KH

Re: [PATCH 1/8] staging: unisys: add toolaction to sysfs

2014-07-21 Thread Greg KH
On Mon, Jul 21, 2014 at 08:36:02AM -0500, Romer, Benjamin M wrote: > On Sat, 2014-07-19 at 09:36 -0700, Greg KH wrote: > > > > /* /sys/devices/platform/visorchipset */ > > > static struct platform_device Visorchipset_platform_device = { > > > .name = "visorchipset", > > > .id = -1, > > > + .

[PATCH 1/2] staging: comedi: ni_6527: support INSN_CONFIG_DIGITAL_TRIG

2014-07-21 Thread Ian Abbott
The "edge detection interrupt" subdevice supports the `INSN_CONFIG_CHANGE_NOTIFY` comedi instruction which is only supported by one other driver. The `INSN_CONFIG_DIGITAL_TRIG` comedi instruction is more flexible as it supports both edge and level detection, but is not currently supported by this

[PATCH 0/2] staging: comedi: ni_6527 edge detection changes

2014-07-21 Thread Ian Abbott
Add partial support for INSN_CONFIG_DIGITAL_TRIG as an alternative to INSN_CONFIG_CHANGE_NOTIFY, and initialize the edge detection registers. 1) staging: comedi: ni_6527: support INSN_CONFIG_DIGITAL_TRIG 2) staging: comedi: ni_6527: reset edge detection registers drivers/staging/comedi/drivers/n

[PATCH 2/2] staging: comedi: ni_6527: reset edge detection registers

2014-07-21 Thread Ian Abbott
`ni6527_reset()` is called to reset various registers when the device is being initialized or deinitialized. The edge detection interrupt is disabled by this function, but the rising and falling edge detection registers are currently left alone. Call `ni6527_set_edge_detection()` to set them to a

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-07-21 Thread Dan Williams
On Mon, 2014-07-21 at 15:11 +0200, Lennart Poettering wrote: > On Mon, 21.07.14 10:21, Yue Zhang (OSTC DEV) (yue...@microsoft.com) wrote: > > > Some network monitoring daemon, like ifplugd has a deferring mechanism. > > When it detects carriers is offline, it doesn't trigger DHCP renew > > immedi

[PATCH 1/2] staging: comedi: comedi_fops: remove disabled subdevice lock/unlock callback

2014-07-21 Thread H Hartley Sweeten
According to Ian Abbott, this code was added in comedi-0.7.6 back in June 1999 and has always been disabled. The 'lock_f' and 'unlock' members don't even exist in the comedi_subdevice. Just remove the disabled code. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- dr

[PATCH 0/2] staging: comedi: remove unused subdevice lock/unlock

2014-07-21 Thread H Hartley Sweeten
The subdevice lock/unlock callbacks have been disbled ever since the code was merged. It's also broken due to the core member names in the struct not matching the calls in the core. Just remove it. H Hartley Sweeten (2): staging: comedi: comedi_fops: remove disabled subdevice lock/unlock callbac

[PATCH 2/2] staging: comedi: comedidev.h: remove unused callbacks from comedi_subdevice

2014-07-21 Thread H Hartley Sweeten
The 'do_lock' and 'do_unlock' callbacks are not used be any of the comedi drivers or the comedi core. Just remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/comedidev.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/st

[PATCH 1/4] staging: unisys: remove virthba proc

2014-07-21 Thread Erik Arfvidson
This patch removes all proc entries, directories, and functions Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/virthba/virthba.c | 206 --- 1 file changed, 206 deletions(-) diff --git a/drivers/staging/unisys/virthba/virthba.c

[PATCH 1/4] staging: unisys: remove virthba proc

2014-07-21 Thread Erik Arfvidson
This patch removes all proc entries, directories, and functions Signed-off-by: Erik Arfvidson --- drivers/staging/unisys/virthba/virthba.c | 206 --- 1 file changed, 206 deletions(-) diff --git a/drivers/staging/unisys/virthba/virthba.c b/drivers/staging/unisys/virt

[PATCH 2/4] staging: unisys: added virthba debugfs dir and info entry

2014-07-21 Thread Erik Arfvidson
This patch adds virthba debugfs directory and info entry Signed-off-by: Erik Arfvidson --- drivers/staging/unisys/virthba/virthba.c | 79 1 file changed, 79 insertions(+) diff --git a/drivers/staging/unisys/virthba/virthba.c b/drivers/staging/unisys/virthba/vir

[PATCH 3/4] staging: unisys: added virthba rqwait entry

2014-07-21 Thread Erik Arfvidson
This patch adds the rqwait entry into the virthba debugfs directory Signed-off-by: Erik Arfvidson --- drivers/staging/unisys/virthba/virthba.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/unisys/virthba/virthba.c b/drivers/staging/unisys/virthba/virthba.c index 121cc05.

[PATCH 2/4] staging: unisys: added virthba debugfs dir and info entry

2014-07-21 Thread Erik Arfvidson
This patch adds virthba debugfs directory and info entry Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/virthba/virthba.c | 79 1 file changed, 79 insertions(+) diff --git a/drivers/staging/unisys/virthba/virthba.c b/dri

[PATCH 4/4] staging: unisys: added virthba enable_ints entry

2014-07-21 Thread Erik Arfvidson
This patch adds enable_ints entry to virthba directory Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/virthba/virthba.c | 63 1 file changed, 63 insertions(+) diff --git a/drivers/staging/unisys/virthba/virthba.c b/drive

[PATCH 4/4] staging: unisys: added virthba enable_ints entry

2014-07-21 Thread Erik Arfvidson
This patch adds enable_ints entry to virthba directory Signed-off-by: Erik Arfvidson --- drivers/staging/unisys/virthba/virthba.c | 63 1 file changed, 63 insertions(+) diff --git a/drivers/staging/unisys/virthba/virthba.c b/drivers/staging/unisys/virthba/virth

[PATCH 3/4] staging: unisys: added virthba rqwait entry

2014-07-21 Thread Erik Arfvidson
This patch adds the rqwait entry into the virthba debugfs directory Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/virthba/virthba.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/unisys/virthba/virthba.c b/drivers/staging/unisys/v

Disregard temporary files in patch submission

2014-07-21 Thread Erik Arfvidson
Hi Greg, I accidentally sent the temporary files(.patch~) in my patch submission. Please disregard the files that have not been signed off by Benjamin. Sorry for the inconvenience, Erik Arfvidson ___ devel mailing list de...@linuxdriverproject.org ht

Re: Disregard temporary files in patch submission

2014-07-21 Thread gre...@linuxfoundation.org
On Mon, Jul 21, 2014 at 02:33:16PM -0400, Erik Arfvidson wrote: > Hi Greg, > > I accidentally sent the temporary files(.patch~) in my patch submission. What "patch submission"? Please be more specific, with a Subject: and all of that, or just respond to the patches themselves. Remember, I _aver

[PATCH 1/4] staging: unisys: remove virthba proc

2014-07-21 Thread Erik Arfvidson
This patch removes all proc entries, directories, and functions Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/virthba/virthba.c | 206 --- 1 file changed, 206 deletions(-) diff --git a/drivers/staging/unisys/virthba/virthba.c

[PATCH 4/4] staging: unisys: added virthba enable_ints entry

2014-07-21 Thread Erik Arfvidson
This patch adds enable_ints entry to virthba directory Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/virthba/virthba.c | 63 1 file changed, 63 insertions(+) diff --git a/drivers/staging/unisys/virthba/virthba.c b/drive

[PATCH 3/4] staging: unisys: added virthba rqwait entry

2014-07-21 Thread Erik Arfvidson
This patch adds the rqwait entry into the virthba debugfs directory Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/virthba/virthba.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/unisys/virthba/virthba.c b/drivers/staging/unisys/v

[PATCH 2/4] staging: unisys: added virthba debugfs dir and info entry

2014-07-21 Thread Erik Arfvidson
This patch adds virthba debugfs directory and info entry Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/virthba/virthba.c | 79 1 file changed, 79 insertions(+) diff --git a/drivers/staging/unisys/virthba/virthba.c b/dri

[PATCH] staging: comedi: comedidev.h: remove 'new_size' param from subdevice (*buf_change)

2014-07-21 Thread H Hartley Sweeten
This parameter is never used by any of the comedi drivers that provide a (*buf_change) callback. If the 'new_size' is needed in the callback it can be found from the 's->async->prealloc_bufsz' as done in the ni_pcidio driver. Remove the unused parameter. Signed-off-by: H Hartley Sweeten Cc: Ian

Re: [PATCH 00/29] staging: rtl8723au: Remove bad layer API

2014-07-21 Thread Greg KH
On Mon, Jul 21, 2014 at 11:24:40AM +0200, jes.soren...@redhat.com wrote: > From: Jes Sorensen > > Greg, > > Another set of rtl8723au changes - this was meant to be a 'I'll just > fix this little issue' but snowballed into a fair bit more, as I > realized just how bad the original code was (patch

Re: Disregard temporary files in patch submission

2014-07-21 Thread Erik Arfvidson
That works, I'm sending them again right now Thanks, Erik Arfvidson On 07/21/2014 02:38 PM, gre...@linuxfoundation.org wrote: On Mon, Jul 21, 2014 at 02:33:16PM -0400, Erik Arfvidson wrote: Hi Greg, I accidentally sent the temporary files(.patch~) in my patch submission. What "patch submissio

Re: [PATCH 1/4] staging: sep: Solves some problems reported by checkpatch

2014-07-21 Thread Greg KH
On Sat, Jul 19, 2014 at 07:34:39PM +0200, LABBE Corentin wrote: > Signed-off-by: LABBE Corentin > --- > drivers/staging/sep/sep_main.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) _which_ specific problems are fixed here? Please be specific and provide a valid changel

Re: [PATCH] staging/nvec: Pass proper resource to mfd_add_devices()

2014-07-21 Thread Marc Dietrich
Hi Thierry, On Mon, 21 Jul 2014 13:52:41 +0200 Thierry Reding wrote: > From: Thierry Reding > > The mfd_add_devices() parameter takes a struct resource * as fifth > argument, but the nvec driver passes in a void __iomem *. The driver > gets away with it because none of the subdevices ever dire

Re: [PATCH] staging/nvec: Remove double const qualifier

2014-07-21 Thread Marc Dietrich
On Mon, 21 Jul 2014 13:54:41 +0200 Thierry Reding wrote: > From: Thierry Reding > > The SIMPLE_DEV_PM_OPS macro already uses the const qualifier, so there's > no need to repeat it. > > Signed-off-by: Thierry Reding Acked-by: Marc Dietrich > --- > drivers/staging/nvec/nvec.c | 2 +- > 1 fi

Re: [PATCH] Staging: vt6655: remove redundant comments

2014-07-21 Thread Greg KH
On Sun, Jul 20, 2014 at 08:41:50AM +0300, Igor Bezukh wrote: > Clean redundant comments in the code. You also messed with some strings :( Which would have been fine, in a separate patch. Please break this up into at least 2 different patches, each only doing one type of thing. thanks, greg k-h

Re: [PATCH] staging/nvec: Pass proper resource to mfd_add_devices()

2014-07-21 Thread Greg Kroah-Hartman
On Mon, Jul 21, 2014 at 01:52:41PM +0200, Thierry Reding wrote: > From: Thierry Reding > > The mfd_add_devices() parameter takes a struct resource * as fifth > argument, but the nvec driver passes in a void __iomem *. The driver > gets away with it because none of the subdevices ever directly acc

Re: [PATCH 1/4] staging: unisys: remove virthba proc

2014-07-21 Thread Greg KH
On Mon, Jul 21, 2014 at 02:47:42PM -0400, Erik Arfvidson wrote: > This patch removes all proc entries, directories, and functions A better Subject would be: staging: unisys: remove virthba proc files right? ___ devel mailing list de...@linuxdriv

Re: [PATCH 2/4] staging: unisys: added virthba debugfs dir and info entry

2014-07-21 Thread Greg KH
On Mon, Jul 21, 2014 at 02:47:43PM -0400, Erik Arfvidson wrote: > This patch adds virthba debugfs directory and info entry > > Signed-off-by: Erik Arfvidson > Signed-off-by: Benjamin Romer > --- > drivers/staging/unisys/virthba/virthba.c | 79 > > 1 file change

Re: [PATCH 4/4] staging: unisys: added virthba enable_ints entry

2014-07-21 Thread Greg KH
On Mon, Jul 21, 2014 at 02:47:45PM -0400, Erik Arfvidson wrote: > This patch adds enable_ints entry to virthba directory > > Signed-off-by: Erik Arfvidson > Signed-off-by: Benjamin Romer > --- > drivers/staging/unisys/virthba/virthba.c | 63 > > 1 file changed,

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-07-21 Thread David Miller
From: Olaf Hering Date: Mon, 21 Jul 2014 11:18:51 +0200 > On Mon, Jul 21, Richard Weinberger wrote: > >> My concern is that 10 seconds is maybe not a the right choice. >> (As we cannot know all implementations) > > Until someone reports an issue with it, 10 is fine. Just like 20 or 666. Wrong,

[PATCH v4 2/3] Staging: rts5208: Use dev_dbg and %*ph specifier to dump memory

2014-07-21 Thread Fabio Falzoi
Use dev_dbg with %*ph format specifier to dump memory instead of relying on custom macro. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/ms.c| 4 ++-- drivers/staging/rts5208/rtsx_chip.c | 4 ++-- drivers/staging/rts5208/rtsx_scsi.c | 7 +++ drivers/staging/rts5208/sd.c

[PATCH v4 0/3] Staging: rts5208: Use standard debug features

2014-07-21 Thread Fabio Falzoi
Use standard debug features instead of relying on the custom configuration option CONFIG_RTS5208_DEBUG and a series of home grown macros. Changes in v4: * use dev_dbg instead of pr_debug * use dev_dbg with %*ph modifier instead of print_hex_dump_bytes Changes in v3: * defined rtsx_hex_dump as a s

[PATCH v4 3/3] Staging: rts5208: Remove CONFIG_RTS5208_DEBUG option

2014-07-21 Thread Fabio Falzoi
CONFIG_RTS5208_DEBUG is no more needed, we rely on dynamic debug config options instead. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/Kconfig | 7 --- drivers/staging/rts5208/sd.c| 5 + 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rts5208/

Re: [PATCH] staging/nvec: Pass proper resource to mfd_add_devices()

2014-07-21 Thread Greg Kroah-Hartman
On Mon, Jul 21, 2014 at 10:01:36PM +0200, Marc Dietrich wrote: > Hi Thierry, > > On Mon, 21 Jul 2014 13:52:41 +0200 > Thierry Reding wrote: > > > From: Thierry Reding > > > > The mfd_add_devices() parameter takes a struct resource * as fifth > > argument, but the nvec driver passes in a void _

Re: [PATCH] staging/nvec: Pass proper resource to mfd_add_devices()

2014-07-21 Thread Thierry Reding
On Mon, Jul 21, 2014 at 02:39:15PM -0700, Greg Kroah-Hartman wrote: > On Mon, Jul 21, 2014 at 10:01:36PM +0200, Marc Dietrich wrote: > > Hi Thierry, > > > > On Mon, 21 Jul 2014 13:52:41 +0200 > > Thierry Reding wrote: > > > > > From: Thierry Reding > > > > > > The mfd_add_devices() parameter t

[PATCH 1/1] Drivers: scsi: storvsc: Add blist flags

2014-07-21 Thread K. Y. Srinivasan
Add blist flags to permit the reading of the VPD pages even when the target may claim SPC-2 compliance. MSFT targets currently claim SPC-2 compliance while they implement post SPC-2 features. With this patch we can correctly handle WRITE_SAME_16 issues. Signed-off-by: K. Y. Srinivasan --- driver

Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-21 Thread Bjorn Helgaas
[+cc Jingoo] On Fri, Jul 18, 2014 at 12:50 PM, James Bottomley wrote: > On Fri, 2014-07-18 at 11:17 -0700, Greg KH wrote: >> On Fri, Jul 18, 2014 at 09:54:32AM -0700, James Bottomley wrote: >> > On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote: >> > > On Fri, Jul 18, 2014 at 12:22:13PM -0400, Joh

[PATCH] staging: llite: rw.c: use gfp_t to store GFP flags

2014-07-21 Thread Guillaume Morin
Use gfp_t to store GPF_* flags instead of unsigned int. This was reported by sparse. Signed-off-by: Guillaume Morin --- drivers/staging/lustre/lustre/llite/rw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/rw.c b/drivers/staging/lustre

Re: [PATCH] staging: llite: rw.c: use gfp_t to store GFP flags

2014-07-21 Thread Greg KH
On Tue, Jul 22, 2014 at 02:57:57AM +0200, Guillaume Morin wrote: > Use gfp_t to store GPF_* flags instead of unsigned int. > This was reported by sparse. > > Signed-off-by: Guillaume Morin > --- > drivers/staging/lustre/lustre/llite/rw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: Realtek RTL8821ae driver

2014-07-21 Thread Greg KH
On Mon, Jul 21, 2014 at 08:50:26PM -0400, Chris Murphy wrote: > Problem: On Asus TX201LA running 15.6 kernel x86_64, driver repeatedly > disconnects and reconnects. Dual boot same machine on Win 8.1 is very stable. > > Behavior starts as soon as Linux is booted and logged in. Saw same behavior on

[PATCH v2] staging: llite: rw.c: remove gfp_mask

2014-07-21 Thread Guillaume Morin
sparse reported that gfp_mask was of the wrong type to store gfp flags. The variable is not used so it can be removed. Signed-off-by: Guillaume Morin Suggested-by: gre...@linuxfoundation.org --- v2: remove the variable instead of just fixing the type since it is not used drivers/staging/lustre

Re: [PATCH] staging: llite: rw.c: use gfp_t to store GFP flags

2014-07-21 Thread Guillaume Morin
On 21 Jul 19:08, Greg KH wrote: > Odd thing is, that function doesn't seem to even use that variable > anywhere... Can you just remove it entirely? Oh that's right. Resubmitted. Thanks Guillaume. -- Guillaume Morin ___ devel mailing list de...@lin

[PATCH 2/2] Staging: comedi: amcc_s5933: a style issue fixed

2014-07-21 Thread Sam Asadi
A 'line over 80 characters' fixed by removing comment to the previous line. Signed-off-by: Sam Asadi --- drivers/staging/comedi/drivers/amcc_s5933.h |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/amcc_s5933.h b/drivers/staging/comedi/driv

  1   2   >