On Wed, Dec 17, 2014 at 11:42:53PM +0100, Rickard Strandqvist wrote:
> Removed an unnecessary NULL check.
> I have checked the only place this function is called from.
Next time, in the changelog mention that the checking isn't consistent
so it creates as static checker warning. That is a good mo
Thank you for your feedback Greg!
I wonder if I should send a patch v3 or patch v2.1 with a better description.
Is there any standard that I should follow when sending another
version of a patch?
Thanks,
Best regards,
Eduardo dos Santos Barretto
On Thu, Dec 18, 2014 at 1:11 AM, Greg KH wrote:
diff --git a/drivers/staging/gdm724x/gdm_mux.c
b/drivers/staging/gdm724x/gdm_mux.c
index b5b063a..d1ab996 100644
--- a/drivers/staging/gdm724x/gdm_mux.c
+++ b/drivers/staging/gdm724x/gdm_mux.c
@@ -220,7 +220,7 @@ static int up_to_host(struct mux_rx *r)
static void do_rx(struct work_struct *work)
On Wed, Dec 17, 2014 at 05:03:22PM +0300, Dan Carpenter wrote:
> On Wed, Dec 17, 2014 at 04:43:54PM +0300, samuel kihahu wrote:
> > On Wed, Dec 17, 2014 at 03:11:19PM +0300, Dan Carpenter wrote:
> > > On Wed, Dec 17, 2014 at 02:56:02PM +0300, samuel kihahu wrote:
> > > > Replacing obsolete simple_s
This patch fixes a coding style issue found by the checkpatch.pl tool in
amplc_dio200_common.c by removing the unnecessary parentheses around the
expression in a return statement.
Signed-off-by: Aapo Vienamo
---
drivers/staging/comedi/drivers/amplc_dio200_common.c | 2 +-
1 file changed, 1 inser
On 12/17/2014 05:54 PM, at...@opensource.altera.com wrote:
> From: Alan Tull
>
> Add driver to fpga manager framework to allow configuration
> of FPGA in Altera SoCFPGA parts.
>
> Signed-off-by: Alan Tull
> ---
> v2: fpga_manager struct now contains struct device
> fpga_manager_register par
This is a patch to the gdm_mux.c file that fixes a space before comma coding
style issue found by the checkpatch.pl tool.
Signed-off-by: Robert Nachlinger
---
drivers/staging/gdm724x/gdm_mux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_mux.c
On Thu, Dec 18, 2014 at 05:46:29PM +0100, Robert Nachlinger wrote:
> This is a patch to the gdm_mux.c file that fixes a space before comma coding
> style issue found by the checkpatch.pl tool.
Please line-wrap your changelog text, there's no reason to have lines
this long, right?
greg k-h
_
This is a patch to the gdm_mux.c file that fixes a space before comma
coding style issue found by the checkpatch.pl tool.
Signed-off-by: Robert Nachlinger
---
drivers/staging/gdm724x/gdm_mux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_mux.c
Hi Alan,
first of all - there are these kernel-doc warnings.
Info(drivers/staging/fpga/fpga-mgr.c:37): Scanning doc for
fpga_mgr_low_level_state
Warning(drivers/staging/fpga/fpga-mgr.c:43): No description found for return
value of 'fpga_mgr_low_level_state'
Info(drivers/staging/fpga/fpga-mgr.c:
used #include instead of
used #include instead of
Signed-off-by: Hariharan Rangasamy
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
b/drivers/staging/ft1000/ft1000-
On Thu, 18 Dec 2014, Michal Simek wrote:
> Hi Alan,
>
> first of all - there are these kernel-doc warnings.
>
> Info(drivers/staging/fpga/fpga-mgr.c:37): Scanning doc for
> fpga_mgr_low_level_state
> Warning(drivers/staging/fpga/fpga-mgr.c:43): No description found for return
> value of 'fpga_
On Thu, 18 Dec 2014, Michal Simek wrote:
Hi Michal,
> > +
> > + /* Write out remaining non 32-bit chunks. */
> > + switch (count) {
> > + case 3:
> > + socfpga_fpga_data_writel(priv, buffer_32[i++] & 0x00ff);
> > + break;
> > + case 2:
> > + socfpga_fpga_
On Thu, Dec 18, 2014 at 05:48:10PM +0300, samuel kihahu wrote:
> On Wed, Dec 17, 2014 at 05:03:22PM +0300, Dan Carpenter wrote:
> > On Wed, Dec 17, 2014 at 04:43:54PM +0300, samuel kihahu wrote:
> > > On Wed, Dec 17, 2014 at 03:11:19PM +0300, Dan Carpenter wrote:
> > > > On Wed, Dec 17, 2014 at 02:
On Fri, Dec 19, 2014 at 12:15:22AM +0530, Hariharan Rangasamy wrote:
>
> used #include instead of
> used #include instead of
>
> Signed-off-by: Hariharan Rangasamy
Your subject line looks crazy, not to mention you used my wrong email
address :(
Please fix up and resend.
thanks,
greg k-h
Building with the attached random configuration file,
ERROR: "usb_kill_urb" [drivers/staging/media/tlg2300/poseidon.ko] undefined!
ERROR: "usb_deregister" [drivers/staging/media/tlg2300/poseidon.ko] undefined!
ERROR: "usb_set_interface" [drivers/staging/media/tlg2300/poseidon.ko]
undefined!
ERROR:
From: Alan Tull
Dropping the changes to socfpga DTS and defconfig from this
patch set.
Kernel doc fixes and other minor fixes as listed in the patches.
Alan
Alan Tull (4):
doc: add bindings document for altera fpga manager
fpga manager: add sysfs interface document
staging: fpga manager:
From: Alan Tull
New bindings document for Altera fpga manager.
Signed-off-by: Alan Tull
---
v5 : Move bindings to drivers/staging/fpga/Documentation/bindings
v6 : No change in this patch for v6 of the patch set
---
.../Documentation/bindings/altera-fpga-mgr.txt | 17 +
1
From: Alan Tull
Supports standard ops for low level FPGA drivers.
Various manufacturors' FPGAs can be supported by adding low
level drivers. Each driver needs to register its ops
using fpga_mgr_register().
Exports methods of doing operations to program FPGAs. These
should be sufficient for ind
From: Alan Tull
Add documentation under drivers/staging for new fpga manager's
sysfs interface.
Signed-off-by: Alan Tull
---
v5 : (actually second version, but keeping version numbers
aligned with rest of patch series)
Move document to drivers/staging/fpga/Documentation/ABI
v6 :
From: Alan Tull
Add driver to fpga manager framework to allow configuration
of FPGA in Altera SoCFPGA parts.
Signed-off-by: Alan Tull
Acked-by: Michal Simek
---
v2: fpga_manager struct now contains struct device
fpga_manager_register parameters now take device
v3: skip a version to align
Aapo,
On Thu, Dec 18, 2014 at 05:32:52PM +0200, Aapo Vienamo wrote:
> This patch fixes a coding style issue found by the checkpatch.pl tool in
> amplc_dio200_common.c by removing the unnecessary parentheses around the
> expression in a return statement.
>
> Signed-off-by: Aapo Vienamo
> ---
> d
Checkpatch was complaining about the else statement because the if statement
had a return '1' call. Taking a look at the function which this else statement
belongs, you can see that it has an switch case statement.
The main idea of the function is to return '1' if you get into any of the cases
(
On 12/18/2014 09:59 PM, atull wrote:
> On Thu, 18 Dec 2014, Michal Simek wrote:
>
> Hi Michal,
>
>>> +
>>> + /* Write out remaining non 32-bit chunks. */
>>> + switch (count) {
>>> + case 3:
>>> + socfpga_fpga_data_writel(priv, buffer_32[i++] & 0x00ff);
>>> + break;
On 12/18/2014 09:46 PM, atull wrote:
> On Thu, 18 Dec 2014, Michal Simek wrote:
>
>> Hi Alan,
>>
>> first of all - there are these kernel-doc warnings.
>>
>> Info(drivers/staging/fpga/fpga-mgr.c:37): Scanning doc for
>> fpga_mgr_low_level_state
>> Warning(drivers/staging/fpga/fpga-mgr.c:43): No d
25 matches
Mail list logo
