Re: [PATCH] staging: sm750fb: Fix sparse warning

2015-03-10 Thread Dan Carpenter
On Mon, Mar 09, 2015 at 08:57:08PM +, Lorenzo Stoakes wrote: > This patch fixes the following sparse warning:- > > drivers/staging/sm750fb/ddk750_help.c: warning: incorrect type in assignment > (different address spaces) > > Signed-off-by: Lorenzo Stoakes > --- > drivers/staging/sm750fb/dd

Re: [PATCH 1/4] staging/lustre: checkpatch cleanup: macros should not use a trailing semicolon

2015-03-10 Thread Dan Carpenter
On Mon, Mar 09, 2015 at 11:23:22PM -0300, mrugi...@gmail.com wrote: > From: "Mario J. Rugiero" Just fix your mail client so we don't need an extra From header. No signed-off-by. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.o

[patch] staging: dgnc: off by one in dgnc_mgmt_ioctl()

2015-03-10 Thread Dan Carpenter
"dgnc_NumBoards" is the number of initialized elements in the dgnc_Board[] array so the comparison should be ">=" instead of ">" so we don't read invalid data. We can remove the special handling of the empty array now that we've fixed this bug. Signed-off-by: Dan Carpenter diff --git a/drivers/

Re: [PATCH v2] dgnc: Don't save boards in memory that have failed to initialize

2015-03-10 Thread Dan Carpenter
On Mon, Mar 09, 2015 at 06:29:38PM +0200, Giedrius Statkevičius wrote: > Remove BOARD_FAILED and don't save dgnc_boards which failed to > initialize. > > Assign the result of kzalloc() to brd in dgnc_found_board() and only put > it in the dgnc_Board[] if it successfully initializes. Also, remove >

Re: [PATCH 0/6] Drivers: hv: Miscellaneous fixes

2015-03-10 Thread gre...@linuxfoundation.org
On Tue, Mar 10, 2015 at 03:31:44AM +, KY Srinivasan wrote: > > > > -Original Message- > > From: KY Srinivasan > > Sent: Friday, March 6, 2015 9:20 PM > > To: KY Srinivasan; gre...@linuxfoundation.org; linux- > > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > >

Re: [PATCH] staging: sm750fb: Fix sparse warning

2015-03-10 Thread Sudip Mukherjee
On Mon, Mar 09, 2015 at 08:57:08PM +, Lorenzo Stoakes wrote: > > +#include > + apart from what Dan Carpenter has said, this is introducing one checkpatch warning, better to use #include checkpatch is also giving warning about your patch subject only one concern - if Greg first applies the

Re: [PATCH V2 1/7] Drivers: hv: vmbus: Export the vmbus_sendpacket_pagebuffer_ctl()

2015-03-10 Thread Greg KH
On Fri, Mar 06, 2015 at 11:04:28PM -0800, K. Y. Srinivasan wrote: > Export the vmbus_sendpacket_pagebuffer_ctl() interface. Why? Nothing in this patch needs it. Please include this in the patch that needs the symbol, or at least give a hint as to what is going on. As it is, this just looks like

[PATCH v6 00/22] power_supply: Allow safe usage of power supply

2015-03-10 Thread Krzysztof Kozlowski
Hi, The patchset fixes invalid memory accesses in certain race scenarios by moving ownership of struct power_supply to the core. All drivers are modified. TLDR for driver and subsystem maintainers = Two patches of patchset change power_supply_register() f

[PATCH v6 03/22] power_supply: Add driver private data

2015-03-10 Thread Krzysztof Kozlowski
Allow drivers to store private data inside power_supply structure for later usage in power supply operations. Usage of driver private data is necessary to access driver's state container object from power supply calls (like get_property()) if struct 'power_supply' is a stored there as a pointer, f

[PATCH v6 01/22] compal-laptop: Fix leaking hwmon device

2015-03-10 Thread Krzysztof Kozlowski
The commit c2be45f09bb0 ("compal-laptop: Use devm_hwmon_device_register_with_groups") wanted to change the registering of hwmon device to resource-managed version. It mostly did it except the main thing - it forgot to use devm-like function so the hwmon device leaked after device removal or probe f

[PATCH v6 02/22] compal-laptop: Check return value of power_supply_register

2015-03-10 Thread Krzysztof Kozlowski
The return value of power_supply_register() call was not checked and even on error probe() function returned 0. If registering failed then during unbind the driver tried to unregister power supply which was not actually registered. This could lead to memory corruption because power_supply_unregist

[PATCH v6 06/22] power_supply: sysfs: Use power_supply_*() API for accessing function attrs

2015-03-10 Thread Krzysztof Kozlowski
Replace direct calls to power supply function attributes with wrappers. Wrappers provide safe access in case of unregistering the power supply (e.g. by removing the driver). Replace: - get_property -> power_supply_get_property - set_property -> power_supply_set_property - property_is_writeable -

[PATCH v6 04/22] power_supply: Move run-time configuration to separate structure

2015-03-10 Thread Krzysztof Kozlowski
Add new structure 'power_supply_config' for holding run-time initialization data like of_node, supplies and private driver data. The power_supply_register() function is changed so all power supply drivers need updating. When registering the power supply this new 'power_supply_config' should be us

[PATCH v6 07/22] power_supply: 88pm860x_charger: Use power_supply_*() API for accessing function attrs

2015-03-10 Thread Krzysztof Kozlowski
Replace direct calls to power supply function attributes with wrappers. Wrappers provide safe access in case of unregistering the power supply (e.g. by removing the driver). Replace: - get_property -> power_supply_get_property - set_property -> power_supply_set_property Signed-off-by: Krzysztof

[PATCH v6 09/22] mfd: ab8500: Use power_supply_*() API for accessing function attrs

2015-03-10 Thread Krzysztof Kozlowski
Replace direct calls to power supply function attributes with wrappers. Wrappers provide safe access in case of unregistering the power supply (e.g. by removing the driver). Replace: - get_property -> power_supply_get_property Signed-off-by: Krzysztof Kozlowski Acked-by: Jonghwa Lee Acked-by: P

[PATCH v6 08/22] power_supply: ab8500: Use power_supply_*() API for accessing function attrs

2015-03-10 Thread Krzysztof Kozlowski
Replace direct calls to power supply function attributes with wrappers. Wrappers provide safe access in case of unregistering the power supply (e.g. by removing the driver). Replace: - get_property -> power_supply_get_property Signed-off-by: Krzysztof Kozlowski Acked-by: Jonghwa Lee Acked-by: P

[PATCH v6 05/22] power_supply: Add API for safe access of power supply function attrs

2015-03-10 Thread Krzysztof Kozlowski
Add simple wrappers for accessing power supply's function attributes: - get_property -> power_supply_get_property - set_property -> power_supply_set_property - property_is_writeable -> power_supply_property_is_writeable - external_power_changed -> power_supply_external_power_changed This API a

[PATCH v6 18/22] x86/olpc/xo15/sci: Use newly added power_supply_put API

2015-03-10 Thread Krzysztof Kozlowski
Replace direct usage of put_device() with new API: power_supply_put(). Signed-off-by: Krzysztof Kozlowski Acked-by: Pavel Machek Reviewed-by: Bartlomiej Zolnierkiewicz Reviewed-by: Sebastian Reichel --- arch/x86/platform/olpc/olpc-xo15-sci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

[PATCH v6 10/22] power_supply: apm_power: Use power_supply_*() API for accessing function attrs

2015-03-10 Thread Krzysztof Kozlowski
Replace direct calls to power supply function attributes with wrappers. Wrappers provide safe access in case of unregistering the power supply (e.g. by removing the driver). Replace: - get_property -> power_supply_get_property Signed-off-by: Krzysztof Kozlowski Acked-by: Jonghwa Lee Acked-by: P

[PATCH v6 12/22] power_supply: charger-manager: Use power_supply_*() API for accessing function attrs

2015-03-10 Thread Krzysztof Kozlowski
Replace direct calls to power supply function attributes with wrappers. Wrappers provide safe access in case of unregistering the power supply (e.g. by removing the driver). Replace: - get_property -> power_supply_get_property Signed-off-by: Krzysztof Kozlowski Acked-by: Jonghwa Lee Acked-by: P

[PATCH v6 19/22] power_supply: 88pm860x_charger: Decrement the power supply's device reference counter

2015-03-10 Thread Krzysztof Kozlowski
Use power_supply_put() to decrement the power supply's device reference counter. Signed-off-by: Krzysztof Kozlowski Acked-by: Pavel Machek Reviewed-by: Bartlomiej Zolnierkiewicz Reviewed-by: Sebastian Reichel --- drivers/power/88pm860x_charger.c | 11 +-- 1 file changed, 9 insertions(

[PATCH v6 17/22] x86/olpc/xo1/sci: Use newly added power_supply_put API

2015-03-10 Thread Krzysztof Kozlowski
Replace direct usage of put_device() with new API: power_supply_put(). Signed-off-by: Krzysztof Kozlowski Acked-by: Pavel Machek Reviewed-by: Bartlomiej Zolnierkiewicz Reviewed-by: Sebastian Reichel --- arch/x86/platform/olpc/olpc-xo1-sci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletio

[PATCH v6 15/22] power_supply: Increment power supply use counter when obtaining references

2015-03-10 Thread Krzysztof Kozlowski
Increment the power_supply.use_cnt usage counter on: - power_supply_get_by_phandle() - power_supply_get_by_name() and decrement it on power_supply_put() call. This helps tracking of valid usage of power supply instance by consumers. The usage counter itself also allows safe calling of power_supp

[PATCH v6 22/22] arm: mach-pxa: Decrement the power supply's device reference counter

2015-03-10 Thread Krzysztof Kozlowski
Use power_supply_put() to decrement the power supply's device reference counter. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bartlomiej Zolnierkiewicz Reviewed-by: Sebastian Reichel Acked-by: Robert Jarzmik Acked-by: Pavel Machek --- arch/arm/mach-pxa/raumfeld.c | 4 +++- 1 file changed,

[PATCH v6 21/22] mfd: ab8500: Decrement the power supply's device reference counter

2015-03-10 Thread Krzysztof Kozlowski
Use power_supply_put() to decrement the power supply's device reference counter. Signed-off-by: Krzysztof Kozlowski Acked-by: Pavel Machek Acked-by: Linus Walleij Acked-by: Lee Jones Reviewed-by: Bartlomiej Zolnierkiewicz Reviewed-by: Sebastian Reichel --- drivers/mfd/ab8500-sysctrl.c | 2 +

[PATCH v6 20/22] power_supply: bq2415x_charger: Decrement the power supply's device reference counter

2015-03-10 Thread Krzysztof Kozlowski
Use power_supply_put() to decrement the power supply's device reference counter (increased by power_supply_get_by_name() or power_supply_get_by_phandle()). Signed-off-by: Krzysztof Kozlowski Acked-by: Pavel Machek Reviewed-by: Bartlomiej Zolnierkiewicz Reviewed-by: Sebastian Reichel --- drive

[PATCH v6 14/22] power_supply: Add power_supply_put for decrementing device reference counter

2015-03-10 Thread Krzysztof Kozlowski
The power_supply_get_by_phandle() and power_supply_get_by_name() use function class_find_device() for obtaining the reference to power supply. Each use of class_find_device() increases the power supply's device reference counter. However the reference counter was not decreased by users of this API

[PATCH v6 11/22] power_supply: bq2415x_charger: Use power_supply_*() API for accessing function attrs

2015-03-10 Thread Krzysztof Kozlowski
Replace direct calls to power supply function attributes with wrappers. Wrappers provide safe access in case of unregistering the power supply (e.g. by removing the driver). Replace: - get_property -> power_supply_get_property Signed-off-by: Krzysztof Kozlowski Acked-by: Jonghwa Lee Acked-by: P

[PATCH v6 16/22] power_supply: charger-manager: Decrement the power supply's device reference counter

2015-03-10 Thread Krzysztof Kozlowski
Use power_supply_put() to decrement the power supply's device reference counter. Signed-off-by: Krzysztof Kozlowski Acked-by: Pavel Machek Reviewed-by: Bartlomiej Zolnierkiewicz Reviewed-by: Sebastian Reichel --- drivers/power/charger-manager.c | 70 +++--

Re: [PATCH] staging: sm750fb: Fix sparse warning

2015-03-10 Thread Lorenzo Stoakes
On 10 March 2015 at 07:42, Sudip Mukherjee wrote: > only one concern - if Greg first applies the patches i sent yesterday then > this patch will not apply, and if this one is applied first then my series > will not apply ... Indeed, I am more than happy to adapt the patch as required if your pa

[PATCH v3 2/5] staging: sm750fb: remove pragma optimize

2015-03-10 Thread Sudip Mukherjee
remove use of #pragma optimize which will usually be ignored by the compiler. Signed-off-by: Sudip Mukherjee --- v3: no change v2: no change drivers/staging/sm750fb/ddk750_swi2c.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c b/drivers/staging/sm

[PATCH v3 1/5] staging: sm750fb: wrong type for print

2015-03-10 Thread Sudip Mukherjee
mention correct format specifier while printing. fixes all the build warnings about incorrect argument type while printing. since this is a framebuffer device and it should follow what the framebuffer layer is suggesting in struct fb_fix_screeninfo at smem_start and mmio_start, so accordingly chang

[PATCH v3 3/5] staging: sm750fb: correctly define SM750LE_REVISION_ID

2015-03-10 Thread Sudip Mukherjee
check if it is already defined before defining SM750LE_REVISION_ID again and at the same time mention correct data type. Signed-off-by: Sudip Mukherjee --- v3: no change v2: removed the redundant cast in sm750_hw.c SM750LE_REVISION_ID is defined also in ddk750_chip.h. drivers/staging/sm750fb/

[PATCH v3 4/5] staging: sm750fb: fix undeclared function

2015-03-10 Thread Sudip Mukherjee
kbuild test robot reported that for microblaze-allyesconfig chan_to_field() and lynxfb_ops_set_par() were not defined. These two functions were defined under CONFIG_PM, so for any archtecture if CONFIG_PM is not defined we will have this error. while moving the lynxfb_suspend() function some very

[PATCH v3 5/5] staging: sm750fb: fix build failure

2015-03-10 Thread Sudip Mukherjee
for powerpc-allyesconfig build failed with an error of g_option undeclared. we will get this error on all architecture if MODULE is not defined. fixed the declaration of g_option. Reported-by: Stephen Rothwell Signed-off-by: Sudip Mukherjee --- v3: new entry in the series, it was not there till

Re: [PATCH] staging: sm750fb: Fix sparse warning

2015-03-10 Thread Lorenzo Stoakes
On 10 March 2015 at 07:00, Dan Carpenter wrote: > No need for the volatile. Will remove. > Really mmio750 should be a "void __iomem *" > it is declared as "unsigned char __iomem *" but it's not a char pointer > that's only to make the pointer math work. It would work just as well > as a void a

[PATCH v2] staging: sm750fb: Fix sparse warning

2015-03-10 Thread Lorenzo Stoakes
This patch fixes the following sparse warning:- drivers/staging/sm750fb/ddk750_help.c: warning: incorrect type in assignment (different address spaces) In addition it eliminates an unnecessary volatile. Signed-off-by: Lorenzo Stoakes --- drivers/staging/sm750fb/ddk750_chip.h | 4 +++- drivers

Re: [PATCH] staging: sm750fb: Fix sparse warning

2015-03-10 Thread Dan Carpenter
On Tue, Mar 10, 2015 at 08:47:47AM +, Lorenzo Stoakes wrote: > On 10 March 2015 at 07:00, Dan Carpenter wrote: > > > No need for the volatile. > > Will remove. > > > Really mmio750 should be a "void __iomem *" > > it is declared as "unsigned char __iomem *" but it's not a char pointer > > t

Re: [PATCH] staging: sm750fb: Fix sparse warning

2015-03-10 Thread Lorenzo Stoakes
On 10 March 2015 at 08:59, Dan Carpenter wrote: > > The patch is: > > [patch] cleanup the type of mmio750 > > silencing a Sparse warning is just a side benifit of using correct > data types. The "one thing per patch" rule also means that you should > fix a whole problem instead of half a thing pe

[PATCH] staging: rtl8192e: remove unused functions

2015-03-10 Thread Sudip Mukherjee
removed some functions which were not being used anywhere. build tested and also verified by git grep that there is no other reference to these functions. Signed-off-by: Sudip Mukherjee --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 154 -- drivers/staging/rtl8192e/r

Re: [PATCH 1/4] staging/lustre: checkpatch cleanup: macros should not use a trailing semicolon

2015-03-10 Thread Mario J. Rugiero
That's weird, I passed the parameter signed-off-by to git-send-email. The from header must have been my mistake, I thought that parameter was mandatory. Thanks for the hint. Regards, Mario. ___ devel mailing list de...@linuxdriverproject.org http://d

[PATCH] staging: sm750fb: Cleanup the type of mmio750

2015-03-10 Thread Lorenzo Stoakes
This patch assigns the more appropriate void* type to the mmio750 variable eliminating an unnecessary volatile qualifier in the process. Additionally it updates parameter types as necessary where those parameters interact with mmio750 and removes unnecessary casts. As a consequence, this patch fix

[PATCH 0/4] staging/lustre: checkpatch cleanup

2015-03-10 Thread Mario J. Rugiero
As Dan Carpenter (thank you!) noticed, my original patchset had an extra from field and lacked the signed-off-by. I'm not sure the first was fixed, but I would be really confused if it isn't. I checked that the signed-off-by was generated this time. As a reminder, this patchset aims to fix the

[PATCH 2/4] staging/lustre: checkpatch cleanup: __printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check)))

2015-03-10 Thread Mario J. Rugiero
Signed-off-by: Mario J. Rugiero --- drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h | 4 ++-- drivers/staging/lustre/lustre/include/lu_object.h | 2 +- drivers/staging/lustre/lustre/include/lustre_dlm.h | 2 +- drivers/staging/lustre/lustre/include/lustre_net.h

[PATCH 3/4] staging/lustre: checkpatch cleanup: __aligned(size) is preferred over __attribute__((aligned(size)))

2015-03-10 Thread Mario J. Rugiero
Signed-off-by: Mario J. Rugiero --- drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h b/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.

[PATCH 4/4] staging/lustre: checkpatch cleanup: __packed is preferred over __attribute__((packed))

2015-03-10 Thread Mario J. Rugiero
Signed-off-by: Mario J. Rugiero --- .../include/linux/libcfs/libcfs_kernelcomm.h | 2 +- .../staging/lustre/include/linux/lnet/lib-types.h | 2 +- .../lustre/lustre/include/lustre/lustre_idl.h | 44 +++--- .../lustre/lustre/include/lustre/lustre_user.h | 14 +++--

[PATCH 1/4] staging/lustre: checkpatch cleanup: macros should not use a trailing semicolon

2015-03-10 Thread Mario J. Rugiero
Signed-off-by: Mario J. Rugiero --- drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h | 2 +- drivers/staging/lustre/include/linux/libcfs/libcfs_private.h | 4 ++-- drivers/staging/lustre/lustre/include/lprocfs_status.h | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-)

Re: [PATCH] staging: sm750fb: Cleanup the type of mmio750

2015-03-10 Thread Dan Carpenter
On Tue, Mar 10, 2015 at 09:57:06AM +, Lorenzo Stoakes wrote: > This patch assigns the more appropriate void* type to the mmio750 variable > eliminating an unnecessary volatile qualifier in the process. Additionally it > updates parameter types as necessary where those parameters interact with >

Re: [PATCH] SCSI:STORVSC Use SCSI layer to allocate memory for per-command device request data

2015-03-10 Thread Olaf Hering
On Mon, Dec 29, Christoph Hellwig wrote: > +++ b/drivers/scsi/storvsc_drv.c > static struct scsi_host_template scsi_driver = { > .module = THIS_MODULE, > .name = "storvsc_host_t", > + .cmd_size = sizeof(struct storvsc_cmd_request), >

Re: [PATCH 1/4] staging/lustre: checkpatch cleanup: macros should not use a trailing semicolon

2015-03-10 Thread Greg KH
On Tue, Mar 10, 2015 at 07:17:52AM -0300, Mario J. Rugiero wrote: > Signed-off-by: Mario J. Rugiero > --- You need to have something in the changelog area, it can't just be blank, sorry. ___ devel mailing list de...@linuxdriverproject.org http://driver

Re: [PATCH 2/4] staging/lustre: checkpatch cleanup: __printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check)))

2015-03-10 Thread Greg KH
On Tue, Mar 10, 2015 at 07:17:53AM -0300, Mario J. Rugiero wrote: > Signed-off-by: Mario J. Rugiero > --- Your subject line is really long, please fix, and again, add some comments in the changelog area. Same for the rest of the patches in this series. thanks, greg k-h

Re: [PATCH 1/4] staging/lustre: checkpatch cleanup: macros should not use a trailing semicolon

2015-03-10 Thread Mario J. Rugiero
Do you mean a description, or the diffstats? I thought it was enough to describe it in the cover letter, I'll fix it and resend, thank you. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/dri

Re: [PATCH] staging: sm750fb: Cleanup the type of mmio750

2015-03-10 Thread Sudip Mukherjee
On Tue, Mar 10, 2015 at 02:40:30PM +0300, Dan Carpenter wrote: > On Tue, Mar 10, 2015 at 09:57:06AM +, Lorenzo Stoakes wrote: > > This patch assigns the more appropriate void* type to the mmio750 variable > > eliminating an unnecessary volatile qualifier in the process. Additionally > > it > >

Re: [PATCH 1/4] staging/lustre: checkpatch cleanup: macros should not use a trailing semicolon

2015-03-10 Thread Greg KH
On Tue, Mar 10, 2015 at 09:34:24AM -0300, Mario J. Rugiero wrote: > Do you mean a description, or the diffstats? > I thought it was enough to describe it in the cover letter, I'll fix it and > resend, thank you. Cover letters don't end up in the changelog, and some people (myself included) never u

Re: [PATCH 2/3 v3] hyperv: hyperv_fb.c: match wait_for_completion_timeout return type

2015-03-10 Thread Tomi Valkeinen
On 29/01/15 12:24, Nicholas Mc Guire wrote: > The return type of wait_for_completion_timeout is unsigned long not > int. This patch fixes up the declarations only. > > Signed-off-by: Nicholas Mc Guire > --- > > v2: fixed subject line > v3: fixed patch description as recommended by Dan Carpenter

Re: [PATCH] staging: sm750fb: Cleanup the type of mmio750

2015-03-10 Thread Lorenzo Stoakes
On 10 March 2015 at 12:36, Sudip Mukherjee wrote: > but it is introducing two new build warnings: > > drivers/staging/sm750fb/sm750_hw.c: In function ‘hw_sm750_map’: > drivers/staging/sm750fb/sm750_hw.c:67:2: warning: passing argument 1 of > ‘ddk750_set_mmio’ discards ‘volatile’ qualifier from po

Re: [PATCH 1/4] staging/lustre: checkpatch cleanup: macros should not use a trailing semicolon

2015-03-10 Thread Mario J. Rugiero
OK, thanks, I'll fix it. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 0/4] staging/lustre: checkpatch cleanup

2015-03-10 Thread Mario J. Rugiero
This patches cleans the following checkpatch issues: trailing semicolons in macros __attribute__(format(printf,...)) instead of __printf(...) __attribute__(aligned(size)) instead of __aligned(size) __attribute__(packed) instead of __packed Mario J. Rugiero (4): staging/lustre: checkpatch cleanup

[PATCH 1/4] staging/lustre: clean trailing semicolon in macros

2015-03-10 Thread Mario J. Rugiero
Cleanup trailing semicolons in macros, as recommended by cleanpatch. Signed-off-by: Mario J. Rugiero --- drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h | 2 +- drivers/staging/lustre/include/linux/libcfs/libcfs_private.h | 4 ++-- drivers/staging/lustre/lustre/include/lprocfs_statu

[PATCH 4/4] staging/lustre: use __packed instead of

2015-03-10 Thread Mario J. Rugiero
Replace __attribute__(packed) by __packed, as recommended by checkpatch. Signed-off-by: Mario J. Rugiero --- .../include/linux/libcfs/libcfs_kernelcomm.h | 2 +- .../staging/lustre/include/linux/lnet/lib-types.h | 2 +- .../lustre/lustre/include/lustre/lustre_idl.h | 44 +++

[PATCH 2/4] staging/lustre: use __printf(...) instead of its

2015-03-10 Thread Mario J. Rugiero
Substitute uses of __attribute__(format(printf(...)) by __printf(...), as recommended by checkpatch. Signed-off-by: Mario J. Rugiero --- drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h | 4 ++-- drivers/staging/lustre/lustre/include/lu_object.h | 2 +- drivers/staging/lustre

[PATCH 3/4] staging/lustre: use __aligned(size) instead of the

2015-03-10 Thread Mario J. Rugiero
Replace uses of __attribute__(aligned(size)) by __aligned(size), as recommended by checkpatch. Signed-off-by: Mario J. Rugiero --- drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/include/l

Re: [PATCH] staging: sm750fb: Cleanup the type of mmio750

2015-03-10 Thread Dan Carpenter
On Tue, Mar 10, 2015 at 12:47:44PM +, Lorenzo Stoakes wrote: > On 10 March 2015 at 12:36, Sudip Mukherjee wrote: > > but it is introducing two new build warnings: > > > > drivers/staging/sm750fb/sm750_hw.c: In function ‘hw_sm750_map’: > > drivers/staging/sm750fb/sm750_hw.c:67:2: warning: passi

Re: [PATCH 2/4] staging/lustre: use __printf(...) instead of its

2015-03-10 Thread Dan Carpenter
Now the subjects don't make regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: sm750fb: Cleanup the type of mmio750

2015-03-10 Thread Lorenzo Stoakes
On 10 March 2015 at 13:06, Dan Carpenter wrote: > You should have said that in the patch description or under the --- > cut off. But anyway, it's not ok. And we'll need to redo this patch. > Breaking up patches into logical changes is sort of tricky because > everything touches everything else

[PATCH v2] staging: sm750fb: Cleanup the type of mmio750

2015-03-10 Thread Lorenzo Stoakes
This patch assigns the more appropriate void* type to the mmio750 variable eliminating an unnecessary volatile qualifier in the process. Additionally it updates parameter types as necessary where those parameters interact with mmio750, removes unnecessary casts and updates the type of the lynx_shar

Re: [PATCH] SCSI:STORVSC Use SCSI layer to allocate memory for per-command device request data

2015-03-10 Thread Christoph Hellwig
On Tue, Mar 10, 2015 at 12:42:33PM +0100, Olaf Hering wrote: > It would be nice to change .proc_name to KBUILD_MODNAME before v4.0 is > released. We carry a patch which adds this field. Of cource we can just > change the patch, but if code gets touched upstream anyway... Please send a patch. Woul

RE: [PATCH 0/6] Drivers: hv: Miscellaneous fixes

2015-03-10 Thread KY Srinivasan
> -Original Message- > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, March 10, 2015 12:41 AM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com > Subject: R

Re: [PATCH 0/6] Drivers: hv: Miscellaneous fixes

2015-03-10 Thread gre...@linuxfoundation.org
On Tue, Mar 10, 2015 at 02:54:16PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > > Sent: Tuesday, March 10, 2015 12:41 AM > > To: KY Srinivasan > > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverprojec

[PATCH 2/4] staging/lustre: use __printf(...) instead of __attribute__(format(__printf, ...))

2015-03-10 Thread Mario J. Rugiero
Replace uses of __attribute__(format(__printf,...)) by __printf(...), as suggested by checkpatch. Signed-off-by: Mario J. Rugiero --- drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h | 4 ++-- drivers/staging/lustre/lustre/include/lu_object.h | 2 +- drivers/staging/lustre/lu

[PATCH 1/4] staging/lustre: clean trailing semicolons in macros

2015-03-10 Thread Mario J. Rugiero
Remove trailing semicolons from macros, as suggested by checkpatch. Signed-off-by: Mario J. Rugiero --- drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h | 2 +- drivers/staging/lustre/include/linux/libcfs/libcfs_private.h | 4 ++-- drivers/staging/lustre/lustre/include/lprocfs_status

[PATCH 3/4] staging/lustre: use __aligned(size) instead of __attribute__(aligned(size))

2015-03-10 Thread Mario J. Rugiero
Replace uses of __attribute__(aligned(size)) by __aligned(size), as suggested by checkpatch. Signed-off-by: Mario J. Rugiero --- drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/include/lin

[PATCH 0/4] staging/lustre: checkpatch cleanup

2015-03-10 Thread Mario J. Rugiero
This patchset attempts to fix the following issues catched by checkpatch: trailing semicolons in macros use of __attribute__(format(printf,...)) where __printf(...) would suffice use of __attribute__(aligned(size)) where __aligned(size) would suffice use of __attribute__(packed) where __packed woul

[PATCH 4/4] staging/lustre: use __packed instead of __attribute__(packed)

2015-03-10 Thread Mario J. Rugiero
Replace __attribute__(packed) by __packed as suggested by checkpatch. Signed-off-by: Mario J. Rugiero --- .../include/linux/libcfs/libcfs_kernelcomm.h | 2 +- .../staging/lustre/include/linux/lnet/lib-types.h | 2 +- .../lustre/lustre/include/lustre/lustre_idl.h | 44 +++---

Re: [PATCH] staging: sm750fb: Cleanup the type of mmio750

2015-03-10 Thread Greg KH
On Tue, Mar 10, 2015 at 12:47:44PM +, Lorenzo Stoakes wrote: > On 10 March 2015 at 12:36, Sudip Mukherjee wrote: > > but it is introducing two new build warnings: > > > > drivers/staging/sm750fb/sm750_hw.c: In function ‘hw_sm750_map’: > > drivers/staging/sm750fb/sm750_hw.c:67:2: warning: passi

Re: [PATCH] SCSI:STORVSC Use SCSI layer to allocate memory for per-command device request data

2015-03-10 Thread Olaf Hering
On Tue, Mar 10, Christoph Hellwig wrote: > On Tue, Mar 10, 2015 at 12:42:33PM +0100, Olaf Hering wrote: > > It would be nice to change .proc_name to KBUILD_MODNAME before v4.0 is > > released. We carry a patch which adds this field. Of cource we can just > > change the patch, but if code gets touc

RE: [PATCH V2 1/7] Drivers: hv: vmbus: Export the vmbus_sendpacket_pagebuffer_ctl()

2015-03-10 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, March 10, 2015 12:42 AM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com > Subject: Re: [PATCH V2 1/7] D

Re: [PATCH] staging: sm750fb: Cleanup the type of mmio750

2015-03-10 Thread Lorenzo Stoakes
On 10 March 2015 at 15:04, Greg KH wrote: > I can't apply patches that add new build warnings, sorry. Please fix > this up in the patch itself. > > greg k-h Hi Greg, Apologies for this, I've resolved this issue in v2 of the patch, no warning messages are added in the updated version of this pat

Re: [PATCH v2] staging: sm750fb: Fix sparse warning

2015-03-10 Thread Greg KH
On Tue, Mar 10, 2015 at 08:51:59AM +, Lorenzo Stoakes wrote: > This patch fixes the following sparse warning:- > > drivers/staging/sm750fb/ddk750_help.c: warning: incorrect type in assignment > (different address spaces) > > In addition it eliminates an unnecessary volatile. This doesn't ap

Re: [PATCH v2] staging: sm750fb: Cleanup the type of mmio750

2015-03-10 Thread Greg KH
On Tue, Mar 10, 2015 at 01:27:48PM +, Lorenzo Stoakes wrote: > This patch assigns the more appropriate void* type to the mmio750 variable > eliminating an unnecessary volatile qualifier in the process. Additionally it > updates parameter types as necessary where those parameters interact with >

Re: [PATCH V2 1/7] Drivers: hv: vmbus: Export the vmbus_sendpacket_pagebuffer_ctl()

2015-03-10 Thread Greg KH
On Tue, Mar 10, 2015 at 03:05:26PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Tuesday, March 10, 2015 12:42 AM > > To: KY Srinivasan > > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > > o...@aep

Re: Amazing Deal On Latest Apple Products

2015-03-10 Thread PC & Gadget
We Offer for sale brand new Apple iPhone. We have the iPhone. 4, 4s, 5, 5c, 5s,6 & 6plus Also available is the Apple iPad Air WIFI + 4G We have them in 16/32/64 and 128gigs These items are original, brand new factory unlocked (works with any SIM card} and comes with full accessories and 1 yea

[PATCH v3] staging: sm750fb: Cleanup the type of mmio750

2015-03-10 Thread Lorenzo Stoakes
This patch assigns the more appropriate void* type to the mmio750 variable eliminating an unnecessary volatile qualifier in the process. Additionally it updates parameter types as necessary where those parameters interact with mmio750, removes unnecessary casts and updates the type of the lynx_shar

[PATCH] storvsc: use KBUILD_MODNAME to fill .proc_name

2015-03-10 Thread Olaf Hering
Since the previous patch ead3700d893654d440edcb66fb3767a0c0db54cf ("storvsc: use cmd_size to allocate per-command data") fills .proc_name now anyway give it a usable content for v4.0. Old mkinitrd in SLES makes use of this variable to find the required storage driver. Signed-off-by: Olaf Hering -

Re: [PATCH v2] staging: sm750fb: Fix sparse warning

2015-03-10 Thread Lorenzo Stoakes
On 10 March 2015 at 15:06, Greg KH wrote: > This doesn't apply anymore due to other patches I just took, so can you > rebase this patch on my latest staging-testing branch of staging.git? Fixed in v3 of staging: sm750fb: Cleanup the type of mmio75. > Also, how about someone fixing the real compi

[PATCH 00/56] staging: comedi: introduce comedi_pci.h header

2015-03-10 Thread Ian Abbott
"comedidev.h" includes PCI-specific stuff that gets included by all comedi drivers including non-PCI ones. Separate it out into its own header "comedi_pci.h". Make the new header include and "comedidev.h" so that comedi PCI drivers do not need to include them explicitly. 01) staging: comedi: ad

[PATCH 01/56] staging: comedi: add comedi_pci.h

2015-03-10 Thread Ian Abbott
Add a new header that Comedi PCI drivers can include instead of "comedidev.h". Currently, it just pulls in and "comedidev.h", but the plan is to migrate the PCI-specific stuff from "comedidev.h" here. Signed-off-by: Ian Abbott --- drivers/staging/comedi/comedi_pci.h | 30 ++

[PATCH 05/56] staging: comedi: addi_apci_1500: include new "comedi_pci.h" header

2015-03-10 Thread Ian Abbott
Include the new "../comedi_pci.h" header instead of and "../comedidev.h", which will now get included indirectly. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/addi_apci_1500.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ad

[PATCH 21/56] staging: comedi: adv_pci1724: include new "comedi_pci.h" header

2015-03-10 Thread Ian Abbott
Include the new "../comedi_pci.h" header instead of and "../comedidev.h", which will now get included indirectly. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/adv_pci1724.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/adv_p

[PATCH 20/56] staging: comedi: adv_pci1723: include new "comedi_pci.h" header

2015-03-10 Thread Ian Abbott
Include the new "../comedi_pci.h" header instead of and "../comedidev.h", which will now get included indirectly. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/adv_pci1723.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/adv_p

[PATCH 13/56] staging: comedi: addi_apci_3xxx: include new "comedi_pci.h" header

2015-03-10 Thread Ian Abbott
Include the new "../comedi_pci.h" header instead of and "../comedidev.h", which will now get included indirectly. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/addi_apci_3xxx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ad

[PATCH 17/56] staging: comedi: adl_pci9111: include new "comedi_pci.h" header

2015-03-10 Thread Ian Abbott
Include the new "../comedi_pci.h" header instead of and "../comedidev.h", which will now get included indirectly. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/adl_pci9111.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/adl_p

[PATCH 35/56] staging: comedi: das08_pci: include new "comedi_pci.h" header

2015-03-10 Thread Ian Abbott
Include the new "../comedi_pci.h" header instead of and "../comedidev.h", which will now get included indirectly. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/das08_pci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/das08_p

[PATCH 12/56] staging: comedi: addi_apci_3501: include new "comedi_pci.h" header

2015-03-10 Thread Ian Abbott
Include the new "../comedi_pci.h" header instead of and "../comedidev.h", which will now get included indirectly. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/addi_apci_3501.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ad

[PATCH 29/56] staging: comedi: cb_pcidas: include new "comedi_pci.h" header

2015-03-10 Thread Ian Abbott
Include the new "../comedi_pci.h" header instead of and "../comedidev.h", which will now get included indirectly. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/cb_pcidas.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/cb_pcid

[PATCH 07/56] staging: comedi: addi_apci_1564: include new "comedi_pci.h" header

2015-03-10 Thread Ian Abbott
Include the new "../comedi_pci.h" header instead of and "../comedidev.h", which will now get included indirectly. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/addi_apci_1564.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ad

[PATCH 10/56] staging: comedi: addi_apci_2200: include new "comedi_pci.h" header

2015-03-10 Thread Ian Abbott
Include the new "../comedi_pci.h" header instead of and "../comedidev.h", which will now get included indirectly. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/addi_apci_2200.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ad

[PATCH 24/56] staging: comedi: amplc_pci224: include new "comedi_pci.h" header

2015-03-10 Thread Ian Abbott
Include the new "../comedi_pci.h" header instead of and "../comedidev.h", which will now get included indirectly. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci224.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ampl

[PATCH 03/56] staging: comedi: 8255_pci: include new "comedi_pci.h" header

2015-03-10 Thread Ian Abbott
Include the new "../comedi_pci.h" header instead of and "../comedidev.h", which will now get included indirectly. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/8255_pci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/8255_pci

[PATCH 18/56] staging: comedi: adl_pci9118: include new "comedi_pci.h" header

2015-03-10 Thread Ian Abbott
Include the new "../comedi_pci.h" header instead of and "../comedidev.h", which will now get included indirectly. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/adl_pci9118.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/adl_p

  1   2   >