Include the new "../comedi_pci.h" header instead of and
"../comedidev.h", which will now get included indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/amplc_dio200_pci.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/
Include the new "../comedi_pci.h" header instead of and
"../comedidev.h", which will now get included indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/addi_apci_1516.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ad
Include the new "../comedi_pci.h" header instead of and
"../comedidev.h", which will now get included indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/adl_pci6208.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adl_p
Include the new "../comedi_pci.h" header instead of and
"../comedidev.h", which will now get included indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/icp_multi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/icp_mul
Include the new "../comedi_pci.h" header instead of and
"../comedidev.h", which will now get included indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/amplc_pci236.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ampl
Include the new "../comedi_pci.h" header instead of and
"../comedidev.h", which will now get included indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/addi_apci_3120.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ad
Include the new "../comedi_pci.h" header instead of and
"../comedidev.h", which will now get included indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/cb_pcidda.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/cb_pcid
Include the new "../comedi_pci.h" header instead of and
"../comedidev.h", which will now get included indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dyna
Include the new "../comedi_pci.h" header instead of and
"../comedidev.h", which will now get included indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/amplc_pci263.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ampl
Include the new "../comedi_pci.h" header instead of and
"../comedidev.h", which will now get included indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/cb_pcimdda.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/cb_pci
Include the new "../comedi_pci.h" header instead of and
"../comedidev.h", which will now get included indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/addi_apci_2032.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ad
Include the new "../comedi_pci.h" header instead of and
"../comedidev.h", which will now get included indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/mite.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/mite.h
b/dr
Include the new "../comedi_pci.h" header instead of and
"../comedidev.h", which will now get included indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/mf6x4.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/mf6x4.c
Clients often get confused when ion_phys errors out due to some heap
being used that they didn't expect. Add the heap name and heap type to
the error message to make it more obvious.
Signed-off-by: Mitchel Humpherys
---
drivers/staging/android/ion/ion.c | 4 ++--
1 file changed, 2 insertions(+)
> -Original Message-
> From: Jason Wang [mailto:jasow...@redhat.com]
> Sent: Tuesday, March 10, 2015 8:34 PM
> To: KY Srinivasan
> Cc: da...@davemloft.net; net...@vger.kernel.org;
> gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; a
removed some variables which were only declared but were never used.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/sm750fb/sm750_cursor.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750_cursor.c
b/drivers/staging/sm750fb/sm750_cursor.c
in
Take into consideration the xmit_more flag in skb to decide if we should
notify the host as we place packets in VMBUS.
The VMBUS API that would give us this control is already in Greg's tree, in this
patch-set, that API is exported so it can be used in the netvsc driver.
K. Y. Srinivasan (2):
D
Export the vmbus_sendpacket_pagebuffer_ctl() interface. This interface
will be used in the netvsc driver to optimize signalling the host.
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/channel.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/hv/channel.c b/drive
On Tue, Mar 10, 2015 at 11:50:03AM -0700, K. Y. Srinivasan wrote:
> Export the vmbus_sendpacket_pagebuffer_ctl() interface. This interface
> will be used in the netvsc driver to optimize signalling the host.
>
> Signed-off-by: K. Y. Srinivasan
Acked-by: Greg Kroah-Hartman
__
This patch removes the unnecessary spinlock helper function and instead
calls spin_lock and spin_unlock directly.
This does *not* resolve sparse warnings about context imbalances but these are
spurious.
Signed-off-by: Lorenzo Stoakes
---
drivers/staging/sm750fb/sm750.c | 47
Use /dev/vmbus/hv_vss instead of netlink.
Signed-off-by: Vitaly Kuznetsov
---
tools/hv/hv_vss_daemon.c | 139 +--
1 file changed, 25 insertions(+), 114 deletions(-)
diff --git a/tools/hv/hv_vss_daemon.c b/tools/hv/hv_vss_daemon.c
index 5e63f70..135425
... to support both netlink and /dev/vmbus/hv_vss communication methods.
Signed-off-by: Vitaly Kuznetsov
---
drivers/hv/hv_snapshot.c | 52 +---
1 file changed, 27 insertions(+), 25 deletions(-)
diff --git a/drivers/hv/hv_snapshot.c b/drivers/hv/hv_sn
... and move it to debug level as normally daemons write to syslog themselves
and these kernel messages are useless.
Signed-off-by: Vitaly Kuznetsov
---
drivers/hv/hv_fcopy.c| 3 +--
drivers/hv/hv_kvp.c | 3 ++-
drivers/hv/hv_snapshot.c | 2 +-
3 files changed, 4 insertions(+), 4 deleti
This function is called on the previous and the next failure branches.
This patch adds the call on the branch where it seems to be missing.
Signed-off-by: Quentin Lambert
---
drivers/staging/dgnc/dgnc_driver.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
On Wed, Mar 11, 2015 at 10:45:49AM +, Lorenzo Stoakes wrote:
> This patch removes the unnecessary spinlock helper function and instead
> calls spin_lock and spin_unlock directly.
>
> This does *not* resolve sparse warnings about context imbalances but these are
> spurious.
tested the whole se
On Thu, Mar 12, 2015 at 10:02:24AM +0100, Greg KH wrote:
> On Wed, Mar 11, 2015 at 06:56:54PM -0700, K. Y. Srinivasan wrote:
> > This patch is a continuation of the rescind handling cleanup work. We cannot
> > block in the global message handling work context especially if we are
> > blocking
> >
On Wed, Mar 11, 2015 at 06:56:54PM -0700, K. Y. Srinivasan wrote:
> This patch is a continuation of the rescind handling cleanup work. We cannot
> block in the global message handling work context especially if we are
> blocking
> waiting for the host to wake us up. I would like to thank
> Dexuan
When the caller specifies that signalling should be deferred, we need to
address the case where we are not able to place the current packet because
the buffer is full. In this case, we will signal the host as some packets
may have been placed on the ring buffer.
I would like to thank Jason Wang fo
On Wed, Mar 11, 2015 at 06:37:30PM +0200, Giedrius Statkevičius wrote:
> It's still not in staging-testing for some reason :(
>
It can take several weeks to get merged. Relax.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
On 12/03/2015 10:27, Dan Carpenter wrote:
On Wed, Mar 11, 2015 at 06:37:30PM +0200, Giedrius Statkevičius wrote:
It's still not in staging-testing for some reason :(
It can take several weeks to get merged. Relax.
regards,
dan carpenter
What should i do concerning that ?
I need to send a
Signed-off-by: Ragavendra BN
This patch fixes the coding style warning found by checkpath.pl for the
open braces next to declaration.
---
drivers/staging/sm750fb/ddk750_chip.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c
b/driver
On Thu, Mar 12, 2015 at 02:31:55AM -0700, Ragavendra BN wrote:
> Signed-off-by: Ragavendra BN
Don't include this. Fix your From header so it has your legal name.
Remover the [user] part.
>
> This patch fixes the coding style warning found by checkpath.pl for the
> open braces next to declarati
On Thu, Mar 12, 2015 at 02:31:55AM -0700, Ragavendra BN wrote:
> Signed-off-by: Ragavendra BN
what is [user] in your email address?
>
> This patch fixes the coding style warning found by checkpath.pl for the
> open braces next to declaration.
Signed-off-by line should be here after your commit
On Thu, Mar 12, 2015 at 10:32:40AM +0100, Quentin Lambert wrote:
> Should I wait these several weeks to send the second version or should
> I send a second version fixing this issue a wait for someone to ask me
> to solve the conflict ?
Greg applies patches in the order they come. It's normally s
On Thu, Mar 12, 2015 at 10:32:40AM +0100, Quentin Lambert wrote:
>
>
> On 12/03/2015 10:27, Dan Carpenter wrote:
> >On Wed, Mar 11, 2015 at 06:37:30PM +0200, Giedrius Statkevičius wrote:
> >>It's still not in staging-testing for some reason :(
> >>
> >It can take several weeks to get merged. Rel
On Mon, Mar 09, 2015 at 06:29:38PM +0200, Giedrius Statkevičius wrote:
> Remove BOARD_FAILED and don't save dgnc_boards which failed to
> initialize.
>
> Assign the result of kzalloc() to brd in dgnc_found_board() and only put
> it in the dgnc_Board[] if it successfully initializes. Also, remove
>
On Tue, Mar 10, 2015 at 09:29:19PM +0200, Giedrius Statkevičius wrote:
> In sysfs methods struct device is guaranteed to not be NULL thus bd will
> not be NULL in any way. Also, checking for bd->magic != DGNC_BOARD_MAGIC
> and bd->state != BOARD_READY is redundant because we already don't
> initial
On Thu, Mar 12, 2015 at 11:08:49AM +0100, Greg KH wrote:
> I really want to see this whole "static list of boards/cards" go away.
Yes, but I feel like this is a step in that direction. It just deletes
dead code, it doesn't add anything.
regards,
dan carpenter
___
On 10/03/15 16:25, Joe Perches wrote:
On Tue, 2015-03-10 at 16:10 +, Ian Abbott wrote:
"comedidev.h" includes PCI-specific stuff that gets included by all
comedi drivers including non-PCI ones. Separate it out into its own
header "comedi_pci.h". Make the new header include and
"comedidev.
Signed-off-by: Ragavendra BN
This patch fixes the coding style warnings found by checkpath.pl for
the if else block
---
drivers/staging/sm750fb/ddk750_chip.c | 25 ++---
1 file changed, 10 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c
On Thu, Mar 12, 2015 at 03:33:19AM -0700, Ragavendra BN wrote:
> Signed-off-by: Ragavendra BN
>
This goes on the bottom of the changelog text.
> This patch fixes the coding style warnings found by checkpath.pl for
> the if else block
It also does something else, so I have to reject this. Ple
On Wed, Mar 11, K. Y. Srinivasan wrote:
> The current Linux 4.0 RC3 tree is broken and this patch fixes the problem.
This does not seem to apply to master. What it is based on?
checking file drivers/hv/channel_mgmt.c
Hunk #3 FAILED at 139.
Hunk #4 succeeded at 194 (offset -31 lines).
Hunk #5 suc
On Wed, Mar 11, K. Y. Srinivasan wrote:
> +++ b/drivers/hv/hv_balloon.c
> @@ -652,6 +652,7 @@ static void hv_mem_hot_add(unsigned long start, unsigned
> long size,
> }
> has->ha_end_pfn -= HA_CHUNK;
> has->covered_end_pfn -= proce
Olaf Hering writes:
> On Wed, Mar 11, K. Y. Srinivasan wrote:
>
>> +++ b/drivers/hv/hv_balloon.c
>> @@ -652,6 +652,7 @@ static void hv_mem_hot_add(unsigned long start, unsigned
>> long size,
>> }
>> has->ha_end_pfn -= HA_CHUNK;
>> ha
On Wed, Mar 11, KY Srinivasan wrote:
> This is the convention that we have used for patches submitted to
> David's tree.
I see, it refers to the directory name. In a bunch of backports it gives
the impression it affects the Hyper-V support as whole, while in fact a
given change is just for the ne
On Thu, Mar 12, Vitaly Kuznetsov wrote:
> My "Drivers: hv: hv_balloon: eliminate the trylock path in
> acquire/release_region_mutex" (b05d8d9ef5ef21d1b18440430f950304836e1aaa
> in char-misc-next) removed these wrappers.
I see now. There are many changes in char-misc-next. The description
gives th
* Krzysztof Kozlowski wrote:
> Replace direct usage of put_device() with new API: power_supply_put().
>
> Signed-off-by: Krzysztof Kozlowski
> Acked-by: Pavel Machek
> Reviewed-by: Bartlomiej Zolnierkiewicz
> Reviewed-by: Sebastian Reichel
> ---
> arch/x86/platform/olpc/olpc-xo1-sci.c | 4
* Krzysztof Kozlowski wrote:
> Replace direct usage of put_device() with new API: power_supply_put().
>
> Signed-off-by: Krzysztof Kozlowski
> Acked-by: Pavel Machek
> Reviewed-by: Bartlomiej Zolnierkiewicz
> Reviewed-by: Sebastian Reichel
> ---
> arch/x86/platform/olpc/olpc-xo15-sci.c | 4
On Thu, Mar 12, 2015 at 12:14:28PM +0100, Olaf Hering wrote:
> On Thu, Mar 12, Vitaly Kuznetsov wrote:
>
> > My "Drivers: hv: hv_balloon: eliminate the trylock path in
> > acquire/release_region_mutex" (b05d8d9ef5ef21d1b18440430f950304836e1aaa
> > in char-misc-next) removed these wrappers.
>
> I
This patch fixed spelling typo found in sm750fb source files.
Both printk and comments are fixed.
Signed-off-by: Masanari Iida
---
drivers/staging/sm750fb/ddk750_chip.c | 4 ++--
drivers/staging/sm750fb/ddk750_dvi.h| 2 +-
drivers/staging/sm750fb/ddk750_help.h | 2 +-
drivers/staging/
> -Original Message-
> From: Olaf Hering [mailto:o...@aepfle.de]
> Sent: Thursday, March 12, 2015 4:14 AM
> To: Vitaly Kuznetsov
> Cc: KY Srinivasan; gre...@linuxfoundation.org; linux-
> ker...@vger.kernel.org; de...@linuxdriverproject.org; a...@canonical.com
> Subject: Re: [PATCH 2/6] Dr
When we removed the ERRDEV() macro we made a small mistake so now it
doesn't print the "Virtual PCI devices" section header.
Fixes: 0aca78449b58 ('staging: unisys: remove ERRDEV macros')
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/unisys/virtpci/virtpci.c
b/drivers/staging/unisys/
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Thursday, March 12, 2015 2:03 AM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com
> Subject: Re: [PATCH 1/6] Driv
On Thu, Mar 12, 2015 at 09:43:38PM +0900, Masanari Iida wrote:
> This patch fixed spelling typo found in sm750fb source files.
> Both printk and comments are fixed.
your patch is not applying to next-20150312. please refresh your patch
against staging-testing branch of the staging tree.
r
On Thu, Mar 12, 2015 at 01:12:29PM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Greg KH [mailto:gre...@linuxfoundation.org]
> > Sent: Thursday, March 12, 2015 2:03 AM
> > To: KY Srinivasan
> > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> > o...@aep
the macro comparison is always true as MAJOR is defined as
unsiged int.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/unisys/visorchipset/file.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/unisys/visorchipset/file.c
b/drivers/staging/unisys/vis
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Thursday, March 12, 2015 6:29 AM
> To: KY Srinivasan
> Cc: a...@canonical.com; de...@linuxdriverproject.org; o...@aepfle.de;
> linux-ker...@vger.kernel.org
> Subject: Re: [PATCH 1/6] Drivers: hv: vmbus: Perfo
On Thu, Mar 12, 2015 at 07:44:21PM +0530, Sudip Mukherjee wrote:
> the macro comparison is always true as MAJOR is defined as
> unsiged int.
>
> Signed-off-by: Sudip Mukherjee
> ---
> drivers/staging/unisys/visorchipset/file.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> di
these variable were being assigned some values but never reused.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/unisys/virthba/virthba.c | 18 ++
drivers/staging/unisys/virtpci/virtpci.c | 22 +++---
2 files changed, 13 insertions(+), 27 deletions(-)
diff --g
> -Original Message-
> From: Olaf Hering [mailto:o...@aepfle.de]
> Sent: Thursday, March 12, 2015 3:44 AM
> To: KY Srinivasan
> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; a...@canonical.com; vkuzn...@redhat.com
> Subject: Re: [PATCH 1/6]
> -Original Message-
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On
> Behalf Of KY Srinivasan
> Sent: Thursday, March 12, 2015 7:29 AM
> To: Olaf Hering
> Cc: a...@canonical.com; gre...@linuxfoundation.org; linux-
> ker...@vger.kernel.org; de...@linuxdriverprojec
On 2015.03.12 12:08, Greg KH wrote:
> On Mon, Mar 09, 2015 at 06:29:38PM +0200, Giedrius Statkevičius wrote:
>> Remove BOARD_FAILED and don't save dgnc_boards which failed to
>> initialize.
>>
>> Assign the result of kzalloc() to brd in dgnc_found_board() and only put
>> it in the dgnc_Board[] if i
On Mon 09-03-15 09:40:43, Vitaly Kuznetsov wrote:
> Michal Hocko writes:
>
> > [Sorry for the late response]
> >
> > This is basically the same code posted by KY Srinivasan posted late last
> > year (http://marc.info/?l=linux-mm&m=141782228129426&w=2). I had
> > objections to the implementation
>
"brd->nasync" amd "brd->maxports" are the same. They hold the number of
filled out channels in the brd->channels[] array. These tests should
be ">=" instead of ">" so that we don't read one element past the end.
Signed-off-by: Dan Carpenter
diff --git a/drivers/tty/serial/jsm/jsm_cls.c b/drive
"dgnc_NumBoards" is the number of filled out elements in the
dgnc_Board[] array. "->nasync" and "->maxports" are the value. They
are the number of channels in the ->channels[] array so these tests
should be ">=" instead of ">" so we avoid reading past the end of the
arrays.
I cleaned up the cond
On Thu, Mar 12, 2015 at 08:07:39PM +0300, Dan Carpenter wrote:
> "dgnc_NumBoards" is the number of filled out elements in the
> dgnc_Board[] array. "->nasync" and "->maxports" are the value.
I meant "the *same* value". I'll resend.
regards,
dan carpenter
___
"dgnc_NumBoards" is the number of filled out elements in the
dgnc_Board[] array. "->nasync" and "->maxports" are the same value.
They are the number of channels in the ->channels[] array so these tests
should be ">=" instead of ">" so we avoid reading past the end of the
arrays.
I cleaned up the
MAJOR(majordev) is 0 when dynamic major number is used, and it is
greater than 0 when static major number is used. Considering both the
cases the expression is always true.
Signed-off-by: Sudip Mukherjee
---
v2: changed commit log
drivers/staging/unisys/visorchipset/file.c | 6 ++
1 file c
dev_t is defined to be of unsigned int type, no use initializing
it to -1.
Signed-off-by: Sudip Mukherjee
---
v2: it was not in v1
drivers/staging/unisys/visorchipset/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorchipset/file.c
b/drivers
rearranged the functions to remove the forward declarations.
Signed-off-by: Sudip Mukherjee
---
v2: it was not in v1
drivers/staging/unisys/visorchipset/file.c | 78 ++
1 file changed, 36 insertions(+), 42 deletions(-)
diff --git a/drivers/staging/unisys/visorchips
these variable were being assigned some values but never reused.
Signed-off-by: Sudip Mukherjee
---
v2: no change
drivers/staging/unisys/virthba/virthba.c | 18 ++
drivers/staging/unisys/virtpci/virtpci.c | 22 +++---
2 files changed, 13 insertions(+), 27 deleti
The semantic patch that makes this change is available
in scriptcoccinelle/api/memdup.cocci.
Signed-off-by: Madhusudhanan Ravindran
---
drivers/staging/lustre/lustre/llite/xattr_cache.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/xatt
Dpacompat.h contained a lot of unused #defines and only few things are
used from it so since we've trimmed down digi.h, now we can delete
dpacompat.h and move remaining stuff into digi.h.
Signed-off-by: Giedrius Statkevičius
---
drivers/staging/dgnc/dgnc_driver.c | 1 -
drivers/staging/dgnc/dg
Remove a lot of unused #defines and struct definitions from digi.h. In
dgnc_mgmt.c, termios.h is included before that defines it's own TIOCM_LE
and others protected under #ifndef in digi.h so we can't delete them
yet. Also, be careful with TIOCMSET and TIOCMBIC since
include/uapi/asm-generic/ioctl
TRUE/FALSE defined in dgnc_types.h are only used in dgnc_tty.c thus it
would be better to just use 1/0 to avoid unnecessary extra files and
includes.
Signed-off-by: Giedrius Statkevičius
---
drivers/staging/dgnc/dgnc_cls.h| 3 ---
drivers/staging/dgnc/dgnc_driver.h | 1 -
drivers/staging/d
Remove unused defines from dgnc_cls.h
Signed-off-by: Giedrius Statkevičius
---
drivers/staging/dgnc/dgnc_cls.h | 13 -
1 file changed, 13 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_cls.h b/drivers/staging/dgnc/dgnc_cls.h
index 85042bd..2597e36 100644
--- a/drivers/staging/d
dgnc_kcompat.h contains some old legacy defines in case the kernel
doesn't have __user defined but for current kernel versions these
defines don't make sense and are useless so remove them. Move the
TTY_FLIPBUF_SIZE define to digi.h because it's used in the code.
Signed-off-by: Giedrius Statkeviči
Remove redundant blank lines, move absolute include after relative
include.
Signed-off-by: Giedrius Statkevičius
---
drivers/staging/dgnc/dgnc_sysfs.h | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_sysfs.h
b/drivers/staging/dgnc/dgnc_sysfs.h
in
On Thu, Mar 12, 2015 at 08:14:25PM +0200, Giedrius Statkevičius wrote:
> TRUE/FALSE defined in dgnc_types.h are only used in dgnc_tty.c thus it
> would be better to just use 1/0 to avoid unnecessary extra files and
> includes.
>
Use true/false. I don't care much about this personally but true/fa
On 2015.03.12 20:59, Dan Carpenter wrote:
> On Thu, Mar 12, 2015 at 08:14:25PM +0200, Giedrius Statkevičius wrote:
>> TRUE/FALSE defined in dgnc_types.h are only used in dgnc_tty.c thus it
>> would be better to just use 1/0 to avoid unnecessary extra files and
>> includes.
>>
>
> Use true/false.
On Tuesday, March 10, 2015 09:27:17 AM Krzysztof Kozlowski wrote:
> Change the ownership of power_supply structure from each driver
> implementing the class to the power supply core.
>
> The patch changes power_supply_register() function thus all drivers
> implementing power supply class are adjus
Fix checkpatch.pl warning 'min() should probably be min_t()'.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_rx.c | 16 +++-
drivers/staging/rtl8192e/rtllib_wx.c | 4 ++--
2 files changed, 13 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8192e
Various coding style fixes for rtl8192e driver.
This series of patches includes v2 (changes to rtllib_wx.c),
but also includes similar fixes for other files.
checkpatch.pl still complains about some of patches - this will be fixed
in further commits (warnings were mostly already there):
1/6:
-
Fix checkpatch.pl errors 'Macros with complex values should be enclosed in
parentheses'.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl819x_HT.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h
b/drivers/staging
Some messages were reported with netdev_* macros and internal
driver-specific macro.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_wx.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib_wx.c
b/drivers/staging/rtl8192e/rtllib_wx.c
ind
Fix checkpatch.pl warning 'space prohibited before semicolon'.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 2 +-
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 2 +-
drivers/staging/rtl8192e/rtl8192e/r8192E_hwimg.h| 14 +++---
Use netdev_*() functions to print diagnostic messages.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_wx.c | 21 +
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib_wx.c
b/drivers/staging/rtl8192e/rtllib_wx.
Fix checkpatch.pl warnings:
- 'WARNING: quoted string split across lines'
- 'WARNING: break quoted strings at a space character'
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c | 51 +++---
drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 28 +--
dr
On Fri, 2015-03-13 at 00:53 +0100, Mateusz Kulikowski wrote:
[]
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
> b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
> index 0e6bdd2..01d2201 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
> +++ b/drivers/stagin
Minor change to convert if-else to if statement
Signed-off-by: Janakarajan Natarajan
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
b/drivers/staging/ft1000/ft1000-p
Minor changes to fix ft1000 driver checkpatch.pl warnings
Janakarajan Natarajan (5):
Drivers: Staging: ft1000: Single line if-statement changes
Drivers: Staging: ft1000: Fix extra parenthesis warnings
Drivers: Staging: ft1000: Refactoring if-else statement
Drivers: Staging: ft1000: Fix bla
Minor change to remove {} for single line if statements
Signed-off-by: Janakarajan Natarajan
---
drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c
b/drivers/staging/ft1000/f
Merges variable declaration and definition.
Signed-off-by: Janakarajan Natarajan
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
b/drivers/staging/ft1000/ft1000-pcmcia/ft1
Minor changes to remove extra parenthesis
Signed-off-by: Janakarajan Natarajan
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 2 +-
drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-pcmcia
Replaces and with and
Signed-off-by: Janakarajan Natarajan
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
index b
Signed-off-by: Ragavendra BN
This patch removes the braces for the single line if statement. It fixes
the indent positions correctly. It fixes the spaces appropriately making the
code give no
warnings by the checkpath.pl script check.
---
drivers/staging/sm750fb/ddk750_chip.c | 22 --
On Thu, Mar 12, 2015 at 08:43:33PM -0700, Ragavendra BN wrote:
> Signed-off-by: Ragavendra BN
>
> This patch removes the braces for the single line if statement. It fixes
> the indent positions correctly. It fixes the spaces appropriately making the
> code give no
> warnings by the checkpath.pl
This patch removes the braces for the single line if statement. It fixes
the indent positions correctly. It fixes the spaces appropriately making the
code give no
warnings by the checpath.pl script check.
Signed-off-by: Ragavendra BN
---
drivers/staging/sm750fb/ddk750_chip.c | 22 --
On Thu, Mar 12, 2015 at 10:14:36PM -0700, Ragavendra BN wrote:
> This patch removes the braces for the single line if statement. It fixes
> the indent positions correctly. It fixes the spaces appropriately making the
> code give no
> warnings by the checpath.pl script check.
your From: is still h
This patch removes the braces for the single line if statement. It fixes
the indent positions correctly. It fixes the spaces appropriately making the
code give no
warnings by the checpath.pl script check. Please accept.
Signed-off-by: Ragavendra BN
---
drivers/staging/sm750fb/ddk750_chip.c |
100 matches
Mail list logo
