> @@ -582,7 +582,7 @@ int rtllib_xmit_inter(struct sk_buff *skb, struct
> net_device *dev)
> IEEE_SOFTMAC_TX_QUEUE)) ||
> ((!ieee->softmac_data_hard_start_xmit &&
> (ieee->softmac_features & IEEE_SOFTMAC_TX_QUEUE {
> - printk(KERN_WARNING "%s: No xmit ha
Fix your from header so it has your name.
On Thu, Apr 02, 2015 at 04:57:52PM +0200, vcaba...@clipper.ens.fr wrote:
> >From 654380760bfc5b35ed3d3d4a7d3eb126fe747959 Mon Sep 17 00:00:00 2001
> From: Vivien Cabannes
> Date: Thu, 2 Apr 2015 16:32:15 +0200
> Subject: [PATCH] Staging: lustre: api-ni.c:
On Thu, Apr 02, 2015 at 06:12:46PM +0200, Greg KH wrote:
> On Thu, Apr 02, 2015 at 06:24:21PM +0300, Dan Carpenter wrote:
> > Still mangled. Read Documentation/email-clients.txt. Send the patch
> > to yourself. Apply it with git am. Then resend when that works.
>
> Also, the students had to en
On Thu, Apr 02, 2015 at 07:52:07PM +0200, Guillaume Matheron wrote:
> I fixed lines over 80 characters and unnecessary returns
>
> Signed-off-by: Guillaume Matheron
> ---
> .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 53
> +-
> 1 file changed, 31 insertions(+), 22 d
On Thu, Apr 02, 2015 at 07:35:45PM +0200, Guillaume Matheron wrote:
> I focused on function declarations (placed return type on the same line
> as function name), and spaces between function name and parenthesis
>
> Signed-off-by: Guillaume Matheron
> ---
> .../staging/lustre/lnet/klnds/o2iblnd/
On Fri, Mar 27, 2015 at 09:29:43PM +0100, Witos wrote:
> Changed bool to u8.
>
> Signed-off-by: Piotr Witoslawski
Your From: email line and signed-off-by: line names do not match, so I
can't take this patch :(
Please fix up and resend.
> ---
> drivers/staging/speakup/fakekey.c | 2 +-
> 1 fil
On Fri, Mar 27, 2015 at 09:36:07PM +0100, Witos wrote:
> Changed bool to u8 to get rid of sparse warning.
>
> Signed-off-by: Piotr Witoslawski
> ---
> drivers/staging/speakup/fakekey.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/fakekey.c
>
This reverts commit d13778d537a0ed6115d2a79a942af999cfb8eec6.
Commit 13c11072536f2613 ("staging:board: remove unnecessary function")
fixed the build of drivers/staging/board/board.c.
Signed-off-by: Geert Uytterhoeven
---
drivers/staging/board/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff -
As of commit 9a1091ef0017c40a ("irqchip: gic: Support hierarchy irq
domain."), GIC IRQ numbers are virtual, breaking hardcoded hardware IRQ
numbers in platform device resources.
Translate the hardware IRQ numbers to virtual IRQ numbers to fix this.
Signed-off-by: Geert Uytterhoeven
---
Untested
Add staging board support for the r8a7740-based armadillo800eva board
and add platform devices to allow in-tree continuous development of the
drivers on the armadillo800eva board.
When DT bindings are ready for theses drivers then the platform devices
in the armadillo800eva staging board code can
Hi all,
This RFC patch series adds board staging support for r8a7740/armadillo.
For now this supports only the frame buffer device for the on-board LCD.
The goal is to complete the move to ARM multiplatform kernels for all
shmobile platforms, and drop the existing board files
(arch/arm/mac
Add support for easy registering of one ore more platform devices that
may:
- need clocks that are described in DT,
- need pin control configuration,
- rely on a configured GPIO,
- be part of a PM Domain.
All these dependencies are optional.
Signed-off-by: Geert Uytterhoeven
---
drivers
Currently the staging board code is initialized from a late_initcall().
However, unused PM domains are also disabled from a late_initcall(),
which happens before due to link order.
Change the initialization of staging board code from using
late_initcall() to device_initcall() to fix this.
Signed-
As of commit 9a1091ef0017c40a ("irqchip: gic: Support hierarchy irq
domain."), GIC IRQ numbers are virtual, breaking hardcoded hardware IRQ
numbers in platform device resources.
Add support for translating hardware IRQ numbers to virtual IRQ numbers,
and fixing up platform device resources with ha
On Fri, Apr 03, 2015 at 02:42:02PM +0200, Geert Uytterhoeven wrote:
> +int __init board_staging_register_clock(const struct board_staging_clk *bsc)
> +{
> + struct clk *clk;
> + int error;
> +
> + pr_debug("Registering clock %s for con_id %s dev_id %s\n", bsc->clk,
> + bsc-
On Thu, Apr 02, 2015 at 09:36:06PM +0700, Phong Tran wrote:
> Add the remove() method for deregister from misc device
> when it's unloaded.
>
> Signed-off-by: Phong Tran
> ---
> drivers/staging/android/ion/ion_test.c | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers
On Fri, Apr 3, 2015 at 2:57 PM, Dan Carpenter wrote:
>> + error = clk_register_clkdev(clk, bsc->con_id, bsc->dev_id);
>> + if (error)
>> + pr_err("Failed to register clock %s (%d)\n", bsc->clk, error);
>> + return error;
>
> Missing curly braces. Also it's weird th
On Mon, Mar 30, 2015 at 03:11:25PM +, Dhere, Chaitanya (C.) wrote:
> This change was detected with the help of coccinelle tool.
> It performs the same function as kzalloc amd memcpy.
>
> Signed-off-by: Chaitanya Dhere
Your From: line and this line don't match :(
> ---
> drivers/staging/rtl
Hi Greg,
I resend 2 patches
(1) add the remove() platform driver callback to
deregister the misc device
(2) unregister platform device when driver is unloaded
Changes from v2:
Remove the extra space of patch (1)
Changes from v1:
Imporve the coding style
Phong Tran (2):
(1)
The driver has to unregister from platform device when it's unloaded
Signed-off-by: Phong Tran
---
drivers/staging/android/ion/ion_test.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion_test.c
b/drivers/staging/android/ion/ion_test.c
in
Add the remove() method for deregister from misc device
when it's unloaded.
Signed-off-by: Phong Tran
---
drivers/staging/android/ion/ion_test.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/staging/android/ion/ion_test.c
b/drivers/staging/android/ion/ion_test.c
inde
This patch fix spelling typo in sm750fb driver.
Signed-off-by: Masanari Iida
---
drivers/staging/sm750fb/ddk750_chip.c | 2 +-
drivers/staging/sm750fb/ddk750_dvi.h| 2 +-
drivers/staging/sm750fb/ddk750_help.h | 2 +-
drivers/staging/sm750fb/ddk750_mode.c | 4 ++--
drivers/staging/s
On April 3, 2015 5:19:55 AM EDT, Dan Carpenter wrote:
>
>> @@ -582,7 +582,7 @@ int rtllib_xmit_inter(struct sk_buff *skb, struct
>net_device *dev)
>> IEEE_SOFTMAC_TX_QUEUE)) ||
>> ((!ieee->softmac_data_hard_start_xmit &&
>> (ieee->softmac_features & IEEE_SOFTMAC_TX_QUEUE)
On Sat, Apr 04, 2015 at 12:15:10AM +0900, Masanari Iida wrote:
> This patch fix spelling typo in sm750fb driver.
your patch is not applying. please send a v2 and base it on staging-testing.
regards
sudip
___
devel mailing list
de...@linuxdriverproject.
Hello Geert,
Thank you for the patches.
On Friday 03 April 2015 14:41:57 Geert Uytterhoeven wrote:
> Hi all,
>
> This RFC patch series adds board staging support for r8a7740/armadillo.
> For now this supports only the frame buffer device for the on-board LCD.
I've started adding DT suppor
Removes variable comparison with 0 by using !.
Done using following coccinelle script.
@ disable is_zero,isnt_zero @
expression *E;
expression E1,f;
@@
E = f(...)
<...
(
- E == 0
+ !E
|
- E != 0
+ E
|
- 0 == E
+ !E
|
- 0 != E
+ E
)
...>
?E = E1
@ disable is_zero,isnt_zero @
expression *E;
@@
(
On Fri, Apr 03, 2015 at 10:12:11PM +0530, Amitoj Kaur Chawla wrote:
> Removes variable comparison with 0 by using !.
Sometimes testing for zero makes sense. When you write code, you are
telling a story. If you are talking about zero as a number then it
can make sense. If it's zero as a boolean
On Fri, 2015-04-03 at 19:51 +0300, Dan Carpenter wrote:
> On Fri, Apr 03, 2015 at 10:12:11PM +0530, Amitoj Kaur Chawla wrote:
> > Removes variable comparison with 0 by using !.
>
> Sometimes testing for zero makes sense.
> When you write code, you are
> telling a story. If you are talking about
On Fri, Apr 3, 2015 at 10:21 PM, Dan Carpenter wrote:
>
> On Fri, Apr 03, 2015 at 10:12:11PM +0530, Amitoj Kaur Chawla wrote:
> > Removes variable comparison with 0 by using !.
>
> Sometimes testing for zero makes sense. When you write code, you are
> telling a story. If you are talking about ze
On Fri, Apr 03, 2015 at 11:49:57AM -0400, Nicholas Krause wrote:
>
>
> On April 3, 2015 5:19:55 AM EDT, Dan Carpenter
> wrote:
> >
> >> @@ -582,7 +582,7 @@ int rtllib_xmit_inter(struct sk_buff *skb, struct
> >net_device *dev)
> >> IEEE_SOFTMAC_TX_QUEUE)) ||
> >> ((!ieee->softmac_dat
On Fri, Apr 03, 2015 at 03:27:40PM +0200, Geert Uytterhoeven wrote:
> On Fri, Apr 3, 2015 at 2:57 PM, Dan Carpenter
> wrote:
> >> + error = clk_register_clkdev(clk, bsc->con_id, bsc->dev_id);
> >> + if (error)
> >> + pr_err("Failed to register clock %s (%d)\n", bsc->clk,
> >>
On Fri, Apr 03, 2015 at 03:57:27PM +0300, Dan Carpenter wrote:
> On Fri, Apr 03, 2015 at 02:42:02PM +0200, Geert Uytterhoeven wrote:
> > +int __init board_staging_register_clock(const struct board_staging_clk
> > *bsc)
> > +{
> > + struct clk *clk;
> > + int error;
> > +
> > + pr_debug("Regi
On April 3, 2015 1:05:59 PM EDT, Greg KH wrote:
>On Fri, Apr 03, 2015 at 11:49:57AM -0400, Nicholas Krause wrote:
>>
>>
>> On April 3, 2015 5:19:55 AM EDT, Dan Carpenter
> wrote:
>> >
>> >> @@ -582,7 +582,7 @@ int rtllib_xmit_inter(struct sk_buff *skb,
>struct
>> >net_device *dev)
>> >> I
On Fri, Apr 03, 2015 at 02:05:11PM -0400, Nicholas Krause wrote:
>
>
> On April 3, 2015 1:05:59 PM EDT, Greg KH wrote:
> >On Fri, Apr 03, 2015 at 11:49:57AM -0400, Nicholas Krause wrote:
> >>
> >>
> >> On April 3, 2015 5:19:55 AM EDT, Dan Carpenter
> > wrote:
> >> >
> >> >> @@ -582,7 +582,7 @@
Hello!
On Apr 2, 2015, at 6:18 AM, Julia Lawall wrote:
>> Julia, I wonder if you happen to have a bunch of other patches to get rid of
>> the rest of OBD_ALLOC and OBD_FREE stuff by any chance?
> I can generate them again, but I wasn't clear on what was wanted. I would
> really prefer something
On April 3, 2015 2:30:01 PM EDT, Greg KH wrote:
>On Fri, Apr 03, 2015 at 02:05:11PM -0400, Nicholas Krause wrote:
>>
>>
>> On April 3, 2015 1:05:59 PM EDT, Greg KH
>wrote:
>> >On Fri, Apr 03, 2015 at 11:49:57AM -0400, Nicholas Krause wrote:
>> >>
>> >>
>> >> On April 3, 2015 5:19:55 AM EDT,
Hi Laurent,
On Fri, Apr 3, 2015 at 6:24 PM, Laurent Pinchart
wrote:
> On Friday 03 April 2015 14:41:57 Geert Uytterhoeven wrote:
>> This RFC patch series adds board staging support for r8a7740/armadillo.
>> For now this supports only the frame buffer device for the on-board LCD.
>
> I've started
On Fri, 3 Apr 2015, Drokin, Oleg wrote:
> Hello!
>
> On Apr 2, 2015, at 6:18 AM, Julia Lawall wrote:
>
> >> Julia, I wonder if you happen to have a bunch of other patches to get rid
> >> of the rest of OBD_ALLOC and OBD_FREE stuff by any chance?
> > I can generate them again, but I wasn't cle
On Fri, Apr 03, 2015 at 10:01:10AM -0700, Joe Perches wrote:
> On Fri, 2015-04-03 at 19:51 +0300, Dan Carpenter wrote:
> > Also strcmp() and similar should always be done as == 0, < 0 or != 0
> > because that is the idiom:
>
> Less true.
>
> When testing for equality, !strcmp is very common.
>
>
This is a patch to the fb_ili9163.c file that inserts a line break in
line #92 to make the line fit into the 80 character limit.
Signed-off-by: Andreas Theodosiou
---
drivers/staging/fbtft/fb_ili9163.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fb
On Sat, 2015-04-04 at 03:23 +0300, Andreas Theodosiou wrote:
> This is a patch to the fb_ili9163.c file that inserts a line break in
> line #92 to make the line fit into the 80 character limit.
[]
> diff --git a/drivers/staging/fbtft/fb_ili9163.c
> b/drivers/staging/fbtft/fb_ili9163.c
[]
> @@ -89,
On Sat, 4 Apr 2015, Andreas Theodosiou wrote:
> This is a patch to the fb_ili9163.c file that inserts a line break in
> line #92 to make the line fit into the 80 character limit.
>
> Signed-off-by: Andreas Theodosiou
> ---
> drivers/staging/fbtft/fb_ili9163.c | 3 ++-
> 1 file changed, 2 insert
42 matches
Mail list logo
