On Mon, Apr 20, 2015 at 10:11:51PM -0500, Jaime Arrocha wrote:
> This patch fixes the warning found by checkpatch.pl:
> ERROR: Macros with complex values should be enclosed in parentheses
>
> Signed-off-by: Jaime Arrocha
> ---
> drivers/staging/gdm72xx/usb_ids.h |4 ++--
> 1 file changed, 2
On Mon, Apr 20, 2015 at 07:57:31PM -0700, Gbenga Adalumo wrote:
> The patch fixes a trailing whitespace and code indenting coding style
> errors as reported by checkpatch.pl tool.
> Details of the lines where the fixed errors were reported are as follows:
>
> drivers/staging/comedi/drivers/daqboa
In case there was an error reported in the response to the
CHANNELMSG_OPENCHANNEL
call we need to do the cleanup as a vmbus_open() user won't be doing it after
receiving an error. The cleanup should be done on all failure paths.
Signed-off-by: Vitaly Kuznetsov
---
drivers/hv/channel.c | 7 -
Explicitly kill tasklets we create on module unload.
Signed-off-by: Vitaly Kuznetsov
---
drivers/hv/vmbus_drv.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index 2b56260..cf20400 100644
--- a/drivers/hv/vmbus_drv.c
+++ b
vmbus_isr() uses synic pages which are being setup in hv_synic_alloc(), we
need to register this irq handler only after we allocate all the required
pages.
Signed-off-by: Vitaly Kuznetsov
---
drivers/hv/vmbus_drv.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Tuesday, April 21, 2015 16:18
> To: KY Srinivasan
> Cc: Haiyang Zhang; de...@linuxdriverproject.org; linux-
> ker...@vger.kernel.org; Dexuan Cui
> Subject: [PATCH 1/3] Drivers: hv: vmbus: do cleanup on all vm
Yeah. That's tricky code for a static checker. You have to know that
if the caller passes kind = 1 or 2 then range is NULL.
The caller users S2002_CFG_KIND_DIGITAL_IN and S2002_CFG_KIND_DIGITAL_OUT
for 1 and 2.
regards,
dan carpenter
___
devel mailin
K. Y.,
here are 3 additional patches for your "[PATCH 0/5] Drivers: hv: vmbus: Cleanup
the vmbus unload path" series (with the fix I suggested). I tested the whole
set on Gen2 Win2012R2 guest, load/unload path seems being stable. Can you
please take a look?
Thanks,
Vitaly Kuznetsov (3):
Driver
On Tue, Apr 21, 2015 at 10:17:52AM +0200, Vitaly Kuznetsov wrote:
> diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
> index 54da66d..836386f 100644
> --- a/drivers/hv/channel.c
> +++ b/drivers/hv/channel.c
> @@ -186,11 +186,12 @@ int vmbus_open(struct vmbus_channel *newchannel, u32
> send
Oh. Ok. Resend with a corrected changelog then.
But don't include all the spammy output just one or two lines or a
summary.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/lis
On 21/04/15 08:50, Greg KH wrote:
On Mon, Apr 20, 2015 at 07:57:31PM -0700, Gbenga Adalumo wrote:
The patch fixes a trailing whitespace and code indenting coding style
errors as reported by checkpatch.pl tool.
Details of the lines where the fixed errors were reported are as follows:
drivers/s
On 20/04/15 19:49, H Hartley Sweeten wrote:
Fix a couple issues reported by Coverity.
H Hartley Sweeten (3):
staging: comedi: comedi_bond: fix 'b_mask' calc in bonding_dio_insn_bits()
staging: comedi: ni_nio_common: don't write non-existing caldac's
staging: comedi: serial2002: fix Cove
On Mon, Apr 20, 2015 at 11:49:04AM -0700, H Hartley Sweeten wrote:
> 'b_chans' may be a valud up to 32. 'b_mask' is an unsigned int and a left
> shift of
> more than 31 bits has undefined behavior. Fix the calc so it works correctly
> with
> a 'b_chans' of 32..
>
> Reported-by: coverity (CID 119
Dexuan Cui writes:
>> -Original Message-
>> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
>> Sent: Tuesday, April 21, 2015 16:18
>> To: KY Srinivasan
>> Cc: Haiyang Zhang; de...@linuxdriverproject.org; linux-
>> ker...@vger.kernel.org; Dexuan Cui
>> Subject: [PATCH 1/3] Drivers: hv:
Dan Carpenter writes:
> On Tue, Apr 21, 2015 at 10:17:52AM +0200, Vitaly Kuznetsov wrote:
>> diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
>> index 54da66d..836386f 100644
>> --- a/drivers/hv/channel.c
>> +++ b/drivers/hv/channel.c
>> @@ -186,11 +186,12 @@ int vmbus_open(struct vmbus_c
Keep the details of the comedi subdevice `runflags` member local to
"comedi_fops.c". In particular, the usage of the
`COMEDI_SRF_FREE_SPRIV` run-flag doesn't really fit in all that well
with the others. It's used as a marker to indicate the subdevice's
`private` pointer can be automatically freed
The `COMEDI_SRF_...` macros define flag combinations in the `runflags`
member of `struct comedi_subdevice`. They are only used directly in
"comedi_fops.c", so move them to there.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedi_fops.c | 17 +
drivers/staging/comedi/co
The `COMEDI_SRF_FREE_SPRIV` flag in the `runflags` member of `struct
comedi_subdevice` indicates that the memory pointed to by the `private`
member can be automatically freed by the comedi core on subdevice
clean-up (when the low-level comedi device is being "detached"). the
flag doesn't really be
On 21/04/15 12:13, Dan Carpenter wrote:
On Mon, Apr 20, 2015 at 11:49:04AM -0700, H Hartley Sweeten wrote:
'b_chans' may be a valud up to 32. 'b_mask' is an unsigned int and a left shift
of
more than 31 bits has undefined behavior. Fix the calc so it works correctly
with
a 'b_chans' of 32..
R
On Tue, Apr 21, 2015 at 01:52:09PM +0100, Ian Abbott wrote:
> >Is that really an improvement? The original code was actually defined.
> >
> >1U << 32 is actually defined. It is zero. Which works for us.
>
> According to the C standards it is undefined (for 32-bit unsigned
> int). See the late
This series is a continuation of the "Drivers: hv: vmbus: Use a round-robin
algorithm for picking the outgoing channel" work. It is supposed to bring two
significant changes:
1) Subchannels for a channel are distributed evenly across all vcpus we have.
Currently we try to distribute all channels
Primary channels are distributed evenly across all vcpus we have. When the host
asks us to create subchannels it usually makes us num_cpus-1 offers and we are
supposed to distribute the work evenly among the channel itself and all its
subchannels. Make sure they are all assigned to different vcpus.
vmbus_get_outgoing_channel() implements the following algorithm for selecting
an outgoing channel (despite the comment before the function saying it
distributes the load equally):
1) If we have no subchannels return the primary channel;
2) If primary->next_oc is grater than primary->num_sc reset th
We need to call init_vp_index() after we added the channel to the appropriate
list (global or subchannel) to be able to use this information when assigning
the channel to the particular vcpu. To do so we need to move a couple of
functions around. The only real change is the init_vp_index() call. Th
It is unlikely that that host will ask us to close only one subchannel for a
device but let's be consistent. Do both num_sc++ and num_sc-- with
channel->lock to be on the safe side.
Signed-off-by: Vitaly Kuznetsov
---
drivers/hv/channel_mgmt.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion
Remove some code duplication, no functional change intended.
Signed-off-by: Vitaly Kuznetsov
---
drivers/hv/channel_mgmt.c | 51 +--
1 file changed, 18 insertions(+), 33 deletions(-)
diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c
i
next_oc and num_sc fields of struct vmbus_channel deserve a description. Move
them closer to sc_list as these fields are related to it.
Signed-off-by: Vitaly Kuznetsov
---
include/linux/hyperv.h | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/include/linux/hyperv
On Tue, 21 Apr 2015 07:40:15 + Greg KH
wrote
> On Mon, Apr 20, 2015 at 10:11:51PM -0500, Jaime Arrocha wrote:
> > This patch fixes the warning found by checkpatch.pl:
> > ERROR: Macros with complex values should be enclosed in parentheses
> >
> > Signed-off-by: Jaime Arr
On Tue, Apr 21, 2015 at 02:21:32PM +, Jaime Arrocha wrote:
>
>
> On Tue, 21 Apr 2015 07:40:15 + Greg KH
> wrote
> > On Mon, Apr 20, 2015 at 10:11:51PM -0500, Jaime Arrocha wrote:
> > > This patch fixes the warning found by checkpatch.pl:
> > > ERROR: Macros with complex v
On Tuesday, April 21, 2015 6:35 AM, Dan Carpenter wrote:
> On Tue, Apr 21, 2015 at 01:52:09PM +0100, Ian Abbott wrote:
>>>Is that really an improvement? The original code was actually defined.
>>>
>>>1U << 32 is actually defined. It is zero. Which works for us.
>>
>> According to the C standard
Changes since v1 (PATCH 1/3):
- Return -EAGAIN instead of open_info->response.open_result.status [Dexuan Cui]
- Avoid 'if (ret != 0)' statement [Dan Carpenter]
Original description:
K. Y.,
Here are 3 additional patches for your "[PATCH 0/5] Drivers: hv: vmbus: Cleanup
the vmbus unload path" seri
Explicitly kill tasklets we create on module unload.
Signed-off-by: Vitaly Kuznetsov
---
drivers/hv/vmbus_drv.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index 2b56260..cf20400 100644
--- a/drivers/hv/vmbus_drv.c
+++ b
In case there was an error reported in the response to the
CHANNELMSG_OPENCHANNEL
call we need to do the cleanup as a vmbus_open() user won't be doing it after
receiving an error. The cleanup should be done on all failure paths. We also
need
to avoid returning open_info->response.open_result.stat
vmbus_isr() uses synic pages which are being setup in hv_synic_alloc(), we
need to register this irq handler only after we allocate all the required
pages.
Signed-off-by: Vitaly Kuznetsov
---
drivers/hv/vmbus_drv.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/
On Tuesday, April 21, 2015 5:18 AM, Ian Abbott wrote:
> Keep the details of the comedi subdevice `runflags` member local to
> "comedi_fops.c". In particular, the usage of the
> `COMEDI_SRF_FREE_SPRIV` run-flag doesn't really fit in all that well
> with the others. It's used as a marker to indicat
On 21/04/15 17:07, Hartley Sweeten wrote:
On Tuesday, April 21, 2015 6:35 AM, Dan Carpenter wrote:
On Tue, Apr 21, 2015 at 01:52:09PM +0100, Ian Abbott wrote:
Is that really an improvement? The original code was actually defined.
1U << 32 is actually defined. It is zero. Which works for us.
It seems that most all of the comedi code cleanliness
issues have been resolved.
What's left before this is accepted into mainline?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-de
I knew the original was undefined because Ian showed me the relevant
section from the standard. I'm actually surprised that it doesn't work
in GCC. Using -fno-strict-overflow doesn't help either. I think at the
optimizations that the kernel uses -O2 and -Os the original "works".
Anyway, the old
From: "Luis R. Rodriguez"
The same area used for ioremap() is used for the MTRR area.
Convert the driver from using the x86 specific MTRR code to
the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add()
will avoid MTRR if write-combining is available, in order to
take advantage of that al
From: "Luis R. Rodriguez"
The same area used for ioremap() is used for the MTRR area.
Convert the driver from using the x86 specific MTRR code to
the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add()
will avoid MTRR if write-combining is available, in order to
take advantage of that al
From: Simon Xiao
Signed-off-by: Simon Xiao
Reviewed-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h | 3 +++
drivers/net/hyperv/netvsc_drv.c | 8
drivers/net/hyperv/rndis_filter.c | 3 ++-
3 files changed, 13 insertions(+), 1 deletion(-)
diff
From: six...@microsoft.com
Date: Tue, 21 Apr 2015 15:58:05 -0700
> From: Simon Xiao
>
> Signed-off-by: Simon Xiao
> Reviewed-by: K. Y. Srinivasan
> Reviewed-by: Haiyang Zhang
I just gave you feedback on this patch in response to your
original submission, do not ignore it.
___
> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Tuesday, April 21, 2015 2:49 PM
> To: Simon Xiao
> Cc: KY Srinivasan; Haiyang Zhang; de...@linuxdriverproject.org;
> net...@vger.kernel.org; linux-ker...@vger.kernel.org
> Subject: Re: [PATCH net-next,1/1] hv_ne
From: Simon Xiao
Date: Tue, 21 Apr 2015 22:14:14 +
> In current netvsc driver, for each packet received, it will call
> dump_rndis_message() to try to dump the rndis packet information by
> netdev_dbg(). In non-debug mode, dump_rndis_message() will not dump
> anything but it still initialize
This message was created automatically by mail delivery software.
A message that you sent has not yet been delivered to one or more of its
recipients after more than 48 hours on the queue on server.g1novelas.org.
The message identifier is: 1YiPTz-0007Bh-GG
The subject of the message is: Êëèåíò
Dear All,
Thank you kindly in advance for your help. Please forgive any trivial
questions or mistakes by me. I am new to linux (1 month). Hope this is
the proper place for such a question. Here goes.
I have a number of tp-link tl-wn725n usb adapters that I want to use in
laptops. The laptops
The sm750fb's Kconfig option is CONFIG_FB_SM750, not CONFIG_FB_SM7XX.
Thus fix it to make the sm750fb can be built successfully.
Cc: Sudip Mukherjee
Signed-off-by: Binbin Zhou
Reviewed-by: Huacai Chen
---
drivers/staging/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --gi
getname/putname in fs/namei.c is a well-implemented way to copy a file
name from userland, however other ways, such as directly calling
__getname() and strncpy_from_user(), may lack features(e.g. auditing and
reusing), introduce errors or at least reinvent wheels. Therefore for
places need a kernel
As Al Viro pointed out:
https://lkml.org/lkml/2015/4/11/243
There are bugs in ll_getname() because of wrong assumptions of returning
values from strncpy_from_user(). Moreover, what ll_getname want to do is
just to try copy the file name from userland. Since we already have
getname() for the same
As pointed by Al Viro:
https://lkml.org/lkml/2015/4/11/243
There are bugs in ll_getname() because of wrong assumptions of returning
values from strncpy_from_user(). Moreover, what ll_getname want to do is
just to try copy the file name from userland. Since we already have
getname() for the same p
On Wed, Apr 22, 2015 at 11:37:26AM +0800, Binbin Zhou wrote:
> The sm750fb's Kconfig option is CONFIG_FB_SM750, not CONFIG_FB_SM7XX.
> Thus fix it to make the sm750fb can be built successfully.
I always used to build sm750fb and sm7xxfb together, so failed to notice
the error. thanks.
Acked-by: S
On 2015/04/21, 9:50 PM, "Boqun Feng" wrote:
>As pointed by Al Viro:
>
>https://lkml.org/lkml/2015/4/11/243
>
>There are bugs in ll_getname() because of wrong assumptions of returning
>values from strncpy_from_user(). Moreover, what ll_getname want to do is
>just to try copy the file name from use
Nak on exporting symbols for broken staging code. Please get rid of
the ioctls looking up path names in horrible ways in the lustre code.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driver
Dear Sir/Madam ,
Salaam
Please my English is poor read carefully my word ok ,yes I am Houzan
al-Douri ,Son of Ezzat Ibrahim al-Duri,the late Iraqi general,vice
president and former deputy of the late Saddam Hussein before the 2003
US-led invasion on Iraq.My father is suffering from leukemia was
k
On Apr 22, 2015, at 1:53 AM, Christoph Hellwig wrote:
> Nak on exporting symbols for broken staging code. Please get rid of
> the ioctls looking up path names in horrible ways in the lustre code.
For a reference, is there a good example of a non-horrible way to look up a
pathname?
Thanks.
Bye
On Wed, Apr 22, 2015 at 06:27:11AM +, Drokin, Oleg wrote:
> > Nak on exporting symbols for broken staging code. Please get rid of
> > the ioctls looking up path names in horrible ways in the lustre code.
>
> For a reference, is there a good example of a non-horrible way to look up a
> pathna
On Tue, Apr 21, 2015 at 10:53:11PM -0700, Christoph Hellwig wrote:
> Nak on exporting symbols for broken staging code. Please get rid of
> the ioctls looking up path names in horrible ways in the lustre code.
I agree with Christoph, we shouldn't be doing this. Let's fix lustre
"properly", which
Hi, Sudip,
We also get a sm750 kernel driver from Silicon Motion
(http://dev.lemote.com/files/upload/lm/kernel/testing/sm750fb.tar.gz), its
Version is 1.0.8.
I'm not sure whether your driver (which has merged in staging) is newer than
ours, but it seems yours is older (Because there are LINUX_
On Apr 22, 2015, at 2:31 AM, Greg Kroah-Hartman wrote:
> On Tue, Apr 21, 2015 at 10:53:11PM -0700, Christoph Hellwig wrote:
>> Nak on exporting symbols for broken staging code. Please get rid of
>> the ioctls looking up path names in horrible ways in the lustre code.
>
> I agree with Christoph,
On Apr 22, 2015, at 2:31 AM, Christoph Hellwig wrote:
> On Wed, Apr 22, 2015 at 06:27:11AM +, Drokin, Oleg wrote:
>>> Nak on exporting symbols for broken staging code. Please get rid of
>>> the ioctls looking up path names in horrible ways in the lustre code.
>>
>> For a reference, is there
60 matches
Mail list logo
