Re: [PATCH v2 1/2] staging: rtl8723au: core: avoid bitwise arithmetic with forced endianness

2015-06-07 Thread Dan Carpenter
You're CC'ing all the lustre people on this by mistake. Can we find which patch introduced this bug, and add a Fixes: tag and CC whoever introduced it? Please, resend with the correct CC list. regards, dan carpenter ___ devel mailing list de...@linuxd

Re: [PATCH v2 2/2] staging: rtl8723au: core: remove redundant endianness conversion

2015-06-07 Thread Dan Carpenter
On Sat, Jun 06, 2015 at 05:34:00PM -0700, David Decotigny wrote: > Source and destination have the same little-endian annotation: this > patch removes forced conversion from host byte order to little-endian. The patch seems correct but the changelog is a bit wrong. It will change it from little e

Re: [patch] staging: rtl8192e: fix some confusing indenting

2015-06-07 Thread Mateusz Kulikowski
On 05.06.2015 11:24, Dan Carpenter wrote: > The indenting here causes a static checker warning: > > drivers/staging/rtl8192e/rtllib_rx.c:626 RxReorderIndicatePacket() > warn: curly braces intended? > > The code is actually correct, it's just that these lines were pushed in > an extra

Reply

2015-06-07 Thread Santander Bank UK
Dr. Lucas Willmon Operations/Regional Manager Santander Bank Plc, 47-48 Piccadilly PICCADILLY W1J0DT London United Kingdom Hello friend, I am Dr. Lucas Willmon, from Harlesden North West London, Head of Accounting Audit Department and formal senior programmer manager at Deutsche bank, here in

Re: [PATCH 07/11] staging: rtl8192e: Remove dead code: dig_t::dbg_mode

2015-06-07 Thread Mateusz Kulikowski
On 04.06.2015 08:06, Sudip Mukherjee wrote: > On Thu, Jun 04, 2015 at 07:50:07AM +0200, Mateusz Kulikowski wrote: >> On 04.06.2015 07:18, Sudip Mukherjee wrote: >>> On Wed, Jun 03, 2015 at 08:21:02PM +0200, Mateusz Kulikowski wrote: On 03.06.2015 09:26, Sudip Mukherjee wrote: > On Tue, Jun

Re: [PATCH 06/11] staging: rtl8192e: Remove dead code: rtl_dm.[ch]

2015-06-07 Thread Mateusz Kulikowski
On 04.06.2015 15:52, Dan Carpenter wrote: > On Tue, Jun 02, 2015 at 10:48:10PM +0200, Mateusz Kulikowski wrote: >> - Remove unused fields in dig_t structures. Some of them were only >> initialized and never accessed. >> - Remove unused enums/macros/defines in rtl_dm.h >> - Remove duplicated funct

lustre: question about lov_request.c

2015-06-07 Thread Julia Lawall
Hello, The function lov_finish_set in drivers/staging/lustre/lustre/lov/lov_request.c contains the code: if (set->set_pga) { int len = set->set_oabufs * sizeof(*set->set_pga); OBD_FREE_LARGE(set->set_pga, len); } If I change the call to OBD_FREE_LA

Re: lustre: question about lov_request.c

2015-06-07 Thread Drokin, Oleg
Hello! You are right, set_pga seems to be a dead member. It was alive a once, but somehow not fully removed now, so it's safe to drop the whole if and also the struct member itself. set_oabufs could be dropped as well. Thanks. Bye, Oleg On Jun 7, 2015, at 4:11 PM, Julia Lawall wrote

Re: lustre: question about lov_request.c

2015-06-07 Thread Julia Lawall
On Sun, 7 Jun 2015, Drokin, Oleg wrote: > Hello! > > You are right, set_pga seems to be a dead member. It was alive a once, but > somehow not fully removed now, > so it's safe to drop the whole if and also the struct member itself. > set_oabufs could be dropped as well. Thanks. I will do

Re: [PATCH v2 1/2] staging: rtl8723au: core: avoid bitwise arithmetic with forced endianness

2015-06-07 Thread David Decotigny
This was introduced by kernel bulk commit 5e93f3520 "staging: r8723au: Add source files for new driver - part 1", initially from github according to commit description. On github, this traces back to another bulk commit: 2896bda04353 "Add new files in core directory", which is the 1st version of th

[PATCH v2 0/2] staging: rtl8723au: core: endianness issues

2015-06-07 Thread David Decotigny
The code shows a couple inconsistencies (described in commit descriptions) which would not be an issue on little-endian cpus, but could cause breakage on non-LE cpus. Note: I could not test on real hardware, these patches created based on sparse reports. Hostory: - resending the same patches to

[PATCH v2 1/2] staging: rtl8723au: core: avoid bitwise arithmetic with forced endianness

2015-06-07 Thread David Decotigny
This fixes bitwise arithmetic performed on the host on a variable previously converted to little-endian, and subsequently converted again to little-endian: - issue_action_BA23a() called with "status" crafted in host byte order - "status" converted to LE - bitwise arithmetic on the (LE) "statu

[PATCH v2 2/2] staging: rtl8723au: core: remove redundant endianness conversion

2015-06-07 Thread David Decotigny
Source and destination have the same little-endian annotation: this patch removes incorrect byte-swap on non-LE cpus. This addresses the following sparse warning: drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3911:56: warning: incorrect type in argument 1 (different base types) drivers/staging/rt