Re: [PATCH 6/8] Staging: sm750fb: ddk750_sii164.c: Place braces on previous lines

On Fri, Jun 19, 2015 at 12:48:19PM -0700, Isaac Assegai wrote: > Place braces on previous lines in ddk750_sii164.c to > rectify the following checkpatch errors: > ERROR: that open brace { should be on the previous line > > Signed-off-by: Isaac Assegai > --- > drivers/staging/sm750fb/ddk750_sii16

Re: [PATCH v3] staging: sm750fb: use tabs for indentation

On Fri, Jun 19, 2015 at 10:50:57PM -0700, Juston Li wrote: > Replace spaces with tabs for indentation to fix the checkpatch.pl warning > 'WARNING: please, no spaces at the start of a line' > > checkpatch doesn't catch comments indented by spaces but I fixed comments > adjacent to warnings as well

Re: [PATCH v3] staging: sm750fb: use tabs for indentation

On Sat, Jun 20, 2015 at 12:43 AM, Sudip Mukherjee wrote: > On Fri, Jun 19, 2015 at 10:50:57PM -0700, Juston Li wrote: >> Replace spaces with tabs for indentation to fix the checkpatch.pl warning >> 'WARNING: please, no spaces at the start of a line' >> >> checkpatch doesn't catch comments indented

[PATCH 0/4] staging: sm750fb: checkpatch.pl fixes

This patch set includes 4 patches fixing indentation, spacing, brace placement and missing blank lines from checkpatch.pl warnings/errors in staging/sm750fb. Regards Juston - drivers/staging/sm750fb/ddk750_chip.c| 15 +-- drivers/staging/sm750fb/ddk750_chip.h| 12 +- driver

[PATCH] staging: comedi: fix sparse warning in ni_mio_common.c

This patch fixes the following sparse warning: drivers/staging/comedi/drivers/ni_mio_common.c:573:26: warning: shift too big (4294967295) for type int Signed-off-by: Geliang Tang --- drivers/staging/comedi/drivers/ni_mio_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 3/4] staging: sm750fb: fix brace placement

Fix brace placement errors and warnings caught by checkpatch.pl ERROR: that open brace { should be on the previous line WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.h| 12 ++ drivers/staging/sm750fb/ddk7

[PATCH] staging: comedi: fix sparse warning in comedi_compat32.c

This patch fixes the following sparse warning: drivers/staging/comedi/comedi_compat32.c:205:16: warning: cast removes address space of expression Signed-off-by: Geliang Tang --- drivers/staging/comedi/comedi_compat32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

[PATCH 2/4] staging: sm750fb: fix spacing issues

Fix spacing errors and warnings caught by checkpatch.pl ERROR: space prohibited after that open parenthesis '(' ERROR: space required before the open brace '{' ERROR: need consistent spacing around ERROR: trailing whitespace WARNING: unnecessary whitespace before a quoted newline Signed-off-by: Ju

[PATCH 4/4] staging: sm750fb: add missing blank line after declarations

fixes checkpatch.pl WARNING: Missing a blank line after declarations Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.c| 1 + drivers/staging/sm750fb/ddk750_display.c | 2 ++ drivers/staging/sm750fb/ddk750_dvi.c | 1 + drivers/staging/sm750fb/ddk750_mode.c| 3 +++ dri

[PATCH 1/4] staging: sm750fb: use tabs for indentation

Replace spaces with tabs for indentation to fix the checkpatch.pl error ERROR: code indent should use tabs where possible WARNING: please, no spaces at the start of a line Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.c | 100 drivers/staging/sm750fb/ddk750_display

[PATCH v2] staging: media: lirc: fix coding style error

Fix code indentation error by replacing tab in place of spaces. Signed-off-by: Sunil Shahu --- drivers/staging/media/lirc/lirc_sasem.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/lirc/lirc_sasem.c b/drivers/staging/media/lirc/lirc_sasem.c index 8

Re: [PATCH] staging: comedi: fix sparse warning in comedi_compat32.c

On Sat, Jun 20, 2015 at 04:49:13PM +, Geliang Tang wrote: > This patch fixes the following sparse warning: > > drivers/staging/comedi/comedi_compat32.c:205:16: warning: cast removes > address space of expression > > Signed-off-by: Geliang Tang > --- > drivers/staging/comedi/comedi_compat32.

Re: [PATCH 1/4] staging: sm750fb: use tabs for indentation

On Sat, Jun 20, 2015 at 01:48:32AM -0700, Juston Li wrote: > Replace spaces with tabs for indentation to fix the checkpatch.pl error > ERROR: code indent should use tabs where possible > WARNING: please, no spaces at the start of a line > > Signed-off-by: Juston Li > --- > diff --git a/drivers/s

Re: [PATCH 2/4] staging: sm750fb: fix spacing issues

On Sat, Jun 20, 2015 at 01:48:33AM -0700, Juston Li wrote: > Fix spacing errors and warnings caught by checkpatch.pl > ERROR: space prohibited after that open parenthesis '(' > ERROR: space required before the open brace '{' > ERROR: need consistent spacing around > ERROR: trailing whitespace > WAR

Re: doubt about sm7xxfb (was: Re: [PATCH v4 0/7] staging: fsl-mc: New functionality to the MC bus driver)

On Fri, Jun 19, 2015 at 01:29:13PM +0300, Dan Carpenter wrote: > On Sat, Jun 13, 2015 at 02:16:18PM +0530, Sudip Mukherjee wrote: > > > > can you please have a look (when you are free) at it to see if anything > > else needs to be done. > > Remove any unused macros. I will check. > Cleanup indenti

Re: [PATCH 0/6] Staging: comedi: Simplify a trivial if-return sequence

On 19/06/15 06:59, Abdul, Hussain (H.) wrote: This patch simplify a trivial if-return sequence. Possibly combine with a preceding function call. Abdul Hussain (6): staging: comedi: dmm32at: Simplify a trivial if-return sequence staging: comedi: fl512: Simplify a trivial if-return seq

Re: [PATCH] staging: comedi: fix sparse warning in ni_mio_common.c

On 20/06/15 17:47, Geliang Tang wrote: This patch fixes the following sparse warning: drivers/staging/comedi/drivers/ni_mio_common.c:573:26: warning: shift too big (4294967295) for type int Signed-off-by: Geliang Tang --- drivers/staging/comedi/drivers/ni_mio_common.c | 2 +- 1 file changed

[PATCH] staging:rtl8723au:odm.c:Removing trailing whitespaces

From: Joglekar Tejas This patch removes the trailing whitespace error given by checkpatch.pl Signed-off-by: Joglekar Tejas --- drivers/staging/rtl8723au/hal/odm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723a

Re: [PATCH] staging: comedi: fix sparse warning in ni_mio_common.c

On Sat, Jun 20, 2015 at 04:47:33PM +, Geliang Tang wrote: > This patch fixes the following sparse warning: > > drivers/staging/comedi/drivers/ni_mio_common.c:573:26: warning: shift > too big (4294967295) for type int > > Signed-off-by: Geliang Tang > --- > drivers/staging/comedi/drivers/ni_

[PATCH v2] staging: comedi: fix cast warning in comedi_compat32.c

This patch fixes the following sparse warning: drivers/staging/comedi/comedi_compat32.c:205:16: warning: cast removes address space of expression Signed-off-by: Geliang Tang --- Changes in v2: - compat_ptr() is substituted by 'unsigned long'. --- drivers/staging/comedi/comedi_compat32.c | 2 +

Re: [PATCH] staging: comedi: fix sparse warning in comedi_compat32.c

On Sat, Jun 20, 2015 at 04:08:19PM +0530, Sudip Mukherjee wrote: > compat_ptr is already a typecast. > static inline void __user *compat_ptr(compat_uptr_t uptr) > { > return (void __user *)(unsigned long)uptr; > } > > so you are adding another typecast to an already exitsing typecast. :( >

Re: [PATCH 1/4] staging: sm750fb: use tabs for indentation

My apologies, I thought I removed all of those. Fixed for real this time, resending. Regards Juston On Sat, Jun 20, 2015 at 3:45 AM, Sudip Mukherjee wrote: > On Sat, Jun 20, 2015 at 01:48:32AM -0700, Juston Li wrote: >> Replace spaces with tabs for indentation to fix the checkpatch.pl error >> E

[PATCH 03/12] staging: lustre: lclient: Use !x to check for kzalloc failure

!x is more normal for kzalloc failure in the kernel. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression x; statement S1, S2; @@ x = kzalloc(...); if ( - x == NULL + !x ) S1 else S2 // Signed-off-by: Julia Lawall --- drivers/staging/lustr

[PATCH 04/12] staging: lustre: ldlm: Use !x to check for kzalloc failure

!x is more normal for kzalloc failure in the kernel. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression x; statement S1, S2; @@ x = kzalloc(...); if ( - x == NULL + !x ) S1 else S2 // Signed-off-by: Julia Lawall --- drivers/staging/lustr

[PATCH 09/12] staging: lustre: obdclass: Use !x to check for kzalloc failure

!x is more normal for kzalloc failure in the kernel. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression x; statement S1, S2; @@ x = kzalloc(...); if ( - x == NULL + !x ) S1 else S2 // Signed-off-by: Julia Lawall --- drivers/staging/lustr

[PATCH 12/12] staging: lustre: ptlrpc: Use !x to check for kzalloc failure

!x is more normal for kzalloc failure in the kernel. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression x; statement S1, S2; @@ x = kzalloc(...); if ( - x == NULL + !x ) S1 else S2 // Signed-off-by: Julia Lawall --- drivers/staging/lustr

[PATCH 08/12] staging: lustre: mgc: Use !x to check for kzalloc failure

!x is more normal for kzalloc failure in the kernel. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression x; statement S1, S2; @@ x = kzalloc(...); if ( - x == NULL + !x ) S1 else S2 // Signed-off-by: Julia Lawall --- drivers/staging/lustr

[PATCH 10/12] staging: lustre: obdecho: Use !x to check for kzalloc failure

!x is more normal for kzalloc failure in the kernel. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression x; statement S1, S2; @@ x = kzalloc(...); if ( - x == NULL + !x ) S1 else S2 // Signed-off-by: Julia Lawall --- drivers/staging/lustr

[PATCH 02/12] staging: lustre: fld: Use !x to check for kzalloc failure

!x is more normal for kzalloc failure in the kernel. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression x; statement S1, S2; @@ x = kzalloc(...); if ( - x == NULL + !x ) S1 else S2 // Signed-off-by: Julia Lawall --- drivers/staging/lustr

[PATCH 00/12] Use !x to check for kzalloc failure

Use !x to check for kzalloc failure, as is more normal in the kernel. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 07/12] staging: lustre: mdc: Use !x to check for kzalloc failure

!x is more normal for kzalloc failure in the kernel. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression x; statement S1, S2; @@ x = kzalloc(...); if ( - x == NULL + !x ) S1 else S2 // Signed-off-by: Julia Lawall --- drivers/staging/lustr

[PATCH 06/12] staging: lustre: lov: Use !x to check for kzalloc failure

!x is more normal for kzalloc failure in the kernel. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression x; statement S1, S2; @@ x = kzalloc(...); if ( - x == NULL + !x ) S1 else S2 // Signed-off-by: Julia Lawall --- drivers/staging/lustr

[PATCH 01/12] staging: lustre: fid: Use !x to check for kzalloc failure

!x is more normal for kzalloc failure in the kernel. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression x; statement S1, S2; @@ x = kzalloc(...); if ( - x == NULL + !x ) S1 else S2 // Signed-off-by: Julia Lawall --- drivers/staging/lustr

[PATCH 05/12] staging: lustre: lmv: Use !x to check for kzalloc failure

!x is more normal for kzalloc failure in the kernel. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression x; statement S1, S2; @@ x = kzalloc(...); if ( - x == NULL + !x ) S1 else S2 // Signed-off-by: Julia Lawall --- drivers/staging/lustr

[PATCH 11/12] staging: lustre: osc: Use !x to check for kzalloc failure

!x is more normal for kzalloc failure in the kernel. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression x; statement S1, S2; @@ x = kzalloc(...); if ( - x == NULL + !x ) S1 else S2 // Signed-off-by: Julia Lawall --- drivers/staging/lustr

[PATCH] staging: i2o: iop.c: Fix pointer declarations

Kernel coding style dictates that pointer declarations have the asterisk next to the data name. Signed-off-by: Joseph Kogut --- drivers/staging/i2o/iop.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/i2o/iop.c b/drivers/staging/i2o/iop.c index 23bdbe4.

[PATCH 2/5] staging: lustre: llite: drop trivially useless initialization

Remove initialization of a variable that is immediately reassigned. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ type T; identifier x; constant C; expression e; @@ T x - = C ; x = e; // Signed-off-by: Julia Lawall --- drivers/staging/lustre/l

[PATCH 1/5] staging: lustre: libcfs: drop trivially useless initialization

Remove initialization of a variable that is immediately reassigned. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ type T; identifier x; constant C; expression e; @@ T x - = C ; x = e; // Signed-off-by: Julia Lawall --- drivers/staging/lustre/l

[PATCH 0/5] drop trivially useless initialization

These patches remove initializations of variables that are immediately reassigned. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 3/5] staging: lustre: lmv: drop trivially useless initialization

Remove initialization of a variable that is immediately reassigned. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ type T; identifier x; constant C; expression e; @@ T x - = C ; x = e; // Signed-off-by: Julia Lawall --- drivers/staging/lustre/l

[PATCH 5/5] staging: lustre: osc: drop trivially useless initialization

Remove initialization of a variable that is immediately reassigned. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ type T; identifier x; constant C; expression e; @@ T x - = C ; x = e; // Signed-off-by: Julia Lawall --- drivers/staging/lustre/l

[PATCH 4/5] staging: lustre: obdclass: llog: drop trivially useless initialization

Remove initialization of a variable that is immediately reassigned. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ type T; identifier x; constant C; expression e; @@ T x - = C ; x = e; // Signed-off-by: Julia Lawall --- drivers/staging/lustre/l

[PATCH] staging: comedi: don't split Author string

fixes checkpatch.pl WARNING: quoted string split across lines +MODULE_AUTHOR("David A. Schleef , " + "Frank Mori Hess "); total: 0 errors, 1 warnings, 114 lines checked Modules with multiple authors have a MODULE_AUTHOR line for each one. Signed-off-by: Luis de Bethencourt --- dri

[PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors

Fix checkpatch.pl "space required before the open parenthesis '('" errors Signed-off-by: Greg Donald --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 97 ++ 1 file changed, 44 insertions(+), 53 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTPr

randconfig build error with next-20150620, in drivers/staging/board/board.c

Building with the attached random configuration file, drivers/built-in.o: In function `board_staging_register_clock': /home/jim/linux/drivers/staging/board/board.c:131: undefined reference to `clk_add_alias' # # Automatically generated file; DO NOT EDIT. # Linux/x86 4.1.0-rc8 Kernel Configuration

Re: [PATCH 5/5] staging: lustre: osc: drop trivially useless initialization

On 20 June 2015 at 21:07, Julia Lawall wrote: > Remove initialization of a variable that is immediately reassigned. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > type T; > identifier x; > constant C; > expression e; > @@ > > T x > - = C

Re: [PATCH 5/5] staging: lustre: osc: drop trivially useless initialization

On Sat, 20 Jun 2015, Joachim Eastwood wrote: > On 20 June 2015 at 21:07, Julia Lawall wrote: > > Remove initialization of a variable that is immediately reassigned. > > > > The semantic patch that makes this change is as follows: > > (http://coccinelle.lip6.fr/) > > > > // > > @@ > > type T; > >

[PATCH] Staging: wilc1000: Replace memset with eth_zero_addr

Use eth_zero_addr to assign the zero address to the given address array instead of memset when second argument is address of zero. The Coccinelle semantic patch that makes this change is as follows: // @eth_zero_addr@ expression e; @@ -memset(e,0x00,ETH_ALEN); +eth_zero_addr(e); // Signed-off

Re: randconfig build error with next-20150620, in drivers/staging/board/board.c

On Sat, Jun 20, 2015 at 5:40 PM, Jim Davis wrote: > Building with the attached random configuration file, > > drivers/built-in.o: In function `board_staging_register_clock': > /home/jim/linux/drivers/staging/board/board.c:131: undefined reference > to `clk_add_alias' Should be fixed once this get