From: Anders Fridlund
This is a patch to the cl_page.c file that fixes a
"space required after that ','" error found by the checkpatch.pl tool.
Signed-off-by: Anders Fridlund
---
drivers/staging/lustre/lustre/obdclass/cl_page.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: Anders Fridlund
This is a patch to the ddk750_dvi.h file that fixes up a brace error
found by the checkpatch.pl tool
Signed-off-by: Anders Fridlund
---
drivers/staging/sm750fb/ddk750_dvi.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk75
On Wed, 2015-07-08 at 22:59 -0700, Greg KH wrote:
> On Thu, Jul 09, 2015 at 08:20:57AM +0530, rcodin wrote:
> > Fixed a coding style issue.
[]
> > diff --git a/drivers/staging/android/ion/ion.c
> > b/drivers/staging/android/ion/ion.c
[]
> @@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(st
---
drivers/staging/lustre/lustre/obdclass/cl_page.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c
b/drivers/staging/lustre/lustre/obdclass/cl_page.c
index a7f3032..428c6b2 100644
--- a/drivers/staging/
---
drivers/staging/lustre/lustre/obdclass/cl_page.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c
b/drivers/staging/lustre/lustre/obdclass/cl_page.c
index a7f3032..428c6b2 100644
--- a/drivers/staging/
On Thu, Jul 09, 2015 at 12:57:56AM +0800, Incarnation P. Lee wrote:
> ---
> drivers/staging/lustre/lustre/obdclass/cl_page.c | 21 +++--
> 1 file changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c
> b/drivers/staging/lustr
On Wed, Jul 08, 2015 at 05:27:38PM +0200, SF Markus Elfring wrote:
> > Note also that some maintainers have work flow that deliberately smash
> > the date (i.e., because they are using a system such as guilt),
> > so if you are depending on the submitted timestamp, it's going to
> > break on you.
>
From: Tim Sell
A struct visornic_devdata for each visornic device is actually allocated as
part of alloc_etherdev(), here in visornic_probe():
netdev = alloc_etherdev(sizeof(struct visornic_devdata));
But code in devdata_release() was treating devdata as a pointer that needed
to be kfree()d
From: Tim Sell
Prevent faults in visornic_pause, visornic_resume(), and visornic_remove()
Prior to this patch, any call to visornic_pause(), visornic_resume(), or
visornic_remove() would fault, due to dev_set_drvdata() never having been
called to stash our struct visornic_devdata * into the devi
From: Tim Sell
Correct visornic_pause() to indicate completion asynchronously rather
than in-line
Previously, visornic_pause() (called to stop the device due to IOVM service
partition recovery) was calling the passed complete_func() in-line, rather
than delaying the calling until after the devic
From: Tim Sell
Prevent faults processing messages for devices that no driver has yet
registered to handle.
Previously, code of the form:
drv = to_visor_driver(dev->device.driver);
if (!drv)
goto away;
was not having the desired intent, because to_visor_driver() was
essentially
From: Tim Sell
Looks like an errant patch fitting caused us to redundantly allocate the
workqueues at both the beginning and end of visornic_init(). This was
corrected by removing the allocations at the beginning.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
drivers/staging/unis
From: Tim Sell
visornic_cleanup() was previously incorrectly destroying its global
workqueues prior to cleaning up the devices which used them. This patch
corrects the order of these operations.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visornic/visorni
From: David Kershner
We inadvertently remove the MODULE_DEVICE_TABLE line for visorbus,
this patch adds it back in.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorchipset.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/sta
From: Tim Sell
visornic_remove() is called to logically detach the visornic driver from a
visorbus-supplied device, which can happen either just prior to a
visorbus-supplied device disappearing, or as a result of an rmmod of
visornic. Prior to this patch, logic was missing to properly clean up f
From: Tim Sell
Just switch this line so it uses the correct function call.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visornic/visornic_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visornic/visornic_mai
From: Tim Sell
Add error message to genuine rare error paths, and debug messages
to enable relatively non-verbose tracing of code paths
You can enable debug messages by including this on the kernel command line:
visornic.dyndbg=+p
or by this from the command line:
echo "module visorni
From: Tim Sell
This only makes sense, since the worker thread depends upon the netdev
existing.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visornic/visornic_main.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers
From: Tim Sell
Neglect to NULL rcvbuf pointer array could result in faults later
This problem would exhibit itself as a fault when when attempting to stop
any visornic device (i.e., in visornic_disable_with_timeout() or
visornic_serverdown_complete()) that had never been started (i.e., for
which
This patch set contains fixes for visorbus and visornic, and adds
appropriate error messages to the visornic driver.
David Kershner (1):
staging: unisys: Allow visorbus to autoload
Tim Sell (12):
staging: unisys: respond to msgs post device_create
staging: unisys: prevent faults processing
From: Tim Sell
Fix problem that prevents us from responding to any device message after
device_create.
By neglecting to NULL out pending_msg_hdr after the device_create response,
we were effectively preventing any subsequent messages to the device from
working, because device_epilog() will corre
From: Ken Cox
When building with ARCH=um you get the following error:
arch/x86/include/asm/cpufeature.h:252:42: error: 'REQUIRED_MASK0'
undeclared
The Unisys drivers should not be compiled for UML, so this patch addresses
that by adding a dependency to kconfig for !UML.
Reported-by: kb
From: Jacob Kiefer
Style fix for octeon/ethernet-tx.c
Signed-off-by: Jacob Kiefer
---
drivers/staging/octeon/ethernet-tx.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/octeon/ethernet-tx.c
b/drivers/staging/octeon/ethernet-tx.c
index 7c1c1b0..
On Thu, Jul 09, 2015 at 08:46:04PM -0400, Jacob Kiefer wrote:
> From: Jacob Kiefer
No need to mention this From: as it will come from the email header.
>
> Style fix for octeon/ethernet-tx.c
Please mention which style you have fixed.
regards
sudip
___
On Thu, Jul 09, 2015 at 11:02:09AM +0200, anders.fridl...@gmail.com wrote:
> From: Anders Fridlund
No need to mention this From: here. Please fix your .gitconfig so that
git send-email will put your name in the email From: header.
regards
sudip
___
deve
Broke line with greater than 80 characters into two lines and
improved logical operator readability in hardware checksum if statement.
Signed-off-by: Jacob Kiefer
---
drivers/staging/octeon/ethernet-tx.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/stagi
On Thu, Jul 09, 2015 at 02:45:22PM +0200, anders.fridl...@gmail.com wrote:
> From: Anders Fridlund
same comment that I gave to your another patch.
"No need to mention this From: here. Please fix your .gitconfig so that
git send-email will put your name in the email From: header."
regards
sudip
__
Hello Greg.
This driver convert pointer address to integer value and use it
as function argument. because the value has a limited 32bit size,
current driver happen many issues on x64 machine.
I have split it up enough sensibliy to allow review. If this patches
are accepted, I will update more pat
Last argument of wilc_wlan_cfg_set function is actually structure's address.
This should be changed to be compatible with 64bit machine.
Because wilc_wlan_cfg_set function is mapped by function pointer later,
wilc_wlan_oup_t.wlan_cfg_set should be changed together.
tstrWILC_WFIDrv structure is def
A argument of wilc_wlan_cfg_commit() is address of structure.
But because the size is restricted to 32bit, it is not correct
for 64bit machine.
So, this changes the interger value to obvious structure pointer.
Signed-off-by: Johnny Kim
---
drivers/staging/wilc1000/wilc_wlan.c | 8
1 fi
Last argument of wilc_wlan_cfg_get function is actually structure's address.
This should be changed to be compatible with 64bit machine.
Because wilc_wlan_cfg_get function is mapped by function pointer later,
wilc_wlan_oup_t.wlan_cfg_get should be changed together.
tstrWILC_WFIDrv structure is def
This patch replaces a integer argument of SendConfigPkt function with
void type pointer and fix code that the function is called.
Because tstrWILC_WFIDrv structure is defined after SendConfigPkt function
is defined, the function can not refer to the structure type.
So this patch change the argumen
gu8FlushedJoinReqDrvHandler variable is be using to save structure pointer.
But because that is restricted to 32bit and has needless casting,
the varibale should be changed to pointer of same type.
Signed-off-by: Johnny Kim
---
drivers/staging/wilc1000/host_interface.c | 16
1 f
Hi Johnny,
On Fri, Jul 10, 2015 at 3:55 PM, Johnny Kim wrote:
> A argument of wilc_wlan_cfg_commit() is address of structure.
> But because the size is restricted to 32bit, it is not correct
> for 64bit machine.
>
> So, this changes the interger value to obvious structure pointer.
>
> Signed-off-
Hi Johnny,
On Fri, Jul 10, 2015 at 3:55 PM, Johnny Kim wrote:
> Last argument of wilc_wlan_cfg_get function is actually structure's address.
> This should be changed to be compatible with 64bit machine.
> Because wilc_wlan_cfg_get function is mapped by function pointer later,
> wilc_wlan_oup_t.wl
On Thu, Jul 09, 2015 at 01:27:47PM -0400, Benjamin Romer wrote:
> From: Tim Sell
>
> Looks like an errant patch fitting caused us to redundantly allocate the
> workqueues at both the beginning and end of visornic_init(). This was
> corrected by removing the allocations at the beginning.
>
> Sig
Hi Johnny,
On Fri, Jul 10, 2015 at 3:55 PM, Johnny Kim wrote:
> Last argument of wilc_wlan_cfg_set function is actually structure's address.
> This should be changed to be compatible with 64bit machine.
> Because wilc_wlan_cfg_set function is mapped by function pointer later,
> wilc_wlan_oup_t.wl
Hi Johnny,
On Fri, Jul 10, 2015 at 3:55 PM, Johnny Kim wrote:
> This patch replaces a integer argument of SendConfigPkt function with
> void type pointer and fix code that the function is called.
>
> Because tstrWILC_WFIDrv structure is defined after SendConfigPkt function
> is defined, the funct
i2c_driver does not need to set an owner because i2c_register_driver()
will set it.
Signed-off-by: Krzysztof Kozlowski
---
The coccinelle script which generated the patch was sent here:
http://www.spinics.net/lists/kernel/msg2029903.html
---
drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c | 1 -
i2c_driver does not need to set an owner because i2c_register_driver()
will set it.
Signed-off-by: Krzysztof Kozlowski
---
The coccinelle script which generated the patch was sent here:
http://www.spinics.net/lists/kernel/msg2029903.html
---
drivers/staging/iio/addac/adt7316-i2c.c | 1 -
drive
Hi,
The i2c drivers also do not have to set 'owner' field because
i2c_register_driver() will do it instead.
'owner' is removed from i2c drivers, which I was able to compile
with allyesconfig (arm, arm64, i386, x86_64, ppc64).
Only compile-tested.
The coccinelle script which generated the patch
i2c_driver does not need to set an owner because i2c_register_driver()
will set it.
Signed-off-by: Krzysztof Kozlowski
---
The coccinelle script which generated the patch was sent here:
http://www.spinics.net/lists/kernel/msg2029903.html
---
drivers/staging/media/lirc/lirc_zilog.c | 1 -
drive
Sorry, for that. Do I need to re-submit the patch(es), or should I
only change it for future patches?
Cheers,
Anders Fridlund
On Fri, Jul 10, 2015 at 7:33 AM, Sudip Mukherjee
wrote:
> On Thu, Jul 09, 2015 at 02:45:22PM +0200, anders.fridl...@gmail.com wrote:
>> From: Anders Fridlund
> same comm
43 matches
Mail list logo
