This patche removes the extra braces found in
drivers/staging/media/lirc/lirc_imon.c to fix the warning thrown by
checkpatch.pl
Signed-off-by: Pradheep Shrinivasan
---
drivers/staging/media/lirc/lirc_imon.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/stagi
This fix changes the space in the code to tab to fix the ERROR
"ERROR: code indent should use tabs where possible"
Signed-off-by: Pradheep Shrinivasan
---
drivers/staging/media/lirc/lirc_sasem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/lirc/lirc_s
On 04/08/15 18:57, H Hartley Sweeten wrote:
The 'board' pointer is only used in this function to verify that the
'chan' is valid for an aref of AREF_DIFF. The comedi core ensures that
that aref is only possible if the subdevice has the SDF_DIFF subdevice_flag
set. If so, the maximum channel is ha
On 04/08/15 18:57, H Hartley Sweeten wrote:
The maximum differential channel is half the subdevice 'n_chan'. Use
that instead and remove the need for the 'board' variable.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000.c | 4 +---
1 file changed, 1 insertion(+), 3
On 04/08/15 18:57, H Hartley Sweeten wrote:
This define evaluates to 0 and is OR'ed with the 'entry' value that is
written to the ME4000_AI_CHANNEL_LIST_REG when the channel aref is a
single-ended type (AREF_GROUND or AREF_COMMON). OR'ing a zero value is
pretty silly, just remove it.
Simplify me
Top posting ;) Greg -- I know you're busy but I just wanted to make sure you
didn't miss this question re: drivers/staging and patches that touch other areas
of the kernel.
Thanks!
P.
On 08/03/2015 01:21 PM, Prarit Bhargava wrote:
> On 07/31/2015 07:07 PM, Greg KH wrote:> On Fri, Jul 24, 2015 a
On 04/08/15 18:57, H Hartley Sweeten wrote:
The comedi_lrange table for the analog inputs is inverted compared
to the values that need to be written to the ME4000_AI_CHANNEL_LIST_REG
to select the range.
Create a macro, ME4000_AI_LIST_RANGE(), to handle the inversion. Remove
the old defines and
On Wed, Aug 5, 2015 at 3:15 PM, Lars Svensson
wrote:
> Fixing indentation errors in
> drivers/staging/iio/iio_simple_dummy_events.c.
>
> Signed-off-by: Lars Svensson
Good catch.
Acked-by: Daniel Baluta
> ---
> drivers/staging/iio/iio_simple_dummy_events.c | 4 ++--
> 1 file changed, 2 inser
Fixing indentation errors in
drivers/staging/iio/iio_simple_dummy_events.c.
Signed-off-by: Lars Svensson
---
drivers/staging/iio/iio_simple_dummy_events.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/iio_simple_dummy_events.c
b/drivers/staging/iio/
On 04/08/15 18:57, H Hartley Sweeten wrote:
The coemdi (*insn_read) functions are supposed to read insn->n values
from the hardware. Make this function work like the core expects.
Use the comedi_offset_munge() helper to munge the two's complement
values to offset binary.
My guess would be that
On 04/08/15 18:58, H Hartley Sweeten wrote:
There is no real reason to reset the board when detaching. But the PLX
interrupts should be disabled. Currently the PLX interrupt is left
enabled when the driver is detached.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000
Use __acquire() and __release() in the right place to silence the sparse
lock checking warning.
drivers/staging/sm750fb/sm750.c:177:13: warning: context imbalance in
'lynxfb_ops_fillrect' - different lock contexts for basic block
drivers/staging/sm750fb/sm750.c:243:9: warning: context imbalance i
fixed coding style issue by replacing ENOSYS
with EIO because it means 'invalid syscall nr'
and nothing else.
Signed-off-by: Ted Chen
---
drivers/staging/comedi/drivers.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/com
On 04/08/15 15:56, Ted Chen wrote:
fixed coding style issue by replacing ENOSYS
with EIO because it means 'invalid syscall nr'
and nothing else.
Signed-off-by: Ted Chen
---
drivers/staging/comedi/drivers.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging
Hi all,
Please consider applying the following patch. It fixes some
sparse-warning related to global variable not being correctly declared.
Applies to linux-next/next-20150804.
Best Regards,
--
Patrick.
>From b04a87fd78f5e0dcdfe83362df367e4c244a4e3e Mon Sep 17 00:00:00 2001
From: Patrick Boettch
Hi all,
Please consider applying the following patch. It fixes some
sparse-warning related to global variable not being correctly declared.
This is a resent with the patch inline. Greg's bot was picky about it
for a reason!
Applies to linux-next/next-20150804.
>From b04a87fd78f5e0dcdfe83
On Wed, Aug 05, 2015 at 05:26:22PM +0200, Patrick Boettcher wrote:
> Hi all,
>
> Please consider applying the following patch. It fixes some
> sparse-warning related to global variable not being correctly declared.
>
> This is a resent with the patch inline. Greg's bot was picky about it
> for a
On Wednesday, August 05, 2015 4:38 AM, Ian Abbott wrote:
> On 04/08/15 18:57, H Hartley Sweeten wrote:
>> The 'board' pointer is only used in this function to verify that the
>> 'chan' is valid for an aref of AREF_DIFF. The comedi core ensures that
>> that aref is only possible if the subdevice has
fixed coding style issue by replacing ENOSYS
with EIO because it means 'invalid syscall nr'
and nothing else.
Signed-off-by: Ted Chen
---
drivers/staging/comedi/drivers.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/com
v2 - Resending as v1 patch series did not apply cleanly.
These patches fixes a few style errors reported by checkpatch.pl.
PATCH 3/3 should be applied after PATCH 2/3.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproje
The character ' ' is removed after the character '('. This fixes the
checkpatch.pl error - "space prohibited after that open
parenthesis '('".
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_w
Added 'void' keyword in the paranthesis of function definitions, when
there are no arguments to the functions. This fixes the checkpatch.pl
error - "Bad function definition 'function()' should probably be
function(void)".
---
drivers/staging/wilc1000/linux_mon.c | 2 +-
drivers/staging/wilc1000
Moved the opening brace of code blocks to the previous lines. This
fixes the checkpatch.pl error - "that open brace { should be on the
previous line".
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/stagin
On 04/08/15 18:18, Ted Chen wrote:
fixed coding style issue by replacing ENOSYS
with EIO because it means 'invalid syscall nr'
and nothing else.
Signed-off-by: Ted Chen
---
drivers/staging/comedi/drivers.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging
On Wed, Aug 05, 2015 at 09:43:00PM +0530, Chandra S Gorentla wrote:
> Added 'void' keyword in the paranthesis of function definitions, when
> there are no arguments to the functions. This fixes the checkpatch.pl
> error - "Bad function definition 'function()' should probably be
> function(void)".
Added 'void' keyword in the paranthesis of function definitions, when
there are no arguments to the functions. This fixes the checkpatch.pl
error - "Bad function definition 'function()' should probably be
function(void)".
Signed-off-by: Chandra S Gorentla
---
drivers/staging/wilc1000/linux_mon.
v3 - Resending as v2 patch was series missing signedoff line. Corrected now.
v2 - Resending as v1 patch series did not apply cleanly.
These patches fixes a few style errors reported by checkpatch.pl.
PATCH 3/3 should be applied after PATCH 2/3.
___
dev
Moved the opening brace of code blocks to the previous lines. This
fixes the checkpatch.pl error - "that open brace { should be on the
previous line".
Signed-off-by: Chandra S Gorentla
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 9 +++--
1 file changed, 3 insertions(+), 6 deleti
The character ' ' is removed after the character '('. This fixes the
checkpatch.pl error - "space prohibited after that open
parenthesis '('".
Signed-off-by: Chandra S Gorentla
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --gi
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/range.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/range.c b/drivers/staging/comedi/range.c
index 6a393b2..ce3a58a 100644
--- a/drivers/staging/comedi/range.c
+++ b/drivers/staging/c
On Wednesday, August 05, 2015 10:13 AM, Ian Abbott wrote:
>
> Signed-off-by: Ian Abbott
> ---
> drivers/staging/comedi/range.c | 13 -
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/range.c b/drivers/staging/comedi/range.c
> index 6a393b2..ce
All the boards supported by this driver have 32 digital I/O channels.
Remove the unnecessary boardinfo.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 38 +++--
1 file changed, 8 insertions(+), 30
All the boards supported by this driver have analog inputs. They just
differ in the number of channels (32 or 16).
Always initialize the analog input subdevice in me4000_auto_attach().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me
Here's the big cleanup series for the Comedi me4000 driver.
This fixes all the checkpatch issues and removes a bunch of cruft
from the driver.
v2: Address some issues pointed out by Ian Abbott, the comedi core
does not validate the 'aref' so the driver needs to handle it.
H Hartley Sweeten (
Some of the boards supported by this driver do not have differential analog
inputs. Only set the SDF_DIFF subdev_flag when the board supports it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 4 +++-
1 file changed, 3 inser
The comedi core validates that the 'chan' is valid for the subdevice
before calling the (*insn_read) operation. Remove the unnecessary check.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 5 -
1 file changed, 5 deletion
The 'board' pointer is only used in this function to verify that the
'chan' is valid for an aref of AREF_DIFF. For differential inputs, the
maximum channel is half the subdevice 'n_chan'. Use that instead and
remove the 'board' variable.
Also, the comedi core does not validate the aref flags. Add
The maximum differential channel is half the subdevice 'n_chan'. Use
that instead and remove the need for the 'board' variable.
Also, the comedi core does no validate the aref flags. Add a check
to ensure that the subdevice actually supports the AREF_DIFF mode.
Signed-off-by: H Hartley Sweeten
C
Change the boardinfo 'has_counter' and 'ai_trig_analog' flags into
bit-fields to save a bit of space.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drive
This member of the boardinfo is only used as a flag indicating that the
board supports differential analog inputs. Convert the member to a bit-
field to save a bit of space. For aesthetics, rename the member to
'can_do_diff_ai'.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hart
Some of the boards supported by this driver can do analog input sample &
hold on 8 of the channels. The 'ai_sh_nchan' member of the boardinfo is
used to indicate which boards support this feature. To save a bit of space,
convert this member to a bit-field, 'can_do_sh_ai'. Note, this feature is
not
For the boards that have analog output capability, there are always
4 analog output channels. Convert the 'ao_nchan' member of the boardinfo
into a bit-field, 'has_ao', to save a bit of space and set the analog
output subdevice 'n_chan' to 4 when supported.
Signed-off-by: H Hartley Sweeten
Cc: Ia
In comedi drivers the local variable used for the dev->private pointer is
normally named 'devpriv'. For aesthetics, rename the variables in this
driver. Also, rename the struct to follow the norm.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi
This define evaluates to 0 and is OR'ed with the 'entry' value that is
written to the ME4000_AI_CHANNEL_LIST_REG when the channel aref is a
single-ended type (AREF_GROUND or AREF_COMMON). OR'ing a zero value is
pretty silly, just remove it.
Remove the switch() in me4000_ai_insn_read() to simplify
This member of the boardinfo is always '4' for the boards that have an
analog output FIFO. Covert it to a bit-field, 'has_ao_fifo', to save a
bit of space.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 10 +-
1 file
The comedi_lrange table for the analog inputs is inverted compared
to the values that need to be written to the ME4000_AI_CHANNEL_LIST_REG
to select the range.
Create a macro, ME4000_AI_LIST_RANGE(), to handle the inversion. Remove
the old defines and simplify the code a bit.
Signed-off-by: H Har
Rename this function so it has namespace associated with the driver.
The last entry of the chanlist needs the ME4000_AI_LIST_LAST_ENTRY bit
set to end the list. Fix the function and tidy if up a bit.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/co
Use the BIT() macro to define the bits of this register.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/me4000.c
b/drivers
Use the comedi_timeout() helper to busy-wait for the analog input end-of-
conversion instead of the udelay().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 27 ---
1 file changed, 16 insertions(+), 1
The chanspec channel, range, and aref are unsigned int values. Use the
correct types when extracting them.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --gi
Use the helper function to check the range type instead of relying on the
value. For aesthetics, rename the local variable used for the range.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 9 -
1 file changed, 4 ins
The coemdi (*insn_read) functions are supposed to read insn->n values
from the hardware. Make this function work like the core expects.
Use the comedi_offset_munge() helper to munge the two's complement
values to offset binary.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hart
Use the BIT() marco to define the bits of this register.
For aesthetics, rename all the defines to remove the '_BIT' from the
name. Also, use ME4000_AI_STATUS_REG instead of ME4000_AI_CTRL_REG
when reading the register (they happen to be the same).
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Use the BIT() marco to define the bits of this register.
For aesthetics, rename all the defines to remove the '_BIT' from the
name.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 123
1 file
Use the BIT() marco to define the bits of this register.
For aesthetics, rename all the defines to remove the '_BIT' from the
name.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 20 ++--
1 file changed, 10
Use the BIT() marco to define the bits of this register.
For aesthetics, rename all the defines to remove the '_BIT' from the
name.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 25 -
1 file changed
Use the BIT() marco to define the bits of this register.
For aesthetics, rename all the defines to remove the '_BIT' from the
name.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 8
1 file changed, 4 insertions(+),
Use the BIT() marco to define the bits of this register.
For aesthetics, rename all the defines to remove the '_BIT' from the
name.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 51 -
1 file
The ai (*do_cmd_test) validates the trigger sources in Step 2b to ensure
that they are compatible. Save the 'ai_ctrl_mode' that will be used in the
private data so that ai_prepare(), which is called by the ai (*do_cmd),
does not have to recheck the sources in order to figure it out.
Also, tidy up
This function is only called by me4000_ai_do_cmd(). Absorb it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 35 +
1 file changed, 14 insertions(+), 21 deletions(-)
diff --git a/drivers/stag
This function always succeeds. Change the return type to void and
remove the unnecessary error check in me4000_ai_do_cmd().
Move the function call in me4000_ai_do_cmd_test() from before Step 1
to Step 3 where the arguments are validated. There is no reason to
get the values if the previous steps f
The ai (*do_cmd_test) calls me4000_ai_round_cmd_args() to calculate the
timing values needed to the command. The the command test passes, the
core will then call the ai (*do_cmd) which then has to call
me4000_ai_round_cmd_args() again in order to get the same values to
pass to ai_prepare() in order
This function never fails and it's only called by me4000_ai_do_cmd().
Absorb it and remove the unnecessary failure check.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 31 +--
1 file changed, 9
This function always returns 0 and the return value is never checked.
Just return void.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/staging
The me4000_ai_cancel() already reset this register.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/me4000.c
b/drivers/staging/comedi/drivers
The STOP and IMMEDIATE_STOP bits in the ME4000_AI_CTRL_REG should be set,
not cleared, to stop any running conversions.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 8
1 file changed, 4 insertions(+), 4 deletions(
Reset the analog input control register after ensuring that any active
conversions have been stopped. This mimics what the ai subdevice (*cancel)
does.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 3 +++
1 file changed, 3
Introduce a helper function to stop any ai conversions and reset the
ai control register. This consolidates the common code in me4000_reset()
and me4000_ai_cancel().
Use the new helper in the ai (*insn_read) to ensure that the ai control
register is set to a known state after reading the samples.
The comedi core ensures that the subdevice is not busy before it allows
starting a new command. The subdevice (*cancel) is called when the
subdevice is set to not busy. In this driver the me4000_ai_cancel()
is the ai (*cancel) so the extra call in the ai (*do_cmd) is not
necessary. Remove it.
Sign
For aesthetics, add some white space to the analog output subdevice
initialization.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 20
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/drive
Currently me4000_reset() always enables the PLX interrupt. Move the
enable of the interrupt into me4000_auto_attach() and only do the
enable if we actually have and irq.
Make sure the PLX interrupt is disabled in me4000_reset() before we
try to request the irq.
Signed-off-by: H Hartley Sweeten
C
The irq handler does not need to manually stop conversions and disable
interrupts when "end-of-acquisition", "error", or "overflow" events are
detected. The comedi_handle_events() will call the subdevice (*cancel)
when these are detected and stop the acquisition.
Signed-off-by: H Hartley Sweeten
The hardware returns two's complement values for the analog input
samples. These need to be converted to the unsigned binary format
that the comedi core expects. Introduce a helper function to handle
this.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/stagi
There is no real reason to reset the board when detaching. The comedi core
will ensure that any commands are canceled before the detach.
But the PLX interrupts should be disabled.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.
Firmware loading was fixed by:
Commit: ac584af5
"staging: comedi: me4000: fix firmware downloading"
Change the driver status to "untested" and remove the comments about
the driver being broken,
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/
Format the multi-line comments in the kernel CodingStyle.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 74 -
1 file changed, 37 insertions(+), 37 deletions(-)
diff --git a/drivers/staging/c
Fix checkpatch issue: "CHECK: usleep_range is preferred over udelay; see
Documentation/timers/timers-howto.txt". `udelay()` is only used in the
firmware upload process. Replace them with `usleep_range()` with a
reasonable upper limit.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kr
Change the MODULE_DESCRIPTION to something more useful than "Comedi low-
level driver"
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/d
On Mon, Aug 03, 2015 at 08:26:40AM +, Wang, Biao wrote:
> Consider the following case:
> Task A trigger lmk with a lock held, while task B try to get this lock, but
> unfortunately B is the very culprit task lmk select to kill. Then B will
> never be killed, and A will forever select B to kil
On Wed, Aug 05, 2015 at 03:18:04AM +0530, Shraddha Barke wrote:
> This patch introduces the use of the function usb_endpoint_type.
>
> The Coccinelle semantic patch that makes these changes is as follows:
>
> @@ struct usb_endpoint_descriptor *epd; @@
>
> - (epd->bmAttributes & \(USB_ENDPOINT_XF
On Wed, Aug 05, 2015 at 01:24:52PM +0800, Navy Cheng wrote:
> The waring message will mislead developers and users. This will cause a
> potential damage. Fix the waring message to give developers and users the
> correct guidance.
"waring"?
>
> Signed-off-by: Navy Cheng
> ---
> drivers/stagin
On Wed, Aug 05, 2015 at 09:26:44PM +0800, Peng Fan wrote:
> Use __acquire() and __release() in the right place to silence the sparse
> lock checking warning.
>
> drivers/staging/sm750fb/sm750.c:177:13: warning: context imbalance in
> 'lynxfb_ops_fillrect' - different lock contexts for basic block
This patch fixes checkpatch.pl warning,
all warnings are releted to comments code style.
---
drivers/staging/panel/panel.c | 38 +-
1 file changed, 25 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
ind
On Tue, 4 Aug 2015 20:44:53 +0200
Adrian Remonda wrote:
> This is a patch to the most/hdm-usb/hdm_usb.c file. It
> makes several local functions and structures static to prevent global
> visibility.
>
> Signed-off-by: Adrian Remonda
> ---
> drivers/staging/most/hdm-usb/hdm_usb.c | 16 -
On Mon, Jul 06, 2015 at 01:31:47PM +0100, Martyn Welch wrote:
> Hi Dmitry,
>
> These are looking good to me.
Can I get an "Acked-by:" or something so that I know it's ok to apply
these?
thanks,
greg k-h-
___
devel mailing list
de...@linuxdriverproject
The Linux kernel coding style suggests starting every line in a block
comment with an asterisk and finishing the block comment with */ on a
separate line. This patch fixes those warnings, clearing all warnings
and errors in this file, as reported by the checkpatch script.
Signed-off-by: Okash Kha
This patch fixes checkpatch.pl warnings,
related to comments.
Signed-off-by: Lior Pugatch
---
drivers/staging/panel/panel.c | 38 +-
1 file changed, 25 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
i
On Wed, Aug 05, 2015 at 10:43:23PM +0300, Lior Pugatch wrote:
> This patch fixes checkpatch.pl warning,
> all warnings are releted to comments code style.
Acked-by: Willy Tarreau
Thanks!
Willy
___
devel mailing list
de...@linuxdriverproject.org
http:/
Attn: Applicant,
I am a loan lender offering out loans with interest rate of 3% my offer is
guaranteed and also very fast and easy.
Do you want to be financially equipped?
DO you want a loan to start up your own business?
Have you been looking for a legitimate loan lender?
Do you want to pay
On Wed, Aug 05, 2015 at 11:19:53PM +0300, Lior Pugatch wrote:
> This patch fixes checkpatch.pl warnings,
> related to comments.
>
> Signed-off-by: Lior Pugatch
> ---
> drivers/staging/panel/panel.c | 38 +-
> 1 file changed, 25 insertions(+), 13 deletions(-)
>
On Tue, Aug 04, 2015 at 07:19:01PM +0100, Salah Triki wrote:
> @@ -508,14 +509,15 @@ static struct zram_meta *zram_meta_alloc(int device_id,
> u64 disksize)
> num_pages = disksize >> PAGE_SHIFT;
> meta->table = vzalloc(num_pages * sizeof(*meta->table));
> if (!meta->table) {
> -
On Wed, Aug 05, 2015 at 09:26:44PM +0800, Peng Fan wrote:
> Use __acquire() and __release() in the right place to silence the sparse
> lock checking warning.
>
> drivers/staging/sm750fb/sm750.c:177:13: warning: context imbalance in
> 'lynxfb_ops_fillrect' - different lock contexts for basic block
Hi Sanjeev,
thanx for comments.
best regards,
salah triki
On Wed, Aug 05, 2015 at 10:10:58AM +0530, sanjeev sharma wrote:
> Hello Salah,
>
> It would be good,if you provide some information why you are doing so like
> " messages that are associated with a particular device" should be tagged
>
I posted v4 of this patch set a week ago and there have been no
comments. I hope this is a good sign that the patches are good.
However, I have noticed that I managed to use the same message id
for the coverletter of v4 as for v3, which might have caused people
to hold off reviewing, perhaps thin
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/
struct ndis_wlan_bssid_ex is a doppelganger of struct wlan_bssid_ex,
and is used about a third as often.
Switch all instances to wlan_bssid_ex, and remove ndis_wlan_bssid_ex
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton
---
drivers/staging/rtl8712/rt
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clay
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 7 +-
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 --
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h
b/drivers/staging/rtl8712/rtl871x
1 - 100 of 117 matches
Mail list logo
