[PATCH] Staging: rtl8712: rtl871x_ioctl.h: Coding style warning fix for block comment

2015-09-23 Thread Punit Vara
This patch is to the rtl871x_ioctl.h that fixes up following warning reported by checkpatch.pl : -Block comments use a trailing */ on a separate line Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_ioctl.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/d

[PATCH] Staging: rtl8712: rtl871x_ioctl_set.c: Coding style warnings fix for block comments

2015-09-23 Thread Punit Vara
This patch is to the rtl871x_ioctl_set.c file that fixes up following warning reported by checkpatch.pl : -Block comments use a trailing */ on a separate line Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_ioctl_set.c | 12 1 file changed, 8 insertions(+), 4 deletion

[PATCH] Staging: rtl8712: rtl871x_io.h: Coding style warning fix for block comments

2015-09-23 Thread Punit Vara
This patch is to the rtl871x_io.h file that fixes up following warning reported by checkpatch.pl : Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_io.h | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_io.h b/drive

[PATCH 0/3] staging/wlan-ng: fix buffer overflow and clean up redundant code

2015-09-23 Thread Tillmann Heidsieck
Hi, smatch found a possible buffer overflow in staging/wlan-ng, the first patch of this series fixes this issue. The remaining two patches clean up redundant code. Cheers Tillmann Tillmann Heidsieck (3): staging: wlan-ng fix buffer overflow in firmware handling staging: wlan-ng remove redund

[PATCH 2/3] staging: wlan-ng remove redundant conditional

2015-09-23 Thread Tillmann Heidsieck
We exit the above loop either if curroff >= (HFA384x_PDA_LEN_MAX / 2 - 1) or if we found the END marker in the element beyond the current one. The first case is checked for in the preceding if statement, therefore the second if statement is redundant and can be removed. Signed-off-by: Tillmann Hei

[PATCH 3/3] staging: wlan-ng remove unnessecary variable

2015-09-23 Thread Tillmann Heidsieck
The result variable is not set anywhere beyond its initialization, therefore it can be remove. Signed-off-by: Tillmann Heidsieck --- drivers/staging/wlan-ng/prism2fw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan

[PATCH 1/3] staging: wlan-ng fix buffer overflow in firmware handling

2015-09-23 Thread Tillmann Heidsieck
We test for an END marker in the element beyond the current one, this effectively limits the size of the array to be HFA384x_PDA_LEN_MAX/2 - 1 not HFA384x_PDR_END_OF_PDA/2. This patch fixes a possible buffer overflow in case there was no END marker. Signed-off-by: Tillmann Heidsieck --- drivers/

[PATCH] Staging: rtl8712: rtl871x_led.h: Coding style warnings fix for block comments

2015-09-23 Thread Punit Vara
This patch is to the rtl871x_led.h that fixes up following warnings reported by checkpatch.pl : -Block comments use a trailing */ on a separate line Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_led.h | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff -

[PATCH] Staging: rtl8712: rtl871x_mlme.c: Coding style warnings fix for block comments

2015-09-23 Thread Punit Vara
This patch is to the rtl871x_mlme.c file that fixes up following warning reported by checkpatch.pl: - Block comments use * on subsequent lines - Block comments use a trailing */ on a separate line Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_mlme.c | 45

[PATCH] Staging: rtl8712: rtl871x_mlme.h: Coding style warnings fix for block comments

2015-09-23 Thread Punit Vara
This patch is to the rtl871x_mlme.h file that fixes up following warning reported by checkpatch.pl : -Block comments use * on subsequent lines -Block comments use a trailing */ on a separate line Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_mlme.h | 28 -

[PATCH] Staging: rtl8712: rtl871x_mp.c: Coding style warning fix for block comment

2015-09-23 Thread Punit Vara
This patch is to the rtl871x_mp.c file that fixes up following warning reported by checkpatch.pl : -Block comments use a trailing */ on a separate line Signed-off-by: Punit vara --- drivers/staging/rtl8712/rtl871x_mp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/driver

[PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix for block comment

2015-09-23 Thread Punit Vara
This is a patch to the rtl871x_mp.h that fixes up following warnings reported by checkpatch.pl : -Block comments use a trailing */ on a separate line Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_mp.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/

[PATCH] Staging: rtl8712: rtl871x_mp_ioctl.h: Coding style warnings fix for block comments

2015-09-23 Thread Punit Vara
This patch is for the rtl871x_mp_ioctl.h that fixes up following warning reported by checkpatch.pl: -Block comments use a trailing */ on a separate line Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_mp_ioctl.h | 39 -- 1 file changed, 26 insertions(+)

[PATCH] Staging: rtl8712: rtl871x_mp_phy_regdef.h: Coding style warning fix for block comments

2015-09-23 Thread Punit Vara
This patch is to the rtl871x_mp_phy_regdef.h file that fixes up following warning reported by checkpatch.pl : -Block comments use a trailing */ on a separate line Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_mp_phy_regdef.h | 33 - 1 file changed, 22 in

RE: [PATCH] staging: comedi: comedi_pci.c: improve function documentation

2015-09-23 Thread Hartley Sweeten
On Wednesday, September 23, 2015 11:36 AM, Ian Abbott wrote: > Expand the descriptions of the functions and document the return values. > > Signed-off-by: Ian Abbott Thanks, Reviewed-by: H Hartley Sweeten ___ devel mailing list de...@linuxdriverproje

[PATCH] Staging: rtl8712: Coding Style warnings fix for block comments

2015-09-23 Thread Punit Vara
This is patch to the rtl871x_pwrctrl.c file that fixes following warning reported by checkpatch.pl : -Block comments use a trailing */ on a separate line -Block comments use * on subsequent lines Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_pwrctrl.c | 41 --

[PATCH] Staging: rtl8712: rtl871x_recv.c: Coding style warnings fix for block comments

2015-09-23 Thread Punit Vara
This patch is to the rtl871x_recv.c that fixes up following warnings reported by checkpatch.pl : -Block comments use a trailing */ on a separate line -Block comments use * on subsequent lines Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_recv.c | 27 ---

[PATCH] Staging: rtl8712: rtl871x_recv.h: Coding style warnings fix for block comments

2015-09-23 Thread Punit Vara
This patch is to the rtl871x_recv.h file that fixes up following warnings reported by checkpatch.pl : -Block comments use a trailing */ on a separate line -Block comments use * on subsequent lines Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_recv.h | 21 - 1

[PATCH] Staging: rtl8712: rtl871x_security.c: Coding style warning fix for block commment

2015-09-23 Thread Punit Vara
This is patch to the rtl871x_security.c that fixes up following warning reported by checkpatch.pl : -Block comments use * on subsequent lines Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_security.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/s

[PATCHv2 0/3] staging: lustre: fix (non-)static symbols issues

2015-09-23 Thread Anton Gerasimov
This series of patches eliminates some sparse warnings concerning static variables in lustre rtlrpc module where it seemed reasonable. Symbols that are really local to a source file are made static and declarations added to a header for symbols that are shared between source files. v2: Thank Andre

[PATCHv2 1/3] staging: lustre: moved extern declarations to a header

2015-09-23 Thread Anton Gerasimov
This patch moves declarations of variables used in several files across the ptlrpc module from source files to a local header. Signed-off-by: Anton Gerasimov --- drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c| 1 - drivers/staging/lustre/lustre/ptlrpc/nrs.c | 1 - drivers/st

[PATCHv2 2/3] staging: lustre: include header with local ptlrpc declarations

2015-09-23 Thread Anton Gerasimov
Include the header with declarations of variables that are shared between several sources in ptlrpc module into the appropriate source files. Signed-off-by: Anton Gerasimov --- drivers/staging/lustre/lustre/ptlrpc/sec_null.c | 2 ++ drivers/staging/lustre/lustre/ptlrpc/wiretest.c | 2 ++ 2 files

[PATCH] Staging: rtl8712: rtl871x_security.h: Coding style warnings fix for block comments

2015-09-23 Thread Punit Vara
This patch is to the rtl871x_security.h file that fixes up following warning reported by checkpatch.pl : -Block comments use a trailing */ on a separate line Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_security.h | 24 1 file changed, 16 insertions(+),

[PATCHv2 3/3] staging: lustre: make non-exported functions static

2015-09-23 Thread Anton Gerasimov
Declare non-exported functions as static. Signed-off-by: Anton Gerasimov --- drivers/staging/lustre/lustre/ptlrpc/pack_generic.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c b/drivers/staging/lustre/lustre/ptlrpc

[PATCH] Staging: rtl8712: rtl871x_sta_mgt.c: Coding style warning fix for block comment

2015-09-23 Thread Punit Vara
This is a patch to the rtl871x_sta_mgt.c file that fixes up following warning reported by checkpatch.pl: -Block comments use a trailing */ on a separate line Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_sta_mgt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --g

[PATCH v3 2/6] staging: fsl-mc: uprev dpmng binary interface to v8.0

2015-09-23 Thread J. German Rivera
Add cmd_flags parameter to all dpmng APIs to comply with 8.0 MC firmware interface. Updated MC version major number. --- drivers/staging/fsl-mc/bus/dpmng.c | 14 ++ drivers/staging/fsl-mc/bus/mc-bus.c| 4 ++-- drivers/staging/fsl-mc/include/dpmng.h | 14 ++ 3 files

[PATCH v3 1/6] staging: fsl-mc: Add new flags field to MC command header

2015-09-23 Thread J. German Rivera
The Management Complex (MC) binary interface added a new "flags" field to the command header. Add the definitions for this field in preparation for adding the new cmd_flags parameter to all MC interface APIs. Signed-off-by: J. German Rivera --- drivers/staging/fsl-mc/include/mc-cmd.h | 30 ++

[PATCH v3 5/6] staging: fsl-mc: up-rev dpcon binary interface to v2.0

2015-09-23 Thread J. German Rivera
dpcon object minor version number updated to match latest MC firmware. This change is needed because the dpcon object binds to the allocator and the current driver match logic uses object version numbers. Signed-off-by: J. German Rivera --- drivers/staging/fsl-mc/include/dpcon-cmd.h | 2 +- 1 fi

[PATCH v3 4/6] staging: fsl-mc: up-rev dpmcp binary interface to v2.0

2015-09-23 Thread J. German Rivera
Add cmd_flags parameter to all dpbp APIs to comply with the dpmcp 2.0 MC interface. Updated version major number. Pass irq args in struct instead of separate args. Signed-off-by: J. German Rivera --- drivers/staging/fsl-mc/bus/dpmcp-cmd.h| 2 +- drivers/staging/fsl-mc/bus/dpmcp.c|

[PATCH v3 3/6] staging: fsl-mc: up-rev dpbp binary interface to v2.0

2015-09-23 Thread J. German Rivera
Add cmd_flags parameter to all dpbp APIs to comply with the dpbp 2.0 MC interface. Updated MC version major number. Pass irq args in struct instead of separate args. Signed-off-by: J. German Rivera --- drivers/staging/fsl-mc/bus/dpbp.c | 94 +++ drivers/stagin

[PATCH v3 0/6] staging: fsl-mc: up-rev version of MC interface code

2015-09-23 Thread J. German Rivera
The DPAA2 management complex has a versioned binary interface that has to be kept in sync with the DPAA2 drivers. This patch uprevs the APIs that build MC commands and parse results. This uprev is needed to support object interrupts. MC binary interface changes -overall version from 6.0 to 8.0

[PATCH v3 6/6] staging: fsl-mc: up-rev dprc binary interface to v4.0

2015-09-23 Thread J. German Rivera
Add cmd_flags parameter to all dprc APIs to comply with the dprc 4.0 MC interface. Updated MC version major number. Pass irq args in struct instead of separate args. dprc 4.0 uses MC-relative offsets to specify object regions, instead of physical addresses. So, translate_mc_addr() and struct fsl_

[PATCH] staging: rtl8188eu: Fix build error when CFG80211 is not selected

2015-09-23 Thread Jakub Sitnicki
The kbuild test robot reports the following build error for i386-randconfig-c0-09230740: >> ERROR: "ieee80211_hdrlen" [drivers/staging/rtl8188eu/r8188eu.ko] undefined! Add a dependency on CFG80211 to fix it. Signed-off-by: Jakub Sitnicki --- Same issue has also been reported by Jim Davis for r

Re: [PATCH v11 3/4] add FPGA manager core

2015-09-23 Thread Josh Cartwright
On Wed, Sep 23, 2015 at 12:10:13PM -0500, atull wrote: > On Tue, 22 Sep 2015, Josh Cartwright wrote: [..] > > > +struct fpga_manager *of_fpga_mgr_get(struct device_node *node) > > > +{ > > > + struct fpga_manager *mgr; > > > + struct device *dev; > > > + > > > + if (!node) > > > + return ER

Re: [PATCH] staging: rtl8192u: ieee80211_rx: Fix incorrect type in assignments

2015-09-23 Thread Gaston Gonzalez
On Fri, Jun 26, 2015 at 01:36:14PM -0300, Gaston Gonzalez wrote: > On Thu, Jun 25, 2015 at 02:06:44PM +0200, Arnd Bergmann wrote: > > On Wednesday 24 June 2015 13:34:58 Gaston Gonzalez wrote: > > > On Tue, Jun 23, 2015 at 12:13:47PM +0200, Arnd Bergmann wrote: > > > > On Sunday 21 June 2015 19:12:0

Re: [PATCH 32/37] staging/lustre: use 64-bit times for exp_last_request_time

2015-09-23 Thread Drokin, Oleg
On Sep 23, 2015, at 3:13 PM, Arnd Bergmann wrote: > The last request time is stored as an 'unsigned long', which is > good enough until 2106, but it is then converted to 'long' in > some places, which overflows in 2038. > > This changes the type to time64_t to avoid those problems. Hm… All this

Re: [PATCH 04/37] staging/lustre: tracefile: use 64-bit seconds

2015-09-23 Thread Drokin, Oleg
On Sep 23, 2015, at 3:13 PM, Arnd Bergmann wrote: > The lustre tracefile has a timestamp defined as > > __u32 ph_sec; > __u64 ph_usec; > > which seems completely backwards, as the microsecond portion of > a time stamp will always fit into a __u32 value, while the second > portion wi

Re: [PATCH 13/13] Staging: rtl8712: Coding style warning fix for block comment

2015-09-23 Thread Sudip Mukherjee
On Wed, Sep 23, 2015 at 11:22:09PM +0530, punit vara wrote: > On Wed, Sep 23, 2015 at 10:25 PM, punit vara wrote: > > Thank you very much sir I will definitely follow that. I have seen so > > many people fixing patches over here. Now I know process of submitting > > patches.I am able to fix severa

Re: [PATCH 19/37] staging/lustre: use 64-bit time for procfs output

2015-09-23 Thread Sudip Mukherjee
On Wed, Sep 23, 2015 at 09:13:42PM +0200, Arnd Bergmann wrote: > This time is only printed in procfs, and can be easily converted > to 64-bit to avoid overflowing on 32-bit systems in 2038. > > Signed-off-by: Arnd Bergmann > --- This introduces new build warnings: drivers/staging/lustre/lustre/o

Re: [PATCH] Staging: rtl8712: rtl871x_io.h: Coding style warning fix for block comments

2015-09-23 Thread Sudip Mukherjee
On Thu, Sep 24, 2015 at 01:22:33AM +0530, Punit Vara wrote: > This patch is to the rtl871x_io.h file that fixes up following warning > reported by checkpatch.pl : > > Signed-off-by: Punit Vara > --- You missed copying the warning after mentioning "following warning" in your commit message. regar

Re: [PATCH] Staging: rtl8712: rtl871x_sta_mgt.c: Coding style warning fix for block comment

2015-09-23 Thread Sudip Mukherjee
On Thu, Sep 24, 2015 at 02:38:26AM +0530, Punit Vara wrote: > This is a patch to the rtl871x_sta_mgt.c file that fixes up following > warning reported by checkpatch.pl: > > -Block comments use a trailing */ on a separate line > > Signed-off-by: Punit Vara > --- When you are sending multiple patc

[PATCH 0/6] Staging: rtl8192u: checkpatch.pl fixes

2015-09-23 Thread mike dupuis
This series of patches addresses several checkpatch.pl issues in ieee80211_softmac_wx.c. Before: total: 14 errors, 24 warnings, 59 checks, 602 lines checked After: total: 0 errors, 20 warnings, 59 checks, 599 lines checked Mike Dupuis (6): Staging: rtl8192u: space required after ',' Staging:

[PATCH 5/6] Staging: rtl8192u: spaces required around = operator

2015-09-23 Thread mike dupuis
This is a patch to add spaces around = operators in several instances in ieee80211_softmac_wx.c Signed-off-by: Mike Dupuis --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee802

[PATCH 6/6] Staging: rtl819u: Fix brace styling issues

2015-09-23 Thread mike dupuis
This is a patch to correct two flavors of brace styling issues in ieee80211_softmac_wx.c. Signed-off-by: Mike Dupuis --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee8

[PATCH 2/6] Staging: rtl8192u: add missing blank lines after declarations

2015-09-23 Thread mike dupuis
This is a patch to add blank lines after declaration ins several instances in iee80211_softmac_wx.c. Signed-off-by: Mike Dupuis --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softma

[PATCH 1/6] Staging: rtl8192u: space required after ','

2015-09-23 Thread mike dupuis
This is a fix to add spaces after commas in ieee80211_softmac_wx.c. Signed-off-by: Mike Dupuis --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c b/drivers/st

[PATCH 3/6] Staging: rtl8192u: move open braces to previous lines

2015-09-23 Thread mike dupuis
This is a patch to move opening braces to the lines on which their corresponding if-statements exist in ieee80211_softmac_wx.c. Signed-off-by: Mike Dupuis --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/dr

[PATCH 4/6] Staging: rtl8192u: add spaces around == and || operators

2015-09-23 Thread mike dupuis
This is a patch to add missing spaces around == and || operators in one instance in ieee80211_softmac_wx.c. Signed-off-by: Mike Dupuis --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80

<    1   2