Hi arnd,
Thanks for the all the patches. :)
About the patch ( use proper naming for global symbols ),
We are planning to use this driver not only for wilc1000 but also for
other atmel wireless driver. I'd appreciate if you could use wl instead of
wilc1000.
And the global variable g_linux_wlan w
On Wednesday 21 October 2015 19:06:52 glen lee wrote:
> Hi arnd,
>
> Thanks for the all the patches.
> About the patch ( use proper naming for global symbols ),
> We are planning to use this driver not only for wilc1000 but also for
> other atmel wireless driver. I'd appreciate if you could use w
On Tue, Oct 20, 2015 at 05:10:46PM +0900, Tony Cho wrote:
> This patch reverts the commit, d79fd35b8c5d927695b48fa35aa586919818cce9.
>
> The WID_JOIN_REQ_EXTENDED among WIDs needs two parameters for the request to
> be sent to the firmware, which are the SA and the BSSID. For this case, both
> is
On Mon, Oct 19, 2015 at 10:11:16PM -0400, ira.we...@intel.com wrote:
> From: Mike Marciniszyn
>
> This additional call is a regression from qib. For small messages the
> progress
> routine always builds one and clears out the ahg state when the queue has gone
> to empty which is the predominant
On Mon, Oct 19, 2015 at 10:11:22PM -0400, ira.we...@intel.com wrote:
> From: Niranjana Vishwanathapura
>
> Use NULL instead of 0 for pointer argument to fix the sparse error.
>
> Reviewed-by: Mike Marciniszyn
> Reviewed-by: Mitko Haralanov
> Reviewed-by: Dennis Dalessandro
> Signed-off-by: Ni
The patch to split out bus modules causes new valid build warnings without this.
Signed-off-by: Arnd Bergmann
diff --git a/drivers/staging/wilc1000/linux_wlan.c
b/drivers/staging/wilc1000/linux_wlan.c
index 8a5f4673c5d0..fe3b464f0d5c 100644
--- a/drivers/staging/wilc1000/linux_wlan.c
+++ b/driv
This patch removes multiple assignments as specified in coding style.
Signed-off-by: Christian Gromm
---
drivers/staging/most/hdm-dim2/dim2_hal.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/most/hdm-dim2/dim2_hal.c
b/drivers/staging/most/hdm-dim2/dim
This patch puts spaces around the asterisk operator. It is needed to
prevent checkpatch from reporting an issue.
Signed-off-by: Christian Gromm
---
drivers/staging/most/hdm-dim2/dim2_hal.c |2 +-
drivers/staging/most/hdm-dim2/dim2_hdm.c |2 +-
2 files changed, 2 insertions(+), 2 deletion
This patch removes the usage of multiple blank lines from driver modules.
Signed-off-by: Christian Gromm
---
drivers/staging/most/aim-network/networking.c |4
drivers/staging/most/aim-sound/sound.c|1 -
drivers/staging/most/aim-v4l2/video.c |6 --
drivers/sta
This patchset removes warnings generated by checkpatch.
Christian Gromm (13):
staging: most: remove multiple blank lines
staging: most: put spaces around operator
staging: most: removed redundant code
staging: most: remove multiple assignment
staging: most: make alignment match open pare
This patch uses the preferred call to kzalloc. It replaces
kzalloc(sizeof(struct aim_fh)...) by kzalloc(sizeof(*fh)...).
Signed-off-by: Christian Gromm
---
drivers/staging/most/aim-v4l2/video.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/aim-v4l2/v
This patch fixes style issues regarding braces on all arms of a statement.
Signed-off-by: Christian Gromm
---
drivers/staging/most/hdm-dim2/dim2_hdm.c |4 ++--
drivers/staging/most/hdm-i2c/hdm_i2c.c |3 ++-
drivers/staging/most/hdm-usb/hdm_usb.c |5 +++--
drivers/staging/most/mos
This patch fixes style violation regarding blank lines after
function/struct/union/enum declarations.
Signed-off-by: Christian Gromm
---
drivers/staging/most/aim-cdev/cdev.c |1 +
drivers/staging/most/hdm-usb/hdm_usb.c |4
drivers/staging/most/mostcore/core.c |6 ++
3 fi
This patch simply removes unnecessary parentheses.
Signed-off-by: Christian Gromm
---
drivers/staging/most/hdm-dim2/dim2_hdm.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/hdm-dim2/dim2_hdm.c
b/drivers/staging/most/hdm-dim2/dim2_hdm.c
index 968b2a0
This patch removes redundant code.
Signed-off-by: Christian Gromm
---
drivers/staging/most/aim-v4l2/video.c| 22 --
drivers/staging/most/hdm-dim2/dim2_hal.c | 16
2 files changed, 38 deletions(-)
diff --git a/drivers/staging/most/aim-v4l2/video.c
b/
Signed-off-by: Christian Gromm
---
drivers/staging/most/hdm-usb/hdm_usb.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c
b/drivers/staging/most/hdm-usb/hdm_usb.c
index 747d22e..b5fb1a7 100644
--- a/drivers/staging/most/hdm-usb/hdm_u
This patch fixes coding style violations by making alignments match
open parenthesis.
Signed-off-by: Christian Gromm
---
drivers/staging/most/aim-cdev/cdev.c |2 +-
drivers/staging/most/hdm-dim2/dim2_hal.c |2 +-
drivers/staging/most/hdm-dim2/dim2_hdm.c |2 +-
drivers/staging/mos
This patch removes blank lines after an open brace as specified in
coding style.
Signed-off-by: Christian Gromm
---
drivers/staging/most/hdm-dim2/dim2_hdm.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/most/hdm-dim2/dim2_hdm.c
b/drivers/staging/most/hdm-dim2/dim2_hdm.
This patch puts logical continuations on the previous line to meet
coding style.
Signed-off-by: Christian Gromm
---
drivers/staging/most/aim-cdev/cdev.c |7 +++
drivers/staging/most/mostcore/core.c |4 ++--
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/stagin
This patch makes use of the preferred kernel types such as u16, u32.
Signed-off-by: Christian Gromm
---
drivers/staging/most/aim-network/networking.c |2 +-
drivers/staging/most/hdm-i2c/hdm_i2c.c|2 +-
drivers/staging/most/mostcore/core.c |2 +-
3 files changed, 3 in
>
> On Mon, Oct 19, 2015 at 10:11:22PM -0400, ira.we...@intel.com wrote:
> > From: Niranjana Vishwanathapura
> >
> > Use NULL instead of 0 for pointer argument to fix the sparse error.
> >
> > Reviewed-by: Mike Marciniszyn
> > Reviewed-by: Mitko Haralanov
> > Reviewed-by: Dennis Dalessandro
>
On 18/10/15 15:35, Geliang Tang wrote:
This patch makes ni_tio_has_gate2_registers return boolean, since
this function only uses either one or zero as its return value.
Signed-off-by: Geliang Tang
---
drivers/staging/comedi/drivers/ni_tio.c | 6 +++---
1 file changed, 3 insertions(+), 3 dele
Code is correct, i needs to be moved back by 2 to correct for the last
iteration of the while loop, since READ_NEXT_PAIR advances two. Fixing
the misleading indentation.
Fix a smatch warning:
drivers/staging/rtl8188eu/hal/rf_cfg.c:217
rtl88e_phy_config_rf_with_headerfile() warn: curly braces inten
For loop is outside of the else branch of the above conditional statement.
Fixing misleading indentation.
Fix a smatch warning:
drivers/staging/rtl8723au/core/rtw_wlan_util.c:528
WMMOnAssocRsp23a() warn: curly braces intended?
Signed-off-by: Luis de Bethencourt
---
drivers/staging/rtl8723au/cor
The code is correct, the indentation is misleading. Only the the return rc
is part of the conditional statement if rc != 0.
Fix a smatch warning:
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2157
kiblnd_hdev_setup_mrs() warn: curly braces intended?
Signed-off-by: Luis de Bethencourt
---
This patch fixes some internal voltage settings for the C-Berry28 display.
The original example source files for the C-Berry28 as provided by
its vendor admatec contained six issues where a command parameter's value
didn't match its corresponding comment.
I've informed admatec about these discrepan
This patch removes the function set_addr_win() from fb_st7789v.c, as its
definition is redundant to the default implementation fbtft_set_addr_win()
which can be found in fbtft-core.c.
Signed-off-by: Dennis Menschel
---
drivers/staging/fbtft/fb_st7789v.c | 19 ---
1 file changed,
This patch makes use of the standard MIPI Display Command Set to remove
redundant entries from the command enum of the ST7789V display controller
and also some of the magic constants found in the init sequence of the
C-Berry28 display.
Signed-off-by: Dennis Menschel
---
drivers/staging/fbtft/fb_
Am 11.10.2015 um 16:19 schrieb Noralf Trønnes:
>
> Den 11.10.2015 09:31, skrev Dennis Menschel:
>> Am 10.10.2015 um 17:36 schrieb Noralf Trønnes:
>>> Den 07.10.2015 22:15, skrev Dennis Menschel:
This patch adds support for the Sitronix ST7789V display controller.
The controller is intend
This patch converts the default init sequence of the ST7789V
display controller into an init function, as init sequences
are considered deprecated by the maintainers of fbtft.
Signed-off-by: Dennis Menschel
---
drivers/staging/fbtft/fb_st7789v.c | 43 +-
1 fil
This set of patches brings some improvements for the ST7789V display
controller driver based on suggestions by Noralf Trønnes.
In addition, the settings for the concrete C-Berry28 display have been
adjusted based on feedback by its vendor admatec.
Dennis Menschel (4):
staging: fbtft: use MIPI D
The driver is using -1 instead of the -ENOMEM defined macro to specify that
a buffer allocation failed.
Fixes smatch warning and similars:
drivers/staging/wilc1000/host_interface.c:1782 Handle_Key() warn:
returning -1 instead of -ENOMEM is sloppy
Signed-off-by: Luis de Bethencourt
---
drivers/s
From: Frederic Saunier
Currently NID string handling test for the last entry,
and last entry has .nf_type == (__u32) -1. If we ask
for a non existent LND we hit the last entry which then
calls a strlen on a NULL which causes a error. We can
avoid this problem if we just remove the last entry
sinc
The reason struct netstrfns exist in nidstrings.c
was to avoid forward decleration errors. The best
way to handle this instead is to move this structure
to a header file. Since this structure is used in
the userland utilities as well so we place it in
nidstr.h which is exposed to userland.
Signed-
Update struct netstrfns to use C99 initializers.
Remove old LND types from the netstrfns table, as they are
long obsolete and shouldn't be needed even for interop anymore.
Signed-off-by: James Simmons
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6210
Reviewed-on: http://review.whamcloud.c
Moved the source file nidstring.c from libcfs to lnet
since that is the only place it is used. With the
move of nidstring to lnet some functions in libcfs
need to be exported. In later patches those functions
that are only used by LNet also will be moved to the
LNet layer. Also add in missing MAX_N
Since forward declarations are frowned on upstream we move
the NID range handling to near the start of the nidstring.c
file.
Signed-off-by: James Simmons
Reviewed-on: http://review.whamcloud.com/15086
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6245
Reviewed-by: Dmitry Eremin
Reviewed-by
From: Joshua Walgenbach
This is a partial backport of the NID range management
added in for nodemap. We only backport the libcfs related
parts here.
Signed-off-by: Joshua Walgenbach
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3527
Reviewed-on: http://review.whamcloud.com/8057
Reviewed-b
Much of the LNet network setup is managed with modprobe configuration
files. Those configurations are parse with the code in nidstring.c
which currently located in the libcfs layer. This patch series moves
nidstring.c to the LNet layer where it belongs and we update the
source with all the changes
From: Gregoire Pichon
The libcfs already provides services to parse a string into a nidlist
and to match a nid into a nidlist. This patch implements a service
that prints a nidlist into a buffer.
This is required for instance to print the nosquash_nids parameter
of the MDT procfs component.
Add
All the function libcfs_init_string did was initialize
a spinlock. We can initialize the spinlock statically
instead.
Signed-off-by: James Simmons
---
.../staging/lustre/include/linux/libcfs/libcfs.h |2 --
drivers/staging/lustre/lnet/lnet/nidstrings.c |8 +---
drivers/staging
From: Dmitry Eremin
Provide duplicates with separate buffers for libcfs_*2str() functions.
Replace libcfs_nid2str() with libcfs_nid2str_r() function in critical
places.
Provide buffer size for nf_addr2str functions.
Use __u32 as nf_type always
Signed-off-by: Dmitry Eremin
Intel-bug-id: https
Both of cfs_ip_addr_parse and cfs_ip_addr_match which are located in
libcfs kernel module are used only for LNet so move this into the
nidstring handling code where it belongs. Also create user land
versions of these functions in the libcfs user land library.
Signed-off-by: James Simmons
Intel-bu
No need to have a one line wrapper in libcfs that only
is used to delete a list which is only done once in the
LNet layer.
Signed-off-by: James Simmons
---
.../lustre/include/linux/libcfs/libcfs_string.h|1 -
drivers/staging/lustre/lnet/lnet/config.c |2 +-
.../staging/lustr
Remove the functions which are defined but not used anywhere
Signed-off-by: Shraddha Barke
---
drivers/staging/lustre/lustre/include/lustre_log.h | 90 --
1 file changed, 90 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/lustre_log.h
b/drivers/staging/lustr
The code enclosed in '#if 1' anyway gets compiled. Removing useless
conditionals.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/ddk750_chip.c | 13 +
drivers/staging/sm750fb/ddk750_mode.c | 3 +--
drivers/staging/sm750fb/sm750_hw.c| 3 +--
3 files changed, 7 insertio
Hi,
These patches simplify PLL divisors calculations in sm750fb.
The first patch is not strictly related to that, but when I removed '#if 1'
while working on the calculations, I've decided to do that for other
occurencies as well.
I've checked that the PLL control register field values are the sa
The calcPllValues currently uses arrays of PLL parametres that contain
possible PLL control register field values and redundant data that is
calculated according to those values. The usage of these arrays can be
replaced with simple arithmetics.
Signed-off-by: Mike Rapoport
---
drivers/staging/s
The pllcalparam type is not used and can be removed.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/ddk750_chip.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c
b/drivers/staging/sm750fb/ddk750_chip.c
index 7084a4a..0331d34 100644
--- a
49 matches
Mail list logo
