Re: [PATCH 2/2] staging: most: avoid assignment in if

2015-11-27 Thread Dan Carpenter
Just ignore the checkpatch warning. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH net-next] hv_netvsc: rework link status change handling

2015-11-27 Thread Vitaly Kuznetsov
There are several issues in hv_netvsc driver with regards to link status change handling: - RNDIS_STATUS_NETWORK_CHANGE results in calling userspace helper doing '/etc/init.d/network restart' and this is inappropriate and broken for many reasons. - link_watch infrastructure only sends one notif

Re: [PATCH v4 0/7] staging: sm750fb: refactor lynxfb_pci_probe

2015-11-27 Thread Mike Rapoport
On Sun, Nov 08, 2015 at 11:52:16AM +0200, Mike Rapoport wrote: > Hi, > > These patches refactor the lynxfb_pci_probe Any comments on this? Should I resend? > v4 changes: > * address Dan's comments > > v3 changes: > * rebased on current Greg's staging-testing > > v2 changes: > * add pci_disabl

Re: [PATCH 00/18] staging: sm750fb: change some register fields defines

2015-11-27 Thread Mike Rapoport
On Mon, Nov 16, 2015 at 09:59:49AM +0200, Mike Rapoport wrote: > Hi, > > This is the first set of patches that aim to replace custom defines for > register fields. The ultimate goal is to have MSB:LSB notation for register > fields and FIELD_* macros removed. I'd highly appreciate some feedback

Re: [PATCH v4 0/7] staging: sm750fb: refactor lynxfb_pci_probe

2015-11-27 Thread Dan Carpenter
On Fri, Nov 27, 2015 at 09:30:23PM +0200, Mike Rapoport wrote: > On Sun, Nov 08, 2015 at 11:52:16AM +0200, Mike Rapoport wrote: > > Hi, > > > > These patches refactor the lynxfb_pci_probe > > Any comments on this? Should I resend? No. Wait for Greg to get to it. regards, dan carpenter ___

Re: [PATCH 00/18] staging: sm750fb: change some register fields defines

2015-11-27 Thread Dan Carpenter
Just wait for Greg. He'll get to it eventually. It won't be lost or silently dropped. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2] staging: lustre: ptlrpc: constify ptlrpc_sec_cops structs

2015-11-27 Thread Aya Mahfouz
Constifies ptlrpc_sec_cops structures in the lustre driver since they are not modified after their initialization. Detected and found using Coccinelle. Suggested-by: Julia Lawall Signed-off-by: Aya Mahfouz --- Changelog: v2: added const to a ptlrpc_sec_cops structure in the defi