Re: [PATCH] staging: lustre: lprocfs_status.h: fix sparse error: symbol redeclared with different type

2016-10-07 Thread Samuele Baisi
Il giorno ven 7 ott 2016 alle 5:55, Greg KH ha scritto: On Thu, Oct 06, 2016 at 06:52:07PM +0200, Samuele Baisi wrote: drivers/staging/lustre/lustre/obdclass/lprocfs_status.c:1554:5: error: symbol 'lprocfs_wr_root_squash' redeclared with different type (originally declared at drivers/st

Re: [patch] staging: ion: use two separate locks for heaps and clients in ion_device

2016-10-07 Thread YiPing Xu
On 2016/10/5 2:02, Laura Abbott wrote: On 09/30/2016 01:18 AM, Xu YiPing wrote: ion_alloc may get into slow path to get free page, the call stack: __alloc_pages_slowpath ion_page_pool_alloc_pages alloc_buffer_page ion_system_heap_allocate ion_buffer_create <-- hold ion_device->lock ion_alloc

Re: [PATCH] staging: sm750fb: Fix printk() style warning

2016-10-07 Thread Mike Rapoport
On Thu, Oct 06, 2016 at 09:27:36PM -0700, Edward Lipinsky wrote: > On Sun, Oct 02, 2016 at 08:13:01PM +0200, Greg KH wrote: > > On Sun, Oct 02, 2016 at 11:05:05AM -0700, Edward Lipinsky wrote: > > > This patch fixes the checkpatch.pl warning: > > > > > > WARNING: printk() should include KERN_ faci

[PATCH] staging: ks7010: remove unnecessary else statement

2016-10-07 Thread Ebru Akagunduz
This patch removes else statement which is not usefull after a return. Issue found by checkpatch.pl. Signed-off-by: Ebru Akagunduz --- drivers/staging/ks7010/ks_wlan_net.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/stag

Re: [RFC 0/3] Add support for led triggers on phy link state change

2016-10-07 Thread Pavel Machek
Hi! > Some drivers that include phy.h defined LED_OFF which conflicts with > definition in leds.h. phy led support uses leds.h so the two namespaces are no > longer isolated. > The first two patches fix the two net drivers that declared enum constants > that > conflict with enum constants in linu

[PATCH 2/3] staging: jnx: Common Juniper PCI methods

2016-10-07 Thread Pantelis Antoniou
From: Rajat Jain All Juniper PTX platforms, whether powerpc or x86 based, use similar PCI bridges (PLX & IDT). We don't want to duplicate code in different arch directories, so put them here. Signed-off-by: Debjit Ghosh Signed-off-by: Guenter Roeck Signed-off-by: JawaharBalaji Thirumalaisamy

[PATCH 1/3] staging: jnx: PCI quirks for all Juniper platforms

2016-10-07 Thread Pantelis Antoniou
From: Rajat Jain PCI quirks for all juniper platforms. This is located here since the same PCI devices are present on both PPC and x86 platforms, so per-arch quirks are not appropriate. Signed-off-by: Debjit Ghosh Signed-off-by: Georgi Vlaev Signed-off-by: Guenter Roeck Signed-off-by: Jawahar

[PATCH 3/3] staging: jnx: pex8xxx I2C interface driver

2016-10-07 Thread Pantelis Antoniou
From: Rajat Jain Some Juniper platforms contain an Avago PEX8614, PEX8616 or PEX8713 PCI express switch which is controlled via a I2C interface. This driver provides a sysfs interface for configuration from user-space. Signed-off-by: Guenter Roeck Signed-off-by: Rajat Jain [Ported from Junipe

[PATCH 0/2] Juniper infrastructure

2016-10-07 Thread Pantelis Antoniou
Introduce a staging driver containing all the bit and pieces of Juniper's board support infrastructure that don't quite fit in any other place. The Juniper series of routers comprise of both x86 and powerpc platforms that contain similar hardware components necessitating common support methods. N

[PATCH 2/2] jnx: Introduce include/linux/jnx/pci_ids.h

2016-10-07 Thread Pantelis Antoniou
From: Rajat Jain Add this header to contain the PCI device IDs that we cannot add in the linux pci_ids.h. This would contain PCI device IDs of Juniper devices as well as any PCIe switches etc. Signed-off-by: Rajat Jain Signed-off-by: Debjit Ghosh Signed-off-by: Georgi Vlaev Signed-off-by: Gue

[PATCH 0/3] Juniper PCI methods

2016-10-07 Thread Pantelis Antoniou
Introduce PCI methods and infrastructure dealing with the peculiarities of Juniper PTX series of routers. The Juniper series of routers comprise of both x86 and powerpc platforms that contain similar hardware components necessitating common support methods. Note that this is the first submission

Re: [PATCH 0/2] Juniper infrastructure

2016-10-07 Thread Greg Kroah-Hartman
On Fri, Oct 07, 2016 at 06:15:44PM +0300, Pantelis Antoniou wrote: > Introduce a staging driver containing all the bit and > pieces of Juniper's board support infrastructure that don't quite > fit in any other place. Why staging? > The Juniper series of routers comprise of both x86 and powerpc >

[PATCH 2/6] gpio: Add support for PTX1K CBC FPGA spare GPIOs

2016-10-07 Thread Pantelis Antoniou
From: Georgi Vlaev Add support for the GPIO block in Juniper's CBC FPGA. A number of GPIOs exported by different kind of boards is supported. Signed-off-by: Georgi Vlaev Signed-off-by: Guenter Roeck [Ported from Juniper kernel] Signed-off-by: Pantelis Antoniou --- drivers/gpio/Kconfig|

[PATCH 6/6] staging: jnx: CBD-FPGA infrastructure

2016-10-07 Thread Pantelis Antoniou
From: Tom Kavanagh Every Juniper platform contains a CBD (Control Board) FPGA. While each CBD FPGA is different, a common abstact API makes handling them common for every platform and the same parts they have can be factored out. The supported CBDs are PTX1K, PTX21K, PTX3K & PTX5K. Signed-off-

[PATCH 3/6] gpio: gpio-cbc: Document bindings of CBC FPGA GPIO block

2016-10-07 Thread Pantelis Antoniou
From: Georgi Vlaev Add device tree bindings document for the GPIO driver of Juniper's CBC FPGA. Signed-off-by: Georgi Vlaev [Ported from Juniper kernel] Signed-off-by: Pantelis Antoniou --- .../devicetree/bindings/gpio/jnx,gpio-cbc.txt | 30 ++ 1 file changed, 30 inse

[RFC 2/2] staging: jnx-connector: add device tree binding

2016-10-07 Thread Pantelis Antoniou
From: Guenter Roeck Add documentation for the Juniper connector driver. Signed-off-by: Alon Ronen Signed-off-by: Guenter Roeck [Ported from Juniper kernel] Signed-off-by: Pantelis Antoniou --- .../devicetree/bindings/jnx/jnx-connector | 59 ++ 1 file changed, 59

[PATCH 4/6] gpio: cbc-presence: Add CBC presence detect as GPIO driver

2016-10-07 Thread Pantelis Antoniou
From: Georgi Vlaev This driver exports the CB FPGA presence detect bits from a single 32bit CB register as GPIOs. Signed-off-by: Georgi Vlaev Signed-off-by: Guenter Roeck [Ported from Juniper kernel] Signed-off-by: Pantelis Antoniou --- drivers/gpio/Kconfig | 12 + drivers/gpio/

Re: [PATCH 2/2] jnx: Introduce include/linux/jnx/pci_ids.h

2016-10-07 Thread Greg Kroah-Hartman
On Fri, Oct 07, 2016 at 06:15:46PM +0300, Pantelis Antoniou wrote: > From: Rajat Jain > > Add this header to contain the PCI device IDs that we cannot add in > the linux pci_ids.h. Why can't you? > This would contain PCI device IDs of Juniper devices as well as any > PCIe switches etc. Why do

[PATCH 0/6] Introduce Juniper CBC FPGA

2016-10-07 Thread Pantelis Antoniou
Add Juniper's PTX1K CBC FPGA driver. Those FPGAs are present in Juniper's PTX series of routers. The MFD driver provices a gpio device and a special driver for Juniper's board infrastucture. The FPGA infrastucture driver is providing an interface for user-space handling of the FPGA in those platfo

Re: [PATCH 0/3] Juniper PCI methods

2016-10-07 Thread Greg Kroah-Hartman
On Fri, Oct 07, 2016 at 06:15:53PM +0300, Pantelis Antoniou wrote: > Introduce PCI methods and infrastructure dealing with the > peculiarities of Juniper PTX series of routers. Same comments as my previous ones, why is this in staging, and make it all one patch series please. thanks, greg k-h

Re: [RFC 0/2] Juniper DT based connector driver

2016-10-07 Thread Greg Kroah-Hartman
On Fri, Oct 07, 2016 at 06:16:10PM +0300, Pantelis Antoniou wrote: > Introduce a Juniper PTX router series DT overlay based > connector driver. > > This is submitted as an RFC since some OF infrastructure > patches (like changeset helpers etc) are not yet mainlined. staging drivers almost always

[PATCH 5/6] gpio: gpio-cbc-presense: Document bindings of CBC FPGA presence

2016-10-07 Thread Pantelis Antoniou
From: Georgi Vlaev Add device tree bindings document for the presence virtual GPIOs on Juniper's CBC FPGA. Signed-off-by: Georgi Vlaev [Ported from Juniper kernel] Signed-off-by: Pantelis Antoniou --- .../bindings/gpio/jnx,gpio-cbc-presense.txt| 31 ++ 1 file chang

[PATCH 1/6] mfd: Add support for the PTX1K CBC FPGA

2016-10-07 Thread Pantelis Antoniou
From: Georgi Vlaev The CBC intergrates CB and SAM on single FPGA. This is a PCI MFD driver and provides support for the following functions as subdrivers: * SAM I2C accelerator * SAM MTD flash * CBC spare GPIOs * CBC JNX infrastructure Signed-off-by: Georgi Vlaev Signed-off-by: Guenter Roeck

[RFC 1/2] staging: jnx: Add Juniper connector driver

2016-10-07 Thread Pantelis Antoniou
From: Guenter Roeck Driver to manage connectors in various Juniper devices. Currently supports PIC and SIB as well as various RE boards. Supports and uses device tree overlay as well as LED triggers. State changes are reported to userspace with sysfs poll events as well as with udev events. Sig

Re: [PATCH 1/2] staging: jnx: Juniper subsystem & board core APIs

2016-10-07 Thread Greg Kroah-Hartman
On Fri, Oct 07, 2016 at 06:15:45PM +0300, Pantelis Antoniou wrote: > From: Tom Kavanagh Minor nit: > +config JNX_DEVICES > + bool > + default n n is always the default. And how about a help entry? > +if JNX_DEVICES > + > +menu "Juniper Devices and Infrastructure" > + > +config JNX_SYS

Re: [PATCH 0/6] Introduce Juniper CBC FPGA

2016-10-07 Thread Greg Kroah-Hartman
On Fri, Oct 07, 2016 at 06:20:08PM +0300, Pantelis Antoniou wrote: > Add Juniper's PTX1K CBC FPGA driver. Those FPGAs > are present in Juniper's PTX series of routers. > > The MFD driver provices a gpio device and a special > driver for Juniper's board infrastucture. > The FPGA infrastucture drive

[PATCH] Staging:fbtft/fb_s6d02a1.c: fixed 80 character line limit coding

2016-10-07 Thread Nadim Almas
style issue Fixed coding style issue Signed-off-by: Nadim Almas --- drivers/staging/fbtft/fb_s6d02a1.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/drivers/staging/fbtft/fb_s6d02a1.c b/drivers/staging/fbtft/fb_s6d02a1.c index 774b0ff..bc0

Re: [PATCH 0/6] Introduce Juniper CBC FPGA

2016-10-07 Thread Pantelis Antoniou
> On Oct 7, 2016, at 18:39 , Greg Kroah-Hartman > wrote: > > On Fri, Oct 07, 2016 at 06:20:08PM +0300, Pantelis Antoniou wrote: >> Add Juniper's PTX1K CBC FPGA driver. Those FPGAs >> are present in Juniper's PTX series of routers. >> >> The MFD driver provices a gpio device and a special >> dr

[RFC 0/2] Juniper DT based connector driver

2016-10-07 Thread Pantelis Antoniou
Introduce a Juniper PTX router series DT overlay based connector driver. This is submitted as an RFC since some OF infrastructure patches (like changeset helpers etc) are not yet mainlined. The Juniper series of routers comprise of both x86 and powerpc platforms that contain similar hardware comp

[PATCH 1/2] staging: jnx: Juniper subsystem & board core APIs

2016-10-07 Thread Pantelis Antoniou
From: Tom Kavanagh The Juniper System Infrastructure subsystem creates platform devices for the platform, chassis and cards and provides sysfs attributes for these devices. Each board contains I2C ID EEPROMs which contain information about the chassis, platform, type and assembly IDs. All Junip

Re: [PATCH 2/3] staging: jnx: Common Juniper PCI methods

2016-10-07 Thread Joe Perches
___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/3] Staging: i4l: Warning "Prefer "pr_debug over printk(KERN_DEBUG... " fixed

2016-10-07 Thread Harman Kalra
Warning "Prefer "pr_debug over printk(KERN_DEBUG... " and "few line more than 80 character" fixed Signed-off-by: Harman Kalra --- drivers/staging/i4l/icn/icn.h |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/i4l/icn/icn.h b/drivers/staging/i4l/icn/icn.h i

[PATCH 2/3] Staging: i4l: Error "open brace { should be on the previous line" fixed.

2016-10-07 Thread Harman Kalra
Errors "open brace { should be on the previous line" caught by checkpatch.pl fixed. Signed-off-by: Harman Kalra --- drivers/staging/i4l/icn/icn.h |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/i4l/icn/icn.h b/drivers/staging/i4l/icn/icn.h index aa4c593.

[PATCH 3/3] Staging: i4l: Error "open brace { should be on the previous line" fixed.

2016-10-07 Thread Harman Kalra
Error "open brace { should be on the previous line" caught by checkpatch.pl fixed. Signed-off-by: Harman Kalra --- drivers/staging/i4l/icn/icn.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/staging/i4l/icn/icn.c index 514bfc2..3

Re: [PATCH] Staging:fbtft/fb_s6d02a1.c: fixed 80 character line limit coding

2016-10-07 Thread Greg KH
On Fri, Oct 07, 2016 at 08:43:02AM -0700, Nadim Almas wrote: > style issue > > Fixed coding style issue This does not seem like valid sentances that mean much to me. Do they to you? > > Signed-off-by: Nadim Almas > --- > drivers/staging/fbtft/fb_s6d02a1.c | 30 --

[PATCH] fbtft: Convert int arrays to s16

2016-10-07 Thread Joe Perches
These arrays use -1, -2, and -3 as initiators for various types of writes to initialize hardware. No values are used that conflict with using these arrays as s16 instead of int and reducing overall data is good. $ size drivers/staging/fbtft/built-in.o* textdata bss dec hex file

Re: [RFC 1/2] staging: jnx: Add Juniper connector driver

2016-10-07 Thread Joe Perches
On Fri, 2016-10-07 at 18:16 +0300, Pantelis Antoniou wrote: > diff --git a/drivers/staging/jnx/jnx-connector.c > b/drivers/staging/jnx/jnx-connector.c [] > +struct jnx_conn_data { > + struct device *dev; /* parent (platform) device */ > + const char *name[NUM_OVERLAYS]; /* over

[PATCH 25/34] staging:r8188eu: remove prhdr local variable from rtw_free_stainfo function

2016-10-07 Thread Ivan Safonov
This variable is unnecessary. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c index a71e252..941d1a0 10

[PATCH 13/34] staging:r8188eu: remove ExternalPA member of hal_data_8188e structure

2016-10-07 Thread Ivan Safonov
ExternalPA always is false. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/rf.c | 2 -- drivers/staging/rtl8188eu/include/rtl8188e_hal.h | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rf.c b/drivers/staging/rtl8188eu/hal/rf.c inde

[PATCH 27/34] staging:r8188eu: remove pallocated_recv_buf member of the recv_priv structure

2016-10-07 Thread Ivan Safonov
recv_priv used instead. recv_priv does not changed after assigning and it can be used as kfree argument Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c | 10 +++--- drivers/staging/rtl8188eu/include/rtw_recv.h | 1 - 2 files changed, 3 insertions(+), 8 delet

[PATCH 21/34] staging:r8188eu: remove ANTTEST(ALL|A|B) definitions

2016-10-07 Thread Ivan Safonov
These defintions does not used. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/odm.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/odm.h b/drivers/staging/rtl8188eu/include/odm.h index 0c15e5f..4fb3bb0 100644 --- a/drivers/staging/r

[PATCH 01/34] staging:r8188eu: remove rtw_os_recv_resource_alloc function

2016-10-07 Thread Ivan Safonov
This simple function does not allocate any resource. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_recv.c | 3 +-- drivers/staging/rtl8188eu/include/recv_osdep.h | 2 -- drivers/staging/rtl8188eu/os_dep/recv_linux.c | 6 -- 3 files changed, 1 insertion(+), 10 delet

[PATCH 02/34] staging:r8188eu: remove wrappers for rtw_hal_inirp_init function

2016-10-07 Thread Ivan Safonov
There is no reason to use these wrappers. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/drv_types.h | 1 - drivers/staging/rtl8188eu/os_dep/os_intfs.c | 6 ++ drivers/staging/rtl8188eu/os_dep/usb_intf.c | 10 -- 3 files changed, 2 insertions(+), 15 deletions

[PATCH 04/34] staging:r8188eu: remove free_recv_buf_queue_cnt member of recv_priv structure

2016-10-07 Thread Ivan Safonov
This variable does not used. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c | 1 - drivers/staging/rtl8188eu/hal/usb_halinit.c| 1 - drivers/staging/rtl8188eu/include/rtw_recv.h | 1 - 3 files changed, 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/h

[PATCH 03/34] staging:r8188eu: remove pm_netdev_open function

2016-10-07 Thread Ivan Safonov
netdev_open and ips_netdrv_open are used instead of pm_netdev_open. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 2 +- drivers/staging/rtl8188eu/include/osdep_intf.h | 3 ++- drivers/staging/rtl8188eu/os_dep/os_intfs.c| 16 ++-- drivers/stagi

[PATCH 09/34] staging:r8188eu: remove wrappers for LedControl8188eu function

2016-10-07 Thread Ivan Safonov
There is no reason to use these wrappers. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 6 +++--- drivers/staging/rtl8188eu/core/rtw_mlme.c | 4 ++-- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 2 +- drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++--

[PATCH 32/34] staging:r8188eu: change poiter type from u8 to void for pallocated_frame_buf member of recv_priv structure

2016-10-07 Thread Ivan Safonov
pallocated_frame_buf used only to preserve pointer for vfree function. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_recv.c| 2 +- drivers/staging/rtl8188eu/include/rtw_recv.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188e

[PATCH 17/34] staging:r8188eu: remove RF_TYPE_8190P enumeration

2016-10-07 Thread Ivan Safonov
This enumeration does not used. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h b/drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h index 0976a7

[PATCH 08/34] staging:r8188eu: remove ff_hwaddr member of recv_priv structure

2016-10-07 Thread Ivan Safonov
Its value used instead. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 4 +--- drivers/staging/rtl8188eu/include/rtw_recv.h | 1 - drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 6 +++--- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/d

[PATCH 16/34] staging:r8188eu: remove rf_chip member of hal_data_8188e structure

2016-10-07 Thread Ivan Safonov
This member is constant. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/phy.c | 13 + drivers/staging/rtl8188eu/hal/usb_halinit.c | 6 -- drivers/staging/rtl8188eu/include/rtl8188e_hal.h | 1 - 3 files changed, 1 insertion(+), 19 deletions(-) d

[PATCH 12/34] staging:r8188eu: remove bLedOpenDrain member of hal_data_8188e structure

2016-10-07 Thread Ivan Safonov
bLedOpenDrain always is true. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/rtl8188eu_led.c| 18 ++ drivers/staging/rtl8188eu/include/rtl8188e_hal.h | 2 -- 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e

[PATCH 22/34] staging:r8188eu: remove rtw_endofpktfile function

2016-10-07 Thread Ivan Safonov
rtw_endofpktfile is one-line function. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 2 +- drivers/staging/rtl8188eu/include/xmit_osdep.h | 1 - drivers/staging/rtl8188eu/os_dep/xmit_linux.c | 5 - 3 files changed, 1 insertion(+), 7 deletions(-) diff --gi

[PATCH 30/34] staging:r8188eu: remove rx_pending_cnt member of recv_priv structure

2016-10-07 Thread Ivan Safonov
Value of this variable does not used. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_recv.c| 2 -- drivers/staging/rtl8188eu/include/rtw_recv.h | 2 -- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 4 3 files changed, 8 deletions(-) diff --git a/drivers

[PATCH 20/34] staging:r8188eu: remove bTXPowerTrackingInit member of odm_rf_cal structure

2016-10-07 Thread Ivan Safonov
bTXPowerTrackingInit assigned, but not used. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/odm.c | 1 - drivers/staging/rtl8188eu/hal/phy.c | 1 - drivers/staging/rtl8188eu/include/odm.h | 1 - 3 files changed, 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/od

[PATCH 31/34] staging:r8188eu: remove precv_frame_buf member of recv_priv structure

2016-10-07 Thread Ivan Safonov
precv_frame_buf is used as local variable only in one function. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_recv.c| 4 +--- drivers/staging/rtl8188eu/include/rtw_recv.h | 1 - 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/

[PATCH 28/34] staging:r8188eu: remove intf_stop member of adapter structure

2016-10-07 Thread Ivan Safonov
call usb_intf_stop directly. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/drv_types.h | 1 - drivers/staging/rtl8188eu/include/hal_intf.h | 1 + drivers/staging/rtl8188eu/os_dep/os_intfs.c | 3 +-- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 7 ++- 4 files changed

[PATCH 10/34] staging:r8188eu: remove bRegUseLed member of led_priv structure

2016-10-07 Thread Ivan Safonov
bRegUseLed always is true. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_led.c | 5 - drivers/staging/rtl8188eu/hal/rtl8188eu_led.c | 1 - drivers/staging/rtl8188eu/include/rtw_led.h | 1 - 3 files changed, 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/co

[PATCH 26/34] staging:r8188eu: change type of the precv_buf member of recv_priv structure

2016-10-07 Thread Ivan Safonov
To avoid unnecessary typecast. To use compiler type checking. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c | 6 +++--- drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +- drivers/staging/rtl8188eu/include/rtw_recv.h | 2 +- drivers/staging/rtl8188eu/o

[PATCH 18/34] staging:r8188eu: remove NumTotalRFPath member of hal_data_8188e structure

2016-10-07 Thread Ivan Safonov
NumTotalRFPath is 1 for r8188eu chip. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/phy.c | 11 ++-- drivers/staging/rtl8188eu/hal/rf.c| 20 +++ drivers/staging/rtl8188eu/hal/rf_cfg.c| 70 --- drivers/staging/rtl81

[PATCH 23/34] staging:r8188eu: remove padapter and free_sz arguments of rtw_os_xmit_resource_free function

2016-10-07 Thread Ivan Safonov
These argumets does not used by rtw_os_xmit_resource_free function. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 5 ++--- drivers/staging/rtl8188eu/include/xmit_osdep.h | 3 +-- drivers/staging/rtl8188eu/os_dep/xmit_linux.c | 3 +-- 3 files changed, 4 inserti

[PATCH 05/34] staging:r8188eu: remove skb data alignment in r8188eu driver code

2016-10-07 Thread Ivan Safonov
(__)netdev_alloc_skb align skb data. Also this function set skb device. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c | 10 +- drivers/staging/rtl8188eu/include/rtw_recv.h | 2 -- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 8 +--- 3 fi

[PATCH 29/34] staging:r8188eu: remove free_recvframe_cnt member of recv_priv structure

2016-10-07 Thread Ivan Safonov
Value of free_recvframe_cnt does not used. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_recv.c| 33 ++-- drivers/staging/rtl8188eu/include/rtw_recv.h | 1 - 2 files changed, 2 insertions(+), 32 deletions(-) diff --git a/drivers/staging/rtl8188e

[PATCH 11/34] staging:r8188eu: remove bLedStartToLinkBlinkInProgress and bSWLedCtrl members of LED_871x structure

2016-10-07 Thread Ivan Safonov
These members of LED_871x structure does not used. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_led.c| 1 - drivers/staging/rtl8188eu/include/rtw_led.h | 3 --- 2 files changed, 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_led.c b/drivers/staging/rtl

[PATCH 15/34] staging:r8188eu: remove Antenna_(Lfet|Right) enumeration items

2016-10-07 Thread Ivan Safonov
These defintions does not used. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index b1740cf..87e379e 100644 --- a/drive

[PATCH 33/34] staging:r8188eu: refactor recvbuf2recvframe function

2016-10-07 Thread Ivan Safonov
Reduce number of nesting levels. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 31 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c b/drivers/staging/rtl8188eu/os_dep/us

[PATCH 14/34] staging:r8188eu: remove unused members of hal_data_8188e structure

2016-10-07 Thread Ivan Safonov
These members of hal_data_8188e structure does not used. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 3 --- drivers/staging/rtl8188eu/include/rtl8188e_hal.h | 13 - 2 files changed, 16 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/us

[PATCH 24/34] staging:r8188eu: remove unused function declerations

2016-10-07 Thread Ivan Safonov
rtl8188eu_recv_hdl and rtl8188e_query_rx_phy_status doesn't used. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/rtl8188e_recv.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtl8188e_recv.h b/drivers/staging/rtl8188eu/include/rtl8188e

[PATCH 07/34] staging:r8188eu: remove (u32 cnt) argument of usb_read_port function

2016-10-07 Thread Ivan Safonov
This argument does not used by usb_read_port function. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +- drivers/staging/rtl8188eu/include/usb_ops_linux.h | 2 +- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 8 3 files changed, 6 insertions

[PATCH 19/34] staging:r8188eu: refactor rtl88eu_dm_txpower_tracking_callback_thermalmeter function

2016-10-07 Thread Ivan Safonov
Remove is2t and rf local variables from this function. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/phy.c | 34 +++--- 1 file changed, 7 insertions(+), 27 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/phy.c b/drivers/staging/rtl8188eu/hal/

[PATCH 34/34] staging:r8188eu: remove unnecessary type cast for update_recvframe_phyinfo_88e argument

2016-10-07 Thread Ivan Safonov
pphy_status alreay is (struct phy_stat *). Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c ind

[PATCH 06/34] staging:r8188eu: change usb_read_port last argument type to (struct *recv_buf)

2016-10-07 Thread Ivan Safonov
To avoid unnecessary typecasts. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +- drivers/staging/rtl8188eu/include/usb_ops_linux.h | 2 +- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 9 - 3 files changed, 6 insertions(+), 7 deletions(-) d

Re: [PATCH 0/6] Introduce Juniper CBC FPGA

2016-10-07 Thread Pantelis Antoniou
Hi Greg, > On Oct 7, 2016, at 18:39 , Greg Kroah-Hartman > wrote: > > On Fri, Oct 07, 2016 at 06:20:08PM +0300, Pantelis Antoniou wrote: >> Add Juniper's PTX1K CBC FPGA driver. Those FPGAs >> are present in Juniper's PTX series of routers. >> >> The MFD driver provices a gpio device and a spec

Re: [PATCH] Staging:fbtft/fb_s6d02a1.c: fixed 80 character line limit coding

2016-10-07 Thread Nadim Almas
why its seems worst to you i am just removing "80 character line limit coding style" for the last 3 months I am trying to submit my first patch but patch is not accepted by you by giving reason i can't able to understand please help me On Fri, Oct 7, 2016 at 10:37 PM, Greg KH wrote: > On Fri, Oc

Re: [RFC 1/2] staging: jnx: Add Juniper connector driver

2016-10-07 Thread Pantelis Antoniou
Hi Joe, > On Oct 7, 2016, at 19:25 , Joe Perches wrote: > > On Fri, 2016-10-07 at 18:16 +0300, Pantelis Antoniou wrote: >> diff --git a/drivers/staging/jnx/jnx-connector.c >> b/drivers/staging/jnx/jnx-connector.c > [] >> +struct jnx_conn_data { >> +struct device *dev; /* parent

[staging:staging-testing 4/6] ERROR: "v6_dma_map_area" [drivers/staging/vc04_services/vchiq.ko] undefined!

2016-10-07 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 4d76986a55999546d4ef4f14e2a7a5c770be38f0 commit: 69b5c631ef53ada80d8796f2db3e2b8c4bdf0d4a [4/6] staging/vchi: Remove dependency on CONFIG_BROKEN. config: arm-allmodconfig (attached as .config) compi

Re: [PATCH] Staging:fbtft/fb_s6d02a1.c: fixed 80 character line limit coding

2016-10-07 Thread Joe Perches
On Sat, 2016-10-08 at 00:25 +0530, Nadim Almas wrote: > why its seems worst to you i am just removing "80 character line > limit coding style" > for the last 3 months I am trying to submit my first patch but patch > is not accepted by you by giving reason i can't able to understand > please help m

[PATCH] Staging:greybus:arche-apb-ctrl: fix trailing */ Block comments and 80 character line limit coding style issue

2016-10-07 Thread Nadim Almas
Fixed coding style issue Signed-off-by: Nadim Almas --- drivers/staging/greybus/arche-apb-ctrl.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/arche-apb-ctrl.c b/drivers/staging/greybus/arche-apb-ctrl.c index 70323aa..eeba912 100644 --- a

Re: [PATCH] Staging:greybus:arche-apb-ctrl: fix trailing */ Block comments and 80 character line limit coding style issue

2016-10-07 Thread Joe Perches
On Fri, 2016-10-07 at 13:23 -0700, Nadim Almas wrote: > Fixed coding style issue > diff --git a/drivers/staging/greybus/arche-apb-ctrl.c > b/drivers/staging/greybus/arche-apb-ctrl.c [] > @@ -168,7 +168,10 @@ static int standby_boot_seq(struct platform_device *pdev) > if (apb->init_disabled)

Re: [PATCH 0/6] Introduce Juniper CBC FPGA

2016-10-07 Thread Greg Kroah-Hartman
On Fri, Oct 07, 2016 at 09:53:29PM +0300, Pantelis Antoniou wrote: > Hi Greg, > > > On Oct 7, 2016, at 18:39 , Greg Kroah-Hartman > > wrote: > > > > On Fri, Oct 07, 2016 at 06:20:08PM +0300, Pantelis Antoniou wrote: > >> Add Juniper's PTX1K CBC FPGA driver. Those FPGAs > >> are present in Junip

Re: [PATCH 1/3] Staging: i4l: Warning "Prefer "pr_debug over printk(KERN_DEBUG... " fixed

2016-10-07 Thread Joe Perches
On Fri, 2016-10-07 at 22:27 +0530, Harman Kalra wrote: > Warning "Prefer "pr_debug over printk(KERN_DEBUG... " and "few line more than > 80 character" fixed The commit subject and message doesn't match the code change. > diff --git a/drivers/staging/i4l/icn/icn.h b/drivers/staging/i4l/icn/icn.h

[PATCH v2 1/2] Staging:greybus:arche-apb-ctrl: fix trailing */ Block comments and 80 character line limit coding style issue

2016-10-07 Thread Nadim Almas
Fixed coding style issue Signed-off-by: Nadim Almas --- Changes in v2: - Used space after leading * in block comments. drivers/staging/greybus/arche-apb-ctrl.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/arche-apb-ctrl.c b/drivers/st

[PATCH 0/3] Add support for led triggers on phy link state change

2016-10-07 Thread Zach Brown
Fix skge driver that declared enum contants that conflicted with enum constants in linux/leds.h Create function that encapsulates actions taken during the adjust phy link step of phy state changes. Add support for led triggers on phy link state changes by adding a config option. When set the conf

[RFC v3 1/3] skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace

2016-10-07 Thread Zach Brown
Adding led support for phy causes namespace conflicts for some phy drivers. The marvel skge driver declared an enum for representing the states of Link LED Register. The enum contained constant LED_OFF which conflicted with declartation found in linux/leds.h. LED_OFF changed to LED_REG_OFF Also ch

[RFC v3 3/3] phy, leds: add support for led triggers on phy link state change

2016-10-07 Thread Zach Brown
From: Josh Cartwright Create an option CONFIG_LED_TRIGGER_PHY (default n), which will create a set of led triggers for each instantiated PHY device. There is one LED trigger per link-speed, per-phy. This allows for a user to configure their system to allow a set of LEDs to represent link state

[RFC v3 2/3] phy: Encapsulate actions performed during link state changes into function phy_adjust_link

2016-10-07 Thread Zach Brown
During phy state machine state transitions some set of actions should occur whenever the link state changes. These actions should be encapsulated into a single function This patch adds the phy_adjust_link function, which is called whenever phydev->adjust_link would have been called before. Actions

[PATCH] drivers: staging: greybus: Fixed CHECKS for brace issues

2016-10-07 Thread Chase Metzger
Added braces to else statements where checkpatch complained. Signed-off-by: Chase Metzger --- drivers/staging/greybus/audio_codec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c index 8a0744b.