[PATCH RESEND 05/12] staging: wlan-ng: avoid CamelCase: hfa384x_CommTallies16

2016-10-19 Thread Sergio Paracuellos
Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wl

[PATCH 5/5] staging: wlan-ng: Replace data type declaration with variable of same type in prism2sta.c

2016-10-19 Thread Sergio Paracuellos
sizeof(*var) instead of sizeof(struct XXX) is preferred. Fix them in prism2sta.c file. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/prism2sta.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-

[PATCH 10/12] staging: wlan-ng: avoid CamelCase: hfa384x_AuthRequest

2016-10-19 Thread Sergio Paracuellos
Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wl

[PATCH RESEND 06/12] staging: wlan-ng: avoid CamelCase: hfa384x_ChInfoResult

2016-10-19 Thread Sergio Paracuellos
Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/

[PATCH RESEND 08/12] staging: wlan-ng: avoid CamelCase: hfa384x_HScanResult

2016-10-19 Thread Sergio Paracuellos
Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wl

[PATCH RESEND 04/12] staging: wlan-ng: avoid CamelCase in fields of struct hfa384x_dbmcommsquality

2016-10-19 Thread Sergio Paracuellos
Replace CamelCase fields of struct with underscores to comply with the standard kernel coding style Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/stag

[PATCH RESEND 03/12] staging: wlan-ng: avoid CamelCase: hfa384x_WPAData

2016-10-19 Thread Sergio Paracuellos
Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 2 +- drivers/staging/wlan-ng/prism2mib.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/st

[PATCH RESEND 01/12] staging: wlan-ng: avoid CamelCase: HFA384x_RID_CNFAPBCNint

2016-10-19 Thread Sergio Paracuellos
Replace CamelCase define to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h| 2 +- drivers/staging/wlan-ng/prism2mgmt.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x

[PATCH 07/12] staging: wlan-ng: avoid CamelCase: hfa384x_HScanResultSub

2016-10-19 Thread Sergio Paracuellos
Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h| 4 ++-- drivers/staging/wlan-ng/prism2mgmt.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/driver

[PATCH 03/12] staging: wlan-ng: avoid CamelCase: hfa384x_WPAData

2016-10-19 Thread Sergio Paracuellos
Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 2 +- drivers/staging/wlan-ng/prism2mib.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/st

[PATCH RESEND 10/12] staging: wlan-ng: avoid CamelCase: hfa384x_AuthRequest

2016-10-19 Thread Sergio Paracuellos
Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wl

[PATCH RESEND 12/12] staging: wlan-ng: avoid CamelCase: hfa384x_KeyIDChanged

2016-10-19 Thread Sergio Paracuellos
Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wl

[PATCH RESEND 11/12] staging: wlan-ng: avoid CamelCase: hfa384x_PSUserCount

2016-10-19 Thread Sergio Paracuellos
Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wl

[PATCH RESEND 07/12] staging: wlan-ng: avoid CamelCase: hfa384x_HScanResultSub

2016-10-19 Thread Sergio Paracuellos
Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h| 4 ++-- drivers/staging/wlan-ng/prism2mgmt.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/driver

[PATCH RESEND 09/12] staging: wlan-ng: avoid CamelCase: hfa384x_LinkStatus

2016-10-19 Thread Sergio Paracuellos
Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wl

Re: [PATCH 3/7] iio: light: tsl2583: use DEVICE_ATTR_{RO, RW, WO} macros

2016-10-19 Thread Jonathan Cameron
On 19 October 2016 11:32:06 BST, Brian Masney wrote: >Use the DEVICE_ATTR_RO, IIO_DEVICE_ATTR_RW, and IIO_DEVICE_ATTR_WO >macros to create the device attributes. > >Signed-off-by: Brian Masney Hi Brian, One very quick comment. Driver should be using an iio_chan_spec array and relevant inf

Re: [PATCH 02/37] staging:r8188eu: remove device assignment after netdev_alloc_skb call

2016-10-19 Thread Andy Shevchenko
On Wed, 2016-10-19 at 22:07 +0700, Ivan Safonov wrote: > netdev_alloc_skb function > already set dev member of pkt_copy. It might be one line. Some special references: functions: function() structs: struct my_struct P.S. Entire series lacks of cover letter. > > Signed-off-by: Ivan Safonov > -

Re: [PATCH 02/37] staging:r8188eu: remove device assignment after netdev_alloc_skb call

2016-10-19 Thread Andy Shevchenko
On Wed, 2016-10-19 at 19:53 +0300, Andy Shevchenko wrote: > On Wed, 2016-10-19 at 22:07 +0700, Ivan Safonov wrote: > > > > netdev_alloc_skb function > > already set dev member of pkt_copy. > > It might be one line. > > Some special references: > functions: function() > structs: struct my_struct

RE: [PATCH] staging: unisys: visorbus: visorchannel: Refactor locking code to be statically deterministic.

2016-10-19 Thread Sell, Timothy C
On Wednesday, October 19, 2016 7:31 AM, Cathal Mullaney wrote: > This patch makes locking in visorchannel_signalempty statically deterministic. > As a result this patch fixes the sparse warning: > Context imbalance in 'visorchannel_signalempty' - different lock contexts for > basic block. > > The

[PATCH 0/5] staging: rtl8188eu: os_dep: fix checkpatch issues

2016-10-19 Thread Pierre-Yves Kerbrat
Hi all, This patchset fixes some of the checkpatch issues found in osdep_service.c file of rtl8188eu Pierre-Yves Kerbrat (5): staging: rtl8188eu: os_dep: remove empty lines staging: rtl8188eu: os_dep: fix block comment alignment issue staging: rtl8188eu: os_dep: fix missing spaces around op

[PATCH 4/5] staging: rtl8188eu: os_dep: remove unnecessary parentheses

2016-10-19 Thread Pierre-Yves Kerbrat
Remove parentheses in _rtw_init_queue to fix checkpatch warning Signed-off-by: Pierre-Yves Kerbrat --- drivers/staging/rtl8188eu/os_dep/osdep_service.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/osdep_service.c b/drivers/staging/rt

[PATCH 3/5] staging: rtl8188eu: os_dep: fix missing spaces around operators

2016-10-19 Thread Pierre-Yves Kerbrat
Fix missing space around operators in rtw_alloc2d function in osdep_service.c Signed-off-by: Pierre-Yves Kerbrat --- drivers/staging/rtl8188eu/os_dep/osdep_service.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/osdep_service.c b/driver

[PATCH 5/5] staging: rtl8188eu: os_dep: remove unnecessary alloc fail message

2016-10-19 Thread Pierre-Yves Kerbrat
Remove redundant alloc fail message This patch fixes the warning found by checkpatch Signed-off-by: Pierre-Yves Kerbrat --- drivers/staging/rtl8188eu/os_dep/osdep_service.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/osdep_service.

[PATCH 2/5] staging: rtl8188eu: os_dep: fix block comment alignment issue

2016-10-19 Thread Pierre-Yves Kerbrat
Fix coding style issue in block comment in osdep_service.c found by checkpatch tool Signed-off-by: Pierre-Yves Kerbrat --- drivers/staging/rtl8188eu/os_dep/osdep_service.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/osdep_service.c

[PATCH 1/5] staging: rtl8188eu: os_dep: remove empty lines

2016-10-19 Thread Pierre-Yves Kerbrat
Remove unnecessary empty lines (issue found by checkpatch) Signed-off-by: Pierre-Yves Kerbrat --- drivers/staging/rtl8188eu/os_dep/osdep_service.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/osdep_service.c b/drivers/staging/rtl8188eu/os_dep/osdep_servi

[PATCH v2] staging: unisys: visorbus: visorchannel: Refactor locking code to be statically deterministic.

2016-10-19 Thread Cathal Mullaney
This patch makes locking in visorchannel_signalempty statically deterministic. As a result this patch fixes the sparse warning: Context imbalance in 'visorchannel_signalempty' - different lock contexts for basic block. The logic of the locking code doesn't change but the layout of the original cod

Re: [PATCH] staging: unisys: visorbus: visorchannel: Refactor locking code to be statically deterministic.

2016-10-19 Thread Chuckleberryfinn
On Wed, Oct 19, 2016 at 05:00:53PM +, Sell, Timothy C wrote: > On Wednesday, October 19, 2016 7:31 AM, Cathal Mullaney wrote: > > This patch makes locking in visorchannel_signalempty statically > > deterministic. > > As a result this patch fixes the sparse warning: > > Context imbalance in 'vi

RE: [PATCH v2] staging: unisys: visorbus: visorchannel: Refactor locking code to be statically deterministic.

2016-10-19 Thread Kershner, David A
> -Original Message- > From: Cathal Mullaney [mailto:chuckleberryf...@gmail.com] > Subject: [PATCH v2] staging: unisys: visorbus: visorchannel: Refactor locking > code to be statically deterministic. > > This patch makes locking in visorchannel_signalempty statically > deterministic. > As

[PATCH] staging: ks7010: Add spaces around '*'

2016-10-19 Thread Nick Rosbrook
Added spaces around a '*' in ks7010_sdio.c. Issue found by checkpatch. Signed-off-by: Nick Rosbrook --- drivers/staging/ks7010/ks7010_sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c index b029

RE: [PATCH v2] staging: unisys: visorbus: visorchannel: Refactor locking code to be statically deterministic.

2016-10-19 Thread Sell, Timothy C
> -Original Message- > From: Kershner, David A > Sent: Wednesday, October 19, 2016 8:04 PM > To: Cathal Mullaney > Subject: RE: [PATCH v2] staging: unisys: visorbus: visorchannel: Refactor > locking code to be statically deterministic. > > > -Original Message- > > From: Cathal Mu

<    1   2