Re: [PATCH 22/29] drivers, scsi: convert iscsi_task.refcount from atomic_t to refcount_t

On 03/09/2017 08:18 AM, Reshetova, Elena wrote: >> On Mon, Mar 06, 2017 at 04:21:09PM +0200, Elena Reshetova wrote: >>> refcount_t type and corresponding API should be >>> used instead of atomic_t when the variable is used as >>> a reference counter. This allows to avoid accidental >>> refcounter o

Re: [PATCH] staging, android: remove lowmemory killer from the tree

Greg, do you see any obstacle to have this merged. The discussion so far shown that a) vendors are not using the code as is b) there seems to be an agreement that something else than we have in the kernel is really needed. On Wed 22-02-17 13:01:21, Michal Hocko wrote: > From: Michal Hocko > > Lo

RE: [PATCH 22/29] drivers, scsi: convert iscsi_task.refcount from atomic_t to refcount_t

> On 03/09/2017 08:18 AM, Reshetova, Elena wrote: > >> On Mon, Mar 06, 2017 at 04:21:09PM +0200, Elena Reshetova wrote: > >>> refcount_t type and corresponding API should be > >>> used instead of atomic_t when the variable is used as > >>> a reference counter. This allows to avoid accidental > >>>

Re: [PATCH] staging, android: remove lowmemory killer from the tree

On Thu, Mar 09, 2017 at 10:15:13AM +0100, Michal Hocko wrote: > Greg, do you see any obstacle to have this merged. The discussion so far > shown that a) vendors are not using the code as is b) there seems to be > an agreement that something else than we have in the kernel is really > needed. Well,

Re: [PATCH 22/29] drivers, scsi: convert iscsi_task.refcount from atomic_t to refcount_t

On 03/09/2017 10:26 AM, Reshetova, Elena wrote: > >> On 03/09/2017 08:18 AM, Reshetova, Elena wrote: On Mon, Mar 06, 2017 at 04:21:09PM +0200, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a refer

Re: [PATCH] staging, android: remove lowmemory killer from the tree

On Thu 09-03-17 10:30:28, Greg KH wrote: > On Thu, Mar 09, 2017 at 10:15:13AM +0100, Michal Hocko wrote: > > Greg, do you see any obstacle to have this merged. The discussion so far > > shown that a) vendors are not using the code as is b) there seems to be > > an agreement that something else than

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-06 17:04 GMT+01:00 Daniel Vetter : > On Mon, Mar 06, 2017 at 11:58:05AM +0100, Mark Brown wrote: >> On Mon, Mar 06, 2017 at 11:40:41AM +0100, Daniel Vetter wrote: >> >> > No one gave a thing about android in upstream, so Greg KH just dumped it >> > all into staging/android/. We've discussed

[PATCH] Minor Fix to please checkpatch Declaring 'unsigned int' instead of 'unsigned'

Signed-off-by: Pushkar Jambhlekar --- drivers/staging/lustre/lustre/llite/vvp_dev.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/vvp_dev.c b/drivers/staging/lustre/lustre/llite/vvp_dev.c index 12c129f7e..8d78755 100644 --- a/dri

Re: [PATCH] Minor Fix to please checkpatch Declaring 'unsigned int' instead of 'unsigned'

On Thu, Mar 09, 2017 at 05:20:51PM +0530, Pushkar Jambhlekar wrote: > Signed-off-by: Pushkar Jambhlekar > --- > drivers/staging/lustre/lustre/llite/vvp_dev.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent

[PATCH] Minor coding guideline Fix in lusture module

Replacing 'unsigned' with 'unsigned int' in vvp_pgcache_id. Checkpath.pl passed. Signed-off-by: Pushkar Jambhlekar --- drivers/staging/lustre/lustre/llite/vvp_dev.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/vvp_dev.c b/driv

Re: [PATCH] drivers: android: staging: ion: cosmetic fixes

On Sun, Mar 05, 2017 at 11:30:26PM +, P Kapadia wrote: > - remove extra line  > - remove unnecessary paranthesis > > Signed-off-by: Purnendu Kapadia I can't accept patches sent in html format :( Please fix up and resend. thanks, greg k-h ___ dev

Re: [PATCH] staging: android: ashmem: lseek failed due to no FMODE_LSEEK.

On Wed, Mar 08, 2017 at 06:18:32PM +0800, zhangshuxia...@gmail.com wrote: > From: zhangshuxiao > > vfs_llseek will check whether the file mode has > FMODE_LSEEK, no return failure. But ashmem can be > lseek, so add FMODE_LSEEK to ashmem file. Really? What is causing this failure? I haven't hea

Re: [PATCH] staging, android: remove lowmemory killer from the tree

On Thu, Mar 09, 2017 at 11:00:07AM +0100, Michal Hocko wrote: > On Thu 09-03-17 10:30:28, Greg KH wrote: > > On Thu, Mar 09, 2017 at 10:15:13AM +0100, Michal Hocko wrote: > > > Greg, do you see any obstacle to have this merged. The discussion so far > > > shown that a) vendors are not using the cod

Re: [PATCH v2 05/12] staging: ks7010: remove unnecessary parenthesis

On Thu, Mar 09, 2017 at 03:47:05PM +1100, Tobin C. Harding wrote: > Checkpatch emits CHECK: Unnecessary parentheses. > > Remove unnecessary parentheses. > > Signed-off-by: Tobin C. Harding > --- > drivers/staging/ks7010/ks_hostif.c | 24 > 1 file changed, 12 insertions(

Re: [PATCH v2 03/12] staging: ks7010: replace C types with kernel types

On Thu, Mar 09, 2017 at 03:47:03PM +1100, Tobin C. Harding wrote: > Checkpatch emits CHECK prefer kernel type. Source and header file use > C standard types uintN_t. > > Replace C standard types with kernel types. uintN_t -> uN Can you just replace one type at a time? Makes it much easier to rev

Re: [PATCH v4] staging: rtl8192e: remove unnecesary whitespace in rtl_wx.c

On Wed, Mar 01, 2017 at 04:38:31PM +0530, Sumantro wrote: > Remove unnecessary whiteshpaces in rtl_wc. > > Problems found by checkpatch.pl. > > Signed-off-by: Sumantro Mukherjee Your signed-off-by: line does not match your "From:" name :( ___ devel ma

Re: [PATCH 1/2] Staging: xgifb: XGI_main_26.c: non-standard C

On Thu, Mar 09, 2017 at 12:28:43AM +0530, Manoj Sawai wrote: > Fixed a checkpatch warning about use of %Lx instead of %llx. > > Signed-off-by: Manoj Sawai > --- > drivers/staging/xgifb/XGI_main_26.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) You sent 2 patches with the same exact s

Re: [PATCH] Minor coding guideline Fix in lusture module

On Thu, Mar 09, 2017 at 05:52:07PM +0530, Pushkar Jambhlekar wrote: > Replacing 'unsigned' with 'unsigned int' in vvp_pgcache_id. > Checkpath.pl passed. > > Signed-off-by: Pushkar Jambhlekar > --- > drivers/staging/lustre/lustre/llite/vvp_dev.c | 9 - > 1 file changed, 4 insertions(+),

Re: [PATCH 1/6] staging: speakup: Add blank line after function/struct/union/enum declarations

On Sat, Mar 04, 2017 at 01:47:04AM +0530, Arushi Singhal wrote: > This patch fixes the warnings reported by checkpatch.pl > for please use a blank line after function/struct/union/enum > declarations. > > Signed-off-by: Arushi Singhal > --- > drivers/staging/speakup/main.c | 1 + > drive

Re: [RFC PATCH v2 12/32] x86: Add early boot support when running with SEV active

On Thu, Mar 02, 2017 at 10:14:48AM -0500, Brijesh Singh wrote: > From: Tom Lendacky > > Early in the boot process, add checks to determine if the kernel is > running with Secure Encrypted Virtualization (SEV) active by issuing > a CPUID instruction. > > During early compressed kernel booting, if

[PATCH 1/2] Staging: xgifb: XGI_main_26.c: Fix a checkpatch warning

Fixes a checkpatch warning about use of non-standard C WARNING: %Lx is non-standard C, use %llx Signed-off-by: Manoj Sawai --- drivers/staging/xgifb/XGI_main_26.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI

[PATCH 2/2] Staging: xgifb: XGI_main_26.c: non-standard C

Fixes the following warning: "WARNING: %Lx is non-standard C, use %llx" Signed-off-by: Manoj Sawai --- drivers/staging/xgifb/XGI_main_26.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c i

[PATCH] staging: lustre: replace simple_strtoul with kstrtoint

Replace simple_strtoul with kstrtoint. simple_strtoul is marked for obsoletion. Signed-off-by: Marcin Ciupak --- drivers/staging/lustre/lustre/obdclass/obd_mount.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/obd

Re: [RFC PATCH v2 12/32] x86: Add early boot support when running with SEV active

On 09/03/2017 15:07, Borislav Petkov wrote: > + /* Check if running under a hypervisor */ > + eax = 0x4000; > + ecx = 0; > + native_cpuid(&eax, &ebx, &ecx, &edx); This is not how you check if running under a hypervisor; you should check the HYPERVISOR bit, i.e. bit 31 of cpui

[PATCH] staging: ks7010: removed code in comments.

Commenting Code Is a Bad Idea. Comments are their to explain the code and how the code achieves its goal and as codes in the comments does not explain what the code is doing so there is no use of commenting them. So in this patch codes in the comments are removed. Signed-off-by: Arushi Singhal -

Re: [PATCH 1/6] staging: speakup: Add blank line after function/struct/union/enum declarations

On Thu, Mar 09, 2017 at 07:33:50PM +0530, Arushi Singhal wrote: > > > On Thu, Mar 9, 2017 at 6:55 PM, Greg KH wrote: > > On Sat, Mar 04, 2017 at 01:47:04AM +0530, Arushi Singhal wrote: > > This patch fixes the warnings reported by checkpatch.pl > > for please use a blank line after

Re: [patch 0/3] speakup: support 16bit unicode screen reading

On Sat, Mar 04, 2017 at 03:01:54PM +0100, Samuel Thibault wrote: > Hello, > > This patch series adds 16bit unicode support to speakup, through three > patches: > > - extend synth buffer to 16bit unicode characters > - convert screen reading to 16bit characters > - add unicode variant of /dev/soft

Re: [RFC PATCH v2 12/32] x86: Add early boot support when running with SEV active

On Thu, Mar 09, 2017 at 05:13:33PM +0100, Paolo Bonzini wrote: > This is not how you check if running under a hypervisor; you should > check the HYPERVISOR bit, i.e. bit 31 of cpuid(1).ecx. This in turn > tells you if leaf 0x4000 is valid. Ah, good point, I already do that in the microcode lo

Re: [patch 0/3] speakup: support 16bit unicode screen reading

Greg KH, on jeu. 09 mars 2017 17:25:51 +0100, wrote: > This is the second version of this series, correct? Next time, please > put a "v2" in them so that I know which to apply. Ah, yes, sorry. The only difference was the Reviewed-by lines. Thanks! Samuel _

[PATCH 0/4] staging: speakup: checkpatch guided cleanups

Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (4): staging: speakup: Comparison to NULL could be written staging: speakup:indentation should use tabs staging: speakup: Alignment match open parenthesis staging: speakup: Placed Logical on the

[PATCH 1/4] staging: speakup: Comparison to NULL could be written

Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style. Signed-off-by: Arushi Singhal --- changes in v2 - fixed coding style error and upto the coding style. --- drivers/staging/speakup/fakekey.c | 2 +- drivers/staging/speaku

[PATCH 2/4] staging: speakup:indentation should use tabs

Indentation should always use tabs and never spaces. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/i18n.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c index 1a3e34880ac1..11f1418b4006 100644 --- a/

[PATCH 3/4] staging: speakup: Alignment match open parenthesis

Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal --- changes in v2 - Aligned the lines which are not aligned in previous patch. --- drivers/staging/speakup/i18n.c | 2 +- drivers/staging/speakup/kobjects.c | 40 +++-

[PATCH 4/4] staging: speakup: Placed Logical on the previous line

Placed Logical continuations on the previous line as reported by checkpatch.pl. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c index a12ec

Re: [PATCH] Staging: fbtft: fbtft-bus.c: checkpatch error

On Thu, Mar 09, 2017 at 12:59:57AM +0530, Manoj Sawai wrote: > Fixes a checkpatch error. > > "ERROR: space prohibited before that close parenthesis ')'" > > Signed-off-by: Manoj Sawai > --- > drivers/staging/fbtft/fbtft-bus.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff

Re: [PATCH 1/7] staging: media: Remove unnecessary typecast of c90 int constant

On Fri, Mar 03, 2017 at 01:21:56AM +0530, simran singhal wrote: > This patch removes unnecessary typecast of c90 int constant. > > WARNING: Unnecessary typecast of c90 int constant > > Signed-off-by: simran singhal > --- > drivers/staging/media/atomisp/i2c/gc2235.c | 6 +++--- > 1 file changed,

Re: [PATCH 1/2] staging: media: Clean up tests if NULL returned on failure

On Sat, Mar 04, 2017 at 12:25:18AM +0530, simran singhal wrote: > Some functions like kmalloc/kzalloc return NULL on failure. > When NULL represents failure, !x is commonly used. > > This was done using Coccinelle: > @@ > expression *e; > identifier l1; > @@ > > e = \(kmalloc\|kzalloc\|kcalloc\|d

Re: [PATCH] staging: media: Remove parentheses from return arguments

On Fri, Mar 03, 2017 at 10:31:39PM +0530, simran singhal wrote: > The sematic patch used for this is: > @@ > identifier i; > constant c; > @@ > return > - ( > \(i\|-i\|i(...)\|c\) > - ) > ; > > Signed-off-by: simran singhal > Acked-by: Julia Lawall > --- > .../media/atomisp/pci/atomisp2/c

[PATCH] staging: speakup: fix "Alignment match open parenthesis"

Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal --- drivers/staging/speakup/i18n.c | 2 +- drivers/staging/speakup/kobjects.c | 40 +++--- 2 files changed, 21 insertions(+), 21 deletions(-) diff --git a/

Re: [PATCH] staging: vt6655: Fixed some coding style issues

On Sat, Mar 04, 2017 at 07:46:04PM +, Tuomo Rinne wrote: > Copied function argument names from definition to delcaration. This > fixes some checkpatch warnings. Which warning did it fix? Please always be specific here, and in the subject line. thanks, greg k-h __

Re: [PATCH] staging: rtl8192u: fix spacing around if statements

On Thu, Mar 02, 2017 at 11:16:23PM +0100, Robin Krahl wrote: > Corrects the spacing around two if statements to fix these checkpatch.pl > errors: > > ERROR: space required before the open brace '{' > ERROR: space prohibited after that open parenthesis '(' > > Signed-off-by: Robin Krahl > --- >

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

On 03/09/2017 02:00 AM, Benjamin Gaignard wrote: > 2017-03-06 17:04 GMT+01:00 Daniel Vetter : >> On Mon, Mar 06, 2017 at 11:58:05AM +0100, Mark Brown wrote: >>> On Mon, Mar 06, 2017 at 11:40:41AM +0100, Daniel Vetter wrote: >>> No one gave a thing about android in upstream, so Greg KH just dum

[PATCH] staging: speakup: Simplify NULL comparisons

Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style. Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/fakekey.c | 2 +- drivers/staging/speakup/kobjects.c | 2

Re: [PATCH] Staging: fbtft: fbtft-bus.c: checkpatch error

Hi Manoj, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.11-rc1 next-20170309] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Manoj-Sawai/Staging-fbtft-fbtft

Re: [PATCH 1/2] Staging: wlan-ng: Fix sparse warnings by using appropriate endian types

On Fri, Mar 03, 2017 at 07:58:30PM +0100, Adrien Descamps wrote: > Fix some sparse warning by using correct endian types in structs and > local variables. > This patch only fix sparse warnings and do not change the logic. > > Signed-off-by: Adrien Descamps > --- > Compile tested only > drivers/s

Re: [PATCH 0/4] staging: speakup: checkpatch guided cleanups

On Thu, Mar 09, 2017 at 10:04:29PM +0530, Arushi Singhal wrote: > Improve readability by fixing multiple checkpatch.pl > issues in speakup driver. This series does not apply to my staging-testing branch at all. Please rebase and resend. thanks, greg k-h

Re: [PATCH] staging: speakup: fix "Alignment match open parenthesis"

On Thu, Mar 09, 2017 at 10:23:30PM +0530, Arushi Singhal wrote: > Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". > > Signed-off-by: Arushi Singhal > --- > drivers/staging/speakup/i18n.c | 2 +- > drivers/staging/speakup/kobjects.c | 40 > +++---

Re: [PATCH] staging: speakup: Simplify NULL comparisons

On Thu, Mar 09, 2017 at 11:19:49PM +0530, Arushi Singhal wrote: > Fixed coding style for null comparisons in speakup driver to be more > consistant with the rest of the kernel coding style. > Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'. > > Signed-off-by: Arushi Singhal > --- > driver

Re: [PATCH 1/2] Staging: xgifb: XGI_main_26.c: Fix a checkpatch warning

On Thu, Mar 09, 2017 at 07:59:52PM +0530, Manoj Sawai wrote: > Fixes a checkpatch warning about use of non-standard C > > WARNING: %Lx is non-standard C, use %llx > > Signed-off-by: Manoj Sawai > --- > drivers/staging/xgifb/XGI_main_26.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] staging: rtl8192e: fix coding style issue, improve error handling

Hi Suniel, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.11-rc1 next-20170309] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Suniel-Mahesh/staging-rtl8192e

[PATCH v2 0/5] staging: rtl8192e: Fix coding style, warnings and checks

From: Suniel Mahesh Fixed coding style issues and improved error handling, return -ENOMEM, if it is out of memory instead of err message. Pointer comparisions with NUll are replaced by logical NOT. Fixed unbalanced braces around else statement and preferred to pass a pointer as an argument to s

[PATCH v2 4/5] staging: rtl8192e: Fix unbalanced braces around else statement

From: Suniel Mahesh Fix unbalanced braces around else statement reported by checkpatch.pl Signed-off-by: Suniel Mahesh --- Changes for v2: - new patch addition to the series - Rebased on top of next-20170306 --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 17 ++--- 1 file chang

[PATCH v2 5/5] staging: rtl8192e: Pass a pointer as an argument to sizeof() instead of struct

From: Suniel Mahesh Prefer vzalloc(sizeof(*priv->pFirmware)...) over vzalloc(sizeof(struct rt_firmware)...) as reported by checkpatch.pl Signed-off-by: Suniel Mahesh --- Changes for v2: - new patch addition to the series - Rebased on top of next-20170306 --- drivers/staging/rtl8192e/rtl8192e/

[PATCH v2 1/5] staging: rtl8192e: Fix coding style issues

From: Suniel Mahesh Fix coding style issues and comments in rtl_core.c Signed-off-by: Suniel Mahesh --- Changes for v2: - Split larger patch into multiple commits as suggested by Dan Carpenter - This patch fixes coding style issues, comments in rtl_core.c reported by checkpatch.pl - Modified

[PATCH v2 3/5] staging: rtl8192e: Rectify pointer comparisions

From: Suniel Mahesh Pointer comparison with NULL replaced by logical NOT Signed-off-by: Suniel Mahesh --- Changes for v2: - Rectify pointer comparisions reported by checkpatch.pl in rtl_core.c - new patch addition to the series - Rebased on top of next-20170306 --- drivers/staging/rtl8192e/rt

[PATCH v2 2/5] staging: rtl8192e: Improve error handling

From: Suniel Mahesh Return -ENOMEM, if it is out of memory Signed-off-by: Suniel Mahesh --- Changes for v2: - Improve error handling reported by checkpatch.pl in rtl_core.c - new patch addition to the series - Rebased on top of next-20170306 --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c |

[PATCH 0/6] staging: speakup: multiple checkpatch issues

Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (6): staging: speakup: fix "Alignment match open parenthesis" staging: speakup: Placed Logical on the previous line staging: speakup: spaces preferred around operator staging: speakup: identation

[PATCH 1/6] staging: speakup: fix "Alignment match open parenthesis"

Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal --- drivers/staging/speakup/i18n.c | 2 +- drivers/staging/speakup/kobjects.c | 40 +++--- 2 files changed, 21 insertions(+), 21 deletions(-) diff --git a/

[PATCH 2/6] staging: speakup: Placed Logical on the previous line

Placed Logical continuations on the previous line as reported by checkpatch.pl. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c index a12ec

[PATCH 3/6] staging: speakup: spaces preferred around operator

Fixed the checkpatch.pl issues like: CHECK: spaces preferred around that '&' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) etc. Signed-off-by: Arushi Singhal --- drivers/staging/spea

[PATCH 4/6] staging: speakup: identation should use tabs

Indentation should always use tabs and never spaces. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/speakup_dtlk.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/speakup/speakup_dtlk.h b/drivers/staging/speakup/speakup_dtlk.h index b3b3

[PATCH 6/6] staging: speakup: Add blank line after function/struct/union/enum declarations

This patch fixes the warnings reported by checkpatch.pl for please use a blank line after function/struct/union/enum declarations. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 1 + drivers/staging/speakup/serialio.c | 1 + drivers/staging/speakup/speakup_dtlk.c

[PATCH] Staging: xgifb: XGI_main_26.c: non-standard C

Fixes following checkpatch warning: "WARNING: %Lx is non-standard C, use %llx" Signed-off-by: Manoj Sawai --- drivers/staging/xgifb/XGI_main_26.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_ma

[PATCH 5/6] staging: speakup: Alignment should match open parenthesis

Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal --- drivers/staging/speakup/kobjects.c | 16 drivers/staging/speakup/main.c | 2 +- drivers/staging/speakup/selection.c | 2 +- drivers/staging/speakup/s

Re: [RFC PATCH v2 13/32] KVM: SVM: Enable SEV by setting the SEV_ENABLE CPU feature

On Thu, Mar 02, 2017 at 10:15:01AM -0500, Brijesh Singh wrote: > From: Tom Lendacky > > Modify the SVM cpuid update function to indicate if Secure Encrypted > Virtualization (SEV) is active in the guest by setting the SEV KVM CPU > features bit. SEV is active if Secure Memory Encryption is enable

[PATCH] staging: speakup: Unnecessary parentheses are removed.

Unnecessary parentheses are removed to improve readability. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/kobjects.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c index 9feb97dfd72b..8a5863

[PATCH] staging: speakup: Simplify "NULL" comparisons

Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style. Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/fakekey.c | 2 +- drivers/staging/speakup/main.c| 36 ++

Re: [PATCH v2 05/12] staging: ks7010: remove unnecessary parenthesis

On Thu, Mar 09, 2017 at 02:04:20PM +0100, Greg Kroah-Hartman wrote: > On Thu, Mar 09, 2017 at 03:47:05PM +1100, Tobin C. Harding wrote: > > Checkpatch emits CHECK: Unnecessary parentheses. > > > > Remove unnecessary parentheses. > > > > Signed-off-by: Tobin C. Harding > > --- > > drivers/stagin

Re: [PATCH v2 03/12] staging: ks7010: replace C types with kernel types

On Thu, Mar 09, 2017 at 02:04:45PM +0100, Greg Kroah-Hartman wrote: > On Thu, Mar 09, 2017 at 03:47:03PM +1100, Tobin C. Harding wrote: > > Checkpatch emits CHECK prefer kernel type. Source and header file use > > C standard types uintN_t. > > > > Replace C standard types with kernel types. uintN_

[PATCH 1/2] Staging: wlan-ng: Fix sparse warnings by using appropriate endian types

Fix some sparse warning by using correct endian types in structs and local variables. This patch only fix sparse warnings and do not change the logic. Signed-off-by: Adrien Descamps --- Compile tested only drivers/staging/wlan-ng/hfa384x.h | 54 +-- drivers/st

[PATCH 2/2] Staging: wlan-ng: Fix endian error

sparse report fixed: drivers/staging//wlan-ng//hfa384x_usb.c:3517:35: warning: restricted __be64 degrades to integer drivers/staging//wlan-ng//hfa384x_usb.c:3517:33: warning: incorrect type in assignment (different base types) drivers/staging//wlan-ng//hfa384x_usb.c:3517:33:expected restricte

Re: [PATCH v2 05/12] staging: ks7010: remove unnecessary parenthesis

On Fri, Mar 10, 2017 at 07:08:28AM +1100, Tobin C. Harding wrote: > On Thu, Mar 09, 2017 at 02:04:20PM +0100, Greg Kroah-Hartman wrote: > > On Thu, Mar 09, 2017 at 03:47:05PM +1100, Tobin C. Harding wrote: > > > Checkpatch emits CHECK: Unnecessary parentheses. > > > > > > Remove unnecessary parent

outreachy

Hello, I discussed the issue of outreachy patches for bcm with Greg, and we are not convinced that not having the patches CCd to you is such a good idea. While we don't want to spam you with noise, some of the applicants are starting to make more significant changes that it could be useful for you

Re: outreachy

Hi Julia, On 17-03-09 12:36 PM, Julia Lawall wrote: Hello, I discussed the issue of outreachy patches for bcm with Greg, and we are not convinced that not having the patches CCd to you is such a good idea. While we don't want to spam you with noise, some of the applicants are starting to make m

Re: outreachy

On 03/09/2017 01:51 PM, Scott Branden wrote: Hi Julia, On 17-03-09 12:36 PM, Julia Lawall wrote: Hello, I discussed the issue of outreachy patches for bcm with Greg, and we are not convinced that not having the patches CCd to you is such a good idea. While we don't want to spam you with noise,

Re: [PATCH v2 05/12] staging: ks7010: remove unnecessary parenthesis

On Thu, Mar 09, 2017 at 09:30:40PM +0100, Greg Kroah-Hartman wrote: > On Fri, Mar 10, 2017 at 07:08:28AM +1100, Tobin C. Harding wrote: > > On Thu, Mar 09, 2017 at 02:04:20PM +0100, Greg Kroah-Hartman wrote: > > > On Thu, Mar 09, 2017 at 03:47:05PM +1100, Tobin C. Harding wrote: > > > > Checkpatch

Re: outreachy

On Thu, Mar 09, 2017 at 01:56:49PM -0700, Stephen Warren wrote: > On 03/09/2017 01:51 PM, Scott Branden wrote: > > Hi Julia, > > > > On 17-03-09 12:36 PM, Julia Lawall wrote: > > > Hello, > > > > > > I discussed the issue of outreachy patches for bcm with Greg, and we are > > > not convinced that

Re: [Outreachy kernel] [PATCH 5/6] staging: speakup: Alignment should match open parenthesis

On Fri, 10 Mar 2017, Arushi Singhal wrote: > Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". > > Signed-off-by: Arushi Singhal > --- > if (synth_request_region(speakup_info.port_tts - 1, > - SYNTH_IO_EXTENT)) { > +

Re: outreachy

On 03/09/2017 01:20 PM, Greg KH wrote: > On Thu, Mar 09, 2017 at 01:56:49PM -0700, Stephen Warren wrote: >> On 03/09/2017 01:51 PM, Scott Branden wrote: >>> Hi Julia, >>> >>> On 17-03-09 12:36 PM, Julia Lawall wrote: Hello, I discussed the issue of outreachy patches for bcm with Greg

[PATCH v1 0/7] staging: gc2235: Multiple checkpatch issues

v1: -change the subject of all the patches of the patch-series simran singhal (7): staging: gc2235: Remove unnecessary typecast of c90 int constant staging: gc2235: Add blank line after a declaration staging: gc2235: Replace NULL with "!" staging: gc2235: Remove blank line before '}' an

[PATCH v1 4/7] staging: gc2235: Remove blank line before '}' and after '{' braces

Remove unneeded blank lines preceding/following '}' and '{' braces, as pointed out by checkpatch. This patch addresses the following checkpatch checks: CHECK: Blank lines aren't necessary before a close brace '}' CHECK: Blank lines aren't necessary after an open brace '{' Signed-off-by: simran s

[PATCH v1 5/7] staging: gc2235: Remove multiple assignments

Remove multiple assignments by factorizing them. Problem found using checkpatch.pl CHECK: multiple assignments should be avoided Signed-off-by: simran singhal --- drivers/staging/media/atomisp/i2c/gc2235.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/med

[PATCH v1 1/7] staging: gc2235: Remove unnecessary typecast of c90 int constant

This patch removes unnecessary typecast of c90 int constant. WARNING: Unnecessary typecast of c90 int constant Signed-off-by: simran singhal --- drivers/staging/media/atomisp/i2c/gc2235.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c

[PATCH v1 2/7] staging: gc2235: Add blank line after a declaration

Add blank line after a declaration. Problem found using checkpatch. This patch fixes these warning messages found by checkpatch.pl: WARNING : Missing a blank line after declarations. Signed-off-by: simran singhal --- drivers/staging/media/atomisp/i2c/gc2235.c | 7 +++ 1 file changed, 7 inse

[PATCH v1 3/7] staging: gc2235: Replace NULL with "!"

Use ! in comparison tests using "==NULL" rather than moving the "==NULL" to the right side of the test. Addesses multiple instances of the checkpatch.pl warning: WARNING: Comparisons should place the constant on the right side of the test Signed-off-by: simran singhal --- drivers/staging/media/

[PATCH v1 6/7] staging: gc2235: Use x instead of x != NULL

Use x instead of x != NULL . This patch removes the explicit NULL comparisons.This issue is found by checkpatch.pl script. Signed-off-by: simran singhal --- drivers/staging/media/atomisp/i2c/gc2235.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/

[PATCH v1 7/7] staging: gc2235: Do not use multiple blank lines

Remove multiple blank lines. Problem found using checkpatch.pl "CHECK: Please don't use multiple blank lines". Signed-off-by: simran singhal --- drivers/staging/media/atomisp/i2c/gc2235.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/gc2235.c b/drivers/

Re: [PATCH] net: hyperv: use new api ethtool_{get|set}_link_ksettings

On Wed, 8 Mar 2017 23:41:04 +0100 Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > > Signed-off-by: Philippe Reynes N

Re: [PATCH v4 13/36] [media] v4l2: add a frame timeout event

On 03/05/2017 02:41 PM, Russell King - ARM Linux wrote: On Sat, Mar 04, 2017 at 04:37:43PM -0800, Steve Longerbeam wrote: On 03/04/2017 02:56 AM, Sakari Ailus wrote: That's a bit of a special situation --- still there are alike conditions on existing hardware. You should return the buffers

[PATCH] Staging: iio: return expression instead of return ret

The following Coccinelle script was used to detect this: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Bo YU --- drivers/staging/iio/meter/ade7754.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/iio

[PATCH v5 02/39] [media] dt-bindings: Add bindings for i.MX media driver

Add bindings documentation for the i.MX media driver. Signed-off-by: Steve Longerbeam --- Documentation/devicetree/bindings/media/imx.txt | 74 + 1 file changed, 74 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/imx.txt diff --git a/Documentati

[PATCH v5 00/39] i.MX Media Driver

In version 5: - ov5640: renamed "pwdn-gpios" to "powerdown-gpios" - ov5640: add mutex lock around the subdev op entry points. - ov5640: don't attempt to program the new mode in ov5640_set_fmt(). Instead set a new flag, pending_mode_change, and program the new mode at s_stream() if flag is se

[PATCH v5 01/39] [media] dt-bindings: Add bindings for video-multiplexer device

From: Philipp Zabel Add bindings documentation for the video multiplexer device. Signed-off-by: Sascha Hauer Signed-off-by: Philipp Zabel Signed-off-by: Steve Longerbeam --- .../bindings/media/video-multiplexer.txt | 59 ++ 1 file changed, 59 insertions(+) crea

[PATCH v5 03/39] [media] dt/bindings: Add bindings for OV5640

Add device tree binding documentation for the OV5640 camera sensor. Signed-off-by: Steve Longerbeam --- .../devicetree/bindings/media/i2c/ov5640.txt | 45 ++ 1 file changed, 45 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5640.txt dif

[PATCH v5 04/39] ARM: dts: imx6qdl: Add compatible, clocks, irqs to MIPI CSI-2 node

Add to the MIPI CSI2 receiver node: compatible strings, interrupt sources, and clocks. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index 6d7bf64..d28a

[PATCH v5 10/39] ARM: dts: imx6-sabreauto: create i2cmux for i2c3

The sabreauto uses a steering pin to select between the SDA signal on i2c3 bus, and a data-in pin for an SPI NOR chip. Use i2cmux to control this steering pin. Idle state of the i2cmux selects SPI NOR. This is not a classic way to use i2cmux, since one side of the mux selects something other than a

[PATCH v5 06/39] ARM: dts: imx6qdl: add capture-subsystem device

Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6dl.dtsi | 5 + arch/arm/boot/dts/imx6q.dtsi | 5 + 2 files changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/imx6dl.dtsi b/arch/arm/boot/dts/imx6dl.dtsi index 8958c4a..a959c76 100644 --- a/arch/arm/boot/dts/imx6dl.dtsi +++

[PATCH v5 07/39] ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround

There is a pin conflict with GPIO_6. This pin functions as a power input pin to the OV5642 camera sensor, but ENET uses it as the h/w workaround for erratum ERR006687, to wake-up the ARM cores on normal RX and TX packet done events. So we need to remove the h/w workaround to support the OV5642. The

[PATCH v5 05/39] ARM: dts: imx6qdl: Add mipi_ipu1/2 multiplexers, mipi_csi, and their connections

From: Philipp Zabel This patch adds the device tree graph connecting the input multiplexers to the IPU CSIs and the MIPI-CSI2 gasket on i.MX6. The MIPI_IPU multiplexers are added as children of the iomuxc-gpr syscon device node. On i.MX6Q/D two two-input multiplexers in front of IPU1 CSI0 and IPU

[PATCH v5 09/39] ARM: dts: imx6-sabresd: add OV5642 and OV5640 camera sensors

Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. The OV5642 connects to the parallel-bus mux input port on ipu1_csi0_mux. The OV5640 connects to the input port on the MIPI CSI-2 receiver on mipi_csi. Until the OV5652 sensor module compatible with the SabreSD becomes avai

  1   2   >