Almost there on the subject. Stuff between brackets is removed by git,
so you should rather use something like
[PATCH v2] staging: lirc: Clean up zilog error codes
On Wed, Jul 12, 2017 at 9:17 PM, Yves Lemée wrote:
> According the coding style guidelines, the ENOSYS error code must be returned
>
Remove unnecessary parentheses from ccree driver code.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_aead.c| 4 ++--
drivers/staging/ccree/ssi_buffer_mgr.c | 8
drivers/staging/ccree/ssi_driver.c | 2 +-
drivers/staging/ccree/ssi_ivgen.c | 2 +-
drive
struct ssi_aead_ctx has some nested structure defined, resulting
in code accessing them to be very unreadable.
Move out the nested structure definitions out of the struct
and use the change to make the code accessing it more readable
and better coding style compliant by shortening lines and
proper
Another batch of ccree coding style fixes.
These goes on top of commit a8c4ae12 ("staging: ccree: Fix alignment issues in
ssi_sysfs.c")
in staging-testing.
Gilad Ben-Yossef (12):
staging: ccree remove unnecessary parentheses
staging: ccree: clean up struct ssi_aead_ctx
staging: ccree: use
Fix various remaining parenthesis alignment issues.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_aead.c| 46 +
drivers/staging/ccree/ssi_buffer_mgr.c | 30 ++-
drivers/staging/ccree/ssi_cipher.c | 2 +-
drivers/staging/ccree/ssi_hash.c
Fix strings in log messages being split across lines and the resulting
alignment issues when being fixed.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_aead.c| 9 ++--
drivers/staging/ccree/ssi_buffer_mgr.c | 86 ++---
drivers/staging/ccree/s
Turn local vars and function parameters names in CamelCase
to snake_case.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_aead.c | 26 +-
drivers/staging/ccree/ssi_buffer_mgr.c | 15 ---
drivers/staging/ccree/ssi_hash.c | 29 +
Re-write predicate to avoid constant comparison.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_aead.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c
index dab4914..8a1c408 100644
--- a/driver
Rename aead_req_struct fields from CamelCase to snake_case.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_aead.c | 26 ++--
drivers/staging/ccree/ssi_aead.h | 12 +++---
drivers/staging/ccree/ssi_buffer_mgr.c | 78 +-
3 files ch
Fix needless casting to unsigned long long in printk for
DMA addresses by using proper %pad format.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_aead.c| 16
drivers/staging/ccree/ssi_buffer_mgr.c | 48
drivers/staging/ccree/ssi_cipher.c
Avoid unnecessary line continuation in log function call.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_aead.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c
index 8a1c408..c6edef0 10064
The SSI_LOG macros already add __func__ to log messages, so remove
log message that add them a second time in the log message itself.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_aead.c | 4 ++--
drivers/staging/ccree/ssi_cipher.c | 14 +++---
drivers/staging/ccree/ss
Remove unnecessary whitespace before a quoted newline in strings.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_cipher.c | 6 +++---
drivers/staging/ccree/ssi_hash.c | 2 +-
drivers/staging/ccree/ssi_sysfs.c | 10 +-
3 files changed, 9 insertions(+), 9 deletions(-)
Change places where we alloc memory by sizeof type to sizeof var.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_aead.c| 4 ++--
drivers/staging/ccree/ssi_cipher.c | 4 ++--
drivers/staging/ccree/ssi_driver.c | 2 +-
drivers/staging/ccree/ssi_hash.c| 4 ++
On Wed, Jul 12, 2017 at 07:25:22PM +0100, Alan Cox wrote:
> > spk_ttyio_initialise_ldisc is called separately for each module (e.g.
> > speakup_apollo, speakup_ltlk etc) when it is loaded. spk_ttyio_release
> > is also called separately for each module when it is unloaded. The ldisc
> > stays aroun
On Wed, Jul 12, 2017 at 07:20:28PM +0100, Alan Cox wrote:
>
> > When opening from kernel, we don't use file pointer. The count mismatch
> > is between tty->count and #fd's. So opening from kernel leads to #fd's
> > being less than tty->count. I thought this difference is relevant to
> > user-space
Andy Lutomirski writes:
> On Tue, May 23, 2017 at 5:36 AM, Vitaly Kuznetsov wrote:
>> Andy Lutomirski writes:
>>
>>>
>>> Also, can you share the benchmark you used for these patches?
>>
>> I didn't do much while writing the patchset, mostly I was running the
>> attached dumb trasher (32 pthread
Fixed coding style error flagged checkpatch.pl:
- ERROR: space prohibited after that open parenthesis '('
- WARNING: Block comments use * on subsequent lines
Signed-off-by: Shy More
Output after fixing coding style issues:
$KERN/scripts/checkpatch.pl -f
./media/atomisp/p
On Thu, Jul 13, 2017 at 07:17:56AM -0700, smklearn wrote:
> Fixed coding style error flagged checkpatch.pl:
> - ERROR: space prohibited after that open parenthesis '('
> - WARNING: Block comments use * on subsequent lines
>
> Signed-off-by: Shy More
>
> Output after fixing coding sty
Below were the minor issues flagged by checkpatch.pl:
- WARNING: Block comments use * on subsequent lines
- ERROR: space prohibited after that open parenthesis '('
Signed-off-by: Shy More
---
.../css2400/runtime/isys/src/ibuf_ctrl_rmgr.c | 26 +++---
1 file changed, 13 inser
On Thu, Jul 13, 2017 at 08:06:21AM -0700, smklearn wrote:
> Below were the minor issues flagged by checkpatch.pl:
> - WARNING: Block comments use * on subsequent lines
> - ERROR: space prohibited after that open parenthesis '('
Don't do multiple things in the same patch please, this should be
mult
On Thu, Jul 13, 2017 at 08:55:43AM +0200, Philipp Guendisch wrote:
> This patch fixed code alignment to open paranthesis.
> Semantic should not be affected by this patch.
>
> It has been rebased on top of media_tree atomisp branch
>
> Signed-off-by: Philipp Guendisch
> Signed-off-by: Chris Balle
Hello,
I found some coding style warnings for fbtft_device.c
I fixed it in the patch.
Best regards,
Yurii Pavlenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
From: Pavlenko Yurii
---
drivers/staging/fbtft/fbtft_device.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft_device.c
b/drivers/staging/fbtft/fbtft_device.c
index 0d97473..c2d5dbb 100644
--- a/drivers/staging/fbtft/fbtft_device.c
Below was the minor issue flagged by checkpatch.pl:
- ERROR: space prohibited after that open parenthesis '('
Signed-off-by: Shy More
---
.../atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/drivers/staging/m
On Thu, Jul 13, 2017 at 05:50:11PM +0200, PY wrote:
> From: Pavlenko Yurii
>
> ---
> drivers/staging/fbtft/fbtft_device.c | 16
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fbtft_device.c
> b/drivers/staging/fbtft/fbtft_device.c
> in
Fix the following sparse warning:
drivers/staging//wlan-ng/prism2sta.c:1691:20: warning: incorrect type in
assignment (different base types)
The authantication data is in little endian order. Change the types to little
endian order:
(a) Change struct hfa384x_authenticate_station_data status, alg
According the coding style guidelines, the ENOSYS error code must be returned
in case of a non existent system call. This code has been replaced with
the ENOTTY error code indicating a missing functionality.
Signed-off-by: Yves Lemée
---
v3: Fixed patch subject
Fixed patch revision descriptio
> We now get a helpful warning for code that calls copy_{from,to}_iter
> without checking the return value, introduced by commit aa28de275a24
> ("iov_iter/hardening: move object size checks to inlined part").
>
> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c: In function
> 'kiblnd_send'
On Thu, Jul 13, 2017 at 5:50 PM, PY wrote:
> Hello,
>
> I found some coding style warnings for fbtft_device.c
> I fixed it in the patch.
What patch?
Frans
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailm
On Thu, Jul 13, 2017 at 10:41 PM, Frans Klaver wrote:
> On Thu, Jul 13, 2017 at 5:50 PM, PY wrote:
>> Hello,
>>
>> I found some coding style warnings for fbtft_device.c
>> I fixed it in the patch.
>
> What patch?
Oh, found it.
___
devel mailing list
de
On Thu, Jul 13, 2017 at 7:07 PM, James Simmons wrote:
>
>> We now get a helpful warning for code that calls copy_{from,to}_iter
>> without checking the return value, introduced by commit aa28de275a24
>> ("iov_iter/hardening: move object size checks to inlined part").
>>
>> drivers/staging/lustre/l
On Thu, Jul 13, 2017 at 5:50 PM, PY wrote:
> From: Pavlenko Yurii
>
> ---
> drivers/staging/fbtft/fbtft_device.c | 16
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fbtft_device.c
> b/drivers/staging/fbtft/fbtft_device.c
> index 0d9747
From: Colin Ian King
Trivial fix to spelling mistake, rename the function name
resizer_configure_in_continious_mode to
resizer_configure_in_continuous_mode and also remove an extraneous space.
Signed-off-by: Colin Ian King
---
drivers/staging/media/davinci_vpfe/dm365_resizer.c | 4 ++--
1 file
Hi Colin,
Thank you for the patch.
On Thursday 13 Jul 2017 23:34:16 Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistake, rename the function name
> resizer_configure_in_continious_mode to
> resizer_configure_in_continuous_mode and also remove an extraneous space.
>
> S
On Thu, Jul 13, 2017 at 10:57:59PM +0200, Arnd Bergmann wrote:
> Thanks for testing it!
>
> That means we did not copy any data and the kernel continues with
> an uninitialized buffer, right? The problem may be the definition of
>
> struct kib_immediate_msg {
> struct lnet_hdr ibim_hdr;
36 matches
Mail list logo
