Re: [PATCH v3 1/3] staging: lustre: constify attribute_group structures.

2017-07-21 Thread Dan Carpenter
On Fri, Jul 21, 2017 at 11:29:51AM +0530, Arvind Yadav wrote: > Changes in v3: > typo error in cover-latter. The cover letter gets discarded so no one cares. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http:

Re: [PATCH net-next 2/8] netvsc: add some rtnl_dereference annotations

2017-07-21 Thread kbuild test robot
Hi Stephen, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Stephen-Hemminger/netvsc-lockdep-and-related-fixes/20170720-191938 config: x86_64-rhel (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attac

Re: [PATCH] Make functions rf69_set_bandwidth_intern and rf69_set_dc_cut_off_frequency_intern static

2017-07-21 Thread Marcus Wolf
Reviewed-by: Marcus Wolf Attention: This patch is nothing new, just a combination of Patch [PATCH 2/3][staging-next] staging: pi433: Make functions rf69_set_bandwidth_intern static and [PATCH 1/1][staging-next] staging: pi433: Make functions rf69_set_dc_cut_off_frequency_intern static > Colin

[PATCH] staging: rtl8192u: fix incorrect mask and shift on u8 data

2017-07-21 Thread Colin King
From: Colin Ian King The cfg_action bit comes from the high bit of pmsg[4] so the current mask and shift are in correct and always result in zero. Fix this by using the correct mask and shif to get the correct cfg_action bit value. Detected by CoverityScan, CID#142890 ("Operands don't affect re

[PATCH 0/2] add ESP8089 WiFi chip driver

2017-07-21 Thread Quentin Schulz
The Espressif ESP8089 WiFi chips can be often found in cheap tablets. There is one in A23 Polaroid tablets for example. The chip is often embedded as an eMMC SDIO device. At the moment, there is no publicly available datasheet for this chip. The code was taken from an out-of-tree repository and

[PATCH 2/2] mmc: Add mmc_force_detect_change_begin / _end functions

2017-07-21 Thread Quentin Schulz
From: Hans de Goede Some sdio devices have a multiple stage bring-up process. Specifically the esp8089 (for which an out of tree driver is available) loads firmware on the first call to its sdio-drivers' probe function and then resets the device causing it to reboot from its RAM with the new firm

Re: [PATCH 1/2] staging: net: wireless: add ESP8089 WiFi driver

2017-07-21 Thread Greg KH
On Fri, Jul 21, 2017 at 04:35:01PM +0200, Quentin Schulz wrote: > The Espressif ESP8089 WiFi chips can be often found in cheap tablets. > There is one in A23 Polaroid tablets for example. > > The chip is often embedded as an eMMC SDIO device. > > The code was taken from an out-of-tree repository

Re: [PATCH 1/2] staging: net: wireless: add ESP8089 WiFi driver

2017-07-21 Thread Marcel Holtmann
Hi Quentin, > The Espressif ESP8089 WiFi chips can be often found in cheap tablets. > There is one in A23 Polaroid tablets for example. > > The chip is often embedded as an eMMC SDIO device. > > The code was taken from an out-of-tree repository and has seen a first > pass in the cleanup process.

[PATCH] [media] imx: add VIDEO_V4L2_SUBDEV_API dependency

2017-07-21 Thread Arnd Bergmann
Without this, I get a build error: drivers/staging/media/imx/imx-media-vdic.c: In function '__vdic_get_fmt': drivers/staging/media/imx/imx-media-vdic.c:554:10: error: implicit declaration of function 'v4l2_subdev_get_try_format'; did you mean 'v4l2_subdev_notify_event'? [-Werror=implicit-functio

Re: [PATCH 1/2] staging: net: wireless: add ESP8089 WiFi driver

2017-07-21 Thread Quentin Schulz
Hi Greg, On 21/07/2017 17:01, Greg KH wrote: > On Fri, Jul 21, 2017 at 04:35:01PM +0200, Quentin Schulz wrote: >> The Espressif ESP8089 WiFi chips can be often found in cheap tablets. >> There is one in A23 Polaroid tablets for example. >> >> The chip is often embedded as an eMMC SDIO device. >> >

Re: [PATCH 1/2] staging: net: wireless: add ESP8089 WiFi driver

2017-07-21 Thread Marcel Holtmann
Hi Quentin, >>> The Espressif ESP8089 WiFi chips can be often found in cheap tablets. >>> There is one in A23 Polaroid tablets for example. >>> >>> The chip is often embedded as an eMMC SDIO device. >>> >>> The code was taken from an out-of-tree repository and has seen a first >>> pass in the cl

Re: [PATCH 1/2] staging: net: wireless: add ESP8089 WiFi driver

2017-07-21 Thread Quentin Schulz
Hi Marcel, On 21/07/2017 18:52, Marcel Holtmann wrote: > Hi Quentin, > The Espressif ESP8089 WiFi chips can be often found in cheap tablets. There is one in A23 Polaroid tablets for example. The chip is often embedded as an eMMC SDIO device. The code was taken from a

[PATCH] netvsc: fix ptr_ret.cocci warnings

2017-07-21 Thread kbuild test robot
drivers/net/hyperv/netvsc_drv.c:737:8-14: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 9749fed5d43d ("netvsc: use ERR_PTR to avoid dereference issues") CC: stephen hemminger Signed-off-

Re: [PATCH] staging: vboxvideo: make a couple of symbols static

2017-07-21 Thread Hans de Goede
Hi, On 19-07-17 11:36, Colin King wrote: From: Colin Ian King Module parameter vbox_modeset and structure vbox_bo_driver do not need to be in global scope and hence can be made static. Cleans up a couple of sparse warnings: symbol 'vbox_modeset' was not declared. Should it be static? symbol '

[PATCH 0/3] Drivers: pi433: Style fix

2017-07-21 Thread Derek Robson
Assorted styel fix across whole driver Found using checkpatch Derek Robson (3): staging: pi433: Style fix - align block comments staging: pi433: - style fix, space before tabs staging: pi433: - style fix, space at start of line drivers/staging/pi433/pi433_if.c | 50 +++--- drivers

[PATCH 1/3] staging: pi433: Style fix - align block comments

2017-07-21 Thread Derek Robson
Fixed the alignment of block comments Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/pi433/pi433_if.c | 38 +++-- drivers/staging/pi433/rf69.c | 10 +- drivers/staging/pi433/rf69_registers.h | 280 - 3 files changed, 169 i

[PATCH 2/3] staging: pi433: - style fix, space before tabs

2017-07-21 Thread Derek Robson
Fixed checkpatch errors of "no space before tabs" Signed-off-by: Derek Robson --- drivers/staging/pi433/pi433_if.c | 12 ++-- drivers/staging/pi433/pi433_if.h | 4 ++-- drivers/staging/pi433/rf69.c | 8 drivers/staging/pi433/rf69.h | 6 +++--- 4 files changed, 15 inse

[PATCH 3/3] staging: pi433: - style fix, space at start of line

2017-07-21 Thread Derek Robson
Fixed checkpatch errors of "please, no spaces at the start of a line" Signed-off-by: Derek Robson --- drivers/staging/pi433/rf69.c | 4 +- drivers/staging/pi433/rf69_enum.h | 206 +++--- 2 files changed, 105 insertions(+), 105 deletions(-) diff --git a/dri