Re: [PATCH v2] staging: lustre: llite: fix potential missing-check bug when copying lumv

2018-05-05 Thread Dan Carpenter
On Fri, May 04, 2018 at 10:01:44AM -0500, Kangjie Lu wrote: > > There is nothing preventing the user from using struct lov_mds_md_v3 but > > filling in lmm_magic = LOV_MAGIC_V1 from the beginning, no need for a race. > > > > Right. No need for users to race. There might be a type confusion issue >

Re: [PATCH v3 12/20] media: Remove depends on HAS_DMA in case of platform dependency

2018-05-05 Thread Mauro Carvalho Chehab
Hi Geert, Em Tue, 17 Apr 2018 19:49:12 +0200 Geert Uytterhoeven escreveu: > Remove dependencies on HAS_DMA where a Kconfig symbol depends on another > symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". Applying a patch like that is hard, as there are lots of churn at the code.

Re: [PATCH 34/40] atm: simplify procfs code

2018-05-05 Thread Eric W. Biederman
Christoph Hellwig writes: > Use remove_proc_subtree to remove the whole subtree on cleanup, and > unwind the registration loop into individual calls. Switch to use > proc_create_seq where applicable. Can you please explain why you are removing the error handling when you are unwinding the regis

Re: [PATCH 38/40] ide: remove ide_driver_proc_write

2018-05-05 Thread Eric W. Biederman
Christoph Hellwig writes: > The driver proc file hasn't been writeable for a long time, so this is > just dead code. It is possible to chmod this file to get at the write method. Not that I think anyone does. It looks like this code was merged in 2.3.99-pre1 with permissions S_IFREG|S_IRUGO so

Re: [PATCH 11/40] ipv6/flowlabel: simplify pid namespace lookup

2018-05-05 Thread Eric W. Biederman
Christoph Hellwig writes: > The shole seq_file sequence already operates under a single RCU lock pair, > so move the pid namespace lookup into it, and stop grabbing a reference > and remove all kinds of boilerplate code. This is wrong. Move task_active_pid_ns(current) from open to seq_start act

Re: [PATCH] ANDROID: binder: remove 32-bit binder interface.

2018-05-05 Thread kbuild test robot
/linux/commits/Martijn-Coenen/ANDROID-binder-remove-32-bit-binder-interface/20180505-130632 config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin

[PATCH] staging: board: Replace license boilerplate with SPDX identifiers

2018-05-05 Thread Nathan Chancellor
This satisfies a checkpatch.pl warning and is the preferred method for notating the license due to its lack of ambiguity. Signed-off-by: Nathan Chancellor --- drivers/staging/board/armadillo800eva.c | 10 +- drivers/staging/board/board.c | 5 + 2 files changed, 2 insertion

Re: [PATCH v3 1/3] resource: Use list_head to link sibling resource

2018-05-05 Thread Baoquan He
On 04/26/18 at 11:23am, kbuild test robot wrote: > Hi Baoquan, > > I love your patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [also build test ERROR on v4.17-rc2 next-20180424] > [if your patch is applied to the wrong git tree, please drop us a note to > help impr

Re: [PATCH v3 1/3] resource: Use list_head to link sibling resource

2018-05-05 Thread Baoquan He
On 04/26/18 at 11:01am, kbuild test robot wrote: > Hi Baoquan, > > I love your patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [also build test ERROR on v4.17-rc2 next-20180424] > [if your patch is applied to the wrong git tree, please drop us a note to > help impr

[PATCH] staging: greybus: Remove unused local variable

2018-05-05 Thread Nathan Chancellor
Fixes the following W=1 warning: variable ‘intf_id’ set but not used [-Wunused-but-set-variable] Signed-off-by: Nathan Chancellor --- drivers/staging/greybus/svc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/greybus/svc.c b/drivers/staging/greybus/svc.c index a874fed761