Re: [PATCH 01/25] tty: Change return type to void

2018-09-04 Thread Sergei Shtylyov
Hello! On 9/4/2018 5:44 AM, Jaejoong Kim wrote: Many drivers with tty use the tty_stand_install(). But, there is no need to handle the error, since it always returns 0. So, change the return type of tty_standard_install() and tty_port_install() to void type and remove unnecessary exception hand

[PATCH 0/1] staging:rtl8192u: Fix naming clash of exported symbol

2018-09-04 Thread John Whitmore
Not sure of the procedure having made a mess of the build, (by reusing the name of an exported symbol). I hope that given the obscurity of rtl1892u this doesn't cause people issues. Obviously given the fact that I renamed an exported symbol I should have checked the name. Newbie mistake, I can only

[PATCH 1/1] staging:rtl8192u: Rename dot11d_init to fix name clash

2018-09-04 Thread John Whitmore
The function dot11d_init() was previously renamed to clear a style issue. Unfortunately the new name used, dot11d_init(), clashes with a sybmol which is exported with the same name. To correct this problem the function has been renamed to rtl8192u_dot11d_init(). Signed-off-by: John Whitmore ---

[PATCH 1/2] staging: rtl8188eu: remove empty if statement in rtw_led.c

2018-09-04 Thread Michael Straube
Remove empty if statement from 'if - else if' and replace the else if with if. Remove the now unused variable pmlmepriv. Also clears line over 80 characters and CamelCase checkpatch issues. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_led.c | 5 + 1 file changed, 1 i

[PATCH 2/2] staging: rtl8188eu: remove unnecessary parentheses in rtw_led.c

2018-09-04 Thread Michael Straube
Remove unnecessary parentheses from conditionals. Also clears 'Alignment should match open parenthesis' checkpatch issue. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_led.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl818

yield() and cond_resched() do not yield to another thread

2018-09-04 Thread fei phung
Hi everyone, I am working on https://github.com/promach/riffa/tree/full_duplex While I modifying the linux driver, I faced some issue using yield(). Why riffa_driver.c yield() function https://gist.github.com/promach/7716ee8addcaa33fda140d74d1ad94d6#file-riffa_driver-c-L746 does not yield to ch

Re: [PATCH v7 3/4] gpiolib: Pass array info to get/set array functions

2018-09-04 Thread kbuild test robot
Hi Janusz, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on gpio/for-next] [also build test WARNING on v4.19-rc2 next-20180831] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-c

Re: [PATCH v6 3/4] gpiolib: Pass array info to get/set array functions

2018-09-04 Thread kbuild test robot
Hi Janusz, Thank you for the patch! Yet something to improve: [auto build test ERROR on gpio/for-next] [also build test ERROR on v4.19-rc2 next-20180831] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/

Re: [PATCH v6 1/4] gpiolib: Pass bitmaps, not integer arrays, to get/set array

2018-09-04 Thread kbuild test robot
Hi Janusz, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on gpio/for-next] [also build test WARNING on v4.19-rc2 next-20180831] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-c

Re: [PATCH v6 1/4] gpiolib: Pass bitmaps, not integer arrays, to get/set array

2018-09-04 Thread kbuild test robot
Hi Janusz, Thank you for the patch! Yet something to improve: [auto build test ERROR on gpio/for-next] [also build test ERROR on v4.19-rc2 next-20180831] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/

Re: [PATCH v7 1/4] gpiolib: Pass bitmaps, not integer arrays, to get/set array

2018-09-04 Thread kbuild test robot
Hi Janusz, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on gpio/for-next] [also build test WARNING on v4.19-rc2 next-20180831] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-c

[PATCH] staging: most: net: make array 'broadcast' static, shrinks object size

2018-09-04 Thread Colin King
From: Colin Ian King Don't populate the array 'broadcast' on the stack but instead make it static. Makes the object code smaller by 53 bytes: Before: textdata bss dec hex filename 105111521 448 1248030c0 drivers/staging/most/net/net.o After: textdata

[PATCH] tools: hv: fcopy: set 'error' in case an unknown operation was requested

2018-09-04 Thread Vitaly Kuznetsov
'error' variable is left uninitialized in case we see an unknown operation. As we don't immediately return and proceed to pwrite() we need to set it to something, HV_E_FAIL sounds good enough. Signed-off-by: Vitaly Kuznetsov --- tools/hv/hv_fcopy_daemon.c | 1 + 1 file changed, 1 insertion(+) d

[PATCH v2] staging: android: ion: fix ION_IOC_{MAP, SHARE} use-after-free

2018-09-04 Thread Greg Hackmann
The ION_IOC_{MAP,SHARE} ioctls drop and reacquire client->lock several times while operating on one of the client's ion_handles. This creates windows where userspace can call ION_IOC_FREE on the same client with the same handle, and effectively make the kernel drop its own reference. For example:

Re: [PATCH v2] staging: android: ion: Clean unused debug_show memeber of the heap object

2018-09-04 Thread Laura Abbott
On 08/26/2018 01:08 PM, Alexey Skidanov wrote: ION had supported heap debug info under /sys/kernel/debug/ion/. This support have been removed but some leftovers (dead code) still exist. This patch removes the existing dead code. This was actually an unintended side effect. The goal was to rip

Re: [PATCH v2] staging: android: ion: fix ION_IOC_{MAP,SHARE} use-after-free

2018-09-04 Thread Laura Abbott
On 09/04/2018 09:33 AM, Greg Hackmann wrote: The ION_IOC_{MAP,SHARE} ioctls drop and reacquire client->lock several times while operating on one of the client's ion_handles. This creates windows where userspace can call ION_IOC_FREE on the same client with the same handle, and effectively make t

Re: [PATCH v2] staging: android: ion: Clean unused debug_show memeber of the heap object

2018-09-04 Thread Alexey Skidanov
On 09/04/2018 09:23 PM, Laura Abbott wrote: > On 08/26/2018 01:08 PM, Alexey Skidanov wrote: >> ION had supported heap debug info under >> /sys/kernel/debug/ion/. >> This support have been removed but some leftovers (dead code) still >> exist. >> >> This patch removes the existing dead code. >> >

[PATCH v2] tty: Change tty_{port|standard}_install() return type to void

2018-09-04 Thread Jaejoong Kim
Many drivers with tty use the tty_stand_install(). But, there is no need to handle the error, since it always returns 0. So, change the return type of tty_standard_install() and tty_port_install() to void type and remove unnecessary exception handling where we use these functions. Signed-off-by: J

[PATCH v3] staging: android: ion: Clean unused debug_show memeber of the heap object

2018-09-04 Thread Alexey Skidanov
ION had supported heap debug info under /sys/kernel/debug/ion/. This support have been removed but some leftovers (dead code) still exist. This patch removes the existing dead code. Fixes: 15c6098cfec5 ("staging: android: ion: Remove ion_handle and ion_client") Signed-off-by: Alexey Skidanov ---

Re: [PATCH 01/25] tty: Change return type to void

2018-09-04 Thread Jiri Slaby
On 09/05/2018, 03:08 AM, Jaejoong Kim wrote: > > @@ -688,7 +688,7 @@ extern int tty_port_close_start(struct > tty_port *port, > >   extern void tty_port_close_end(struct tty_port *port, struct > tty_struct *tty); > >   extern void tty_port_close(struct tty_port *port, > >   

Re: [PATCH v7 1/4] gpiolib: Pass bitmaps, not integer arrays, to get/set array

2018-09-04 Thread kbuild test robot
Hi Janusz, Thank you for the patch! Yet something to improve: [auto build test ERROR on gpio/for-next] [also build test ERROR on v4.19-rc2 next-20180905] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/