On 04/10/2018 08:28, Michal Hocko wrote:
> On Wed 03-10-18 19:00:29, David Hildenbrand wrote:
> [...]
>> Let me rephrase: You state that user space has to make the decision and
>> that user should be able to set/reconfigure rules. That is perfectly fine.
>>
>> But then we should give user space acc
On 01/10/2018 18:24, Dave Hansen wrote:
>> How should a policy in user space look like when new memory gets added
>> - on s390x? Not onlining paravirtualized memory is very wrong.
>
> Because we're going to balloon it away in a moment anyway?
No, rether somebody wanted this VM to have more memory
Marcelo Tosatti writes:
> On Wed, Oct 03, 2018 at 11:22:58AM +0200, Vitaly Kuznetsov wrote:
>>
>> There is a very long history of different (hardware) issues Marcelo was
>> fighting with and the current code is the survived Frankenstein.
>
> Right, the code has to handle different TSC modes.
>
>
On 03/10/2018 16:24, Michal Hocko wrote:
> On Wed 03-10-18 15:52:24, Vitaly Kuznetsov wrote:
> [...]
>>> As David said some of the memory cannot be onlined without further steps
>>> (e.g. when it is standby as David called it) and then I fail to see how
>>> eBPF help in any way.
>>
>> and also, we
On 04/10/2018 08:19, Michal Hocko wrote:
> On Wed 03-10-18 19:14:05, David Hildenbrand wrote:
>> On 03/10/2018 16:34, Vitaly Kuznetsov wrote:
>>> Dave Hansen writes:
>>>
On 10/03/2018 06:52 AM, Vitaly Kuznetsov wrote:
> It is more than just memmaps (e.g. forking udev process doing memory
On 10/3/18 11:30 PM, Joe Perches wrote:
On Wed, 2018-10-03 at 22:43 +0200, Michael Straube wrote:
Cleanup array declaration to clear two 'line over 80 characters'
checkpatch warnings and improve readability.
[]
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
b/drivers/staging/rtl81
On Thu, Oct 04, 2018 at 09:54:45AM +0200, Vitaly Kuznetsov wrote:
> I was hoping to hear this from you :-) If I am to suggest how we can
> move forward I'd propose:
> - Check if pure TSC can be used on SkyLake+ systems (where TSC scaling
> is supported).
> - Check if non-masterclock mode is still n
These functions do nothing besides returning NULL and are unused.
Just drop them.
Signed-off-by: Tuomas Tynkkynen
---
.../vc04_services/interface/vchi/vchi.h | 11
.../interface/vchiq_arm/vchiq_shim.c | 27 ---
2 files changed, 38 deletions(-)
diff --git
The connection field of SERVICE_CREATION_T is assigned to but its value
is never read. Drop the field and the resulting no longer needed code
from bcm2835-audio and bcm2835-camera.
Signed-off-by: Tuomas Tynkkynen
---
drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 3 ---
drivers/st
These types are not used anywhere, remove them.
Signed-off-by: Tuomas Tynkkynen
---
drivers/staging/vc04_services/interface/vchi/vchi.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchi/vchi.h
b/drivers/staging/vc04_services/interface/vchi/
There is no definition for this unused function, so drop its prototype.
Signed-off-by: Tuomas Tynkkynen
---
drivers/staging/vc04_services/interface/vchi/vchi.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchi/vchi.h
b/drivers/staging/vc04_servi
Drop various pieces of dead code from here and there to get rid of
the remaining users of VCHI_CONNECTION_T. After that we get to drop
entire header files worth of unused code.
I've tested on a Raspberry Pi Model B (bcm2835_defconfig) that
snd-bcm2835 can still play analog audio just fine.
Tuomas
Remove two parameters which are never used and all where all callers
just pass in dummy values anyway.
Signed-off-by: Tuomas Tynkkynen
---
.../vc04_services/bcm2835-audio/bcm2835-vchiq.c | 2 +-
.../staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 2 +-
drivers/staging/vc04_services/i
These fields are only initialized with constants and never read. Drop
them.
Signed-off-by: Tuomas Tynkkynen
---
.../vc04_services/bcm2835-audio/bcm2835-vchiq.c | 5 -
.../staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 5 -
drivers/staging/vc04_services/interface/vchi/vchi.h
Previously, connection.h was only required for the definition of
VCHI_CONNECTION_T, but now all usages of it are gone. Remove this unused
header.
After connection.h is gone, message.h and vchi_cfg_internal.h are no
longer referenced by anything either. Drop them as well.
Signed-off-by: Tuomas Tyn
On 03/10/18 21:54, Spencer E. Olson wrote:
Fixes two problems introduced as early as
commit 03aef4b6dc12 ("Staging: comedi: add ni_mio_common code"):
(1) Ensures that the last four bits of NISTC_RTSI_TRIGB_OUT_REG register is
not unduly overwritten on e-series devices. On e-series devices,
On 03/10/18 21:55, Spencer E. Olson wrote:
This patch set is the second revision of a recent patch set of the same name.
Changes and notes:
- [PATCH v4 07/13]: Rebased patchset on repaired patch "staging: comedi:
ni_mio_common: protect register write overflow" (that patch had a missing
On 04/10/2018 09:54, Vitaly Kuznetsov wrote:
> - Check if pure TSC can be used on SkyLake+ systems (where TSC scaling
> is supported).
Not if you want to migrate to pre-Skylake systems.
> - Check if non-masterclock mode is still needed. E.g. HyperV's TSC page
> clocksource is a single page for th
On 10/3/18 11:30 PM, Joe Perches wrote:
static struct mlme_handler mlme_sta_tbl[] = {
Perhaps const here too, and as well, the struct
declaration could use const char * instead of char *
Making it const gives following warning.
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c: In function
Ajay Singh writes:
> Hi Kalle,
>
> On Thu, 23 Aug 2018 16:37:45 +0530
> Kalle Valo wrote:
>
>> Ajay Singh writes:
>>
>> >> >>> We need help to review and identify if there are any pending
>> >> >>> items for wilc1000 driver, so we can address those issues and
>> >> >>> make it ready to move to
> On Oct 4, 2018, at 1:11 AM, Peter Zijlstra wrote:
>
>> On Thu, Oct 04, 2018 at 09:54:45AM +0200, Vitaly Kuznetsov wrote:
>> I was hoping to hear this from you :-) If I am to suggest how we can
>> move forward I'd propose:
>> - Check if pure TSC can be used on SkyLake+ systems (where TSC scali
> On Oct 4, 2018, at 5:00 AM, Paolo Bonzini wrote:
>
>> On 04/10/2018 09:54, Vitaly Kuznetsov wrote:
>> - Check if pure TSC can be used on SkyLake+ systems (where TSC scaling
>> is supported).
>
> Not if you want to migrate to pre-Skylake systems.
>
>> - Check if non-masterclock mode is still
On Wed 03-10-18 19:09:39, Arun KS wrote:
[...]
> +static int online_pages_blocks(unsigned long start, unsigned long nr_pages)
> +{
> + unsigned long end = start + nr_pages;
> + int order, ret, onlined_pages = 0;
> +
> + while (start < end) {
> + order = min(MAX_ORDER - 1UL,
On 10/01/2018 09:33 PM, Slawomir Stepien wrote:
> By using the pointer to channel attribute, we can now make the lines
> short enough to eliminate the checkpatch.pl problem:
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Slawomir Stepien
Hi,
Thanks for the patch. Thi
On Thu, 4 Oct 2018 10:13:48 +0200
David Hildenbrand wrote:
ok, so what is the problem here?
Handling the hotplug in userspace through udev may be suboptimal and
kernel handling might be faster but that's orthogonal to the problem at
hand.
The state of the art is to determine what to do with hot
On 04/10/2018 17:28, Michal Suchánek wrote:
> On Thu, 4 Oct 2018 10:13:48 +0200
> David Hildenbrand wrote:
>
> ok, so what is the problem here?
>
> Handling the hotplug in userspace through udev may be suboptimal and
> kernel handling might be faster but that's orthogonal to the problem at
> han
Am 03.10.18 um 23:26 schrieb Joe Perches:
On Wed, 2018-10-03 at 22:43 +0200, Michael Straube wrote:
Line break array declaration to clear a 'line over 80 characters'
checkpatch warning. For consistency replace 0x0 with 0x00.
[]
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
b/driv
In vpfe_isif_init(), there is a while loop to get the ISIF base address and
linearization table0 and table1 address. In the loop body, the function
platform_get_resource() is called to get the resource. If
platform_get_resource() returns NULL, the loop is terminated and the
execution goes to 'fail_
This patchset removes #if 0 blocks in sd.c, dbg.c and dbg.h.
Changes in v6:
- Split the #if 0 removal patch in three patches.
- Each patch addresses one file.
Changes in v5:
- Split the patch in three different patches.
- The first patch removes #if 0 blocks.
- The second one removes msd
This patch removes #if 0 code blocks and usages of
functions defined in the #if 0 blocks in sd.c.
Signed-off-by: Nishad Kamdar
---
drivers/staging/mt7621-mmc/sd.c | 249 +---
1 file changed, 1 insertion(+), 248 deletions(-)
diff --git a/drivers/staging/mt7621-mmc/sd.
This patch removes #if 0 code blocks and usages of
functions defined in the #if 0 blocks in dbg.c
Signed-off-by: Nishad Kamdar
---
drivers/staging/mt7621-mmc/dbg.c | 21 +
1 file changed, 1 insertion(+), 20 deletions(-)
diff --git a/drivers/staging/mt7621-mmc/dbg.c b/drivers
This patch removes #if 0 code blocks and usages of
functions defined in the #if 0 blocks in dbg.h.
Signed-off-by: Nishad Kamdar
---
drivers/staging/mt7621-mmc/dbg.h | 15 ---
1 file changed, 15 deletions(-)
diff --git a/drivers/staging/mt7621-mmc/dbg.h b/drivers/staging/mt7621-mmc/d
On Wed, Oct 03, 2018 at 03:32:08PM -0700, Andy Lutomirski wrote:
> On Wed, Oct 3, 2018 at 12:01 PM Marcelo Tosatti wrote:
> >
> > On Tue, Oct 02, 2018 at 10:15:49PM -0700, Andy Lutomirski wrote:
> > > Hi Vitaly, Paolo, Radim, etc.,
> > >
> > > On Fri, Sep 14, 2018 at 5:52 AM Thomas Gleixner
> >
On paź 04, 2018 17:21, Lars-Peter Clausen wrote:
> On 10/01/2018 09:33 PM, Slawomir Stepien wrote:
> > drivers/staging/iio/cdc/ad7150.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/iio/cdc/ad7150.c
> > b/drivers/staging/iio/cdc/ad7150.c
> >
On Thu, Oct 4, 2018 at 9:43 AM Marcelo Tosatti wrote:
>
> On Wed, Oct 03, 2018 at 03:32:08PM -0700, Andy Lutomirski wrote:
> > On Wed, Oct 3, 2018 at 12:01 PM Marcelo Tosatti wrote:
> > >
> > > On Tue, Oct 02, 2018 at 10:15:49PM -0700, Andy Lutomirski wrote:
> > > > Hi Vitaly, Paolo, Radim, etc.,
Andy Lutomirski writes:
> On Thu, Oct 4, 2018 at 9:43 AM Marcelo Tosatti wrote:
>>
>> On Wed, Oct 03, 2018 at 03:32:08PM -0700, Andy Lutomirski wrote:
>> > On Wed, Oct 3, 2018 at 12:01 PM Marcelo Tosatti
>> > wrote:
>> > >
>> > > On Tue, Oct 02, 2018 at 10:15:49PM -0700, Andy Lutomirski wrote:
Silence the below sparse warnings by casting betwen u8 __iomem *, and
void *.
warning: incorrect type in assignment (different address spaces)
expected unsigned char [noderef] [usertype] *virt_base
got void *[assigned] mem
warning: incorrect type in argument 3 (different address spaces)
e
On Thu, 4 Oct 2018 17:45:13 +0200
David Hildenbrand wrote:
> On 04/10/2018 17:28, Michal Suchánek wrote:
> >
> > The state of the art is to determine what to do with hotplugged
> > memory in userspace based on platform and virtualization type.
>
> Exactly.
>
> >
> > Changing the default to
Change the type of MCS_rate_1R from unsigned char to const u8.
Suggested-by: Joe Perches
Signed-off-by: Michael Straube
---
NOTE:
This series depends on the previous sent series.
[1/3] staging: rtl8188eu: fix line over 80 characters - style
drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +-
Remove spaces and/or replace tabs with spaces in some declarations
in rtw_mlme_ext.h.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_mlme_
The strings in the use of struct action_handler are constant.
Change the type of field str from 'char *' to 'const char *'.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8
The strings in the uses of struct mlme_handler are constant.
Change the type of field str from 'char *' to 'const char *'.
Suggested-by: Joe Perches
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
On Thu, 2018-10-04 at 14:12 +0200, Michael Straube wrote:
> On 10/3/18 11:30 PM, Joe Perches wrote:
>
> > > static struct mlme_handler mlme_sta_tbl[] = {
> >
> > Perhaps const here too, and as well, the struct
> > declaration could use const char * instead of char *
> >
>
> Making it const
IDMAC interlaced scan, a.k.a. interweave, should be enabled in the
IDMAC output channels only if the IDMAC output pad field type is
'seq-bt' or 'seq-tb', and field type at the capture interface is
'interlaced*'.
V4L2_FIELD_HAS_BOTH() macro should not be used on the input to determine
enabling inte
If the incoming sink field type is alternate, the reset crop height
and crop height bounds must be set to twice the incoming height,
because in alternate field mode, upstream will report only the
lines for a single field, and the CSI captures the whole frame.
Signed-off-by: Steve Longerbeam
---
If IDMAC interweaving is enabled in a write channel, the channel must
write the odd chroma rows for 4:2:0 formats. Skipping writing the odd
chroma rows produces corrupted captured 4:2:0 images when interweave
is enabled.
Reported-by: Krzysztof Hałasa
Signed-off-by: Steve Longerbeam
---
drivers/
Skip writing U/V components to odd rows for YVU420 in addition to
YUV420 and NV12.
Signed-off-by: Steve Longerbeam
Reviewed-by: Philipp Zabel
---
drivers/staging/media/imx/imx-media-csi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/imx/imx-media-csi.c
b/drivers/st
If caller passes un-initialized field type V4L2_FIELD_ANY to CSI
sink pad, the reset CSI crop window would not be correct, because
the crop window depends on a valid input field type. To fix move
the reset of crop and compose windows to after the call to
imx_media_fill_default_mbus_fields().
Signe
To support interlaced scan with planar formats, cpmem SLUV must
be programmed with the correct chroma line stride. For full and
partial planar 4:2:2 (YUV422P, NV16), chroma line stride must
be doubled. For full and partial planar 4:2:0 (YUV420, YVU420, NV12),
chroma line stride must _not_ be double
Allow sequential->interlaced interweaving but with top/bottom
lines swapped to the output buffer.
This can be accomplished by adding one line length to IDMAC output
channel address, with a negative line length for the interlace offset.
This is to allow the seq-bt -> interlaced-bt transformation,
prepare_vdi_in_buffers() was setting up the dma pointers as if the
VDIC is always programmed to receive the fields in bottom-top order,
i.e. as if ipu_vdi_set_field_order() only programs BT order in the VDIC.
But that's not true, ipu_vdi_set_field_order() is working correctly.
So fix prepare_vdi_i
The function ipu_csi_init_interface() was inverting the F-bit for
NTSC case, in the CCIR_CODE_1/2 registers. The result being that
for NTSC bottom-top field order, the CSI would swap fields and
capture in top-bottom order.
Instead, base field swap on the field order of the input to the CSI,
and th
On Thu, Oct 04, 2018 at 07:00:45AM -0700, Andy Lutomirski wrote:
> > On Oct 4, 2018, at 1:11 AM, Peter Zijlstra wrote:
> >
> >> On Thu, Oct 04, 2018 at 09:54:45AM +0200, Vitaly Kuznetsov wrote:
> >> I was hoping to hear this from you :-) If I am to suggest how we can
> >> move forward I'd propose
> On Oct 4, 2018, at 12:31 PM, Peter Zijlstra wrote:
>
> On Thu, Oct 04, 2018 at 07:00:45AM -0700, Andy Lutomirski wrote:
>>> On Oct 4, 2018, at 1:11 AM, Peter Zijlstra wrote:
>>>
On Thu, Oct 04, 2018 at 09:54:45AM +0200, Vitaly Kuznetsov wrote:
I was hoping to hear this from you :-
On Fri, Sep 14, 2018 at 5:52 AM Thomas Gleixner wrote:
>
> Matt attempted to add CLOCK_TAI support to the VDSO clock_gettime()
> implementation, which extended the clockid switch case and added yet
> another slightly different copy of the same code.
>
> Especially the extended switch case is probl
For better or for worse, I'm trying to understand this code. So far,
I've come up with this patch:
https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/commit/?h=x86/vdso-tglx&id=14fd71e12b1c4492a06f368f75041f263e6862bf
Is it correct, or am I missing some subtlety?
This patch fixes all "Alignment should match open parenthesis" check
warnings found by checkpatch.pl in the addac/adt7316 driver.
Signed-off-by: Renato Lui Geh
---
drivers/staging/iio/addac/adt7316.c | 462 ++--
drivers/staging/iio/addac/adt7316.h | 2 +-
2 files changed,
Hi Kalle,
On Thu, 4 Oct 2018 15:27:57 +0300
Kalle Valo wrote:
> Ajay Singh writes:
>
> > Hi Kalle,
> >
> > On Thu, 23 Aug 2018 16:37:45 +0530
> > Kalle Valo wrote:
> >
> >> Ajay Singh writes:
> >>
> >> >> >>> We need help to review and identify if there are any pending
> >> >> >>> items for
Ajay Singh writes:
>> > I have submitted a patch series for wilc1000 driver, single file
>> > per patch and its based on wireless-drivers-next.
>> > I hope its done correctly, please provide inputs so we can
>> > address and make this driver ready for mainline.
>>
>> Thanks, I see it in patchwo
59 matches
Mail list logo
